@pikku/kysely 0.12.17 → 0.12.18

package/CHANGELOG.md

@@ -1,3 +1,28 @@
+## 0.12.18
+
+### Patch Changes
+
+- 5c0ff0f: Fix `getRunHistory` dropping step provenance (`fromStepName`). The value was persisted on the step row and used by the graph planner, but `getRunHistory` built its rows from the per-attempt history and never carried `fromStepName` through — so run history (and any timeline reconstructed from it) reported no predecessors. Redis and Kysely `getRunHistory` now return `fromStepName`. Also adds the missing `from_step_name` column (+ backfill) to the Kysely workflow mirror's `workflow_step` schema and persists it on mirror inserts, so a mirror-side history has identical provenance.
+- 72694f6: feat(workflow): expose per-step attempt count + record running/succeeded/failed timestamps
+
+  `getRunStatus` now returns `attempts` (the latest attempt count) per step, so
+  consumers can show retry counts without a second history query. It already
+  computed `duration` from `runningAt`/`succeededAt`, but the kysely and mongodb
+  workflow stores only stamped those timestamps on the _insert_ path — the
+  `running` / `succeeded` / `failed` status transitions updated the history row's
+  status without setting `runningAt` / `succeededAt` / `failedAt`, so `duration`
+  was always undefined. The transitions now stamp the matching timestamp, so step
+  duration is populated for kysely- and mongodb-backed runs. (Redis already
+  stamped on transition.) A shared service-suite test guards both behaviours.
+
+- Updated dependencies [4be205f]
+- Updated dependencies [061c717]
+- Updated dependencies [2c55e13]
+- Updated dependencies [c745c26]
+- Updated dependencies [57900b5]
+- Updated dependencies [72694f6]
+  - @pikku/core@0.12.39
+
 ## 0.12.17
 
 ### Patch Changes

package/dist/src/kysely-workflow-mirror.js

@@ -61,6 +61,7 @@ export class KyselyWorkflowMirror {
             .addColumn('branch_taken', 'text')
             .addColumn('retries', 'integer')
             .addColumn('retry_delay', 'text')
+            .addColumn('from_step_name', 'text')
             .addColumn('created_at', 'timestamp', (col) => col.defaultTo(sql `CURRENT_TIMESTAMP`).notNull())
             .addColumn('updated_at', 'timestamp', (col) => col.defaultTo(sql `CURRENT_TIMESTAMP`).notNull())
             .addUniqueConstraint('workflow_step_run_name_unique', [
@@ -68,6 +69,14 @@ export class KyselyWorkflowMirror {
             'step_name',
         ])
             .execute();
+        // Additive: backfill the column on mirror tables created before from_step_name.
+        await this.db.schema
+            .alterTable('workflow_step')
+            .addColumn('from_step_name', 'text')
+            .execute()
+            .catch(() => {
+            // Column already exists (fresh tables include it above) — nothing to do.
+        });
         await this.db.schema
             .createTable('workflow_step_history')
             .ifNotExists()
@@ -144,6 +153,7 @@ export class KyselyWorkflowMirror {
             status: step.status,
             retries: step.retries ?? null,
             retryDelay: step.retryDelay?.toString() ?? null,
+            fromStepName: step.fromStepName ?? null,
             createdAt: now,
             updatedAt: now,
         })

package/dist/src/kysely-workflow-run-service.js

@@ -137,6 +137,7 @@ export class KyselyWorkflowRunService {
             .select([
             's.workflowStepId',
             's.stepName',
+            's.fromStepName',
             's.retries',
             's.retryDelay',
             'h.status',
@@ -158,6 +159,7 @@ export class KyselyWorkflowRunService {
             return {
                 stepId,
                 stepName: row.stepName,
+                fromStepName: row.fromStepName ?? undefined,
                 status: row.status,
                 result: parseJson(row.result),
                 error: parseJson(row.error),

package/dist/src/kysely-workflow-service.js

@@ -231,7 +231,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         if (latestHistory) {
             await this.db
                 .updateTable('workflowStepHistory')
-                .set({ status: 'running' })
+                .set({ status: 'running', runningAt: new Date() })
                 .where('historyId', '=', latestHistory.historyId)
                 .execute();
         }
@@ -308,7 +308,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         if (latestHistory) {
             await this.db
                 .updateTable('workflowStepHistory')
-                .set({ status: 'succeeded', result: resultJson })
+                .set({ status: 'succeeded', result: resultJson, succeededAt: new Date() })
                 .where('historyId', '=', latestHistory.historyId)
                 .execute();
         }
@@ -340,7 +340,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         if (latestHistory) {
             await this.db
                 .updateTable('workflowStepHistory')
-                .set({ status: 'failed', error: errorJson })
+                .set({ status: 'failed', error: errorJson, failedAt: new Date() })
                 .where('historyId', '=', latestHistory.historyId)
                 .execute();
         }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pikku/kysely",
-  "version": "0.12.17",
+  "version": "0.12.18",
   "author": "yasser.fadl@gmail.com",
   "license": "MIT",
   "module": "dist/src/index.js",
@@ -20,7 +20,7 @@
     "prepublishOnly": "yarn build"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.12.38"
+    "@pikku/core": "^0.12.39"
   },
   "dependencies": {
     "kysely": "^0.29.0"

package/src/kysely-workflow-mirror.test.ts

@@ -103,6 +103,29 @@ describe('KyselyWorkflowMirror — step lifecycle', () => {
     assert.equal(history[0]!.status, 'pending')
   })
 
+  test('getRunHistory surfaces step provenance (fromStepName)', async () => {
+    // The mirror persists fromStepName and getRunHistory reads it back, so the
+    // run history reconstructs the walked path (entry has none, the next step
+    // records its predecessor).
+    await seedStep(STEP_ID, 'begin')
+    await mirror.insertStepState(RUN_ID, {
+      stepId: `${STEP_ID}-2`,
+      stepName: 'next',
+      rpcName: 'rpc.fn',
+      data: { x: 2 },
+      status: 'pending',
+      attemptCount: 1,
+      fromStepName: 'begin',
+      createdAt: new Date(),
+      updatedAt: new Date(),
+    } as any)
+
+    const history = await runService.getRunHistory(RUN_ID)
+    const from = new Map(history.map((h) => [h.stepName, h.fromStepName]))
+    assert.equal(from.get('begin'), undefined, 'entry step has no predecessor')
+    assert.equal(from.get('next'), 'begin', 'next records its predecessor')
+  })
+
   test('running → succeeded updates the in-place history row', async () => {
     await seedStep()
     await mirror.setStepRunning(STEP_ID)

package/src/kysely-workflow-mirror.ts

@@ -79,6 +79,7 @@ export class KyselyWorkflowMirror implements WorkflowRunMirror {
       .addColumn('branch_taken', 'text')
       .addColumn('retries', 'integer')
       .addColumn('retry_delay', 'text')
+      .addColumn('from_step_name', 'text')
       .addColumn('created_at', 'timestamp', (col) =>
         col.defaultTo(sql`CURRENT_TIMESTAMP`).notNull()
       )
@@ -91,6 +92,15 @@ export class KyselyWorkflowMirror implements WorkflowRunMirror {
       ])
       .execute()
 
+    // Additive: backfill the column on mirror tables created before from_step_name.
+    await this.db.schema
+      .alterTable('workflow_step')
+      .addColumn('from_step_name', 'text')
+      .execute()
+      .catch(() => {
+        // Column already exists (fresh tables include it above) — nothing to do.
+      })
+
     await this.db.schema
       .createTable('workflow_step_history')
       .ifNotExists()
@@ -202,6 +212,7 @@ export class KyselyWorkflowMirror implements WorkflowRunMirror {
         status: step.status,
         retries: step.retries ?? null,
         retryDelay: step.retryDelay?.toString() ?? null,
+        fromStepName: step.fromStepName ?? null,
         createdAt: now,
         updatedAt: now,
       })

package/src/kysely-workflow-run-service.ts

@@ -192,6 +192,7 @@ export class KyselyWorkflowRunService implements WorkflowRunService {
       .select([
         's.workflowStepId',
         's.stepName',
+        's.fromStepName',
         's.retries',
         's.retryDelay',
         'h.status',
@@ -215,6 +216,7 @@ export class KyselyWorkflowRunService implements WorkflowRunService {
       return {
         stepId,
         stepName: row.stepName,
+        fromStepName: row.fromStepName ?? undefined,
         status: row.status as StepState['status'],
         result: parseJson(row.result),
         error: parseJson(row.error),

package/src/kysely-workflow-service.ts

@@ -319,7 +319,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     if (latestHistory) {
       await this.db
         .updateTable('workflowStepHistory')
-        .set({ status: 'running' })
+        .set({ status: 'running', runningAt: new Date() })
         .where('historyId', '=', latestHistory.historyId)
         .execute()
     }
@@ -417,7 +417,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     if (latestHistory) {
       await this.db
         .updateTable('workflowStepHistory')
-        .set({ status: 'succeeded', result: resultJson })
+        .set({ status: 'succeeded', result: resultJson, succeededAt: new Date() })
         .where('historyId', '=', latestHistory.historyId)
         .execute()
     }
@@ -456,7 +456,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     if (latestHistory) {
       await this.db
         .updateTable('workflowStepHistory')
-        .set({ status: 'failed', error: errorJson })
+        .set({ status: 'failed', error: errorJson, failedAt: new Date() })
         .where('historyId', '=', latestHistory.historyId)
         .execute()
     }