@pikku/kysely 0.12.16 → 0.12.18

package/CHANGELOG.md

@@ -1,3 +1,91 @@
+## 0.12.18
+
+### Patch Changes
+
+- 5c0ff0f: Fix `getRunHistory` dropping step provenance (`fromStepName`). The value was persisted on the step row and used by the graph planner, but `getRunHistory` built its rows from the per-attempt history and never carried `fromStepName` through — so run history (and any timeline reconstructed from it) reported no predecessors. Redis and Kysely `getRunHistory` now return `fromStepName`. Also adds the missing `from_step_name` column (+ backfill) to the Kysely workflow mirror's `workflow_step` schema and persists it on mirror inserts, so a mirror-side history has identical provenance.
+- 72694f6: feat(workflow): expose per-step attempt count + record running/succeeded/failed timestamps
+
+  `getRunStatus` now returns `attempts` (the latest attempt count) per step, so
+  consumers can show retry counts without a second history query. It already
+  computed `duration` from `runningAt`/`succeededAt`, but the kysely and mongodb
+  workflow stores only stamped those timestamps on the _insert_ path — the
+  `running` / `succeeded` / `failed` status transitions updated the history row's
+  status without setting `runningAt` / `succeededAt` / `failedAt`, so `duration`
+  was always undefined. The transitions now stamp the matching timestamp, so step
+  duration is populated for kysely- and mongodb-backed runs. (Redis already
+  stamped on transition.) A shared service-suite test guards both behaviours.
+
+- Updated dependencies [4be205f]
+- Updated dependencies [061c717]
+- Updated dependencies [2c55e13]
+- Updated dependencies [c745c26]
+- Updated dependencies [57900b5]
+- Updated dependencies [72694f6]
+  - @pikku/core@0.12.39
+
+## 0.12.17
+
+### Patch Changes
+
+- 92cd5b1: feat(workflow): workflow-owned step retries + stable invocationId
+
+  The workflow — not the queue — now owns step retry policy, and each step
+  invocation gets a stable idempotency key.
+  - **Default `retries: 5` with exponential backoff.** A step with no `retries`
+    previously inherited the queue's bare default (e.g. pg-boss `retry_limit 2`,
+    no backoff) so retries fired instantly and couldn't outlast a transient
+    outage. Retries now default to 5 with backoff, resolved at the workflow layer.
+  - **`retries: 0` is honored.** Dispatch previously passed `undefined` options
+    for `retries: 0`, letting the queue re-run a non-idempotent step up to its own
+    default. The resolved policy now always sets `attempts` (`retries: 0` →
+    `attempts: 1`), so the queue never second-guesses the workflow. The persisted
+    step retries and the dispatched `attempts` are resolved together so
+    "retries exhausted" and "no more redeliveries" are the same event.
+  - **`workflowStep.invocationId`** — a deterministic, dependency-free
+    `uuidv5(runId:stepName)` handed to every step. Unlike `stepId` (minted per
+    attempt), it is identical across retries, so a step can dedupe on it
+    (`ON CONFLICT (invocationId)`, Stripe idempotency keys, etc.).
+  - **queue-bullmq**: `mapPikkuJobToBull` now maps `backoff` (previously dropped,
+    so a step's backoff silently never applied on Redis), and `registerQueues`
+    throws a clear error when no logger is available (matching queue-pg-boss).
+  - **Dispatch failures are recoverable, not fatal.** A step is now marked
+    `scheduled` only _after_ it is successfully handed to its transport (queue or
+    scheduler) — a failed hand-off leaves it `pending` so a replay re-dispatches
+    it, instead of stranding it in `scheduled` (replay would pause forever on a
+    job that was never enqueued). A transport outage (e.g. pg-boss momentarily
+    down) is surfaced as a new `WorkflowDispatchException`, which the orchestrator
+    treats as transient: the run is left running and the orchestrator job is
+    rethrown for redelivery (it replays idempotently from the snapshot) rather
+    than the whole run being marked `failed`. The orchestrator job now also
+    carries its own retry policy, so this holds even when the orchestrator queue
+    is configured `retry_limit 0`. A genuine step error still fails the run.
+  - **Same step name can be invoked multiple times in one run.** Step rows are now
+    keyed per _invocation_: the Nth reach of a step name in a replay resolves to a
+    physical key (`name` for the first, `name#N` for repeats), so a literal
+    duplicate name no longer clobbers the earlier step's state. The first reach
+    keeps the bare name, so existing rows, graph-node matching and `invocationId`s
+    are unchanged. Ordinals are derived deterministically from DSL execution order
+    and reset each replay.
+  - **Step provenance (`fromStepName`) + graph cycles.** Every step now records
+    the predecessor it was scheduled from (`fromStepName`; entry steps have none),
+    persisted on the step row across all stores (in-memory, kysely, redis,
+    mongodb, cloudflare DO) and carried in the queued payload. The DSL wire
+    exposes the derived `fromInvocationId` (`uuidv5(runId:fromStepName)`) so
+    consumers get the stable predecessor key without a second persisted id —
+    `fromStepName` is the source of truth (it is replay-deterministic; `stepId`,
+    minted per row, is not). This makes the walked path reconstructable even when
+    a node is reached more than once: in `a → b → a → c` the second `a` is a
+    distinct ordinal instance (`a#1`) whose `fromStepName` is `b`.
+    The graph runner now supports **cycles**: a forward edge into an
+    already-started node still collapses to a single run (joins/diamonds are
+    unchanged), but a _back-edge_ — one whose target can reach its source — fires
+    a fresh ordinal instance, so a node can loop back to itself. Termination is
+    the graph's responsibility (branch routing must converge); the engine enforces
+    no visit cap.
+
+- Updated dependencies [92cd5b1]
+  - @pikku/core@0.12.38
+
 ## 0.12.16
 
 ### Patch Changes

package/dist/src/kysely-tables.d.ts

@@ -43,6 +43,7 @@ export interface WorkflowStepTable {
     branchTaken: string | null;
     retries: number | null;
     retryDelay: string | null;
+    fromStepName: string | null;
     createdAt: Generated<Date>;
     updatedAt: Generated<Date>;
 }

package/dist/src/kysely-workflow-mirror.js

@@ -61,6 +61,7 @@ export class KyselyWorkflowMirror {
             .addColumn('branch_taken', 'text')
             .addColumn('retries', 'integer')
             .addColumn('retry_delay', 'text')
+            .addColumn('from_step_name', 'text')
             .addColumn('created_at', 'timestamp', (col) => col.defaultTo(sql `CURRENT_TIMESTAMP`).notNull())
             .addColumn('updated_at', 'timestamp', (col) => col.defaultTo(sql `CURRENT_TIMESTAMP`).notNull())
             .addUniqueConstraint('workflow_step_run_name_unique', [
@@ -68,6 +69,14 @@ export class KyselyWorkflowMirror {
             'step_name',
         ])
             .execute();
+        // Additive: backfill the column on mirror tables created before from_step_name.
+        await this.db.schema
+            .alterTable('workflow_step')
+            .addColumn('from_step_name', 'text')
+            .execute()
+            .catch(() => {
+            // Column already exists (fresh tables include it above) — nothing to do.
+        });
         await this.db.schema
             .createTable('workflow_step_history')
             .ifNotExists()
@@ -144,6 +153,7 @@ export class KyselyWorkflowMirror {
             status: step.status,
             retries: step.retries ?? null,
             retryDelay: step.retryDelay?.toString() ?? null,
+            fromStepName: step.fromStepName ?? null,
             createdAt: now,
             updatedAt: now,
         })

package/dist/src/kysely-workflow-run-service.js

@@ -137,6 +137,7 @@ export class KyselyWorkflowRunService {
             .select([
             's.workflowStepId',
             's.stepName',
+            's.fromStepName',
             's.retries',
             's.retryDelay',
             'h.status',
@@ -158,6 +159,7 @@ export class KyselyWorkflowRunService {
             return {
                 stepId,
                 stepName: row.stepName,
+                fromStepName: row.fromStepName ?? undefined,
                 status: row.status,
                 result: parseJson(row.result),
                 error: parseJson(row.error),

package/dist/src/kysely-workflow-service.d.ts

@@ -1,5 +1,5 @@
 import type { SerializedError } from '@pikku/core';
-import { PikkuWorkflowService, type WorkflowPlannedStep, type WorkflowRun, type WorkflowRunWire, type StepState, type WorkflowStatus, type WorkflowVersionStatus } from '@pikku/core/workflow';
+import { PikkuWorkflowService, type WorkflowPlannedStep, type WorkflowRun, type WorkflowRunWire, type StepState, type StepStatus, type WorkflowStatus, type WorkflowVersionStatus } from '@pikku/core/workflow';
 import type { Kysely } from 'kysely';
 import type { KyselyPikkuDB } from './kysely-tables.js';
 export declare class KyselyWorkflowService extends PikkuWorkflowService {
@@ -17,7 +17,7 @@ export declare class KyselyWorkflowService extends PikkuWorkflowService {
     protected insertStepStateImpl(runId: string, stepName: string, rpcName: string | null, data: any, stepOptions?: {
         retries?: number;
         retryDelay?: string | number;
-    }): Promise<StepState>;
+    }, fromStepName?: string): Promise<StepState>;
     getStepState(runId: string, stepName: string): Promise<StepState>;
     getRunHistory(runId: string): Promise<Array<StepState & {
         stepName: string;
@@ -38,6 +38,11 @@ export declare class KyselyWorkflowService extends PikkuWorkflowService {
         branchKeys: Record<string, string>;
     }>;
     getNodesWithoutSteps(runId: string, nodeIds: string[]): Promise<string[]>;
+    getStepInstances(runId: string): Promise<Array<{
+        stepName: string;
+        status: StepStatus;
+        fromStepName?: string;
+    }>>;
     getNodeResults(runId: string, nodeIds: string[]): Promise<Record<string, any>>;
     protected setBranchTakenImpl(stepId: string, branchKey: string): Promise<void>;
     protected updateRunStateImpl(runId: string, name: string, value: unknown): Promise<void>;

package/dist/src/kysely-workflow-service.js

@@ -55,6 +55,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             .addColumn('branch_taken', 'text')
             .addColumn('retries', 'integer')
             .addColumn('retry_delay', 'text')
+            .addColumn('from_step_name', 'text')
             .addColumn('created_at', 'timestamp', (col) => col.defaultTo(sql `CURRENT_TIMESTAMP`).notNull())
             .addColumn('updated_at', 'timestamp', (col) => col.defaultTo(sql `CURRENT_TIMESTAMP`).notNull())
             .addUniqueConstraint('workflow_step_run_name_unique', [
@@ -62,6 +63,14 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             'step_name',
         ])
             .execute();
+        // Additive: backfill the column on tables created before from_step_name.
+        await this.db.schema
+            .alterTable('workflow_step')
+            .addColumn('from_step_name', 'text')
+            .execute()
+            .catch(() => {
+            // Column already exists (fresh tables include it above) — nothing to do.
+        });
         await this.db.schema
             .createTable('workflow_step_history')
             .ifNotExists()
@@ -132,7 +141,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             .where('workflowRunId', '=', id)
             .execute();
     }
-    async insertStepStateImpl(runId, stepName, rpcName, data, stepOptions) {
+    async insertStepStateImpl(runId, stepName, rpcName, data, stepOptions, fromStepName) {
         const stepId = crypto.randomUUID();
         const now = new Date();
         await this.db
@@ -146,6 +155,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             status: 'pending',
             retries: stepOptions?.retries ?? null,
             retryDelay: stepOptions?.retryDelay?.toString() ?? null,
+            fromStepName: fromStepName ?? null,
             createdAt: now,
             updatedAt: now,
         })
@@ -159,6 +169,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             attemptCount: 1,
             retries: stepOptions?.retries,
             retryDelay: stepOptions?.retryDelay?.toString(),
+            fromStepName,
             createdAt: now,
             updatedAt: now,
         };
@@ -173,6 +184,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             's.error',
             's.retries',
             's.retryDelay',
+            's.fromStepName',
             's.createdAt',
             's.updatedAt',
         ])
@@ -195,6 +207,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             attemptCount: Number(row.attemptCount),
             retries: row.retries != null ? Number(row.retries) : undefined,
             retryDelay: row.retryDelay ?? undefined,
+            fromStepName: row.fromStepName ?? undefined,
             createdAt: new Date(row.createdAt),
             updatedAt: new Date(row.updatedAt),
         };
@@ -218,7 +231,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         if (latestHistory) {
             await this.db
                 .updateTable('workflowStepHistory')
-                .set({ status: 'running' })
+                .set({ status: 'running', runningAt: new Date() })
                 .where('historyId', '=', latestHistory.historyId)
                 .execute();
         }
@@ -295,7 +308,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         if (latestHistory) {
             await this.db
                 .updateTable('workflowStepHistory')
-                .set({ status: 'succeeded', result: resultJson })
+                .set({ status: 'succeeded', result: resultJson, succeededAt: new Date() })
                 .where('historyId', '=', latestHistory.historyId)
                 .execute();
         }
@@ -327,7 +340,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         if (latestHistory) {
             await this.db
                 .updateTable('workflowStepHistory')
-                .set({ status: 'failed', error: errorJson })
+                .set({ status: 'failed', error: errorJson, failedAt: new Date() })
                 .where('historyId', '=', latestHistory.historyId)
                 .execute();
         }
@@ -348,6 +361,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             's.error',
             's.retries',
             's.retryDelay',
+            's.fromStepName',
             's.createdAt',
             's.updatedAt',
         ])
@@ -366,6 +380,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
             attemptCount: Number(row.attemptCount),
             retries: row.retries != null ? Number(row.retries) : undefined,
             retryDelay: row.retryDelay ?? undefined,
+            fromStepName: row.fromStepName ?? undefined,
             createdAt: new Date(row.createdAt),
             updatedAt: new Date(row.updatedAt),
         };
@@ -420,6 +435,18 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         const existingStepNames = new Set(result.map((r) => r.stepName));
         return nodeIds.filter((id) => !existingStepNames.has(id));
     }
+    async getStepInstances(runId) {
+        const rows = await this.db
+            .selectFrom('workflowStep')
+            .select(['stepName', 'status', 'fromStepName'])
+            .where('workflowRunId', '=', runId)
+            .execute();
+        return rows.map((r) => ({
+            stepName: r.stepName,
+            status: r.status,
+            fromStepName: r.fromStepName ?? undefined,
+        }));
+    }
     async getNodeResults(runId, nodeIds) {
         if (nodeIds.length === 0)
             return {};

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pikku/kysely",
-  "version": "0.12.16",
+  "version": "0.12.18",
   "author": "yasser.fadl@gmail.com",
   "license": "MIT",
   "module": "dist/src/index.js",
@@ -20,7 +20,7 @@
     "prepublishOnly": "yarn build"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.12.28"
+    "@pikku/core": "^0.12.39"
   },
   "dependencies": {
     "kysely": "^0.29.0"

package/src/kysely-tables.ts

@@ -51,6 +51,7 @@ export interface WorkflowStepTable {
   branchTaken: string | null
   retries: number | null
   retryDelay: string | null
+  fromStepName: string | null
   createdAt: Generated<Date>
   updatedAt: Generated<Date>
 }

package/src/kysely-workflow-mirror.test.ts

@@ -103,6 +103,29 @@ describe('KyselyWorkflowMirror — step lifecycle', () => {
     assert.equal(history[0]!.status, 'pending')
   })
 
+  test('getRunHistory surfaces step provenance (fromStepName)', async () => {
+    // The mirror persists fromStepName and getRunHistory reads it back, so the
+    // run history reconstructs the walked path (entry has none, the next step
+    // records its predecessor).
+    await seedStep(STEP_ID, 'begin')
+    await mirror.insertStepState(RUN_ID, {
+      stepId: `${STEP_ID}-2`,
+      stepName: 'next',
+      rpcName: 'rpc.fn',
+      data: { x: 2 },
+      status: 'pending',
+      attemptCount: 1,
+      fromStepName: 'begin',
+      createdAt: new Date(),
+      updatedAt: new Date(),
+    } as any)
+
+    const history = await runService.getRunHistory(RUN_ID)
+    const from = new Map(history.map((h) => [h.stepName, h.fromStepName]))
+    assert.equal(from.get('begin'), undefined, 'entry step has no predecessor')
+    assert.equal(from.get('next'), 'begin', 'next records its predecessor')
+  })
+
   test('running → succeeded updates the in-place history row', async () => {
     await seedStep()
     await mirror.setStepRunning(STEP_ID)

package/src/kysely-workflow-mirror.ts

@@ -79,6 +79,7 @@ export class KyselyWorkflowMirror implements WorkflowRunMirror {
       .addColumn('branch_taken', 'text')
       .addColumn('retries', 'integer')
       .addColumn('retry_delay', 'text')
+      .addColumn('from_step_name', 'text')
       .addColumn('created_at', 'timestamp', (col) =>
         col.defaultTo(sql`CURRENT_TIMESTAMP`).notNull()
       )
@@ -91,6 +92,15 @@ export class KyselyWorkflowMirror implements WorkflowRunMirror {
       ])
       .execute()
 
+    // Additive: backfill the column on mirror tables created before from_step_name.
+    await this.db.schema
+      .alterTable('workflow_step')
+      .addColumn('from_step_name', 'text')
+      .execute()
+      .catch(() => {
+        // Column already exists (fresh tables include it above) — nothing to do.
+      })
+
     await this.db.schema
       .createTable('workflow_step_history')
       .ifNotExists()
@@ -202,6 +212,7 @@ export class KyselyWorkflowMirror implements WorkflowRunMirror {
         status: step.status,
         retries: step.retries ?? null,
         retryDelay: step.retryDelay?.toString() ?? null,
+        fromStepName: step.fromStepName ?? null,
         createdAt: now,
         updatedAt: now,
       })

package/src/kysely-workflow-run-service.ts

@@ -192,6 +192,7 @@ export class KyselyWorkflowRunService implements WorkflowRunService {
       .select([
         's.workflowStepId',
         's.stepName',
+        's.fromStepName',
         's.retries',
         's.retryDelay',
         'h.status',
@@ -215,6 +216,7 @@ export class KyselyWorkflowRunService implements WorkflowRunService {
       return {
         stepId,
         stepName: row.stepName,
+        fromStepName: row.fromStepName ?? undefined,
         status: row.status as StepState['status'],
         result: parseJson(row.result),
         error: parseJson(row.error),

package/src/kysely-workflow-service.ts

@@ -5,6 +5,7 @@ import {
   type WorkflowRun,
   type WorkflowRunWire,
   type StepState,
+  type StepStatus,
   type WorkflowStatus,
   type WorkflowVersionStatus,
 } from '@pikku/core/workflow'
@@ -79,6 +80,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       .addColumn('branch_taken', 'text')
       .addColumn('retries', 'integer')
       .addColumn('retry_delay', 'text')
+      .addColumn('from_step_name', 'text')
       .addColumn('created_at', 'timestamp', (col) =>
         col.defaultTo(sql`CURRENT_TIMESTAMP`).notNull()
       )
@@ -91,6 +93,15 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       ])
       .execute()
 
+    // Additive: backfill the column on tables created before from_step_name.
+    await this.db.schema
+      .alterTable('workflow_step')
+      .addColumn('from_step_name', 'text')
+      .execute()
+      .catch(() => {
+        // Column already exists (fresh tables include it above) — nothing to do.
+      })
+
     await this.db.schema
       .createTable('workflow_step_history')
       .ifNotExists()
@@ -196,7 +207,8 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     stepName: string,
     rpcName: string | null,
     data: any,
-    stepOptions?: { retries?: number; retryDelay?: string | number }
+    stepOptions?: { retries?: number; retryDelay?: string | number },
+    fromStepName?: string
   ): Promise<StepState> {
     const stepId = crypto.randomUUID()
     const now = new Date()
@@ -212,6 +224,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         status: 'pending',
         retries: stepOptions?.retries ?? null,
         retryDelay: stepOptions?.retryDelay?.toString() ?? null,
+        fromStepName: fromStepName ?? null,
         createdAt: now,
         updatedAt: now,
       })
@@ -227,6 +240,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       attemptCount: 1,
       retries: stepOptions?.retries,
       retryDelay: stepOptions?.retryDelay?.toString(),
+      fromStepName,
       createdAt: now,
       updatedAt: now,
     }
@@ -242,6 +256,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         's.error',
         's.retries',
         's.retryDelay',
+        's.fromStepName',
         's.createdAt',
         's.updatedAt',
       ])
@@ -274,6 +289,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       attemptCount: Number(row.attemptCount),
       retries: row.retries != null ? Number(row.retries) : undefined,
       retryDelay: row.retryDelay ?? undefined,
+      fromStepName: row.fromStepName ?? undefined,
       createdAt: new Date(row.createdAt),
       updatedAt: new Date(row.updatedAt),
     }
@@ -303,7 +319,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     if (latestHistory) {
       await this.db
         .updateTable('workflowStepHistory')
-        .set({ status: 'running' })
+        .set({ status: 'running', runningAt: new Date() })
         .where('historyId', '=', latestHistory.historyId)
         .execute()
     }
@@ -401,7 +417,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     if (latestHistory) {
       await this.db
         .updateTable('workflowStepHistory')
-        .set({ status: 'succeeded', result: resultJson })
+        .set({ status: 'succeeded', result: resultJson, succeededAt: new Date() })
         .where('historyId', '=', latestHistory.historyId)
         .execute()
     }
@@ -440,7 +456,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     if (latestHistory) {
       await this.db
         .updateTable('workflowStepHistory')
-        .set({ status: 'failed', error: errorJson })
+        .set({ status: 'failed', error: errorJson, failedAt: new Date() })
         .where('historyId', '=', latestHistory.historyId)
         .execute()
     }
@@ -467,6 +483,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
         's.error',
         's.retries',
         's.retryDelay',
+        's.fromStepName',
         's.createdAt',
         's.updatedAt',
       ])
@@ -492,6 +509,7 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
       attemptCount: Number(row.attemptCount),
       retries: row.retries != null ? Number(row.retries) : undefined,
       retryDelay: row.retryDelay ?? undefined,
+      fromStepName: row.fromStepName ?? undefined,
       createdAt: new Date(row.createdAt),
       updatedAt: new Date(row.updatedAt),
     }
@@ -568,6 +586,21 @@ export class KyselyWorkflowService extends PikkuWorkflowService {
     return nodeIds.filter((id) => !existingStepNames.has(id))
   }
 
+  async getStepInstances(runId: string): Promise<
+    Array<{ stepName: string; status: StepStatus; fromStepName?: string }>
+  > {
+    const rows = await this.db
+      .selectFrom('workflowStep')
+      .select(['stepName', 'status', 'fromStepName'])
+      .where('workflowRunId', '=', runId)
+      .execute()
+    return rows.map((r) => ({
+      stepName: r.stepName,
+      status: r.status as StepStatus,
+      fromStepName: r.fromStepName ?? undefined,
+    }))
+  }
+
   async getNodeResults(
     runId: string,
     nodeIds: string[]