@pikku/inspector 0.12.65 → 0.12.66

package/CHANGELOG.md

@@ -1,3 +1,39 @@
+## 0.12.66
+
+### Patch Changes
+
+- 2f94a0a: Stop `pikku all` failing on a diagnostic its own codegen went on to fix.
+
+  The run inspects several times, because generating the scaffold, the leaf indexes and the type files each changes the source graph the next inspection reads. Every full inspection re-runs every validator, so the newest pass is the complete one — but the logger accumulated diagnostics across all of them, and the build gate failed the run if any pass had ever recorded a critical.
+
+  A project whose system roles grant a scaffold-declared scope (`virtualUser:*`) therefore could not build from clean: the pass taken before the scaffold existed raised PKU124, the pass taken after was clean, and the run failed anyway. Same for PKU951 on a scaffold-declared secret.
+
+  Validation diagnostics are now scoped to the pass that recorded them, so a later pass supersedes an earlier one. Diagnostics reported outside a validation pass — by a generator or a command — are untouched, and a fault every pass reports still fails the run.
+
+- 7eeff81: Record `rpc!.invoke(...)` as an invocation
+
+  `rpc` is optional on the wire, so a caller that knows it is there writes
+  `rpc!.invoke('someFunction', …)`. The inspector matched the receiver as a bare
+  identifier, but a non-null assertion is a node of its own wrapping that
+  identifier, so those call sites were never recorded.
+
+  That is silent rather than loud. An invocation is what puts a function that is
+  not `expose: true` into the runtime registry, so the target was left
+  unregistered and the dispatch failed with `Function not found` — at run time,
+  on a call site that type-checked.
+
+  The generated virtual-user scaffold dispatches exactly this way, which meant
+  `executeVirtualUserRun` was never registered: every virtual-user run sat at
+  `running` forever with nothing logged, because the scaffold's own
+  `.catch(() => {})` swallowed the rejection.
+
+  The receiver is now unwrapped through non-null assertions and parentheses
+  before it is matched.
+
+- Updated dependencies [88629af]
+- Updated dependencies [f1ccfe3]
+  - @pikku/core@0.12.96
+
 ## 0.12.65
 
 ### Patch Changes

package/dist/add/add-rpc-invocations.js

@@ -13,6 +13,25 @@ function outerParent(node) {
 function findCastArg(args) {
     return args.find(hasTypeCast);
 }
+/**
+ * The `rpc` in `rpc.invoke(...)`, seen through whatever the author wrote to
+ * satisfy the type checker.
+ *
+ * `rpc` is optional on the wire, so a caller that knows it is there reaches for
+ * `rpc!.invoke(...)` — and a non-null assertion is a node of its own, not the
+ * identifier underneath it. Matching only the bare identifier meant those calls
+ * were never recorded as invocations, which is silent rather than loud: the
+ * target is not `expose: true`, so nothing else puts it in the registry, and
+ * the dispatch fails with "Function not found" at run time on a call site that
+ * type-checked. Parentheses are unwrapped for the same reason.
+ */
+function invocationReceiver(node) {
+    let inner = node;
+    while (ts.isNonNullExpression(inner) || ts.isParenthesizedExpression(inner)) {
+        inner = inner.expression;
+    }
+    return inner;
+}
 /**
  * Helper to extract namespace from a namespaced function reference like 'ext:hello'
  */
@@ -62,10 +81,14 @@ export function addRPCInvocations(node, state, logger) {
             }
         }
         // Check for rpc.invoke('...') calls
+        const invokeReceiver = ts.isPropertyAccessExpression(expression)
+            ? invocationReceiver(expression.expression)
+            : undefined;
         if (ts.isPropertyAccessExpression(expression) &&
             expression.name.text === 'invoke' &&
-            ts.isIdentifier(expression.expression) &&
-            expression.expression.text === 'rpc') {
+            invokeReceiver &&
+            ts.isIdentifier(invokeReceiver) &&
+            invokeReceiver.text === 'rpc') {
             // Skip PKU940 for generated files — they may contain intentional casts
             // (e.g. the paginated useInfiniteQuery hook in pikku-react-query.gen.ts).
             const sourceFileName = node.getSourceFile().fileName;

package/dist/inspector.js

@@ -371,6 +371,10 @@ export const inspect = async (logger, routeFiles, options = {}) => {
     state.filesAndMethodsErrors = errors;
     logger.debug(`Get files and methods completed in ${(performance.now() - startFilesAndMethods).toFixed(2)}ms`);
     if (!options.setupOnly) {
+        // Everything below re-derives from the state this pass just built, so it
+        // supersedes whatever an earlier pass concluded about a source graph the
+        // run has since finished generating into.
+        logger.beginValidationPass?.();
         const startAggregate = performance.now();
         // Apply the inspected auth handler service set before aggregation so it
         // flows into requiredServices (the generated handler's own func is opaque).
@@ -408,6 +412,7 @@ export const inspect = async (logger, routeFiles, options = {}) => {
         validateScopeReferences(logger, state);
         validateSystemRoleScopes(logger, state);
         validatePersonaRoles(logger, state);
+        logger.endValidationPass?.();
     }
     state.program = program;
     return state;

package/dist/types.d.ts

@@ -300,6 +300,24 @@ export interface InspectorLogger {
     /** Sugar for `diagnostic({ severity: 'critical', code, message })`. */
     critical: (code: ErrorCode, message: string) => void;
     hasCriticalErrors: () => boolean;
+    /**
+     * Opens a validation pass, discarding whatever a previous one recorded.
+     *
+     * A single `pikku all` inspects several times, because generating the
+     * scaffold, the leaf indexes and the type files each changes the source graph
+     * the next inspection reads. The validators are pure functions of that graph
+     * and every full inspection re-runs all of them, so the newest pass is always
+     * the complete one and the ones before it are strictly superseded.
+     *
+     * Without this the diagnostics accumulated instead, and a run failed on a
+     * complaint about its own half-built input: a project whose roles reference
+     * scaffold-declared scopes was reported as failing even though the pass that
+     * ran once the scaffold existed was clean. Optional so a host supplying its
+     * own logger keeps working — one that omits it simply never discards.
+     */
+    beginValidationPass?: () => void;
+    /** Closes the pass opened by `beginValidationPass`. */
+    endValidationPass?: () => void;
 }
 export type AddWiring = (logger: InspectorLogger, node: ts.Node, checker: ts.TypeChecker, state: InspectorState, options: InspectorOptions) => void;
 export interface InspectorFilesAndMethods {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pikku/inspector",
-  "version": "0.12.65",
+  "version": "0.12.66",
   "description": "TypeScript inspector for Pikku — discovers functions and wirings to drive code generation",
   "author": "yasser.fadl@gmail.com",
   "license": "BUSL-1.1",
@@ -45,10 +45,10 @@
     "zod-to-ts": "^2.1.0"
   },
   "peerDependencies": {
-    "@pikku/core": "^0.12.95"
+    "@pikku/core": "^0.12.96"
   },
   "devDependencies": {
-    "@pikku/core": "^0.12.95",
+    "@pikku/core": "^0.12.96",
     "@types/node": "^24.13.3"
   },
   "engines": {

package/src/add/add-rpc-invocations.test.ts

@@ -110,4 +110,54 @@ export const routes = { stream: { func: ref('console:streamWorkflowRun') } }
       await rm(dir, { recursive: true, force: true })
     }
   })
+
+  test('a non-null assertion on the receiver is still an invocation', async () => {
+    const { state, dir } = await inspectFiles({
+      'caller.ts': `
+declare const rpc: { invoke: (name: string, data?: unknown) => Promise<unknown> } | undefined
+export async function doWork() {
+  return rpc!.invoke('executeVirtualUserRun')
+}
+`,
+    })
+    try {
+      assert.ok(state.rpc.invokedFunctions.has('executeVirtualUserRun'))
+      const invoked = [...state.rpc.invokedFunctionsByFile.values()][0]!
+      assert.deepStrictEqual([...invoked], ['executeVirtualUserRun'])
+    } finally {
+      await rm(dir, { recursive: true, force: true })
+    }
+  })
+
+  test('a parenthesised receiver is still an invocation', async () => {
+    const { state, dir } = await inspectFiles({
+      'caller.ts': `
+declare const rpc: { invoke: (name: string, data?: unknown) => Promise<unknown> } | undefined
+export async function doWork() {
+  return (rpc!).invoke('listTasks')
+}
+`,
+    })
+    try {
+      assert.ok(state.rpc.invokedFunctions.has('listTasks'))
+    } finally {
+      await rm(dir, { recursive: true, force: true })
+    }
+  })
+
+  test('invoke on some other receiver is left alone', async () => {
+    const { state, dir } = await inspectFiles({
+      'caller.ts': `
+declare const client: { invoke: (name: string, data?: unknown) => Promise<unknown> } | undefined
+export async function doWork() {
+  return client!.invoke('notAnRpc')
+}
+`,
+    })
+    try {
+      assert.ok(!state.rpc.invokedFunctions.has('notAnRpc'))
+    } finally {
+      await rm(dir, { recursive: true, force: true })
+    }
+  })
 })

package/src/add/add-rpc-invocations.ts

@@ -20,6 +20,26 @@ function findCastArg(
   return args.find(hasTypeCast)
 }
 
+/**
+ * The `rpc` in `rpc.invoke(...)`, seen through whatever the author wrote to
+ * satisfy the type checker.
+ *
+ * `rpc` is optional on the wire, so a caller that knows it is there reaches for
+ * `rpc!.invoke(...)` — and a non-null assertion is a node of its own, not the
+ * identifier underneath it. Matching only the bare identifier meant those calls
+ * were never recorded as invocations, which is silent rather than loud: the
+ * target is not `expose: true`, so nothing else puts it in the registry, and
+ * the dispatch fails with "Function not found" at run time on a call site that
+ * type-checked. Parentheses are unwrapped for the same reason.
+ */
+function invocationReceiver(node: ts.Expression): ts.Expression {
+  let inner = node
+  while (ts.isNonNullExpression(inner) || ts.isParenthesizedExpression(inner)) {
+    inner = inner.expression
+  }
+  return inner
+}
+
 /**
  * Helper to extract namespace from a namespaced function reference like 'ext:hello'
  */
@@ -80,11 +100,15 @@ export function addRPCInvocations(
     }
 
     // Check for rpc.invoke('...') calls
+    const invokeReceiver = ts.isPropertyAccessExpression(expression)
+      ? invocationReceiver(expression.expression)
+      : undefined
     if (
       ts.isPropertyAccessExpression(expression) &&
       expression.name.text === 'invoke' &&
-      ts.isIdentifier(expression.expression) &&
-      expression.expression.text === 'rpc'
+      invokeReceiver &&
+      ts.isIdentifier(invokeReceiver) &&
+      invokeReceiver.text === 'rpc'
     ) {
       // Skip PKU940 for generated files — they may contain intentional casts
       // (e.g. the paginated useInfiniteQuery hook in pikku-react-query.gen.ts).

package/src/inspector.ts

@@ -493,6 +493,10 @@ export const inspect = async (
   )
 
   if (!options.setupOnly) {
+    // Everything below re-derives from the state this pass just built, so it
+    // supersedes whatever an earlier pass concluded about a source graph the
+    // run has since finished generating into.
+    logger.beginValidationPass?.()
     const startAggregate = performance.now()
     // Apply the inspected auth handler service set before aggregation so it
     // flows into requiredServices (the generated handler's own func is opaque).
@@ -542,6 +546,7 @@ export const inspect = async (
     validateScopeReferences(logger, state)
     validateSystemRoleScopes(logger, state)
     validatePersonaRoles(logger, state)
+    logger.endValidationPass?.()
   }
 
   state.program = program

package/src/types.ts

@@ -366,6 +366,24 @@ export interface InspectorLogger {
   /** Sugar for `diagnostic({ severity: 'critical', code, message })`. */
   critical: (code: ErrorCode, message: string) => void
   hasCriticalErrors: () => boolean
+  /**
+   * Opens a validation pass, discarding whatever a previous one recorded.
+   *
+   * A single `pikku all` inspects several times, because generating the
+   * scaffold, the leaf indexes and the type files each changes the source graph
+   * the next inspection reads. The validators are pure functions of that graph
+   * and every full inspection re-runs all of them, so the newest pass is always
+   * the complete one and the ones before it are strictly superseded.
+   *
+   * Without this the diagnostics accumulated instead, and a run failed on a
+   * complaint about its own half-built input: a project whose roles reference
+   * scaffold-declared scopes was reported as failing even though the pass that
+   * ran once the scaffold existed was clean. Optional so a host supplying its
+   * own logger keeps working — one that omits it simply never discards.
+   */
+  beginValidationPass?: () => void
+  /** Closes the pass opened by `beginValidationPass`. */
+  endValidationPass?: () => void
 }
 
 export type AddWiring = (