@pikku/inspector 0.11.0 → 0.11.2

package/src/add/add-mcp-prompt.ts

@@ -1,7 +1,7 @@
 import * as ts from 'typescript'
 import {
   getPropertyValue,
-  getPropertyTags,
+  getCommonWireMetaData,
 } from '../utils/get-property-value.js'
 import { extractWireNames } from '../utils/post-process.js'
 import { ensureFunctionMetadata } from '../utils/ensure-function-metadata.js'
@@ -40,10 +40,12 @@ export const addMCPPrompt: AddWiring = (
     const obj = firstArg
 
     const nameValue = getPropertyValue(obj, 'name') as string | null
-    const descriptionValue = getPropertyValue(obj, 'description') as
-      | string
-      | null
-    const tags = getPropertyTags(obj, 'MCP prompt', nameValue, logger)
+    const { tags, summary, description, errors } = getCommonWireMetaData(
+      obj,
+      'MCP prompt',
+      nameValue,
+      logger
+    )
 
     const funcInitializer = getPropertyAssignmentInitializer(
       obj,
@@ -76,7 +78,7 @@ export const addMCPPrompt: AddWiring = (
       return
     }
 
-    if (!descriptionValue) {
+    if (!description) {
       logger.critical(
         ErrorCode.MISSING_DESCRIPTION,
         `MCP prompt '${nameValue}' is missing a description.`
@@ -116,7 +118,9 @@ export const addMCPPrompt: AddWiring = (
     state.mcpEndpoints.promptsMeta[nameValue] = {
       pikkuFuncName,
       name: nameValue,
-      description: descriptionValue,
+      description,
+      summary,
+      errors,
       tags,
       inputSchema,
       outputSchema,

package/src/add/add-mcp-resource.ts

@@ -1,7 +1,7 @@
 import * as ts from 'typescript'
 import {
   getPropertyValue,
-  getPropertyTags,
+  getCommonWireMetaData,
 } from '../utils/get-property-value.js'
 import { extractWireNames } from '../utils/post-process.js'
 import { ensureFunctionMetadata } from '../utils/ensure-function-metadata.js'
@@ -41,11 +41,13 @@ export const addMCPResource: AddWiring = (
 
     const uriValue = getPropertyValue(obj, 'uri') as string | null
     const titleValue = getPropertyValue(obj, 'title') as string | null
-    const descriptionValue = getPropertyValue(obj, 'description') as
-      | string
-      | null
+    const { tags, summary, description, errors } = getCommonWireMetaData(
+      obj,
+      'MCP resource',
+      uriValue,
+      logger
+    )
     const streamingValue = getPropertyValue(obj, 'streaming') as boolean | null
-    const tags = getPropertyTags(obj, 'MCP resource', uriValue, logger)
 
     if (streamingValue === true) {
       logger.warn(
@@ -92,7 +94,7 @@ export const addMCPResource: AddWiring = (
       return
     }
 
-    if (!descriptionValue) {
+    if (!description) {
       logger.critical(
         ErrorCode.MISSING_DESCRIPTION,
         `MCP resource '${uriValue}' is missing a description.`
@@ -133,7 +135,9 @@ export const addMCPResource: AddWiring = (
       pikkuFuncName,
       uri: uriValue,
       title: titleValue,
-      description: descriptionValue,
+      description,
+      summary,
+      errors,
       ...(streamingValue !== null && { streaming: streamingValue }),
       tags,
       inputSchema,

package/src/add/add-mcp-tool.ts

@@ -1,7 +1,7 @@
 import * as ts from 'typescript'
 import {
   getPropertyValue,
-  getPropertyTags,
+  getCommonWireMetaData,
 } from '../utils/get-property-value.js'
 import { extractWireNames } from '../utils/post-process.js'
 import { ensureFunctionMetadata } from '../utils/ensure-function-metadata.js'
@@ -41,11 +41,13 @@ export const addMCPTool: AddWiring = (
 
     const nameValue = getPropertyValue(obj, 'name') as string | null
     const titleValue = getPropertyValue(obj, 'title') as string | null
-    const descriptionValue = getPropertyValue(obj, 'description') as
-      | string
-      | null
+    const { tags, summary, description, errors } = getCommonWireMetaData(
+      obj,
+      'MCP tool',
+      nameValue,
+      logger
+    )
     const streamingValue = getPropertyValue(obj, 'streaming') as boolean | null
-    const tags = getPropertyTags(obj, 'MCP tool', nameValue, logger)
 
     if (streamingValue === true) {
       logger.warn(
@@ -84,7 +86,7 @@ export const addMCPTool: AddWiring = (
       return
     }
 
-    if (!descriptionValue) {
+    if (!description) {
       logger.critical(
         ErrorCode.MISSING_DESCRIPTION,
         `MCP tool '${nameValue}' is missing a description.`
@@ -125,7 +127,9 @@ export const addMCPTool: AddWiring = (
       pikkuFuncName,
       name: nameValue,
       title: titleValue || undefined,
-      description: descriptionValue,
+      description,
+      summary,
+      errors,
       ...(streamingValue !== null && { streaming: streamingValue }),
       tags,
       inputSchema,

package/src/add/add-middleware.ts

@@ -125,7 +125,7 @@ export const addMiddleware: AddWiring = (logger, node, checker, state) => {
       }
     } else {
       // No pikkuMiddleware wrapper found - extract from factory's return value directly
-      // Factory pattern: (config) => (services, interaction, next) => { ... }
+      // Factory pattern: (config) => (services, wire, next) => { ... }
       if (
         ts.isArrowFunction(factoryNode) ||
         ts.isFunctionExpression(factoryNode)

package/src/add/add-permission.ts

@@ -125,7 +125,7 @@ export const addPermission: AddWiring = (logger, node, checker, state) => {
       }
     } else {
       // No pikkuPermission wrapper found - extract from factory's return value directly
-      // Factory pattern: (config) => (services, data, session) => { ... }
+      // Factory pattern: (config) => (services, data, wire) => { ... }
       if (
         ts.isArrowFunction(factoryNode) ||
         ts.isFunctionExpression(factoryNode)

package/src/add/add-queue-worker.ts

@@ -1,9 +1,8 @@
 import * as ts from 'typescript'
 import {
   getPropertyValue,
-  getPropertyTags,
+  getCommonWireMetaData,
 } from '../utils/get-property-value.js'
-import { PikkuDocs } from '@pikku/core'
 import { AddWiring } from '../types.js'
 import { extractFunctionName } from '../utils/extract-function-name.js'
 import { getPropertyAssignmentInitializer } from '../utils/type-utils.js'
@@ -11,13 +10,7 @@ import { resolveMiddleware } from '../utils/middleware.js'
 import { extractWireNames } from '../utils/post-process.js'
 import { ErrorCode } from '../error-codes.js'
 
-export const addQueueWorker: AddWiring = (
-  logger,
-  node,
-  checker,
-  state,
-  options
-) => {
+export const addQueueWorker: AddWiring = (logger, node, checker, state) => {
   if (!ts.isCallExpression(node)) {
     return
   }
@@ -39,8 +32,12 @@ export const addQueueWorker: AddWiring = (
     const obj = firstArg
 
     const queueName = getPropertyValue(obj, 'queueName') as string | null
-    const docs = (getPropertyValue(obj, 'docs') as PikkuDocs) || undefined
-    const tags = getPropertyTags(obj, 'Queue worker', queueName, logger)
+    const { tags, summary, description, errors } = getCommonWireMetaData(
+      obj,
+      'Queue worker',
+      queueName,
+      logger
+    )
 
     // --- find the referenced function ---
     const funcInitializer = getPropertyAssignmentInitializer(
@@ -84,7 +81,9 @@ export const addQueueWorker: AddWiring = (
     state.queueWorkers.meta[queueName] = {
       pikkuFuncName,
       queueName,
-      docs,
+      summary,
+      description,
+      errors,
       tags,
       middleware,
     }

package/src/add/add-rpc-invocations.ts

@@ -1,48 +1,78 @@
 import * as ts from 'typescript'
 import { InspectorState, InspectorLogger } from '../types.js'
 
+/**
+ * Helper to extract namespace from a namespaced function reference like 'ext:hello'
+ */
+function extractNamespace(functionRef: string): string | null {
+  const colonIndex = functionRef.indexOf(':')
+  if (colonIndex !== -1) {
+    return functionRef.substring(0, colonIndex)
+  }
+  return null
+}
+
 /**
  * Scan for rpc.invoke() calls to track which functions are actually being invoked
+ * Also detects external package usage via:
+ * - Namespaced calls: rpc.invoke('namespace:function')
+ * - External helper: external('namespace:function')
  */
 export function addRPCInvocations(
   node: ts.Node,
   state: InspectorState,
   logger: InspectorLogger
 ) {
-  // Look for property access expressions: rpc.invoke
-  if (ts.isPropertyAccessExpression(node)) {
-    const { expression, name } = node
+  // Look for call expressions: external('ext:hello') or rpc.invoke('...')
+  if (ts.isCallExpression(node)) {
+    const { expression, arguments: args } = node
+
+    // Check for external('namespace:function') calls
+    if (ts.isIdentifier(expression) && expression.text === 'external') {
+      const [firstArg] = args
+      if (firstArg && ts.isStringLiteral(firstArg)) {
+        const functionRef = firstArg.text
+        logger.debug(`• Found external() call: ${functionRef}`)
+        state.rpc.invokedFunctions.add(functionRef)
 
-    // Check if this is accessing 'invoke' property
-    if (name.text === 'invoke') {
-      // Check if the object is 'rpc' (or a variable containing rpc)
-      if (ts.isIdentifier(expression) && expression.text === 'rpc') {
-        // This is rpc.invoke - now we need to find the parent call expression
-        const parent = node.parent
-        if (ts.isCallExpression(parent) && parent.expression === node) {
-          // This is rpc.invoke('function-name')
-          const [firstArg] = parent.arguments
-          if (firstArg) {
-            // Extract the function name from string literal
-            if (ts.isStringLiteral(firstArg)) {
-              const functionName = firstArg.text
-              logger.debug(`• Found RPC invocation: ${functionName}`)
-              state.rpc.invokedFunctions.add(functionName)
-            }
-            // Handle template literals like `function-${name}`
-            else if (
-              ts.isTemplateExpression(firstArg) ||
-              ts.isNoSubstitutionTemplateLiteral(firstArg)
-            ) {
-              logger.warn(
-                `• Found dynamic RPC invocation: ${firstArg.getText()}`
-              )
-              logger.warn(
-                `\tYou can only use string literals for RPC function names, with ' or " and not \``
-              )
-            }
+        const namespace = extractNamespace(functionRef)
+        if (namespace) {
+          logger.debug(`  → External package detected: ${namespace}`)
+          state.rpc.usedExternalPackages.add(namespace)
+        }
+      }
+    }
+
+    // Check for rpc.invoke('...') calls
+    if (
+      ts.isPropertyAccessExpression(expression) &&
+      expression.name.text === 'invoke' &&
+      ts.isIdentifier(expression.expression) &&
+      expression.expression.text === 'rpc'
+    ) {
+      const [firstArg] = args
+      if (firstArg) {
+        if (ts.isStringLiteral(firstArg)) {
+          const functionRef = firstArg.text
+          logger.debug(`• Found RPC invocation: ${functionRef}`)
+          state.rpc.invokedFunctions.add(functionRef)
+
+          const namespace = extractNamespace(functionRef)
+          if (namespace) {
+            logger.debug(`  → External package detected: ${namespace}`)
+            state.rpc.usedExternalPackages.add(namespace)
           }
         }
+        // Handle template literals like `function-${name}`
+        else if (
+          ts.isTemplateExpression(firstArg) ||
+          ts.isNoSubstitutionTemplateLiteral(firstArg)
+        ) {
+          logger.warn(`• Found dynamic RPC invocation: ${firstArg.getText()}`)
+          logger.warn(
+            `\tYou can only use string literals for RPC function names, with ' or " and not \``
+          )
+        }
       }
     }
   }

package/src/add/add-schedule.ts

@@ -1,9 +1,8 @@
 import * as ts from 'typescript'
 import {
   getPropertyValue,
-  getPropertyTags,
+  getCommonWireMetaData,
 } from '../utils/get-property-value.js'
-import { PikkuDocs } from '@pikku/core'
 import { AddWiring } from '../types.js'
 import { extractFunctionName } from '../utils/extract-function-name.js'
 import { getPropertyAssignmentInitializer } from '../utils/type-utils.js'
@@ -40,8 +39,12 @@ export const addSchedule: AddWiring = (
 
     const nameValue = getPropertyValue(obj, 'name') as string | null
     const scheduleValue = getPropertyValue(obj, 'schedule') as string | null
-    const docs = (getPropertyValue(obj, 'docs') as PikkuDocs) || undefined
-    const tags = getPropertyTags(obj, 'Scheduler', nameValue, logger)
+    const { tags, summary, description, errors } = getCommonWireMetaData(
+      obj,
+      'Scheduler',
+      nameValue,
+      logger
+    )
 
     const funcInitializer = getPropertyAssignmentInitializer(
       obj,
@@ -81,7 +84,9 @@ export const addSchedule: AddWiring = (
       pikkuFuncName,
       name: nameValue,
       schedule: scheduleValue,
-      docs,
+      summary,
+      description,
+      errors,
       tags,
       middleware,
     }