@pikku/core 0.12.27 → 0.12.28

package/src/wirings/channel/local/local-channel-handler.ts

@@ -1,3 +1,4 @@
+import type { Logger } from '../../../services/logger.js'
 import type { BinaryData } from '../channel.types.js'
 import { PikkuAbstractChannelHandler } from '../pikku-abstract-channel-handler.js'
 
@@ -7,19 +8,30 @@ export class PikkuLocalChannelHandler<
 > extends PikkuAbstractChannelHandler<OpeningData, Out> {
   private onMessageCallback?: (message: unknown) => void
   private onBinaryMessageCallback?: (data: BinaryData) => void
-  private openCallBack?: () => void
-  private closeCallbacks: (() => void)[] = []
+  private openCallBack?: () => Promise<void> | void
+  private closeCallbacks: (() => Promise<void> | void)[] = []
   private sendCallback?: (message: Out, isBinary?: boolean) => void
   private sendBinaryCallback?: (data: BinaryData) => void
+  private logger?: Logger
 
-  public registerOnOpen(callback: () => void): void {
+  constructor(
+    channelId: string,
+    channelName: string,
+    openingData: OpeningData,
+    logger?: Logger
+  ) {
+    super(channelId, channelName, openingData)
+    this.logger = logger
+  }
+
+  public registerOnOpen(callback: () => Promise<void> | void): void {
     this.openCallBack = callback
   }
 
-  public open() {
+  public async open(): Promise<void> {
     this.getChannel().state = 'open'
     if (this.openCallBack) {
-      this.openCallBack()
+      await this.openCallBack()
     }
   }
 
@@ -43,17 +55,20 @@ export class PikkuLocalChannelHandler<
     return this.onBinaryMessageCallback?.(data)
   }
 
-  public registerOnClose(callback: () => void): void {
+  public registerOnClose(callback: () => Promise<void> | void): void {
     this.closeCallbacks.push(callback)
   }
 
-  public close() {
+  public async close(): Promise<void> {
     if (this.getChannel().state === 'closed') {
       return
     }
     super.close()
-    for (const cb of this.closeCallbacks) {
-      cb()
+    const results = await Promise.allSettled(this.closeCallbacks.map((cb) => cb()))
+    for (const result of results) {
+      if (result.status === 'rejected') {
+        this.logger?.error('Error in channel close callback:', result.reason)
+      }
     }
   }
 

package/src/wirings/channel/local/local-channel-runner.ts

@@ -119,7 +119,8 @@ export const runLocalChannel = async ({
       channelHandler = new PikkuLocalChannelHandler(
         channelId,
         channelConfig.name,
-        openingData
+        openingData,
+        singletonServices.logger
       )
       const channel = channelHandler.getChannel()
       const wire: PikkuWire = {

package/src/wirings/cli/cli-runner.test.ts

@@ -128,6 +128,7 @@ describe('CLI Runner', () => {
           pikkuFuncId: 'greetFunc',
           inputSchemaName: null,
           outputSchemaName: null,
+          sessionless: true,
         },
       })
 
@@ -192,6 +193,7 @@ describe('CLI Runner', () => {
           pikkuFuncId: 'testFunc',
           inputSchemaName: null,
           outputSchemaName: null,
+          sessionless: true,
         },
       })
 
@@ -252,6 +254,7 @@ describe('CLI Runner', () => {
           pikkuFuncId: 'greetFunc',
           inputSchemaName: null,
           outputSchemaName: null,
+          sessionless: true,
         },
       })
 
@@ -296,6 +299,7 @@ describe('CLI Runner', () => {
           pikkuFuncId: 'secureFunc',
           inputSchemaName: null,
           outputSchemaName: null,
+          sessionless: true,
         },
       })
 

package/src/wirings/http/http-runner.test.ts

@@ -129,6 +129,7 @@ const setRouteMeta = (
     inputSchemaName: null,
     outputSchemaName: null,
     sessionless: true,
+    sessionless: true,
     permissions: undefined,
     middleware: undefined,
   } as any

package/src/wirings/queue/queue-runner.test.ts

@@ -43,6 +43,7 @@ const addTestQueueFunction = (pikkuFuncId: string) => {
     pikkuFuncId,
     inputSchemaName: null,
     outputSchemaName: null,
+    sessionless: true,
     middleware: undefined,
     permissions: undefined,
   }

package/src/wirings/scheduler/scheduler-runner.test.ts

@@ -157,6 +157,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_simple-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -199,6 +200,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_task-with-session',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -287,6 +289,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_skipped-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -332,6 +335,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_skipped-task-no-reason',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -380,6 +384,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_wire-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -420,6 +425,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_session-services-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -469,6 +475,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_cleanup-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -517,6 +524,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_error-cleanup-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -558,6 +566,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_error-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 
@@ -607,6 +616,7 @@ describe('runScheduledTask', () => {
       pikkuFuncId: 'scheduler_middleware-task',
       inputSchemaName: null,
       outputSchemaName: null,
+      sessionless: true,
     }
     wireScheduler(mockTask)
 

package/src/wirings/workflow/pikku-workflow-service.ts

@@ -879,7 +879,16 @@ export abstract class PikkuWorkflowService implements WorkflowService {
     data: unknown,
     stepOptions?: WorkflowStepOptions
   ): Promise<boolean> {
-    if (this.isInline(runId) || !getSingletonServices()?.queueService) {
+    if (!getSingletonServices()?.queueService) {
+      return false
+    }
+    // Functions default to inline execution. Only dispatch via queue when the
+    // function explicitly sets inline: false.
+    const functionsMeta = pikkuState(null, 'function', 'meta')
+    const rpcFuncId = pikkuState(null, 'rpc', 'meta')[rpcName]
+    const rpcMeta = typeof rpcFuncId === 'string' ? functionsMeta[rpcFuncId] : undefined
+    const forceQueue = rpcMeta?.inline === false
+    if (!forceQueue && this.isInline(runId)) {
       return false
     }
     const retries = stepOptions?.retries ?? 0