@pikku/core 0.11.2 → 0.12.1

package/src/wirings/secret/validate-secret-definitions.ts

@@ -0,0 +1,82 @@
+import type {
+  SecretDefinitions,
+  SecretDefinitionsMeta,
+} from './secret.types.js'
+
+export interface SchemaRefLike {
+  variableName: string
+  sourceFile: string
+}
+
+export function validateAndBuildSecretDefinitionsMeta(
+  definitions: SecretDefinitions,
+  schemaLookup: Map<string, SchemaRefLike>
+): SecretDefinitionsMeta {
+  const meta: SecretDefinitionsMeta = {}
+  const secretIdToDefinition: Map<string, SecretDefinitions[0]> = new Map()
+
+  for (const def of definitions) {
+    const existingDef = secretIdToDefinition.get(def.secretId)
+
+    if (existingDef) {
+      if (def.schema && existingDef.schema) {
+        const defSchemaRef = schemaLookup.get(def.schema as string)
+        const existingSchemaRef = schemaLookup.get(existingDef.schema as string)
+
+        if (defSchemaRef && existingSchemaRef) {
+          if (
+            defSchemaRef.variableName !== existingSchemaRef.variableName ||
+            defSchemaRef.sourceFile !== existingSchemaRef.sourceFile
+          ) {
+            throw new Error(
+              `Secret '${def.secretId}' is defined with different schemas.\n` +
+                `  First definition: ${existingDef.sourceFile} (schema: ${existingSchemaRef.variableName})\n` +
+                `  Second definition: ${def.sourceFile} (schema: ${defSchemaRef.variableName})\n` +
+                `Credentials sharing a secretId must use the same schema.`
+            )
+          }
+        }
+      }
+
+      if (def.oauth2 && existingDef.oauth2) {
+        if (JSON.stringify(def.oauth2) !== JSON.stringify(existingDef.oauth2)) {
+          throw new Error(
+            `OAuth2 secret '${def.secretId}' is defined with different configurations.\n` +
+              `  First definition: ${existingDef.sourceFile}\n` +
+              `  Second definition: ${def.sourceFile}\n` +
+              `Credentials sharing a secretId must use the same configuration.`
+          )
+        }
+      }
+
+      if (!meta[def.name]) {
+        meta[def.name] = {
+          name: def.name,
+          displayName: def.displayName,
+          description: def.description,
+          secretId: def.secretId,
+          schema: def.schema,
+          oauth2: def.oauth2,
+          sourceFile: def.sourceFile,
+        }
+      }
+      continue
+    }
+
+    secretIdToDefinition.set(def.secretId, def)
+
+    if (!meta[def.name]) {
+      meta[def.name] = {
+        name: def.name,
+        displayName: def.displayName,
+        description: def.description,
+        secretId: def.secretId,
+        schema: def.schema,
+        oauth2: def.oauth2,
+        sourceFile: def.sourceFile,
+      }
+    }
+  }
+
+  return meta
+}

package/src/wirings/trigger/index.ts

@@ -1,2 +1,10 @@
-export * from './trigger.types.js'
-export * from './trigger-runner.js'
+export { wireTrigger, wireTriggerSource } from './trigger-runner.js'
+export { PikkuTriggerService } from './pikku-trigger-service.js'
+export type {
+  TriggerMeta,
+  TriggerSourceMeta,
+  CorePikkuTriggerFunction,
+  CorePikkuTriggerFunctionConfig,
+  CoreTrigger,
+  PikkuTrigger,
+} from './trigger.types.js'

package/src/wirings/trigger/pikku-trigger-service.ts

@@ -0,0 +1,112 @@
+import { rpcService } from '../rpc/rpc-runner.js'
+import { setupTrigger } from './trigger-runner.js'
+import type { TriggerInstance } from './trigger.types.js'
+import type { TriggerService } from '../../services/trigger-service.js'
+import {
+  getSingletonServices,
+  getCreateWireServices,
+  pikkuState,
+} from '../../pikku-state.js'
+
+export type TriggerTarget = {
+  targetType: 'rpc' | 'workflow'
+  targetName: string
+  startNode?: string
+}
+
+export type TriggerSourceInfo = {
+  name: string
+  input: unknown
+}
+
+export abstract class PikkuTriggerService implements TriggerService {
+  protected activeTriggers = new Map<string, TriggerInstance>()
+
+  abstract start(): Promise<void>
+
+  async stop(): Promise<void> {
+    const singletonServices = getSingletonServices()
+    for (const [name, instance] of this.activeTriggers) {
+      try {
+        await instance.teardown()
+        singletonServices.logger.info(`Stopped trigger: ${name}`)
+      } catch (error) {
+        singletonServices.logger.error(
+          `Error stopping trigger ${name}: ${error}`
+        )
+      }
+    }
+    this.activeTriggers.clear()
+  }
+
+  protected getTriggerTargets(): Map<string, TriggerTarget[]> {
+    const triggers = pikkuState(null, 'trigger', 'triggers')
+
+    const triggerTargets = new Map<string, TriggerTarget[]>()
+
+    for (const [name] of triggers) {
+      const meta = pikkuState(null, 'trigger', 'meta')[name]
+      if (meta) {
+        if (!triggerTargets.has(name)) {
+          triggerTargets.set(name, [])
+        }
+        triggerTargets.get(name)!.push({
+          targetType: 'rpc',
+          targetName: meta.pikkuFuncId,
+        })
+      }
+    }
+
+    return triggerTargets
+  }
+
+  protected getTriggerSources(): Map<string, { input?: unknown }> {
+    return pikkuState(null, 'trigger', 'triggerSources')
+  }
+
+  protected async setupTriggerInstance(
+    name: string,
+    input: unknown,
+    onTrigger: (data: unknown) => Promise<void>
+  ): Promise<TriggerInstance> {
+    return setupTrigger({
+      name,
+      input,
+      onTrigger,
+    })
+  }
+
+  protected async onTriggerFire(
+    triggerName: string,
+    targets: TriggerTarget[],
+    data: unknown
+  ): Promise<void> {
+    const singletonServices = getSingletonServices()
+    const createWireServices = getCreateWireServices()
+    const wireServices = await createWireServices?.(singletonServices, {})
+    const services = { ...singletonServices, ...wireServices }
+    const rpc = rpcService.getContextRPCService(services, {}, false)
+
+    for (const target of targets) {
+      try {
+        if (target.targetType === 'workflow') {
+          await rpc.startWorkflow(target.targetName, data, {
+            startNode: target.startNode,
+          })
+          singletonServices.logger.info(
+            `Trigger '${triggerName}' started workflow '${target.targetName}'`
+          )
+        } else {
+          await rpc.invoke(target.targetName, data)
+          singletonServices.logger.info(
+            `Trigger '${triggerName}' invoked RPC '${target.targetName}'`
+          )
+        }
+      } catch (error) {
+        singletonServices.logger.error(
+          `Error invoking ${target.targetType} '${target.targetName}' from trigger '${triggerName}': ${error}`
+        )
+      }
+    }
+  }
+}

package/src/wirings/trigger/trigger-runner.test.ts

@@ -0,0 +1,79 @@
+import { describe, test, beforeEach } from 'node:test'
+import assert from 'node:assert'
+import {
+  wireTrigger,
+  wireTriggerSource,
+  getRegisteredTriggers,
+  getTriggerMeta,
+} from './trigger-runner.js'
+import { resetPikkuState, pikkuState } from '../../pikku-state.js'
+import { PikkuMissingMetaError } from '../../errors/errors.js'
+
+beforeEach(() => {
+  resetPikkuState()
+})
+
+describe('wireTrigger', () => {
+  test('should register a trigger when meta exists', () => {
+    const meta = pikkuState(null, 'trigger', 'meta')
+    ;(meta as any)['myTrigger'] = { pikkuFuncId: 'triggerFunc' }
+
+    wireTrigger({ name: 'myTrigger', func: async () => {} } as any)
+
+    const triggers = getRegisteredTriggers()
+    assert.ok(triggers.has('myTrigger'))
+  })
+
+  test('should throw PikkuMissingMetaError when meta is missing', () => {
+    assert.throws(
+      () => wireTrigger({ name: 'noMeta', func: async () => {} } as any),
+      (err: any) => err instanceof PikkuMissingMetaError
+    )
+  })
+})
+
+describe('wireTriggerSource', () => {
+  test('should register a trigger source when meta exists', () => {
+    const sourceMeta = pikkuState(null, 'trigger', 'sourceMeta')
+    ;(sourceMeta as any)['mySource'] = { pikkuFuncId: 'sourceFunc' }
+
+    wireTriggerSource({ name: 'mySource', func: async () => {} } as any)
+
+    const sources = pikkuState(null, 'trigger', 'triggerSources')
+    assert.ok(sources.has('mySource'))
+  })
+
+  test('should throw PikkuMissingMetaError when source meta is missing', () => {
+    assert.throws(
+      () => wireTriggerSource({ name: 'noMeta', func: async () => {} } as any),
+      (err: any) => err instanceof PikkuMissingMetaError
+    )
+  })
+
+  test('should throw when trigger source already exists', () => {
+    const sourceMeta = pikkuState(null, 'trigger', 'sourceMeta')
+    ;(sourceMeta as any)['dupSource'] = { pikkuFuncId: 'sourceFunc' }
+
+    wireTriggerSource({ name: 'dupSource', func: async () => {} } as any)
+
+    assert.throws(
+      () =>
+        wireTriggerSource({ name: 'dupSource', func: async () => {} } as any),
+      { message: 'Trigger source already exists: dupSource' }
+    )
+  })
+})
+
+describe('getRegisteredTriggers', () => {
+  test('should return the triggers Map', () => {
+    const triggers = getRegisteredTriggers()
+    assert.ok(triggers instanceof Map)
+  })
+})
+
+describe('getTriggerMeta', () => {
+  test('should return the trigger meta object', () => {
+    const meta = getTriggerMeta()
+    assert.ok(typeof meta === 'object')
+  })
+})

package/src/wirings/trigger/trigger-runner.ts

@@ -1,84 +1,123 @@
-import type { CoreSingletonServices } from '../../types/core.types.js'
-import type { CoreTrigger, TriggerInstance } from './trigger.types.js'
-import { pikkuState } from '../../pikku-state.js'
-import type { CorePikkuTriggerFunctionConfig } from '../../function/functions.types.js'
+import type { PikkuWire } from '../../types/core.types.js'
+import type {
+  CoreTrigger,
+  CoreTriggerSource,
+  TriggerInstance,
+} from './trigger.types.js'
+import {
+  pikkuState,
+  getSingletonServices,
+  getCreateWireServices,
+} from '../../pikku-state.js'
+import { addFunction, runPikkuFunc } from '../../function/function-runner.js'
+import { PikkuMissingMetaError } from '../../errors/errors.js'
 
 /**
  * Registers a trigger with the Pikku framework.
- * The trigger will be available for setup via setupTrigger.
+ * Declares a trigger name and its target pikku function.
+ * Runs everywhere. Inspector extracts at build time.
  */
-export const wireTrigger = <
-  TConfig = unknown,
-  TOutput = unknown,
-  TriggerFunctionConfig extends CorePikkuTriggerFunctionConfig<
-    TConfig,
-    TOutput
-  > = CorePikkuTriggerFunctionConfig<TConfig, TOutput>,
->(
-  trigger: CoreTrigger<TConfig, TOutput, TriggerFunctionConfig>
-) => {
+export const wireTrigger = (trigger: CoreTrigger) => {
   const meta = pikkuState(null, 'trigger', 'meta')
   const triggerMeta = meta[trigger.name]
   if (!triggerMeta) {
-    throw new Error(`Trigger metadata not found: ${trigger.name}`)
+    throw new PikkuMissingMetaError(
+      `Missing generated metadata for trigger '${trigger.name}'`
+    )
   }
 
+  addFunction(triggerMeta.pikkuFuncId, trigger.func as any)
+
   const triggers = pikkuState(null, 'trigger', 'triggers')
-  if (triggers.has(trigger.name)) {
-    throw new Error(`Trigger already exists: ${trigger.name}`)
-  }
   triggers.set(trigger.name, trigger as any)
 }
 
+/**
+ * Registers a trigger source with the Pikku framework.
+ * Provides the actual subscription function and input data.
+ * Only imported in the trigger worker process.
+ */
+export const wireTriggerSource = <TInput = unknown, TOutput = unknown>(
+  source: CoreTriggerSource<TInput, TOutput>
+) => {
+  const sourceMeta = pikkuState(null, 'trigger', 'sourceMeta')
+  const triggerSourceMeta = sourceMeta[source.name]
+  if (!triggerSourceMeta) {
+    throw new PikkuMissingMetaError(
+      `Missing generated metadata for trigger source '${source.name}'`
+    )
+  }
+
+  const triggerSources = pikkuState(null, 'trigger', 'triggerSources')
+  if (triggerSources.has(source.name)) {
+    throw new Error(`Trigger source already exists: ${source.name}`)
+  }
+  triggerSources.set(source.name, source as any)
+
+  addFunction(
+    triggerSourceMeta.pikkuFuncId,
+    source.func as any,
+    triggerSourceMeta.packageName
+  )
+}
+
 /**
  * Parameters for setting up a trigger
  */
-export type SetupTriggerParams<TOutput = unknown> = {
+export type SetupTriggerParams<TInput = unknown, TOutput = unknown> = {
   name: string
-  singletonServices: CoreSingletonServices
+  input?: TInput
   onTrigger: (data: TOutput) => void | Promise<void>
 }
 
 /**
  * Sets up a registered trigger and starts listening for events.
  * Returns a TriggerInstance with a teardown function.
+ *
+ * @param name - The trigger name (must be registered via wireTrigger)
+ * @param input - The input to pass to the trigger function
+ * @param onTrigger - Callback invoked when the trigger fires
  */
-export async function setupTrigger<TOutput = unknown>({
+export async function setupTrigger<TInput = unknown, TOutput = unknown>({
   name,
-  singletonServices,
+  input,
   onTrigger,
-}: SetupTriggerParams<TOutput>): Promise<TriggerInstance> {
-  const trigger = pikkuState(null, 'trigger', 'triggers').get(name)
-  const meta = pikkuState(null, 'trigger', 'meta')[name]
+}: SetupTriggerParams<TInput, TOutput>): Promise<TriggerInstance> {
+  const singletonServices = getSingletonServices()
+  const createWireServices = getCreateWireServices()
+  const source = pikkuState(null, 'trigger', 'triggerSources').get(name)
+  const sourceMeta = pikkuState(null, 'trigger', 'sourceMeta')[name]
 
-  if (!trigger) {
-    throw new Error(`Trigger not found: ${name}`)
+  if (!source) {
+    throw new Error(`Trigger source not found: ${name}`)
   }
-  if (!meta) {
-    throw new Error(`Trigger metadata not found: ${name}`)
+  if (!sourceMeta) {
+    throw new PikkuMissingMetaError(
+      `Missing generated metadata for trigger source '${name}'`
+    )
   }
 
-  const wire = {
+  const wire: PikkuWire = {
     trigger: {
-      trigger: (data: TOutput) => {
+      invoke: (data: unknown) => {
         singletonServices.logger.info(`Trigger fired: ${name}`)
-        onTrigger(data)
+        onTrigger(data as TOutput)
       },
     },
   }
 
   singletonServices.logger.info(`Setting up trigger: ${name}`)
 
-  const teardown = await trigger.func.func(
+  const teardown = await runPikkuFunc('trigger', name, sourceMeta.pikkuFuncId, {
     singletonServices,
-    trigger.config,
-    wire as any
-  )
+    createWireServices,
+    auth: false,
+    data: () => input as any,
+    wire,
+    packageName: sourceMeta.packageName || null,
+  })
 
-  return {
-    name,
-    teardown,
-  }
+  return { name, teardown }
 }
 
 /**

package/src/wirings/trigger/trigger.types.ts

@@ -1,50 +1,152 @@
-import type { CorePikkuTriggerFunctionConfig } from '../../function/functions.types.js'
+import type {
+  CommonWireMeta,
+  CoreSingletonServices,
+} from '../../types/core.types.js'
+import type { StandardSchemaV1 } from '@standard-schema/spec'
+import type { CoreNodeConfig } from '../node/node.types.js'
 
 /**
  * The trigger interaction object passed to trigger functions via the wire.
  * Call trigger() to fire the trigger and start a new workflow/execution.
  */
 export interface PikkuTrigger<TOutput = unknown> {
-  trigger: (data: TOutput) => void
+  invoke: (data: TOutput) => void
 }
 
 /**
  * Metadata for registered triggers stored in state.
  */
-export type TriggerMeta = Record<
+export type TriggerMeta = Record<string, CommonWireMeta & { name: string }>
+
+export type TriggerSourceMeta = Record<
   string,
-  {
-    pikkuFuncName: string
-    name: string
-    description?: string
-    tags?: string[]
-  }
+  { name: string; pikkuFuncId: string; packageName?: string }
 >
 
+/**
+ * A trigger function that sets up a subscription and returns a teardown function.
+ * The trigger is fired via wire.trigger.invoke(data).
+ *
+ * @template TInput - Input type (configuration passed when wired)
+ * @template TOutput - Output type produced when trigger fires
+ * @template Services - Services available to the trigger
+ */
+export type CorePikkuTriggerFunction<
+  TInput = unknown,
+  TOutput = unknown,
+  Services extends CoreSingletonServices = CoreSingletonServices,
+> = (
+  services: Services,
+  input: TInput,
+  wire: { trigger: { invoke: (data: TOutput) => void } }
+) => Promise<() => void | Promise<void>>
+
+/**
+ * Configuration object for creating a trigger function with metadata
+ */
+export type CorePikkuTriggerFunctionConfig<
+  TInput = unknown,
+  TOutput = unknown,
+  Services extends CoreSingletonServices = CoreSingletonServices,
+  InputSchema extends StandardSchemaV1 | undefined = undefined,
+  OutputSchema extends StandardSchemaV1 | undefined = undefined,
+> = {
+  /** Optional human-readable title for the trigger */
+  title?: string
+  /** Optional description of what the trigger does */
+  description?: string
+  /** Optional tags for categorization */
+  tags?: string[]
+  /** The trigger function */
+  func: CorePikkuTriggerFunction<TInput, TOutput, Services>
+  /** Optional Zod schema for input validation */
+  input?: InputSchema
+  /** Optional Zod schema for output validation */
+  output?: OutputSchema
+  /** Optional node configuration */
+  node?: CoreNodeConfig
+}
+
+/**
+ * Factory function for creating trigger functions
+ * Supports both direct function and configuration object syntax
+ *
+ * @example
+ * ```typescript
+ * // Direct function syntax
+ * export const redisSubscribeTrigger = pikkuTriggerFunc<
+ *   { channel: string },
+ *   { message: string }
+ * >(async ({ redis }, { channel }, { trigger }) => {
+ *   const subscriber = redis.duplicate()
+ *   await subscriber.subscribe(channel, (msg) => {
+ *     trigger.invoke({ message: msg })
+ *   })
+ *   return () => subscriber.unsubscribe()
+ * })
+ *
+ * // Configuration object syntax with metadata
+ * export const redisSubscribeTrigger = pikkuTriggerFunc({
+ *   title: 'Redis Subscribe Trigger',
+ *   description: 'Listens to Redis pub/sub channel',
+ *   input: z.object({ channel: z.string() }),
+ *   output: z.object({ message: z.string() }),
+ *   func: async ({ redis }, { channel }, { trigger }) => {
+ *     const subscriber = redis.duplicate()
+ *     await subscriber.subscribe(channel, (msg) => {
+ *       trigger.invoke({ message: msg })
+ *     })
+ *     return () => subscriber.unsubscribe()
+ *   }
+ * })
+ * ```
+ */
+export const pikkuTriggerFunc = <
+  TInput = unknown,
+  TOutput = unknown,
+  Services extends CoreSingletonServices = CoreSingletonServices,
+  InputSchema extends StandardSchemaV1 | undefined = undefined,
+  OutputSchema extends StandardSchemaV1 | undefined = undefined,
+>(
+  triggerOrConfig:
+    | CorePikkuTriggerFunction<TInput, TOutput, Services>
+    | CorePikkuTriggerFunctionConfig<
+        TInput,
+        TOutput,
+        Services,
+        InputSchema,
+        OutputSchema
+      >
+): CorePikkuTriggerFunctionConfig<
+  TInput,
+  TOutput,
+  Services,
+  InputSchema,
+  OutputSchema
+> => {
+  if (typeof triggerOrConfig === 'function') {
+    return { func: triggerOrConfig }
+  }
+  return triggerOrConfig
+}
+
 /**
  * Core trigger definition for registration.
  *
- * @template TConfig - Configuration type
+ * @template TInput - Input type (configuration passed when wired)
  * @template TOutput - Output type
  */
-export interface CoreTrigger<
-  TConfig = unknown,
-  TOutput = unknown,
-  TriggerFunctionConfig extends CorePikkuTriggerFunctionConfig<
-    TConfig,
-    TOutput
-  > = CorePikkuTriggerFunctionConfig<TConfig, TOutput>,
-> {
+export interface CoreTrigger<PikkuFunctionConfig = any> {
   /** Unique name for this trigger */
   name: string
-  /** The trigger function configuration */
-  func: TriggerFunctionConfig
-  /** Configuration to pass to the trigger function */
-  config: TConfig
+  /** The target RPC function to invoke when the trigger fires */
+  func: PikkuFunctionConfig
   /** Optional description */
   description?: string
   /** Optional tags for categorization */
   tags?: string[]
+  /** Whether this trigger is used by a graph workflow */
+  graph?: true
 }
 
 /**
@@ -54,3 +156,23 @@ export interface TriggerInstance {
   name: string
   teardown: () => void | Promise<void>
 }
+
+/**
+ * A trigger source that provides the subscription function.
+ * Only imported in the trigger worker process.
+ *
+ * @template TInput - Input type passed to the trigger function
+ * @template TOutput - Output type produced when trigger fires
+ */
+export type CoreTriggerSource<TInput = unknown, TOutput = unknown> = {
+  /** Must match a wireTrigger name */
+  name: string
+  /** The trigger function config that sets up the subscription */
+  func: CorePikkuTriggerFunctionConfig<
+    TInput,
+    TOutput,
+    CoreSingletonServices,
+    StandardSchemaV1 | undefined,
+    StandardSchemaV1 | undefined
+  >
+} & (unknown extends TInput ? { input?: TInput } : { input: TInput })

package/src/wirings/variable/index.ts

@@ -0,0 +1,8 @@
+export { wireVariable } from './variable.types.js'
+export type {
+  CoreVariable,
+  VariableDefinitionMeta,
+  VariableDefinitionsMeta,
+  VariableDefinitions,
+} from './variable.types.js'
+export { validateAndBuildVariableDefinitionsMeta } from './validate-variable-definitions.js'