@pigcloud/skills 1.0.11 → 1.1.2

package/skills/technical-design/references/solid-checklist.md

@@ -1,199 +0,0 @@
-# SOLID 检查清单
-
-> 面向对象设计五大原则检查项
-
----
-
-## S - Single Responsibility Principle (单一职责原则)
-
-**定义**：一个类应该只有一个引起它变化的原因
-
-| 检查项 | 问题信号 | 修复方案 |
-|--------|----------|----------|
-| 类职责过多 | 类名包含"And"或"Or" | 拆分为多个类 |
-| 方法类型混杂 | CRUD + 业务逻辑 + 工具方法 | 分离到不同类 |
-| 字段分组明显 | 字段可按功能分组 | 拆分为多个类 |
-| 变更频率不同 | 部分方法频繁变更，部分不变 | 拆分为多个类 |
-
-**示例**：
-```java
-// ❌ 违反 SRP：订单类同时处理订单数据和邮件通知
-public class Order {
-    private Long id;
-    private String orderNo;
-    
-    public void calculateTotal() { }
-    public void sendEmail() { }  // 应分离到 NotificationService
-}
-
-// ✅ 符合 SRP：职责分离
-public class OrderEntity {
-    private Long id;
-    private String orderNo;
-    public void calculateTotal() { }
-}
-
-public class NotificationService {
-    public void sendOrderEmail(OrderEntity order) { }
-}
-```
-
----
-
-## O - Open/Closed Principle (开闭原则)
-
-**定义**：对扩展开放，对修改关闭
-
-| 检查项 | 问题信号 | 修复方案 |
-|--------|----------|----------|
-| 硬编码条件 | if-else 类型判断 | 使用策略模式/多态 |
-| 新增类型需修改现有代码 | 添加新类型需修改 switch | 使用接口+实现类 |
-| 逻辑固定 | 业务规则硬编码 | 使用配置/规则引擎 |
-
-**示例**：
-```java
-// ❌ 违反 OCP：新增支付方式需修改现有代码
-public class PaymentService {
-    public void pay(String type) {
-        if (type.equals("ALIPAY")) { }
-        else if (type.equals("WECHAT")) { }
-        // 新增支付方式需修改此处
-    }
-}
-
-// ✅ 符合 OCP：使用策略模式
-public interface PaymentStrategy {
-    void pay();
-}
-
-public class AlipayStrategy implements PaymentStrategy { }
-public class WechatStrategy implements PaymentStrategy { }
-// 新增支付方式只需添加新实现类
-```
-
----
-
-## L - Liskov Substitution Principle (里氏替换原则)
-
-**定义**：子类必须能够替换其父类
-
-| 检查项 | 问题信号 | 修复方案 |
-|--------|----------|----------|
-| 子类抛出新异常 | 父类不抛出，子类抛出 | 保持异常一致 |
-| 子类返回不同类型 | 返回类型不兼容 | 保持返回类型一致 |
-| 子类行为不一致 | 相同输入不同输出 | 保持行为一致 |
-| 子类限制更强 | 子类拒绝父类接受的输入 | 放宽限制或重新设计 |
-
-**示例**：
-```java
-// ❌ 违反 LSP：子类行为不一致
-public class Rectangle {
-    public void setWidth(int w) { width = w; }
-    public void setHeight(int h) { height = h; }
-}
-
-public class Square extends Rectangle {
-    @Override
-    public void setWidth(int w) {
-        width = w;
-        height = w;  // 强制宽高相等，行为不一致
-    }
-}
-
-// ✅ 符合 LSP：不使用继承，使用组合
-public class Shape { }
-public class Rectangle extends Shape { }
-public class Square extends Shape { }
-```
-
----
-
-## I - Interface Segregation Principle (接口隔离原则)
-
-**定义**：客户端不应该依赖它不需要的接口
-
-| 检查项 | 问题信号 | 修复方案 |
-|--------|----------|----------|
-| 接口方法过多 | 接口方法数 > 10 | 拆分为多个接口 |
-| 实现类空方法 | 实现类有空方法体 | 拆分接口 |
-| 客户端只使用部分方法 | 客户端调用 < 50% 方法 | 拆分接口 |
-| 接口职责混杂 | 接口包含不同职责方法 | 拆分接口 |
-
-**示例**：
-```java
-// ❌ 违反 ISP：接口方法过多
-public interface Worker {
-    void work();
-    void eat();
-    void sleep();  // Robot 不需要 sleep
-}
-
-// ✅ 符合 ISP：接口拆分
-public interface Workable {
-    void work();
-}
-
-public interface Feedable {
-    void eat();
-}
-
-public class Human implements Workable, Feedable { }
-public class Robot implements Workable { }
-```
-
----
-
-## D - Dependency Inversion Principle (依赖倒置原则)
-
-**定义**：高层模块不应该依赖低层模块，两者都应该依赖抽象
-
-| 检查项 | 问题信号 | 修复方案 |
-|--------|----------|----------|
-| 直接 new 对象 | Service 中 new Mapper() | 使用依赖注入 |
-| 依赖具体类 | 依赖具体实现类 | 依赖接口/抽象类 |
-| 硬编码依赖 | 依赖类型硬编码 | 使用配置/注入 |
-
-**示例**：
-```java
-// ❌ 违反 DIP：Service 直接依赖具体 Mapper
-public class OrderService {
-    private OrderMapper mapper = new OrderMapper();  // 直接 new
-}
-
-// ✅ 符合 DIP：依赖注入
-public class OrderServiceImpl implements OrderService {
-    private final OrderMapper mapper;  // 注入抽象
-    
-    public OrderServiceImpl(OrderMapper mapper) {
-        this.mapper = mapper;
-    }
-}
-```
-
----
-
-## Anti-rationalization Table (Design)
-
-| 常见借口 | 反驳理由 | 正确做法 |
-|---------|---------|---------|
-| "先实现功能，设计文档以后补" | 无文档的设计无法维护 | 先设计后实现 |
-| "这个实体很简单，不需要设计" | 简单实体也会变复杂 | 完整设计 |
-| "状态流转很直观，不用画图" | 直观的流转也有边界情况 | 绘制状态图 |
-| "接口定义很清楚，不需要文档" | 清楚的定义也需要确认 | 编写API文档 |
-| "这个依赖关系很简单" | 简单依赖也会产生循环 | 分析依赖图 |
-| "SOLID检查太耗时" | 违反SOLID的代码更耗时维护 | 执行SOLID检查 |
-| "这个功能单体和微服务都一样" | 架构差异影响设计决策 | 明确架构类型 |
-| "这个类以后会扩展" | 未预留扩展点会导致修改 | 使用开闭原则 |
-
----
-
-## Verification Gates
-
-| 门禁 | 检查方法 | 通过条件 | 失败处理 |
-|------|---------|---------|---------|
-| SRP检查 | 类职责分析 | 每个类职责单一 | 拆分类 |
-| OCP检查 | 扩展点分析 | 新功能无需修改现有代码 | 添加扩展点 |
-| LSP检查 | 子类行为测试 | 子类可替换父类 | 修复行为不一致 |
-| ISP检查 | 接口方法数 | 接口方法 <= 10 | 拆分接口 |
-| DIP检查 | 依赖分析 | 无直接 new 对象 | 使用依赖注入 |
-| 用户确认 | 设计文档评审 | 用户确认设计 | 修改设计 |

package/skills/test-design/SKILL.md

@@ -1,92 +0,0 @@
----
-name: test-design
-description: 当需要验证回归风险或边界场景时，为已实现的变更设计并验证测试覆盖
-lifecycle_stage: verify
-rule_profile: testing
-dependencies:
-  - feature-build
-triggers:
-  - test
-  - validation
-  - coverage
-  - regression
-  - edge case
-  - verification
-inputs:
-  - implementation notes
-  - executable spec-refinement
-  - design constraints
-  - self-test evidence
-outputs:
-  - test strategy
-  - test cases
-  - regression matrix
-  - validation result
-  - gap report
-workflow:
-  - confirm the implementation scope
-  - review the self-test evidence and implementation notes
-  - design test cases and coverage boundaries
-  - run validation or prepare execution steps
-  - hand off a validation result to code-review
-gates:
-  - stop at verification
-  - do not modify production code
-  - do not rewrite the PRD
-  - do not replace code review
-refs:
-  - skills/references/rule-loading-map.md
-  - skills/references/flow-test-cases.md
-  - skills/references/full-chain-replay-scenarios.md
-  - skills/references/prompt-replay-checklist.md
-  - rules/index.md
----
-
-# Test Design
-
-## Purpose
-
-Design and validate test coverage for the implemented change.
-
-## Suitable / Unsuitable
-
-- Suitable: test strategy, test cases, coverage, regression, boundary validation
-- Unsuitable: modifying production code, rewriting the PRD, replacing code review
-
-## Workflow
-
-1. Confirm the implementation scope and risk areas.
-2. Review self-test evidence and identify coverage gaps.
-3. Design coverage, boundaries, and regression cases.
-4. Execute or prepare validation steps.
-5. Hand off a validation result to `code-review`.
-
-## Replay Signals
-
-- Input signal: implementation notes, risk areas, coverage gaps, or verification request.
-- Output to verify: test strategy, test cases, regression matrix, validation result, gap report.
-- Stop signal: modifying production code, rewriting the PRD, or replacing code review.
-- Handoff signal: a validation result is ready for `code-review`.
-
-## Examples
-
-- Input: "The feature is implemented; design coverage and run the validation steps."
-- Output: test strategy, test cases, regression matrix, validation result, gap report
-- Stop: do not change production code
-
-## Stop Rules
-
-- Stop at verification.
-- Do not modify production code.
-- Do not rewrite the PRD.
-- Do not replace code review.
-- Do not skip the self-test evidence.
-
-## References
-
-- `skills/references/rule-loading-map.md`
-- `skills/references/flow-test-cases.md`
-- `skills/references/engineering-delivery-method.md`
-- `skills/references/engineering-delivery-template.md`
-- `rules/index.md`
-

package/skills/workflow-router/SKILL.md

@@ -1,86 +0,0 @@
----
-name: workflow-router
-description: 当意图、归属或交接不清楚时，将工作路由到下一技能和阶段
-lifecycle_stage: routing
-rule_profile: router
-dependencies: []
-triggers:
-  - unclear stage
-  - unclear intent
-  - next step
-  - route
-  - handoff
-inputs:
-  - user intent
-  - current stage
-  - available artifacts
-outputs:
-  - next skill
-  - stage decision
-  - handoff note
-workflow:
-  - identify the intent type
-  - select the next stage and skill
-  - attach the needed inputs
-  - hand off to the target skill
-gates:
-  - stop after routing
-  - do not perform the target skill's work
-  - do not add rule details
-refs:
-  - skills/references/skill-reference-matrix.md
-  - skills/references/rule-loading-map.md
-  - skills/references/flow-test-cases.md
-  - skills/references/prompt-replay-checklist.md
-  - skills/references/full-chain-replay-scenarios.md
----
-
-# Workflow Router
-
-## Purpose
-
-Route a request to the right stage and skill. This skill ends when the next skill is selected.
-
-## Suitable / Unsuitable
-
-- Suitable: stage selection, handoff, intent disambiguation
-- Unsuitable: requirement analysis, design, implementation, review, capture
-
-## Workflow
-
-1. Identify the intent type.
-2. Select the next stage and skill.
-3. Attach the needed inputs.
-4. Hand off to the target skill.
-
-## Replay Signals
-
-- Input signal: user intent, current stage, or available artifacts.
-- Output to verify: next skill, stage decision, handoff note.
-- Stop signal: any target-skill work or rule loading.
-- Handoff signal: the next skill is selected and ready.
-
-## Examples
-
-- Input: "We need a new feature but the stage is unclear."
-- Output: selected next skill and handoff note
-- Stop: do not start analysis or implementation
-
-- Input: "Just tell me which step comes next."
-- Output: next skill decision and minimal handoff note
-- Stop: do not begin the target work
-
-## Stop Rules
-
-- Stop after routing.
-- Do not perform the target skill's work.
-- Do not perform the next skill's work.
-- Do not add rule details.
-
-## References
-
-- `skills/references/skill-reference-matrix.md`
-- `skills/references/rule-loading-map.md`
-- `skills/references/flow-test-cases.md`
-- `skills/references/prompt-replay-checklist.md`
-- `skills/references/full-chain-replay-scenarios.md`