@pify/shell-background 0.3.0 → 0.3.1

package/README.md

@@ -60,6 +60,8 @@ Put these in `.pi/shell-background.json` (project) or `<agentDir>/shell-backgrou
 
 `autoBackgroundMs` is how long a foreground command may run before it auto-backgrounds; set it to `0` to disable auto-background (explicit `background: true` still works). `PIFY_SHELL_BG_MS` overrides it for one run or in CI. `tailBytes` bounds how much of a job's log a status result shows. `maxBackground` bounds how many jobs may be alive at once: over it, a `background: true` request is refused with a message naming the limit (the command can still run in the foreground), and a command that crosses the auto-background threshold simply stays in the foreground instead of moving — a command is never refused, only the decision to background it. Bad values fall back to the defaults with a warning rather than taking the tool down.
 
+A backgrounded command runs with no one to answer it, so its environment says so: `GIT_TERMINAL_PROMPT=0` and `GIT_EDITOR`/`EDITOR`/`VISUAL=true` are forced (a `git commit` without `-m` fails with "empty message" instead of waiting on an editor that never comes, and an https `git fetch` fails instead of prompting for a password), and pagers default to `cat` unless you set them. `CI` and `TERM` are left alone on purpose — dev servers and watchers read them.
+
 The tail a result carries is cleaned the way pi's own bash cleans what the model sees — ANSI escapes, control characters and carriage-return progress frames stripped — so a chatty build or dev server does not spend tokens on colour codes and thousands of overwritten progress lines. The log file on disk keeps every byte.
 
 ## Coexistence with @pify/pretty

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pify/shell-background",
-  "version": "0.3.0",
+  "version": "0.3.1",
   "description": "Long-running bash goes async: background: true launches detached, and any command still running after 30s auto-backgrounds and delivers its result when it finishes",
   "keywords": [
     "pi-package",

package/src/env.ts

@@ -17,6 +17,37 @@
  */
 import { delimiter } from "node:path";
 
+/**
+ * Defaults that keep an unattended child from waiting on a human. FORCED —
+ * they win over the inherited value — because a background job has no one
+ * to answer: `git commit` without -m must not open $EDITOR, `git fetch` over
+ * https must not prompt for a password. With stdin ignored such a prompt
+ * either hangs forever or sits until the tree is killed, and while it waits
+ * it holds one of the maxBackground slots. (Set from oh-my-pi's
+ * non-interactive-env; the editor becomes `true`, which exits 0 with the
+ * message untouched, so git aborts with "empty commit message" instead.)
+ */
+export const NON_INTERACTIVE_FORCED: Readonly<Record<string, string>> = {
+  GIT_TERMINAL_PROMPT: "0",
+  GIT_EDITOR: "true",
+  EDITOR: "true",
+  VISUAL: "true",
+};
+
+/**
+ * Formatting-only defaults, applied UNDER the inherited env so an explicit
+ * value still wins: a pager only ever changes how output is shown, and to a
+ * pipe it is dead weight. Deliberately NOT here: CI=true and TERM=dumb —
+ * this package also runs dev servers and watchers, and those flags make many
+ * of them drop watch mode, change ports or strip the output the user wants.
+ */
+export const NON_INTERACTIVE_DEFAULTS: Readonly<Record<string, string>> = {
+  PAGER: "cat",
+  GIT_PAGER: "cat",
+  GH_PAGER: "cat",
+  LESS: "FRX",
+};
+
 /** The slice of the pi ExtensionContext this needs, kept structural for tests. */
 export interface EnvCtx {
   sessionManager?: { getSessionId?(): string; getSessionFile?(): string | undefined };
@@ -25,16 +56,18 @@ export interface EnvCtx {
 }
 
 /**
- * Copy `base`, prepend `binDir` to PATH when absent, and set the PI_* session
- * variables from `ctx`. The ctx reads are wrapped so a stale ctx after a
- * `/reload` degrades to plain env rather than failing the spawn.
+ * Copy `base`, prepend `binDir` to PATH when absent, set the PI_* session
+ * variables from `ctx`, and layer the non-interactive defaults (formatting
+ * ones under the base, the anti-hang ones over it). The ctx reads are
+ * wrapped so a stale ctx after a `/reload` degrades to plain env rather than
+ * failing the spawn.
  */
 export function buildEnv(
   ctx: EnvCtx,
   binDir: string,
   base: NodeJS.ProcessEnv = process.env,
 ): NodeJS.ProcessEnv {
-  const env: NodeJS.ProcessEnv = { ...base };
+  const env: NodeJS.ProcessEnv = { ...NON_INTERACTIVE_DEFAULTS, ...base, ...NON_INTERACTIVE_FORCED };
 
   // PATH is case-insensitive on Windows; find the real key so we do not create a
   // second, ignored "PATH" alongside an inherited "Path". Only prepend when the