@piewf/cli 5.13.1 → 5.14.0

package/dist/src/cli.js

@@ -1,19 +1,18 @@
 #!/usr/bin/env node
 import { randomUUID } from "node:crypto";
-import { chmodSync, linkSync, mkdirSync, mkdtempSync, realpathSync, renameSync, rmSync, writeFileSync } from "node:fs";
+import { chmodSync, linkSync, mkdirSync, mkdtempSync, renameSync, rmSync, writeFileSync } from "node:fs";
 import { homedir } from "node:os";
 import { basename, dirname, extname, join } from "node:path";
-import { pathToFileURL } from "node:url";
+import { fileURLToPath } from "node:url";
 import { ProjectTrustStore, SessionManager, SettingsManager, createAgentSessionFromServices, createAgentSessionServices, getAgentDir, hasTrustRequiringProjectResources } from "@earendil-works/pi-coding-agent";
 import { Value } from "typebox/value";
 import { doctor, doctorExitCode, formatDoctorReport } from "./doctor.js";
 import { doctorCleanup, doctorCleanupExitCode, formatDoctorCleanupReport } from "./doctor-cleanup.js";
-import workflowExtension, { errorText, formatWorkflowProgress, isNodeError, jsonValue, loadAgentDefinitions, registeredWorkflowFunctionSources, truncateWorkflowProgress, workflowCatalog, workflowSettingsPath } from "pi-extensible-workflows";
+import workflowExtension, { errorText, formatWorkflowProgress, isNodeError, jsonValue, loadAgentDefinitions, object, registeredWorkflowFunctionSources, sameFilesystemPath, truncateWorkflowProgress, workflowCatalog, workflowSettingsPath } from "pi-extensible-workflows";
 import { portableEngineVersion, portablePiVersion, writePortableWorkflowBundle } from "./bundles.js";
 import { runSessionInspector, transcriptFileLines } from "./session-inspector.js";
 import { isPersistedRun, listPersistedSessionIds, listRunIds } from "pi-extensible-workflows/persistence";
 import { shareTrajectoryRun } from "pi-extensible-workflows/trajectory";
-function object(value) { return typeof value === "object" && value !== null && !Array.isArray(value); }
 function has(value, key) { return Object.prototype.hasOwnProperty.call(value, key); }
 function requiredArg(args, index) {
     const value = args[index];
@@ -97,7 +96,7 @@ function coerce(raw, type, schema) {
     }
     else if (type === "number") {
         value = Number(raw);
-        if (!Number.isFinite(value))
+        if (!raw.trim() || !Number.isFinite(value))
             throw new Error(`Invalid number: ${raw}`);
     }
     else {
@@ -717,13 +716,8 @@ async function exportWorkflowCli(rawArgs, options) {
         writeLauncher(destination, workflowName, force);
         if (!output) {
             const binDir = join(homedir(), ".local", "bin");
-            const pathEntries = (process.env.PATH ?? "").split(":").filter(Boolean).map((entry) => { try {
-                return realpathSync(entry);
-            }
-            catch {
-                return entry;
-            } });
-            if (!pathEntries.includes(binDir))
+            const pathEntries = (process.env.PATH ?? "").split(":").filter(Boolean);
+            if (!pathEntries.some((entry) => sameFilesystemPath(entry, binDir)))
                 options.stderr(`Warning: ${binDir} is not in PATH\n`);
         }
         options.write(`Exported ${destination}\n`);
@@ -910,7 +904,7 @@ export async function runCli(args, options = {}, write = (text) => { process.std
     write("Usage: piewf doctor [role] [--role <role>] [--prompt <text>] [--json] | inspect [session-id] [--json|--summary] [--failed] | transcript <session-file> | share <run-id> | bundle <workflow-name> [--name <command>] [--output <path>] [--force] | run <workflow-name> [workflow arguments] | run --script <path> [--name <workflow-name>] [--input <json>] | export <workflow-name> [--name <command>] [--output <path>] [--force] [--bundle]\n");
     return 1;
 }
-if (process.argv[1] && import.meta.url === pathToFileURL(realpathSync(process.argv[1])).href) {
+if (process.argv[1] && sameFilesystemPath(fileURLToPath(import.meta.url), process.argv[1])) {
     const controller = new AbortController();
     const onSignal = () => { controller.abort(); };
     process.once("SIGINT", onSignal);

package/dist/src/doctor-cleanup.js

@@ -2,27 +2,20 @@ import { createHash } from "node:crypto";
 import { lstat, readdir, readFile, stat } from "node:fs/promises";
 import { homedir } from "node:os";
 import { join, resolve } from "node:path";
-import { validateBudget } from "pi-extensible-workflows";
-import { RUN_STATES } from "pi-extensible-workflows";
-import { errorText, isNodeError, jsonValue, validateModelAliases } from "pi-extensible-workflows";
-import { validateSchema } from "pi-extensible-workflows";
+import { AGENT_STATES as CORE_AGENT_STATES, BUDGET_DIMENSIONS as CORE_BUDGET_DIMENSIONS, BUDGET_EVENT_TYPES as CORE_BUDGET_EVENT_TYPES, HARD_TERMINAL_RUN_STATES, RUN_STATES, errorText, isNodeError, isThinkingLevel, jsonValue, object, validateBudget, validateModelAliases, validateSchema } from "pi-extensible-workflows";
 import { acquireSessionLease, hasLiveSessionLease, projectSessionsDirectory, RunStore } from "pi-extensible-workflows/persistence";
-const TERMINAL_STATES = new Set(["completed", "failed", "stopped"]);
 const DAY_MS = 24 * 60 * 60 * 1000;
 const REQUIRED_RUN_FILES = ["workflow.js", "state.json", "snapshot.json", "journal.json", "ownership.json", "worktrees.json", "borrowed-worktrees.json", "system-prompts.json"];
 const OPTIONAL_RUN_FILES = new Set(["result.json", "summary.json"]);
 const RUN_DIRECTORIES = new Set(["worktrees", ".system-prompts"]);
 const RUN_FILES = new Set([...REQUIRED_RUN_FILES, ...OPTIONAL_RUN_FILES]);
-const AGENT_STATES = new Set(["queued", "running", "waiting_for_child", "paused", "retrying", "completed", "failed", "cancelled"]);
-const SCHEDULER_STATES = new Set(["queued", "running", "waiting_for_child", "paused", "retrying", "completed", "failed", "cancelled"]);
-const BUDGET_DIMENSIONS = new Set(["tokens", "costUsd", "durationMs", "agentLaunches"]);
-const BUDGET_EVENT_TYPES = new Set(["soft_crossed", "hard_overrun", "hard_exhausted", "adjustment_requested", "adjustment_approved", "adjustment_rejected"]);
-function object(value) { return typeof value === "object" && value !== null && !Array.isArray(value); }
+// String-keyed views of the core vocabularies: persisted files are read as unknown, so membership is checked on plain strings.
+const AGENT_STATES = new Set(CORE_AGENT_STATES);
+const BUDGET_DIMENSIONS = new Set(CORE_BUDGET_DIMENSIONS);
+const BUDGET_EVENT_TYPES = new Set(CORE_BUDGET_EVENT_TYPES);
 function isList(value) { return Array.isArray(value); }
-function isThinking(value) { return ["off", "minimal", "low", "medium", "high", "xhigh", "max"].some((candidate) => candidate === value); }
 function isRunState(value) { return RUN_STATES.some((candidate) => candidate === value); }
 function isAgentState(value) { return typeof value === "string" && AGENT_STATES.has(value); }
-function isSchedulerState(value) { return typeof value === "string" && SCHEDULER_STATES.has(value); }
 function isToolCallState(value) { return ["running", "completed", "failed"].some((candidate) => candidate === value); }
 function isActivityKind(value) { return ["reasoning", "tool", "text"].some((candidate) => candidate === value); }
 function positiveDays(value) { if (!Number.isSafeInteger(value) || value < 1 || !Number.isFinite(value * DAY_MS))
@@ -42,7 +35,7 @@ function positiveInteger(value, label) { if (typeof value !== "number" || !Numbe
     throw new Error(`${label} is invalid`); }
 function finiteNumber(value, label) { if (typeof value !== "number" || !Number.isFinite(value) || value < 0)
     throw new Error(`${label} is invalid`); }
-function model(value, label) { if (!object(value) || typeof value.provider !== "string" || !value.provider || typeof value.model !== "string" || !value.model || (value.thinking !== undefined && !isThinking(value.thinking)))
+function model(value, label) { if (!object(value) || typeof value.provider !== "string" || !value.provider || typeof value.model !== "string" || !value.model || (value.thinking !== undefined && !isThinkingLevel(value.thinking)))
     throw new Error(`${label} is invalid`); }
 function accounting(value, label) { if (!object(value))
     throw new Error(`${label} is invalid`); for (const key of ["input", "output", "cacheRead", "cacheWrite", "cost"])
@@ -54,7 +47,7 @@ function resourceSelectors(value, label) { if (value === undefined)
     stringList(value.extensions, `${label}.extensions`); if (value.tools !== undefined)
     stringList(value.tools, `${label}.tools`); }
 function agentDefinition(value, label) { if (!object(value))
-    throw new Error(`${label} is invalid`); optionalString(value.prompt, `${label}.prompt`); optionalString(value.description, `${label}.description`); optionalString(value.model, `${label}.model`); if (value.thinking !== undefined && !isThinking(value.thinking))
+    throw new Error(`${label} is invalid`); optionalString(value.prompt, `${label}.prompt`); optionalString(value.description, `${label}.description`); optionalString(value.model, `${label}.model`); if (value.thinking !== undefined && !isThinkingLevel(value.thinking))
     throw new Error(`${label}.thinking is invalid`); if (value.tools !== undefined)
     stringList(value.tools, `${label}.tools`); if (value.skills !== undefined)
     stringList(value.skills, `${label}.skills`); if (value.extensions !== undefined)
@@ -69,7 +62,7 @@ function validateScheduledOptions(value, label) { if (!object(value) || typeof v
     throw new Error(`${label} is invalid`); optionalString(value.requestedLabel, `${label}.requestedLabel`); optionalString(value.parentBreadcrumb, `${label}.parentBreadcrumb`); stringList(value.tools, `${label}.tools`); if (value.skills !== undefined)
     stringList(value.skills, `${label}.skills`); if (value.extensions !== undefined)
     stringList(value.extensions, `${label}.extensions`); if (value.contextFiles !== undefined)
-    stringList(value.contextFiles, `${label}.contextFiles`); optionalString(value.worktreeOwner, `${label}.worktreeOwner`); optionalString(value.model, `${label}.model`); if (value.thinking !== undefined && !isThinking(value.thinking))
+    stringList(value.contextFiles, `${label}.contextFiles`); optionalString(value.worktreeOwner, `${label}.worktreeOwner`); optionalString(value.model, `${label}.model`); if (value.thinking !== undefined && !isThinkingLevel(value.thinking))
     throw new Error(`${label}.thinking is invalid`); optionalRole(value.role, `${label}.role`); if (value.schema !== undefined)
     validateSchema(value.schema, `${label}.schema`); if (value.retries !== undefined)
     nonNegativeInteger(value.retries, `${label}.retries`); if (value.timeoutMs !== undefined && value.timeoutMs !== null)
@@ -146,7 +139,7 @@ function validateAgent(value, label) {
         finiteNumber(value.lastEventAt, `${label}.lastEventAt`);
 }
 function validateUsage(value, label) { if (!object(value))
-    throw new Error(`${label} is invalid`); for (const key of ["tokens", "costUsd", "durationMs", "agentLaunches"])
+    throw new Error(`${label} is invalid`); for (const key of BUDGET_DIMENSIONS)
     finiteNumber(value[key], `${label}.${key}`); }
 function validateBudgetEvents(value) { if (value === undefined)
     return; if (!isList(value))
@@ -306,7 +299,7 @@ async function validateRunDirectory(store) {
     }
 }
 function validateOwnershipRecord(value, label, ownershipIds) {
-    if (!object(value) || typeof value.id !== "string" || !value.id || ownershipIds.has(value.id) || typeof value.label !== "string" || !value.label || !isSchedulerState(value.state))
+    if (!object(value) || typeof value.id !== "string" || !value.id || ownershipIds.has(value.id) || typeof value.label !== "string" || !value.label || !isAgentState(value.state))
         throw new Error(`${label} is invalid`);
     optionalString(value.parentId, `${label}.parentId`);
     optionalString(value.prompt, `${label}.prompt`);
@@ -443,7 +436,7 @@ async function recheckCandidate(entry, cutoffMs) {
         return "State record disappeared before deletion";
     const loaded = await entry.store.load().catch((error) => { throw new Error(`Candidate could not be reloaded: ${errorText(error)}`); });
     validateRunRecord(loaded.run);
-    if (loaded.run.id !== entry.runId || loaded.run.state !== entry.run.state || !TERMINAL_STATES.has(loaded.run.state))
+    if (loaded.run.id !== entry.runId || loaded.run.state !== entry.run.state || !HARD_TERMINAL_RUN_STATES.has(loaded.run.state))
         return "Candidate state changed before deletion";
     const after = await stat(join(entry.store.directory, "state.json"));
     if (before.mtimeMs !== after.mtimeMs || after.mtimeMs !== entry.stateMtimeMs)
@@ -455,7 +448,7 @@ async function recheckCandidate(entry, cutoffMs) {
 function planSession(scan, cutoffMs) {
     if (scan.liveLease)
         return { candidates: [], skipped: scan.runs.map((entry) => runItem(entry, "skipped", "Session has a live ownership lease")) };
-    const oldTerminal = new Set(scan.runs.filter(({ run, stateMtimeMs }) => TERMINAL_STATES.has(run.state) && stateMtimeMs < cutoffMs).map(({ runId }) => runId));
+    const oldTerminal = new Set(scan.runs.filter(({ run, stateMtimeMs }) => HARD_TERMINAL_RUN_STATES.has(run.state) && stateMtimeMs < cutoffMs).map(({ runId }) => runId));
     const protectedRuns = new Set();
     const visit = (runId) => { if (protectedRuns.has(runId))
         return; protectedRuns.add(runId); const entry = scan.runs.find(({ runId: current }) => current === runId); for (const dependency of entry?.dependencies ?? [])
@@ -466,7 +459,7 @@ function planSession(scan, cutoffMs) {
                 visit(dependency);
     const skipped = [];
     for (const entry of scan.runs) {
-        if (!TERMINAL_STATES.has(entry.run.state))
+        if (!HARD_TERMINAL_RUN_STATES.has(entry.run.state))
             skipped.push(runItem(entry, "skipped", `Run state ${entry.run.state} is active or resumable`));
         else if (entry.stateMtimeMs >= cutoffMs)
             skipped.push(runItem(entry, "skipped", "State record is not older than the cutoff"));

package/dist/src/doctor.js

@@ -1,10 +1,10 @@
-import { readFileSync, readdirSync, realpathSync, statSync } from "node:fs";
-import { basename, dirname, extname, join, resolve } from "node:path";
+import { readFileSync, readdirSync, statSync } from "node:fs";
+import { basename, dirname, extname, join } from "node:path";
 import { InMemoryCredentialStore, InMemoryModelsStore } from "@earendil-works/pi-ai";
 import { ModelRuntime, createAgentSessionFromServices, createAgentSessionServices, getAgentDir, hasTrustRequiringProjectResources, SessionManager, SettingsManager, } from "@earendil-works/pi-coding-agent";
-import { DEFAULT_SETTINGS, createLocalPiSession, errorText, isNodeError, isObject, loadSettings, prepareAgentSetupForInspection, resolveAgentResourcePolicy, resolveWorkflowSettings, resolveModelReference, resourcePatternHasMagic, parseThinking, parseRoleMarkdown, registeredWorkflowFunctions, registeredWorkflowRoleDirectoryRegistrations, workflowRoleDirectories, workflowProjectSettingsPath, workflowSettingsPath, } from "pi-extensible-workflows";
+import { DEFAULT_SETTINGS, canonicalPath, createLocalPiSession, errorText, isNodeError, isObject, loadSettings, prepareAgentSetupForInspection, resolveAgentResourcePolicy, resolveWorkflowSettings, resolveModelReference, resourcePatternHasMagic, parseThinking, parseRoleMarkdown, registeredWorkflowFunctions, registeredWorkflowRoleDirectoryRegistrations, workflowRoleDirectories, workflowProjectSettingsPath, workflowSettingsPath, } from "pi-extensible-workflows";
 import { loadingRegistry } from "pi-extensible-workflows";
-import { selectResourcesByLayers, unmatchedResourcePatterns } from "pi-extensible-workflows";
+import { selectResourcesByLayers, unmatchedResourcePatterns, mergeWorkflowExtensionSettings } from "pi-extensible-workflows";
 const THINKING_HINT = "Use off, minimal, low, medium, high, xhigh, or max.";
 const AGENT_RESOURCE_SELECTOR_MIGRATION_ISSUE = "https://github.com/vekexasia/pi-extensible-workflows/issues/205";
 const AGENT_RESOURCE_SELECTOR_MIGRATION_MESSAGE = `\`disabledAgentResources\` is no longer supported by #205. Migrate to direct \`skills\`, \`extensions\`, and \`tools\` selectors: legacy patterns exclude resources and \`!pattern\` re-enables them, while new selectors include matches and \`!pattern\` excludes them. See ${AGENT_RESOURCE_SELECTOR_MIGRATION_ISSUE}`;
@@ -25,15 +25,6 @@ function usesLegacyRoleSelectors(path) {
         return false;
     }
 }
-function canonical(path) {
-    const absolute = resolve(path);
-    try {
-        return realpathSync(absolute);
-    }
-    catch {
-        return absolute;
-    }
-}
 function isDynamicModelAlias(value, aliases) {
     const match = /^([^/\s:]+)(?::([^\s]+))?$/.exec(value);
     const name = match?.[1];
@@ -72,7 +63,7 @@ function savedTrust(cwd, agentDir) {
     }
     if (!isObject(parsed))
         throw new Error("Pi trust.json must be an object");
-    let current = canonical(cwd);
+    let current = canonicalPath(cwd);
     while (current !== dirname(current)) {
         const value = parsed[current];
         if (value === true || value === false)
@@ -249,7 +240,7 @@ function inspectRole(path, activeTools, knownModels, availableModels, diagnostic
     return definition;
 }
 function matchResourcePolicy(policy, pi) {
-    const extensions = [...new Set((pi.extensions ?? []).map(canonical))];
+    const extensions = [...new Set((pi.extensions ?? []).map(canonicalPath))];
     const skills = [...new Set(pi.skills ?? [])];
     const tools = [...new Set(pi.activeTools)];
     const layers = policy.selectorSources;
@@ -258,12 +249,12 @@ function matchResourcePolicy(policy, pi) {
     const selectedTools = selectResourcesByLayers([layers.global.tools, layers.project.tools], tools);
     return { ...policy, selectedSkills, selectedExtensions, selectedTools, unmatchedSkills: unmatchedResourcePatterns(policy.effective.skills, skills), unmatchedExtensions: unmatchedResourcePatterns(policy.effective.extensions, extensions), unmatchedTools: unmatchedResourcePatterns(policy.effective.tools ?? [], tools) };
 }
-async function inspectRoleSession(cwd, agentDir, roleName, definition, rolePath, basePolicy, rootModel, activeTools, aliases, knownModels, availableModels, settingsPath, prompt, hooks, diagnostics) {
+async function inspectRoleSession(cwd, agentDir, roleName, definition, rolePath, basePolicy, rootModel, activeTools, aliases, knownModels, availableModels, settingsPath, extensionSettings, prompt, hooks, diagnostics) {
     const setupDiagnostics = [];
     const signal = new AbortController().signal;
     const transport = { id: "doctor-local", createSession: async () => { throw new Error("Doctor inspection does not create transport sessions"); } };
     const run = { cwd, sessionId: "doctor", runId: "doctor", workflow: { name: "doctor" }, args: null, signal };
-    const root = { cwd, model: { ...rootModel }, tools: new Set(activeTools), agentDefinitions: { [roleName]: definition }, agentDir, modelAliases: aliases, knownModels, availableModels, settingsPath, agentSetupHooks: hooks, agentResourcePolicy: () => structuredClone(basePolicy), runContext: run };
+    const root = { cwd, model: { ...rootModel }, tools: new Set(activeTools), agentDefinitions: { [roleName]: definition }, agentDir, extensionSettings, modelAliases: aliases, knownModels, availableModels, settingsPath, agentSetupHooks: hooks, agentResourcePolicy: () => structuredClone(basePolicy), runContext: run };
     const options = { label: roleName, workflowName: "doctor", role: roleName };
     let prepared;
     try {
@@ -313,13 +304,22 @@ async function inspectRoleSession(cwd, agentDir, roleName, definition, rolePath,
     }
 }
 function resourcePolicySource(settingsSource) { return settingsSource; }
+function validateDoctorExtensionSettings(registry, value, source, cwd, projectTrusted, settingsPath, diagnostics, role) {
+    try {
+        registry.validateExtensionSettings(value, { source, cwd, projectTrusted, settingsPath, ...(role === undefined ? {} : { role }) });
+    }
+    catch (error) {
+        diagnostics.push(diagnostic("error", "SETTINGS_INVALID", errorText(error), `${settingsPath}.extensionSettings`, "Fix the extension-owned settings reported in this error."));
+    }
+}
 export async function doctor(options = {}) {
-    const cwd = canonical(options.cwd ?? process.cwd());
-    const agentDir = canonical(options.agentDir ?? getAgentDir());
-    const settingsPath = canonical(options.settingsPath ?? workflowSettingsPath(agentDir));
+    const cwd = canonicalPath(options.cwd ?? process.cwd());
+    const agentDir = canonicalPath(options.agentDir ?? getAgentDir());
+    const settingsPath = canonicalPath(options.settingsPath ?? workflowSettingsPath(agentDir));
     const projectSettingsPath = workflowProjectSettingsPath(cwd);
     const legacyGlobalSettings = usesLegacySettings(settingsPath);
     const diagnostics = [];
+    const registry = options.registry ?? loadingRegistry();
     let settings = DEFAULT_SETTINGS;
     try {
         settings = loadSettings(settingsPath);
@@ -351,6 +351,11 @@ export async function doctor(options = {}) {
         const resolved = resolveWorkflowSettings(cwd, pi.trust.trusted, settingsPath);
         settings = resolved.effective;
         settingsSources = resolved.sources;
+        if (resolved.global.extensionSettings !== undefined)
+            validateDoctorExtensionSettings(registry, resolved.global.extensionSettings, "global", cwd, pi.trust.trusted, resolved.globalSettingsPath, diagnostics);
+        if (pi.trust.trusted && resolved.project.extensionSettings !== undefined)
+            validateDoctorExtensionSettings(registry, resolved.project.extensionSettings, "project", cwd, true, resolved.projectSettingsPath, diagnostics);
+        validateDoctorExtensionSettings(registry, resolved.effective.extensionSettings, "effective", cwd, pi.trust.trusted, settingsSources.extensionSettings ?? settingsPath, diagnostics);
     }
     catch (error) {
         const message = errorText(error);
@@ -384,7 +389,6 @@ export async function doctor(options = {}) {
     const knownModels = new Set(pi.knownModels);
     const availableModels = new Set(pi.availableModels);
     const aliases = settings.modelAliases ?? {};
-    const registry = options.registry ?? loadingRegistry();
     const registeredModelAliases = registry.modelAliases();
     const dynamicAliases = new Set(registeredModelAliases.map(({ name }) => name).filter((name) => !Object.prototype.hasOwnProperty.call(aliases, name)));
     const modelAliases = [
@@ -430,6 +434,8 @@ export async function doctor(options = {}) {
         const overriddenBy = starterOverriddenBy.get(file.path);
         roles.push({ name: file.name, path: file.path, scope: "extension", active: overriddenBy === undefined, extension: file.extension, ...(starterPath ? { overrides: starterPath } : {}), ...(overriddenBy ? { overriddenBy } : {}) });
         const definition = inspectRole(file.path, activeTools, knownModels, availableModels, diagnostics, aliases, dynamicAliases, settingsPath, { directory: file.directory, extension: file.extension });
+        if (definition)
+            validateDoctorExtensionSettings(registry, mergeWorkflowExtensionSettings(settings.extensionSettings, definition.extensionSettings), "role", cwd, pi.trust.trusted, file.path, diagnostics, file.name);
         if (duplicateExtensionNames.has(file.name))
             continue;
         if (extensionPaths.get(file.name) !== file.path)
@@ -452,6 +458,8 @@ export async function doctor(options = {}) {
             }
         }
         const definition = inspectRole(path, activeTools, knownModels, availableModels, diagnostics, aliases, dynamicAliases, settingsPath);
+        if (definition)
+            validateDoctorExtensionSettings(registry, mergeWorkflowExtensionSettings(settings.extensionSettings, definition.extensionSettings), "role", cwd, pi.trust.trusted, path, diagnostics, name);
         if (definition)
             definitions.set(name, definition);
         else
@@ -481,6 +489,8 @@ export async function doctor(options = {}) {
             }
         }
         const definition = inspectRole(path, activeTools, knownModels, availableModels, diagnostics, aliases, dynamicAliases, settingsPath);
+        if (definition)
+            validateDoctorExtensionSettings(registry, mergeWorkflowExtensionSettings(settings.extensionSettings, definition.extensionSettings), "role", cwd, pi.trust.trusted, path, diagnostics, name);
         if (definition)
             definitions.set(name, definition);
         else
@@ -513,7 +523,7 @@ export async function doctor(options = {}) {
                         const dynamic = await registry.resolveModelAliases({ cwd, projectTrusted: pi.trust.trusted, rootModel, knownModels, availableModels, signal: new AbortController().signal });
                         roleAliases = { ...aliases, ...dynamic };
                     }
-                    roleInspection = await inspectRoleSession(cwd, agentDir, options.role, definition, activeRole.path, resourcePolicy, rootModel, [...activeTools], roleAliases, knownModels, availableModels, settingsPath, options.prompt ?? "", registry.agentSetupHooks(), diagnostics);
+                    roleInspection = await inspectRoleSession(cwd, agentDir, options.role, definition, activeRole.path, resourcePolicy, rootModel, [...activeTools], roleAliases, knownModels, availableModels, settingsPath, settings.extensionSettings, options.prompt ?? "", registry.agentSetupHooks(), diagnostics);
                     if (roleInspection)
                         diagnostics.push(...roleInspection.setup.diagnostics);
                 }
@@ -530,7 +540,7 @@ export async function doctor(options = {}) {
     const severityOrder = { error: 0, warning: 1 };
     diagnostics.sort((left, right) => severityOrder[left.severity] - severityOrder[right.severity] || (left.source ?? "").localeCompare(right.source ?? "") || left.code.localeCompare(right.code) || left.message.localeCompare(right.message));
     roles.sort((left, right) => left.name.localeCompare(right.name) || left.scope.localeCompare(right.scope));
-    return { cwd, agentDir, settingsPath, settings, settingsSources, trust: pi.trust, activeTools: [...activeTools].sort(), piExtensions: [...new Set((pi.extensions ?? []).map(canonical))].sort(), piSkills: [...new Set(pi.skills ?? [])].sort(), roles, functions, modelAliases, resourcePolicy, ...(options.role !== undefined ? { roleTarget: options.role } : {}), ...(roleInspection ? { roleInspection } : {}), diagnostics };
+    return { cwd, agentDir, settingsPath, settings, settingsSources, trust: pi.trust, activeTools: [...activeTools].sort(), piExtensions: [...new Set((pi.extensions ?? []).map(canonicalPath))].sort(), piSkills: [...new Set(pi.skills ?? [])].sort(), roles, functions, modelAliases, resourcePolicy, ...(options.role !== undefined ? { roleTarget: options.role } : {}), ...(roleInspection ? { roleInspection } : {}), diagnostics };
 }
 function count(report, severity) { return report.diagnostics.filter((item) => item.severity === severity).length; }
 export function doctorExitCode(report) { return count(report, "error") > 0 ? 1 : 0; }
@@ -608,7 +618,7 @@ export function formatDoctorReport(report) {
         `- Agent dir: \`${report.agentDir}\``,
         `- Global workflow settings: \`${report.settingsPath}\``,
         `- Project workflow settings: \`${report.resourcePolicy.projectSettingsPath}\` (${report.resourcePolicy.projectTrusted ? "trusted" : "ignored: project untrusted"})`,
-        `- Effective setting sources: concurrency=\`${report.settingsSources.concurrency}\`, modelAliases=\`${report.settingsSources.modelAliases}\`, skills=\`${report.settingsSources.skills ?? "(none)"}\`, extensions=\`${report.settingsSources.extensions ?? "(none)"}\`, tools=\`${report.settingsSources.tools ?? "(none)"}\``,
+        `- Effective setting sources: concurrency=\`${report.settingsSources.concurrency}\`, modelAliases=\`${report.settingsSources.modelAliases}\`, skills=\`${report.settingsSources.skills ?? "(none)"}\`, extensions=\`${report.settingsSources.extensions ?? "(none)"}\`, extensionSettings=\`${report.settingsSources.extensionSettings ?? "(none)"}\`, tools=\`${report.settingsSources.tools ?? "(none)"}\``,
         `- Limits: concurrency=${String(report.settings.concurrency)}`,
         "",
         "## Trust/resources",

package/dist/src/session-inspector.js

@@ -4,7 +4,7 @@ import { emitKeypressEvents } from "node:readline";
 import { createInterface } from "node:readline/promises";
 import { stdin, stdout } from "node:process";
 import { highlightCode, initTheme, SessionManager, truncateToVisualLines } from "@earendil-works/pi-coding-agent";
-import { errorText, formatBudgetStatus, inspectWorkflowScript } from "pi-extensible-workflows";
+import { errorText, formatBudgetStatus, inspectWorkflowScript, parseThinking } from "pi-extensible-workflows";
 import { listPersistedSessionIds, listRunIds, RunStore } from "pi-extensible-workflows/persistence";
 function text(content) {
     if (typeof content === "string")
@@ -69,13 +69,6 @@ function mergedModels(groups) {
             totals.set(item.model, (totals.get(item.model) ?? 0) + item.cost);
     return [...totals].map(([model, cost]) => ({ model, cost })).sort((a, b) => b.cost - a.cost || a.model.localeCompare(b.model));
 }
-const thinkingLevels = ["off", "minimal", "low", "medium", "high", "xhigh", "max"];
-function isThinkingLevel(value) {
-    return typeof value === "string" && thinkingLevels.some((level) => level === value);
-}
-function parsedThinking(value) {
-    return isThinkingLevel(value) ? value : undefined;
-}
 function modelName(provider, model) {
     return typeof provider === "string" && provider && typeof model === "string" && model ? `${provider}/${model}` : undefined;
 }
@@ -93,7 +86,7 @@ function transcript(manager) {
             continue;
         }
         if (entry.type === "thinking_level_change") {
-            thinking = parsedThinking(entry.thinkingLevel);
+            thinking = parseThinking(entry.thinkingLevel);
             if (thinking === undefined)
                 throw new Error("Invalid thinking policy");
             continue;
@@ -180,7 +173,7 @@ async function loadRuns(cwd, sessionId, home) {
     }
     return runs;
 }
-async function agentReport(agent) {
+function agentReport(agent) {
     const fallbackModel = `${agent.model.provider}/${agent.model.model}`;
     const fallbackThinking = agent.model.thinking;
     const attempts = [];
@@ -188,15 +181,10 @@ async function agentReport(agent) {
         const setup = attempt.setup;
         const path = attemptTranscriptPath(attempt);
         const log = path ? readTranscript(path) : undefined;
-        if (log) {
-            const model = log.model ?? `${setup.model.provider}/${setup.model.model}`;
-            const cost = log.cost;
-            attempts.push({ attempt: attempt.attempt, prompt: log.prompt ?? "(transcript unavailable)", model, ...(log.thinking !== undefined ? { thinking: log.thinking } : {}), cost, models: log.models.length ? log.models : [{ model, cost }], ...(attempt.error ? { error: `${attempt.error.code}: ${attempt.error.message}` } : {}), setup });
-            continue;
-        }
-        const model = `${setup.model.provider}/${setup.model.model}`;
-        const cost = attempt.accounting.cost;
-        attempts.push({ attempt: attempt.attempt, prompt: "(transcript unavailable)", model, ...(setup.model.thinking !== undefined ? { thinking: setup.model.thinking } : {}), cost, models: [{ model, cost }], ...(attempt.error ? { error: `${attempt.error.code}: ${attempt.error.message}` } : {}), setup });
+        const model = log?.model ?? `${setup.model.provider}/${setup.model.model}`;
+        const thinking = log ? log.thinking : setup.model.thinking;
+        const cost = log?.cost ?? attempt.accounting.cost;
+        attempts.push({ attempt: attempt.attempt, prompt: log?.prompt ?? "(transcript unavailable)", model, ...(thinking !== undefined ? { thinking } : {}), cost, models: log?.models.length ? log.models : [{ model, cost }], ...(attempt.error ? { error: `${attempt.error.code}: ${attempt.error.message}` } : {}), setup });
     }
     if (!attempts.length) {
         const cost = agent.accounting?.cost ?? 0;
@@ -230,7 +218,7 @@ export async function loadSessionReport(path, home = homedir()) {
         const runId = resultRunId(result);
         const loaded = runId ? runs.get(runId) : undefined;
         const args = call.arguments;
-        const agents = loaded ? await Promise.all(loaded.run.agents.map(agentReport)) : [];
+        const agents = loaded ? loaded.run.agents.map(agentReport) : [];
         const models = mergedModels(agents.flatMap(({ attempts }) => attempts.map(({ models: attemptModels }) => attemptModels)));
         const name = loaded?.run.workflowName ?? (typeof args.name === "string" ? args.name : "workflow");
         const description = typeof args.description === "string" ? args.description : loaded?.snapshot.metadata.description;

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@piewf/cli",
-  "version": "5.13.1",
+  "version": "5.14.0",
   "description": "CLI for pi-extensible-workflows",
   "homepage": "https://vekexasia.github.io/pi-extensible-workflows/",
   "repository": {
@@ -43,7 +43,7 @@
     "@earendil-works/pi-coding-agent": "0.85.0",
     "@earendil-works/pi-server": "0.85.0",
     "@earendil-works/pi-tui": "0.85.0",
-    "pi-extensible-workflows": "5.13.1",
+    "pi-extensible-workflows": "5.14.0",
     "typebox": "1.3.7"
   },
   "publishConfig": {