@pie-lib/graphing-solution-set 4.0.21 → 4.0.22-beta.2

package/src/__tests__/utils.js

@@ -1,41 +0,0 @@
-export const scaleMock = () => {
-  const fn = jest.fn((n) => n);
-  fn.invert = jest.fn((n) => n);
-  fn.domain = jest.fn(() => fn);
-  fn.range = jest.fn(() => fn);
-  fn.copy = jest.fn(() => scaleMock());
-  return fn;
-};
-
-export const graphProps = (dmin = 0, dmax = 1, rmin = 0, rmax = 1) => ({
-  scale: {
-    x: scaleMock(),
-    y: scaleMock(),
-  },
-  snap: {
-    x: jest.fn((n) => n),
-    y: jest.fn((n) => n),
-  },
-  domain: {
-    min: dmin,
-    max: dmax,
-    step: 1,
-  },
-  range: {
-    min: rmin,
-    max: rmax,
-    step: 1,
-  },
-  size: {
-    width: 400,
-    height: 400,
-  },
-});
-
-export const xy = (x, y, index) => {
-  const out = { x, y, index };
-  if (!Number.isFinite(index)) {
-    delete out.index;
-  }
-  return out;
-};

package/src/__tests__/utils.test.js

@@ -1,105 +0,0 @@
-import * as utils from '../utils';
-
-const xy = (x, y) => ({ x, y });
-
-const tick = (isMajor, v) => ({
-  major: isMajor,
-  value: v,
-  x: v,
-});
-
-const major = tick.bind(null, true);
-const minor = tick.bind(null, false);
-
-describe('utils', () => {
-  describe('polygonToArea', () => {
-    const assertPolygon = (points, area) => {
-      it(`converts ${points} -> ${area}`, () => {
-        const result = utils.polygonToArea(points);
-        expect(result).toEqual(area);
-      });
-    };
-    assertPolygon([xy(0, 0), xy(1, 1), xy(1, -1)], {
-      left: 0,
-      top: 1,
-      bottom: -1,
-      right: 1,
-    });
-    assertPolygon([xy(0, 0), xy(3, 0), xy(2, -1), xy(4, -3), xy(1, -4), xy(2, -2)], {
-      left: 0,
-      top: 0,
-      bottom: -4,
-      right: 4,
-    });
-  });
-
-  describe('lineToArea', () => {
-    const assertLine = (from, to, expected) => {
-      it(`${from},${to} => ${expected}`, () => {
-        const result = utils.lineToArea(from, to);
-        expect(result).toEqual(expected);
-      });
-    };
-
-    assertLine(xy(1, 1), xy(2, 2), { left: 1, top: 2, bottom: 1, right: 2 });
-    assertLine(xy(-1, 4), xy(4, -3), {
-      left: -1,
-      top: 4,
-      bottom: -3,
-      right: 4,
-    });
-  });
-
-  describe('getTickValues', () => {
-    const assertGetTickValues = (props, expected) => {
-      it(` => ${expected}`, () => {
-        const result = utils.getTickValues(props);
-        expect(result).toEqual(expected);
-      });
-    };
-
-    assertGetTickValues({ min: 0, max: 10, step: 1 }, [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10]);
-    assertGetTickValues({ min: 0, max: 3, step: 0.5 }, [0, 0.5, 1, 1.5, 2, 2.5, 3]);
-    assertGetTickValues({ min: -0.2, max: 2, step: 0.6 }, [0, 0.6, 1.2, 1.8]);
-    assertGetTickValues({ min: -3.4, max: 6.2, step: 1.2 }, [0, -1.2, -2.4, 1.2, 2.4, 3.6, 4.8, 6]);
-
-    assertGetTickValues(
-      { min: 0.6, max: 4.8, step: 0.3 },
-      [0.6, 0.9, 1.2, 1.5, 1.8, 2.1, 2.4, 2.7, 3.0, 3.3, 3.6, 3.9, 4.2, 4.5, 4.8],
-    );
-    assertGetTickValues(
-      { min: 0.5, max: 4.9, step: 0.3 },
-      [0.6, 0.9, 1.2, 1.5, 1.8, 2.1, 2.4, 2.7, 3.0, 3.3, 3.6, 3.9, 4.2, 4.5, 4.8],
-    );
-    assertGetTickValues(
-      { min: 0, max: 3, step: 0.125 },
-      [
-        0, 0.125, 0.25, 0.375, 0.5, 0.625, 0.75, 0.875, 1, 1.125, 1.25, 1.375, 1.5, 1.625, 1.75, 1.875, 2, 2.125, 2.25,
-        2.375, 2.5, 2.625, 2.75, 2.875, 3,
-      ],
-    );
-  });
-
-  describe('countWords', () => {
-    it('should return 1 if label is undefined', () => {
-      const label = undefined;
-      const result = utils.countWords(label);
-
-      expect(result).toEqual(1);
-    });
-
-    it('should return 1 if label is null', () => {
-      const label = null;
-      const result = utils.countWords(label);
-
-      expect(result).toEqual(1);
-    });
-
-    it('should return 3 if label has 3 words', () => {
-      const label = 'Number of months';
-      const result = utils.countWords(label);
-
-      expect(result).toEqual(3);
-    });
-  });
-});

package/src/axis/__tests__/arrow.test.jsx

@@ -1,43 +0,0 @@
-import { render } from '@pie-lib/test-utils';
-import React from 'react';
-import { Arrow } from '../arrow';
-
-describe('Arrow', () => {
-  let onChange = jest.fn();
-
-  const renderComponent = (extras) => {
-    const defaults = {
-      classes: {},
-      className: 'className',
-      onChange,
-      scale: {
-        x: jest.fn((n) => n),
-        y: jest.fn((n) => n),
-      },
-    };
-    const props = { ...defaults, ...extras };
-    return render(<Arrow {...props} />);
-  };
-
-  describe('rendering', () => {
-    it('renders with direction up', () => {
-      const { container } = renderComponent({ direction: 'up' });
-      expect(container.firstChild).toBeInTheDocument();
-    });
-
-    it('renders with direction down', () => {
-      const { container } = renderComponent({ direction: 'down' });
-      expect(container.firstChild).toBeInTheDocument();
-    });
-
-    it('renders with direction left', () => {
-      const { container } = renderComponent({ direction: 'left' });
-      expect(container.firstChild).toBeInTheDocument();
-    });
-
-    it('renders with direction right', () => {
-      const { container } = renderComponent({ direction: 'right' });
-      expect(container.firstChild).toBeInTheDocument();
-    });
-  });
-});

package/src/axis/__tests__/axes.test.jsx

@@ -1,182 +0,0 @@
-import { render } from '@pie-lib/test-utils';
-import React from 'react';
-import { graphProps } from '../../__tests__/utils';
-
-import { firstNegativeValue, RawXAxis, RawYAxis, sharedValues } from '../axes';
-
-describe('RawXAxis', () => {
-  let onChange = jest.fn();
-
-  const renderComponent = (extras) => {
-    const defaults = {
-      classes: {},
-      className: 'className',
-      onChange,
-      graphProps: graphProps(),
-      includeArrows: {
-        left: true,
-        right: true,
-        up: true,
-        down: true,
-      },
-      columnTicksValues: [-1, 0, 1],
-      skipValues: [],
-      distanceFromOriginToFirstNegativeY: 0,
-      dy: 0,
-    };
-    const props = { ...defaults, ...extras };
-    return render(<RawXAxis {...props} />);
-  };
-
-  describe('rendering', () => {
-    it('renders without crashing', () => {
-      const { container } = renderComponent();
-      expect(container.firstChild).toBeInTheDocument();
-    });
-  });
-});
-
-describe('RawYAxis', () => {
-  let onChange = jest.fn();
-
-  const renderComponent = (extras) => {
-    const defaults = {
-      classes: {},
-      className: 'className',
-      onChange,
-      graphProps: graphProps(),
-      includeArrows: {
-        left: true,
-        right: true,
-        up: true,
-        down: true,
-      },
-      rowTickValues: [-1, 0, 1],
-      skipValues: [],
-    };
-    const props = { ...defaults, ...extras };
-    return render(<RawYAxis {...props} />);
-  };
-
-  describe('rendering', () => {
-    it('renders without crashing', () => {
-      const { container } = renderComponent();
-      expect(container.firstChild).toBeInTheDocument();
-    });
-  });
-});
-
-const customScaleMock = (distance) => {
-  const fn = jest.fn((n) => n * distance);
-  fn.invert = jest.fn((n) => n * distance);
-  fn.domain = jest.fn(() => fn);
-  fn.range = jest.fn(() => fn);
-  fn.copy = jest.fn(() => customScaleMock(distance));
-  return fn;
-};
-
-// Note: Instance method tests (xValues, yValues) have been removed.
-// These methods are internal implementation details and should be tested through
-// component rendering and integration tests that verify the axes render correctly.
-
-describe('firstNegativeValue', () => {
-  it('should return undefined for undefined interval', () => {
-    const interval = undefined;
-    const result = firstNegativeValue(interval);
-    expect(result).toEqual(undefined);
-  });
-
-  it('should return undefined for empty interval', () => {
-    const interval = [];
-    const result = firstNegativeValue(interval);
-    expect(result).toEqual(undefined);
-  });
-
-  it('should return undefined if there is no negative in interval array', () => {
-    const interval = [1, 5, 7, 4, 5];
-    const result = firstNegativeValue(interval);
-    expect(result).toEqual(undefined);
-  });
-
-  it('should return first negative number from interval', () => {
-    const interval = [1, 5, 7, -2, 4, 5, -1];
-    const result = firstNegativeValue(interval);
-    expect(result).toEqual(-2);
-  });
-});
-
-describe('sharedValues', () => {
-  it('should be empty array if firstNegativeValue for one of the axes is undefined', () => {
-    // x
-    const intervalX = [1, 2, 3, 4, 5, 6];
-    const firstNegativeX = firstNegativeValue(intervalX);
-    const distanceFromOriginToFirstNegativeX = -22;
-
-    // y
-    const intervalY = [-1, -2, 1, 2, 3, 4, 5, 6];
-    const firstNegativeY = firstNegativeValue(intervalY);
-    const distanceFromOriginToFirstNegativeY = -22;
-
-    const deltaAllowance = 5;
-
-    const result = sharedValues(
-      firstNegativeX,
-      firstNegativeY,
-      distanceFromOriginToFirstNegativeX,
-      distanceFromOriginToFirstNegativeY,
-      deltaAllowance,
-    );
-
-    expect(result).toEqual([]);
-  });
-
-  it('should be empty array if firstNegativeX and firstNegativeY are equal but they do not overlap', () => {
-    // x
-    const intervalX = [-1, -2, 1, 2, 3, 4, 5, 6];
-    const firstNegativeX = firstNegativeValue(intervalX);
-    const distanceFromOriginToFirstNegativeX = -7;
-
-    // y
-    const intervalY = [-1, -2, 1, 2, 3, 4, 5, 6];
-    const firstNegativeY = firstNegativeValue(intervalY);
-    const distanceFromOriginToFirstNegativeY = -22;
-
-    const deltaAllowance = 5;
-
-    const result = sharedValues(
-      firstNegativeX,
-      firstNegativeY,
-      distanceFromOriginToFirstNegativeX,
-      distanceFromOriginToFirstNegativeY,
-      deltaAllowance,
-    );
-
-    expect(result).toEqual([]);
-  });
-
-  it('should be -1 if firstNegativeX and firstNegativeY are equal and they overlap', () => {
-    // x
-    const intervalX = [-1, -2, 1, 2, 3, 4, 5, 6];
-    const firstNegativeX = firstNegativeValue(intervalX);
-    const distanceFromOriginToFirstNegativeX = -20;
-
-    // y
-    const intervalY = [-1, -2, 1, 2, 3, 4, 5, 6];
-    const firstNegativeY = firstNegativeValue(intervalY);
-    const distanceFromOriginToFirstNegativeY = -22;
-
-    const deltaAllowance = 5;
-    const dy = -20; // dy needs to be within the range for the condition to pass
-
-    const result = sharedValues(
-      firstNegativeX,
-      firstNegativeY,
-      distanceFromOriginToFirstNegativeX,
-      distanceFromOriginToFirstNegativeY,
-      deltaAllowance,
-      dy,
-    );
-
-    expect(result).toEqual([-1]);
-  });
-});

package/src/container/__tests__/actions.test.js

@@ -1,105 +0,0 @@
-import { addMark, changeMarks } from '../actions';
-
-describe('container actions', () => {
-  describe('addMark', () => {
-    it('creates ADD_MARK action', () => {
-      const action = addMark();
-      expect(action).toEqual({
-        type: 'ADD_MARK',
-      });
-    });
-
-    it('creates action without parameters', () => {
-      const action = addMark();
-      expect(action.type).toBe('ADD_MARK');
-      expect(Object.keys(action)).toEqual(['type']);
-    });
-  });
-
-  describe('changeMarks', () => {
-    it('creates CHANGE_MARKS action with marks', () => {
-      const marks = [{ id: 1, type: 'point' }];
-      const action = changeMarks(marks);
-
-      expect(action).toEqual({
-        type: 'CHANGE_MARKS',
-        marks,
-      });
-    });
-
-    it('creates action with empty marks array', () => {
-      const marks = [];
-      const action = changeMarks(marks);
-
-      expect(action).toEqual({
-        type: 'CHANGE_MARKS',
-        marks: [],
-      });
-    });
-
-    it('creates action with multiple marks', () => {
-      const marks = [
-        { id: 1, type: 'point', x: 1, y: 2 },
-        { id: 2, type: 'line', from: { x: 0, y: 0 }, to: { x: 5, y: 5 } },
-      ];
-      const action = changeMarks(marks);
-
-      expect(action.marks).toEqual(marks);
-      expect(action.marks.length).toBe(2);
-    });
-
-    it('creates action with null marks', () => {
-      const marks = null;
-      const action = changeMarks(marks);
-
-      expect(action).toEqual({
-        type: 'CHANGE_MARKS',
-        marks: null,
-      });
-    });
-
-    it('creates action with undefined marks', () => {
-      const marks = undefined;
-      const action = changeMarks(marks);
-
-      expect(action).toEqual({
-        type: 'CHANGE_MARKS',
-        marks: undefined,
-      });
-    });
-
-    it('preserves mark properties', () => {
-      const marks = [
-        {
-          id: 1,
-          type: 'point',
-          x: 10,
-          y: 20,
-          label: 'A',
-          correctness: { value: 'correct' },
-        },
-      ];
-      const action = changeMarks(marks);
-
-      expect(action.marks[0]).toEqual(marks[0]);
-      expect(action.marks[0].correctness).toBeDefined();
-    });
-  });
-
-  describe('action types', () => {
-    it('has consistent action type strings', () => {
-      const addMarkAction = addMark();
-      const changeMarksAction = changeMarks([]);
-
-      expect(typeof addMarkAction.type).toBe('string');
-      expect(typeof changeMarksAction.type).toBe('string');
-    });
-
-    it('has unique action types', () => {
-      const addMarkAction = addMark();
-      const changeMarksAction = changeMarks([]);
-
-      expect(addMarkAction.type).not.toBe(changeMarksAction.type);
-    });
-  });
-});

package/src/container/__tests__/index.test.jsx

@@ -1,227 +0,0 @@
-import React from 'react';
-import { render } from '@pie-lib/test-utils';
-import Root, { GraphContainer } from '../index';
-
-jest.mock('../../graph-with-controls', () => {
-  return function GraphWithControls({ marks, onChangeMarks, onUndo, onRedo, onReset, disabled }) {
-    return (
-      <div data-testid="graph-with-controls">
-        <div data-testid="marks-count">{marks?.length || 0}</div>
-        {disabled && <div data-testid="disabled-indicator">Disabled</div>}
-        <button data-testid="change-marks" onClick={() => onChangeMarks && onChangeMarks([{ id: 1 }])}>
-          Change
-        </button>
-        <button data-testid="undo" onClick={onUndo}>
-          Undo
-        </button>
-        <button data-testid="redo" onClick={onRedo}>
-          Redo
-        </button>
-        <button data-testid="reset" onClick={onReset}>
-          Reset
-        </button>
-      </div>
-    );
-  };
-});
-
-jest.mock('@pie-lib/drag', () => ({
-  DragProvider: ({ children }) => <div data-testid="drag-provider">{children}</div>,
-}));
-
-describe('Container Root Component', () => {
-  const defaultProps = {
-    marks: [],
-    onChangeMarks: jest.fn(),
-  };
-
-  const renderComponent = (props = {}) => {
-    return render(<Root {...defaultProps} {...props} />);
-  };
-
-  describe('rendering', () => {
-    it('renders without crashing', () => {
-      const { container } = renderComponent();
-      expect(container).toBeInTheDocument();
-    });
-
-    it('renders GraphWithControls', () => {
-      const { getByTestId } = renderComponent();
-      expect(getByTestId('graph-with-controls')).toBeInTheDocument();
-    });
-
-    it('renders with Provider when no correctness set', () => {
-      const { container } = renderComponent({ marks: [{ id: 1, type: 'point' }] });
-      expect(container.querySelector('[data-testid="graph-with-controls"]')).toBeInTheDocument();
-    });
-
-    it('renders directly when correctness is set', () => {
-      const marks = [{ id: 1, type: 'point', correctness: { value: 'correct' } }];
-      const { getByTestId } = renderComponent({ marks });
-
-      expect(getByTestId('graph-with-controls')).toBeInTheDocument();
-      expect(getByTestId('disabled-indicator')).toBeInTheDocument();
-    });
-
-    it('passes marks to GraphWithControls', () => {
-      const marks = [{ id: 1 }, { id: 2 }];
-      const { getByTestId } = renderComponent({ marks });
-      expect(getByTestId('marks-count')).toHaveTextContent('2');
-    });
-  });
-
-  describe('componentDidUpdate', () => {
-    it('updates store when marks prop changes', () => {
-      const onChangeMarks = jest.fn();
-      const { rerender } = render(<Root marks={[]} onChangeMarks={onChangeMarks} />);
-
-      const newMarks = [{ id: 1, type: 'point' }];
-      rerender(<Root marks={newMarks} onChangeMarks={onChangeMarks} />);
-
-      expect(onChangeMarks).not.toHaveBeenCalled();
-    });
-
-    it('does not update when marks are equal', () => {
-      const marks = [{ id: 1, type: 'point' }];
-      const onChangeMarks = jest.fn();
-      const { rerender } = render(<Root marks={marks} onChangeMarks={onChangeMarks} />);
-
-      onChangeMarks.mockClear();
-
-      rerender(<Root marks={marks} onChangeMarks={onChangeMarks} />);
-
-      expect(onChangeMarks).not.toHaveBeenCalled();
-    });
-
-    it('handles marks changing from empty to non-empty', () => {
-      const onChangeMarks = jest.fn();
-      const { rerender } = render(<Root marks={[]} onChangeMarks={onChangeMarks} />);
-
-      const newMarks = [{ id: 1 }];
-
-      expect(() => {
-        rerender(<Root marks={newMarks} onChangeMarks={onChangeMarks} />);
-      }).not.toThrow();
-    });
-
-    it('handles marks changing from non-empty to empty', () => {
-      const onChangeMarks = jest.fn();
-      const { rerender } = render(<Root marks={[{ id: 1 }]} onChangeMarks={onChangeMarks} />);
-
-      expect(() => {
-        rerender(<Root marks={[]} onChangeMarks={onChangeMarks} />);
-      }).not.toThrow();
-    });
-  });
-
-  describe('correctness handling', () => {
-    it('disables when any mark has correctness', () => {
-      const marks = [
-        { id: 1, type: 'point' },
-        { id: 2, type: 'point', correctness: { value: 'correct' } },
-      ];
-      const { getByTestId } = renderComponent({ marks });
-
-      expect(getByTestId('disabled-indicator')).toBeInTheDocument();
-    });
-
-    it('renders without Provider when correctness is set', () => {
-      const marks = [{ id: 1, correctness: { value: 'correct' } }];
-      const { container } = renderComponent({ marks });
-
-      expect(container.querySelector('[data-testid="graph-with-controls"]')).toBeInTheDocument();
-    });
-
-    it('does not disable when no correctness is set', () => {
-      const marks = [
-        { id: 1, type: 'point' },
-        { id: 2, type: 'line' },
-      ];
-      const { queryByTestId } = renderComponent({ marks });
-
-      expect(queryByTestId('disabled-indicator')).not.toBeInTheDocument();
-    });
-
-    it('handles correctness with different values', () => {
-      const marks = [{ id: 1, correctness: { value: 'incorrect' } }];
-      const { getByTestId } = renderComponent({ marks });
-
-      expect(getByTestId('disabled-indicator')).toBeInTheDocument();
-    });
-
-    it('handles empty correctness object', () => {
-      const marks = [{ id: 1, correctness: {} }];
-      const { getByTestId } = renderComponent({ marks });
-
-      expect(getByTestId('disabled-indicator')).toBeInTheDocument();
-    });
-  });
-
-  describe('props forwarding', () => {
-    it('forwards additional props to GraphWithControls', () => {
-      const { container } = renderComponent({
-        className: 'custom-class',
-        size: { width: 500, height: 500 },
-      });
-
-      expect(container.querySelector('[data-testid="graph-with-controls"]')).toBeInTheDocument();
-    });
-
-    it('does not forward onChangeMarks and marks to GraphWithControls', () => {
-      const { getByTestId } = renderComponent({
-        marks: [{ id: 1 }],
-        onChangeMarks: jest.fn(),
-        otherProp: 'test',
-      });
-
-      expect(getByTestId('graph-with-controls')).toBeInTheDocument();
-    });
-  });
-
-  describe('edge cases', () => {
-    it('handles empty marks array', () => {
-      const { container } = renderComponent({ marks: [] });
-      expect(container).toBeInTheDocument();
-    });
-
-    it('handles marks with complex structure', () => {
-      const marks = [
-        {
-          id: 1,
-          type: 'line',
-          from: { x: 0, y: 0 },
-          to: { x: 10, y: 10 },
-          label: 'Line A',
-          correctness: { value: 'correct', label: 'Correct!' },
-        },
-      ];
-      const { getByTestId } = renderComponent({ marks });
-      expect(getByTestId('graph-with-controls')).toBeInTheDocument();
-    });
-
-    it('handles switching between correctness states', () => {
-      const { rerender } = render(<Root marks={[{ id: 1 }]} onChangeMarks={jest.fn()} />);
-
-      rerender(<Root marks={[{ id: 1, correctness: { value: 'correct' } }]} onChangeMarks={jest.fn()} />);
-
-      rerender(<Root marks={[{ id: 1 }]} onChangeMarks={jest.fn()} />);
-
-      expect(document.querySelector('[data-testid="graph-with-controls"]')).toBeInTheDocument();
-    });
-  });
-});
-
-describe('GraphContainer (connected component)', () => {
-  it('is a connected component', () => {
-    expect(GraphContainer).toBeDefined();
-    expect(GraphContainer.displayName).toContain('Connect');
-  });
-
-  it('maps state to props', () => {
-    expect(GraphContainer).toBeDefined();
-  });
-
-  it('maps dispatch to props', () => {
-    expect(GraphContainer).toBeDefined();
-  });
-});