@pie-element/image-cloze-association 10.2.0 → 10.3.0

package/src/__tests__/image-drop-target.test.jsx

@@ -0,0 +1,169 @@
+import React from 'react';
+import { render, fireEvent } from '@testing-library/react';
+import ImageDropTarget from '../image-drop-target';
+
+jest.mock('@dnd-kit/core', () => ({
+  useDroppable: () => ({
+    setNodeRef: jest.fn(),
+    isOver: false,
+  }),
+}));
+
+jest.mock('../possible-response', () => (props) => (
+  <div data-testid={`possible-response-${props.data.id}`} onClick={() => props.onSelectClick?.(props.data)}>
+    {props.data.value}
+  </div>
+));
+
+describe('ImageDropTarget', () => {
+  const baseProps = {
+    answers: [],
+    canDrag: true,
+    containerStyle: {},
+    draggingElement: { id: '' },
+    onDragAnswerBegin: jest.fn(),
+    onDragAnswerEnd: jest.fn(),
+    onDrop: jest.fn(),
+    index: 2,
+  };
+
+  describe('empty container', () => {
+    it('is a native tab stop (role=button, tabIndex=0) when canDrag', () => {
+      const { container } = render(<ImageDropTarget {...baseProps} />);
+      const target = container.firstChild;
+
+      expect(target.getAttribute('role')).toBe('button');
+      expect(target.getAttribute('tabindex')).toBe('0');
+    });
+
+    it('is not a tab stop when canDrag is false, and has no role either (I2)', () => {
+      const { container } = render(<ImageDropTarget {...baseProps} canDrag={false} />);
+      const target = container.firstChild;
+
+      expect(target.getAttribute('tabindex')).toBe('-1');
+      expect(target.getAttribute('role')).toBeNull();
+    });
+
+    it('places the selection here on click', () => {
+      const onPlacementClick = jest.fn();
+      const { container } = render(
+        <ImageDropTarget
+          {...baseProps}
+          selectedResponse={{ id: '9', containerIndex: undefined }}
+          onPlacementClick={onPlacementClick}
+        />,
+      );
+
+      fireEvent.click(container.firstChild);
+
+      expect(onPlacementClick).toHaveBeenCalledWith(2);
+    });
+
+    it('does nothing on click when nothing is selected', () => {
+      const onPlacementClick = jest.fn();
+      const { container } = render(<ImageDropTarget {...baseProps} onPlacementClick={onPlacementClick} />);
+
+      fireEvent.click(container.firstChild);
+
+      expect(onPlacementClick).not.toHaveBeenCalled();
+    });
+
+    it('places the selection here on Space/Enter', () => {
+      const onPlacementClick = jest.fn();
+      const { container } = render(
+        <ImageDropTarget
+          {...baseProps}
+          selectedResponse={{ id: '9', containerIndex: undefined }}
+          onPlacementClick={onPlacementClick}
+        />,
+      );
+
+      fireEvent.keyDown(container.firstChild, { code: 'Space' });
+
+      expect(onPlacementClick).toHaveBeenCalledWith(2);
+    });
+  });
+
+  describe('occupied container', () => {
+    const answers = [{ id: '7', value: 'Placed', containerIndex: 2 }];
+
+    it('is not its own tab stop and has no role either — occupied containers must not become unlabeled buttons for screen readers (I2)', () => {
+      const { container } = render(<ImageDropTarget {...baseProps} answers={answers} />);
+      const target = container.firstChild;
+
+      expect(target.getAttribute('tabindex')).toBe('-1');
+      expect(target.getAttribute('role')).toBeNull();
+    });
+
+    it('places the selection here when clicking empty background (not a specific tile)', () => {
+      const onPlacementClick = jest.fn();
+      const { container } = render(
+        <ImageDropTarget
+          {...baseProps}
+          answers={answers}
+          selectedResponse={{ id: '9', containerIndex: undefined }}
+          onPlacementClick={onPlacementClick}
+        />,
+      );
+
+      fireEvent.click(container.firstChild);
+
+      expect(onPlacementClick).toHaveBeenCalledWith(2);
+    });
+
+    it('forwards selection props to the placed tile, which handles its own click', () => {
+      const onSelectClick = jest.fn();
+      const { getByTestId } = render(
+        <ImageDropTarget {...baseProps} answers={answers} onSelectClick={onSelectClick} />,
+      );
+
+      fireEvent.click(getByTestId('possible-response-7'));
+
+      expect(onSelectClick).toHaveBeenCalledWith(answers[0]);
+    });
+  });
+
+  describe('hover affordance during click-to-select (I3)', () => {
+    it('gets the is-over highlight and a pointer cursor on hover when something is selected', () => {
+      const { container } = render(
+        <ImageDropTarget {...baseProps} selectedResponse={{ id: '9', containerIndex: undefined }} />,
+      );
+      const target = container.firstChild;
+
+      expect(target.className).not.toMatch(/\bis-over\b/);
+
+      fireEvent.mouseEnter(target);
+      expect(target.className).toMatch(/\bis-over\b/);
+      expect(target.style.cursor).toBe('pointer');
+
+      fireEvent.mouseLeave(target);
+      expect(target.className).not.toMatch(/\bis-over\b/);
+    });
+
+    it('does not show the is-over highlight on hover when nothing is selected', () => {
+      const { container } = render(<ImageDropTarget {...baseProps} selectedResponse={null} />);
+      const target = container.firstChild;
+
+      fireEvent.mouseEnter(target);
+
+      expect(target.className).not.toMatch(/\bis-over\b/);
+      expect(target.style.cursor).toBe('');
+    });
+
+    it('does not show the is-over highlight on hover when canDrag is false, even with a selection', () => {
+      const { container } = render(
+        <ImageDropTarget
+          {...baseProps}
+          canDrag={false}
+          selectedResponse={{ id: '9', containerIndex: undefined }}
+        />,
+      );
+      const target = container.firstChild;
+
+      fireEvent.mouseEnter(target);
+
+      expect(target.className).not.toMatch(/\bis-over\b/);
+      expect(target.style.cursor).toBe('');
+    });
+  });
+});

package/src/__tests__/keyboard-coordinates.test.js

@@ -0,0 +1,127 @@
+import { KeyboardCode } from '@dnd-kit/core';
+import { closestDroppableKeyboardCoordinates } from '../keyboard-coordinates';
+
+function rectsToContext(rects) {
+  const droppableRects = new Map(Object.entries(rects));
+  const droppableContainers = new Map(Object.keys(rects).map((id) => [id, { disabled: false }]));
+
+  return { droppableRects, droppableContainers };
+}
+
+function makeEvent(code, shiftKey = false) {
+  return { code, preventDefault: () => {}, shiftKey };
+}
+
+// Mirrors dnd-kit's own KeyboardSensor, which always derives collisionRect's top-left
+// from the dragged item's current on-screen position on every keydown — so a test's
+// collisionRect must track currentCoordinates the same way on every simulated press,
+// not stay fixed while currentCoordinates changes across multiple presses.
+function press(rects, currentCoordinates, itemSize, event) {
+  const context = {
+    ...rectsToContext(rects),
+    collisionRect: { left: currentCoordinates.x, top: currentCoordinates.y, ...itemSize },
+  };
+
+  return closestDroppableKeyboardCoordinates(event, { context, currentCoordinates });
+}
+
+describe('closestDroppableKeyboardCoordinates', () => {
+  describe('arrow keys', () => {
+    it("nudges the dragged item by dnd-kit's own default step (25px), unchanged", () => {
+      const context = { ...rectsToContext({}), collisionRect: { left: 0, top: 0, width: 100, height: 40 } };
+      const currentCoordinates = { x: 10, y: 20 };
+
+      expect(
+        closestDroppableKeyboardCoordinates(makeEvent(KeyboardCode.Down), { context, currentCoordinates }),
+      ).toEqual({ x: 10, y: 45 });
+      expect(
+        closestDroppableKeyboardCoordinates(makeEvent(KeyboardCode.Up), { context, currentCoordinates }),
+      ).toEqual({ x: 10, y: -5 });
+      expect(
+        closestDroppableKeyboardCoordinates(makeEvent(KeyboardCode.Right), { context, currentCoordinates }),
+      ).toEqual({ x: 35, y: 20 });
+      expect(
+        closestDroppableKeyboardCoordinates(makeEvent(KeyboardCode.Left), { context, currentCoordinates }),
+      ).toEqual({ x: -15, y: 20 });
+    });
+  });
+
+  describe('Tab / Shift+Tab', () => {
+    // Two response containers plus the choices pool ("ica-board"), laid out
+    // top-to-bottom like they would be over an image.
+    const container0Rect = { left: 0, top: 0, width: 200, height: 40, right: 200, bottom: 40 };
+    const container1Rect = { left: 0, top: 60, width: 200, height: 40, right: 200, bottom: 100 };
+    const poolRect = { left: 0, top: 120, width: 400, height: 300, right: 400, bottom: 420 };
+    const baseRects = {
+      'response-container-0': container0Rect,
+      'response-container-1': container1Rect,
+      'ica-board': poolRect,
+    };
+
+    it('jumps to the next droppable in top-to-bottom order, landing at its center-left point', () => {
+      const currentCoordinates = { x: container0Rect.left, y: container0Rect.top };
+
+      const next = press(baseRects, currentCoordinates, { width: 200, height: 40 }, makeEvent('Tab'));
+
+      expect(next).toEqual({ x: container1Rect.left, y: container1Rect.top + container1Rect.height / 2 });
+    });
+
+    it('cycles backwards with Shift+Tab, wrapping to the pool', () => {
+      const currentCoordinates = { x: container0Rect.left, y: container0Rect.top };
+
+      const next = press(baseRects, currentCoordinates, { width: 200, height: 40 }, makeEvent('Tab', true));
+
+      expect(next).toEqual({ x: poolRect.left, y: poolRect.top + poolRect.height / 2 });
+    });
+
+    it('keeps advancing on repeated Shift+Tab when a container is much wider than the dragged item', () => {
+      // Regression case for the bug already found and fixed in match-list: matching the
+      // "current" target by reconstructing a center from the dragged item's own small
+      // size (instead of checking which target's rect actually contains it) makes the
+      // *next* press re-match a completely different droppable once the item is
+      // actually sitting on a wide target, so it looks like the press does nothing.
+      // Only two targets here (a wide container and the pool), to isolate this from
+      // sort-order effects.
+      const wideContainerRect = { left: 0, top: 0, width: 900, height: 40, right: 900, bottom: 40 };
+      const rects = { 'response-container-0': wideContainerRect, 'ica-board': poolRect };
+      const itemSize = { width: 100, height: 40 };
+
+      // Start inside the pool, Shift+Tab to the only other target: the wide container.
+      const afterFirst = press(rects, { x: poolRect.left, y: poolRect.top }, itemSize, makeEvent('Tab', true));
+
+      expect(afterFirst).toEqual({ x: 0, y: 20 }); // wide container's center-left point
+
+      // Now sitting exactly at that dropPosition — Shift+Tab again must advance back
+      // to the pool, not re-match some other droppable.
+      const afterSecond = press(rects, afterFirst, itemSize, makeEvent('Tab', true));
+
+      expect(afterSecond).toEqual({ x: poolRect.left, y: poolRect.top + poolRect.height / 2 });
+    });
+
+    it("correctly identifies the pool as the current target when picking up an item positioned near the pool's edge, close to a small neighboring container", () => {
+      // Regression case for the OTHER failure mode: matching "current target" purely
+      // by nearest-dropPosition (instead of containment first) can misidentify the
+      // pool as some small, unrelated nearby container, because a large droppable's
+      // dropPosition is anchored at ITS OWN vertical middle — which can be far from an
+      // item that's sitting near the droppable's edge, even though the item is clearly
+      // still inside it.
+      const tallPoolRect = { left: 0, top: 0, width: 400, height: 600, right: 400, bottom: 600 };
+      const smallContainerRect = { left: 0, top: -60, width: 100, height: 40, right: 100, bottom: -20 };
+      const rects = { 'response-container-0': smallContainerRect, 'ica-board': tallPoolRect };
+      const itemSize = { width: 100, height: 40 };
+
+      // The item sits just inside the pool's top edge (y: 10-50) — nowhere near the
+      // pool's own vertical middle (y: 300), but visually still inside it, and closer
+      // in raw distance to the small container's anchor point (top: -60, center y:
+      // -40) than to the pool's anchor point (center y: 300).
+      const currentCoordinates = { x: 0, y: 10 };
+
+      const next = press(rects, currentCoordinates, itemSize, makeEvent('Tab'));
+
+      // Tab forward from the pool lands on the only other target: the small
+      // container — proving the pool, not the small container, was identified as
+      // "current".
+      expect(next).toEqual({ x: smallContainerRect.left, y: smallContainerRect.top + smallContainerRect.height / 2 });
+    });
+  });
+});

package/src/__tests__/possible-response.test.jsx

@@ -0,0 +1,113 @@
+import React from 'react';
+import { render, fireEvent } from '@testing-library/react';
+import PossibleResponse from '../possible-response';
+
+jest.mock('@dnd-kit/core', () => ({
+  useDraggable: () => ({
+    setNodeRef: jest.fn(),
+    attributes: {},
+    listeners: {},
+    isDragging: false,
+  }),
+}));
+
+describe('PossibleResponse', () => {
+  const baseProps = {
+    canDrag: true,
+    data: { id: '0', value: 'Choice A' },
+    onDragBegin: jest.fn(),
+  };
+
+  it('selects a pool item on click when nothing else is selected', () => {
+    const onSelectClick = jest.fn();
+    const onPlacementClick = jest.fn();
+    const { container } = render(
+      <PossibleResponse
+        {...baseProps}
+        selectedResponse={null}
+        onSelectClick={onSelectClick}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(container.firstChild);
+
+    expect(onSelectClick).toHaveBeenCalledWith(baseProps.data);
+    expect(onPlacementClick).not.toHaveBeenCalled();
+  });
+
+  it('toggles off (calls onSelectClick again) when clicking the already-selected item', () => {
+    const onSelectClick = jest.fn();
+    const onPlacementClick = jest.fn();
+    const { container } = render(
+      <PossibleResponse
+        {...baseProps}
+        selectedResponse={{ id: '0', containerIndex: undefined }}
+        onSelectClick={onSelectClick}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(container.firstChild);
+
+    expect(onSelectClick).toHaveBeenCalledWith(baseProps.data);
+    expect(onPlacementClick).not.toHaveBeenCalled();
+  });
+
+  it('selects a different pool item on click even while something else is selected (pool items are never placement targets)', () => {
+    const onSelectClick = jest.fn();
+    const onPlacementClick = jest.fn();
+    const { container } = render(
+      <PossibleResponse
+        {...baseProps}
+        selectedResponse={{ id: '1', containerIndex: 2 }}
+        onSelectClick={onSelectClick}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(container.firstChild);
+
+    expect(onSelectClick).toHaveBeenCalledWith(baseProps.data);
+    expect(onPlacementClick).not.toHaveBeenCalled();
+  });
+
+  it('places the current selection into this tile\'s container when clicking an already-placed tile that is not the selection', () => {
+    const onSelectClick = jest.fn();
+    const onPlacementClick = jest.fn();
+    const placedData = { id: '5', value: 'Choice B', containerIndex: 3 };
+    const { container } = render(
+      <PossibleResponse
+        {...baseProps}
+        data={placedData}
+        selectedResponse={{ id: '1', containerIndex: undefined }}
+        onSelectClick={onSelectClick}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(container.firstChild);
+
+    expect(onPlacementClick).toHaveBeenCalledWith(3);
+    expect(onSelectClick).not.toHaveBeenCalled();
+  });
+
+  it('does nothing on click when disabled (canDrag=false)', () => {
+    const onSelectClick = jest.fn();
+    const onPlacementClick = jest.fn();
+    const { container } = render(
+      <PossibleResponse
+        {...baseProps}
+        canDrag={false}
+        selectedResponse={null}
+        onSelectClick={onSelectClick}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(container.firstChild);
+
+    expect(onSelectClick).not.toHaveBeenCalled();
+    expect(onPlacementClick).not.toHaveBeenCalled();
+  });
+});

package/src/__tests__/possible-responses.test.jsx

@@ -0,0 +1,63 @@
+import React from 'react';
+import { render, fireEvent } from '@testing-library/react';
+import PossibleResponses from '../possible-responses';
+
+jest.mock('@pie-lib/drag', () => ({
+  ICADroppablePlaceholder: ({ children }) => <div data-testid="ica-board">{children}</div>,
+}));
+
+jest.mock('../possible-response', () => (props) => (
+  <div data-testid={`possible-response-${props.data.id}`} onClick={(e) => { e.stopPropagation(); props.onSelectClick?.(props.data); }}>
+    {props.data.value}
+  </div>
+));
+
+describe('PossibleResponses', () => {
+  const baseProps = {
+    canDrag: true,
+    data: [{ id: '0', value: 'Choice A' }],
+    onDragBegin: jest.fn(),
+  };
+
+  it('places the selection into the pool when clicking the pool background', () => {
+    const onPlacementClick = jest.fn();
+    const { container } = render(
+      <PossibleResponses
+        {...baseProps}
+        selectedResponse={{ id: '9', containerIndex: 1 }}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(container.firstChild);
+
+    expect(onPlacementClick).toHaveBeenCalledWith(undefined);
+  });
+
+  it('does nothing when clicking the pool background with nothing selected', () => {
+    const onPlacementClick = jest.fn();
+    const { container } = render(<PossibleResponses {...baseProps} onPlacementClick={onPlacementClick} />);
+
+    fireEvent.click(container.firstChild);
+
+    expect(onPlacementClick).not.toHaveBeenCalled();
+  });
+
+  it('clicking a specific pool item selects it, not the pool background handler', () => {
+    const onPlacementClick = jest.fn();
+    const onSelectClick = jest.fn();
+    const { getByTestId } = render(
+      <PossibleResponses
+        {...baseProps}
+        selectedResponse={{ id: '9', containerIndex: 1 }}
+        onSelectClick={onSelectClick}
+        onPlacementClick={onPlacementClick}
+      />,
+    );
+
+    fireEvent.click(getByTestId('possible-response-0'));
+
+    expect(onSelectClick).toHaveBeenCalledWith(baseProps.data[0]);
+    expect(onPlacementClick).not.toHaveBeenCalled();
+  });
+});