@piagent/platform 1.51.1 → 1.52.0

package/packages/piagent-core/managed/test-scope.mjs

@@ -0,0 +1,170 @@
+// How much of the suite a test command covers: 'partial' (a filter, one file, one
+// package or module), 'suite' (the whole test command) or null when it runs no tests.
+// A member who chose "only the related part" is stuck when a part reads as the
+// whole suite, so each tool says how its own commands narrow: the flags that pick
+// tests, the flags that take a value, and the words that still run everything
+// (a Maven goal, `vitest run`). Any other word on the line names a part.
+
+// What a command runs, without the text it merely quotes (a commit message, an
+// echo): a quoted word stays one word with nothing in it that splits a command.
+export const unquoted = text => text.replace(/"[^"]*"|'[^']*'/g, quoted => quoted.startsWith('"$') ? '$' : quoted.length > 2 ? quoted.slice(1, -1).replace(/[\s;&|<>()]/g, '_') : '""');
+export const partsOf = bare => bare.split(/\s*(?:\|\|?|&&|;)\s*/).map(part => part.replace(/\s\d*[<>].*$/, '').replace(/[\s)}]+$/, '').trim());
+
+const VERSION_ONLY = /(?:^|\s)(?:--version|-V|--help)(?:\s|$)/;
+// Listing the tests runs none of them.
+const LIST_ONLY = /(?:^|\s)(?:--collect-only|--co|--listTests|--list-tests|--list|-list|--dry-run|--dryRun|-showTestPlans)(?=[\s=]|$)/;
+const NOT_A_RUN = /^(echo|printf|grep|rg|cat|sed|awk|head|tail|less|git|ls|find)\b/;
+const NOT_TESTS = /\b(lint|typecheck|type-check|tsc|eslint|biome|ruff|mypy|pyright|vet|clippy|format|build)\b/;
+// What starts a command before the tool itself: a function body, a group, a loop body, env, a runner of binaries.
+const LAUNCHER = /^(?:[\w-]+\s*\(\)\s*\{?\s*|\{\s+|\(\s*|(?:do|then|else)\s+|\w+=\S*\s+|env\s+|time\s+|nohup\s+|timeout\s+\S+\s+|npx\s+(?:-\S+\s+)*|bunx\s+|bun\s+x\s+|pnpm\s+(?:exec|dlx)\s+|(?:yarn|pnpm|bun)\s+(?=(?:jest|vitest|mocha|ava|playwright|cypress|nx|turbo|lerna)\b)|uv\s+run\s+|poetry\s+run\s+|pipenv\s+run\s+|hatch\s+run\s+|bundle\s+exec\s+|php\s+(?=\S*(?:phpunit|pest)\b)|node_modules\/\.bin\/|(?:vendor\/)?bin\/|\.\/)+/;
+
+const NONE = /$^/;
+// A word that names everything there is: the test folder, every package, a glob, a count.
+const ALL_OF_IT = /^(?:\.\/)?(?:tests?|specs?|__tests__|e2e|src)\/?$|^(?:\.\/)?\.\.\.$|\*|^\d+[smh]?$|^auto$/;
+// Does this command pick part of the tests? `narrow` flags pick tests (by name before
+// `=`), `value` flags take the next word, `whole` words still run everything; any
+// other word names a part, unless the tool takes none (`words: false`).
+function narrows(args, { narrow = NONE, value = NONE, whole = NONE, words = true }) {
+  for (let i = 0; i < args.length; i++) {
+    const a = args[i];
+    // A variable: a function's arguments, a loop's file. The caller chose them, so this is not the whole command.
+    if (a.startsWith('$')) return true;
+    if (a === '--') continue;
+    if (a.startsWith('-')) {
+      const name = a.split('=')[0];
+      if (narrow.test(name)) return true;
+      if (!a.includes('=') && value.test(name)) i++;
+      continue;
+    }
+    if (words && !whole.test(a) && !ALL_OF_IT.test(a)) return true;
+  }
+  return false;
+}
+
+const JS = {
+  narrow: /^(?:-t|--testNamePattern|--test-name-pattern|-g|--grep|--fgrep|--testPathPattern|--testPathPatterns|--filter|--spec|--project|--selectProjects|--findRelatedTests|--onlyChanged|-o|--changed|--changedSince|--lastCommit|--only|--test-only|--match|-m)$/,
+  value: /^(?:-w|--maxWorkers|--workers|-j|--jobs|--timeout|--reporter|-r|--require|--import|--loader|--config|-c|--rootDir|--root|--outputFile|--coverageDirectory|--test-concurrency|--test-reporter|--test-reporter-destination|--retries|--repeat-each|--env|--browser|--shard|--seed|--slow|--file|--mode|--environment|--pool|--dir)$/,
+  whole: /^(?:run|watch|dev|test)$/,
+};
+const PYTEST = { narrow: /^(?:-k|-m|--lf|--last-failed|--sw|--stepwise|--deselect|--pyargs)$/, value: /^(?:-n|--numprocesses|-c|-p|--maxfail|--rootdir|--durations|-o|--junitxml|--cov|--timeout|--dist|-W|--basetemp|--log-level|--confcutdir|--ignore|--ignore-glob|--tb|-r|--reruns)$/ };
+const tool = (start, spec, test = () => true) => ({ start, scope: args => test(args) ? (narrows(args, spec) ? 'partial' : 'suite') : null });
+
+// npm/pnpm/yarn/bun: the workspace or filter before the script, the script, then its own arguments (Jest, Vitest, …).
+function packageScript(args) {
+  let picked = false;
+  for (let i = 0; i < args.length; i++) {
+    const a = args[i];
+    if (/^(?:-w|--workspace|--filter|-F)$/.test(a)) { picked = true; i++; continue; }
+    if (/^(?:--workspace|--filter)=/.test(a)) { picked = true; continue; }
+    if (a.startsWith('-')) continue;
+    if (a === 'workspace') { picked = true; i++; continue; }
+    // `npm t` is `npm test`; `npm run t` is a script of that name.
+    const run = /^(?:run|run-script)$/.test(a), script = run ? args[++i] : a;
+    if (!(run ? /^test(?::\S+)?$/ : /^(?:test|t|tst)(?::\S+)?$/).test(script ?? '')) return null;
+    // Before `--`, `-w web` is still npm's workspace; a number is Jest's worker count.
+    const rest = args.slice(i + 1), end = rest.includes('--') ? rest.indexOf('--') : rest.length;
+    picked ||= rest.slice(0, end).some((a, j) => /^--workspace=/.test(a) || (/^(?:-w|--workspace)$/.test(a) && !/^\d+$/.test(rest[j + 1] ?? '0')));
+    return picked || narrows(rest, JS) ? 'partial' : 'suite';
+  }
+  return null;
+}
+// Maven: every word is a goal; it tests when a goal reaches `test`. The flags pick classes, groups or modules.
+function maven(args) {
+  if (!args.some(a => /^(?:[\w.-]+:)*(?:test|verify|integration-test)$/.test(a))) return null;
+  if (args.some(a => /^-D(?:skipTests|maven\.test\.skip)(?:=true)?$/.test(a))) return null;
+  const file = args.findIndex(a => a === '-f' || a === '--file');
+  if (file >= 0 && args[file + 1]?.includes('/')) return 'partial';
+  return narrows(args, { narrow: /^(?:-Dtest|-Dit\.test|-Dgroups|-Dcucumber\.filter\.tags|-Dcucumber\.options|-pl|--projects|-rf|--resume-from)$/, value: /^(?:-T|--threads|-s|--settings|-gs|--global-settings|-P|--activate-profiles|-l|--log-file|-t|--toolchains|-b|--builder|-f|--file)$/, words: false }) ? 'partial' : 'suite';
+}
+// Gradle: the words are tasks; `:cart:test` is one module's.
+function gradle(args) {
+  const value = /^(?:-x|--exclude-task|--max-workers|-I|--init-script|-c|--settings-file|--console|-g|--gradle-user-home)$/;
+  const tasks = args.filter((a, i) => !a.startsWith('-') && !value.test(args[i - 1] ?? ''));
+  const testTasks = tasks.filter(t => /^(?:test|check|[a-zA-Z]*Test)$/.test(t.split(':').pop()));
+  if (!testTasks.length) return null;
+  if (testTasks.some(t => /^:?[\w-]+(?::[\w-]+)*:\w+$/.test(t) && t.replace(/^:/, '').includes(':'))) return 'partial';
+  return narrows(args, { narrow: /^(?:--tests|-p|--project-dir|-b|--build-file)$/, value, words: false }) ? 'partial' : 'suite';
+}
+// Go: the words are packages; none is the current one, `./...` is all of them.
+function goTest(args) {
+  const end = args.indexOf('-args');
+  const own = end >= 0 ? args.slice(0, end) : args;
+  const spec = { narrow: /^-{1,2}run$/, value: /^-{1,2}(?:p|count|timeout|parallel|cpu|tags|exec|covermode|coverpkg|coverprofile|o|bench|benchtime|shuffle|vet|C|fuzz|fuzztime|skip|json)$/ };
+  const packages = own.filter((a, i) => !a.startsWith('-') && !(spec.value.test(own[i - 1] ?? '') && !own[i - 1].includes('=')));
+  return !packages.length || narrows(own, spec) ? 'partial' : 'suite';
+}
+// make: a test target; a variable naming tests narrows it (`make test TEST=./cart`).
+function make(args) {
+  if (!args.some(a => /^(?:test|check)(?:[-_:]\w+)*$/.test(a))) return null;
+  return args.some(a => /^\w*(?:TEST|RUN|FILTER|PKG|SPEC|ONLY|PATTERN|FILE)\w*=/i.test(a) || a.startsWith('$')) ? 'partial' : 'suite';
+}
+// Nx, Turborepo, Lerna run a target across projects; naming projects or `affected` narrows.
+function monorepo(name, args) {
+  const words = args.filter(a => !a.startsWith('-'));
+  const target = args.find((a, i) => /^(?:-t|--targets?)$/.test(args[i - 1] ?? '')) ?? args.find(a => /^--targets?=/.test(a))?.split('=')[1];
+  if (name === 'nx') {
+    const [command, project] = words;
+    if (command === 'run-many') return /test|e2e/.test(target ?? '') ? (args.some(a => /^(?:-p|--projects)(?:=|$)/.test(a)) ? 'partial' : 'suite') : null;
+    if (command === 'affected') return /test|e2e/.test(target ?? words[1] ?? '') ? 'partial' : null;
+    if (command === 'run') return /:(?:\w*test|e2e)\w*$/.test(project ?? '') ? 'partial' : null;
+    return /test|e2e/.test(command ?? '') ? (project ? 'partial' : 'suite') : null;
+  }
+  const tasks = words[0] === 'run' ? words.slice(1) : words;
+  if (!tasks.some(t => /test|e2e/.test(t))) return null;
+  return args.some(a => /^(?:--filter|-F|--scope|--since|--affected)(?:=|$)/.test(a)) ? 'partial' : 'suite';
+}
+
+const TOOLS = [
+  { start: /^(?:npm|pnpm|yarn|bun)(?=\s|$)/, scope: packageScript },
+  tool(/^(?:jest|vitest|mocha|ava|tap|uvu)(?=\s|$)/, JS),
+  tool(/^node(?=\s)/, JS, args => args.includes('--test')),
+  tool(/^playwright\s+test(?=\s|$)/, JS),
+  tool(/^cypress\s+run(?=\s|$)/, JS),
+  tool(/^(?:pytest|py\.test|python[\d.]*\s+-m\s+pytest)(?=\s|$)/, PYTEST),
+  tool(/^python[\d.]*\s+-m\s+unittest(?=\s|$)/, { narrow: /^(?:-k|-p|--pattern)$/, value: /^(?:-s|--start-directory|-t|--top-level-directory)$/, whole: /^discover$/ }),
+  tool(/^python[\d.]*\s+manage\.py\s+test(?=\s|$)/, { narrow: /^(?:-k|--tag)$/, value: /^(?:--parallel|--settings|-v|--verbosity|--exclude-tag|--testrunner)$/ }),
+  tool(/^tox(?=\s|$)/, { value: /^(?:-e|-c|--conf|-p|--parallel|-x|--override)$/ }),
+  { start: /^go\s+test(?=\s|$)/, scope: goTest },
+  tool(/^cargo\s+test(?=\s|$)/, { narrow: /^(?:-p|--package|--test|--lib|--bin|--bins|--example|--examples|--doc|--bench|--manifest-path|--ignored|--exact)$/, value: /^(?:-j|--jobs|--features|-F|--target|--profile|--test-threads|--color|-Z|--target-dir|--message-format|--config|--exclude)$/ }),
+  tool(/^cargo\s+nextest\s+run(?=\s|$)/, { narrow: /^(?:-E|--filterset|--filter-expr|-p|--package|--test|--lib|--bin)$/, value: /^(?:-j|--jobs|--profile|--test-threads|--retries|--partition|--features|-F)$/ }),
+  { start: /^mvnw?(?=\s|$)/, scope: maven },
+  { start: /^gradlew?(?=\s|$)/, scope: gradle },
+  tool(/^dotnet\s+test(?=\s|$)/, { narrow: /^--filter$/, value: /^(?:-c|--configuration|-f|--framework|-r|--runtime|-l|--logger|-s|--settings|-v|--verbosity|--results-directory|-a|--test-adapter-path|--collect|-d|--diag|-o|--output|--arch|--os|--blame-hang-timeout|--blame-crash-dump-type|-e|--environment)$/, whole: /\.slnx?$/ }),
+  tool(/^swift\s+test(?=\s|$)/, { narrow: /^(?:--filter|--package-path)$/, value: /^(?:-c|--configuration|-j|--jobs|--num-workers|--scratch-path|--skip)$/ }),
+  tool(/^xcodebuild(?=\s)/, { narrow: /^-only-testing(?::|$)/, value: /^-(?:scheme|destination|project|workspace|sdk|configuration|derivedDataPath|resultBundlePath|testPlan|skip-testing|parallel-testing-worker-count|xctestrun|target|arch|toolchain|destination-timeout|maximum-parallel-testing-workers|test-iterations|testLanguage|testRegion|only-test-configuration|skip-test-configuration)$/, words: false }, args => args.some(a => /^test(?:-without-building)?$/.test(a))),
+  tool(/^rspec(?=\s|$)/, { narrow: /^(?:-t|--tag|-e|--example|-E|--example-matches|--only-failures|--next-failure|-P|--pattern)$/, value: /^(?:-f|--format|-o|--out|--seed|--order|-r|--require|-I|--default-path|-O|--options)$/ }),
+  tool(/^(?:rails|rake)\s+test(?::\w+)?(?=\s|$)/, { narrow: /^(?:-n|--name)$/, value: /^(?:--seed|-s|-e|--environment|-j)$/ }),
+  tool(/^(?:phpunit|pest|php\s+artisan\s+test)(?=\s|$)/, { narrow: /^(?:--filter|--group|--testsuite)$/, value: /^(?:-c|--configuration|--bootstrap|--log-junit|--exclude-group|--coverage-html|--coverage-clover|--order-by|--cache-directory|--processes|-d)$/ }),
+  tool(/^mix\s+test(?=\s|$)/, { narrow: /^(?:--only|--failed|--stale)$/, value: /^(?:--seed|--max-failures|--exclude|--include|--formatter|--partitions|--max-cases)$/ }),
+  tool(/^(?:flutter|dart)\s+test(?=\s|$)/, { narrow: /^(?:--name|-n|--plain-name|-N|--tags|-t)$/, value: /^(?:-j|--concurrency|-r|--reporter|-p|--platform|-x|--exclude-tags|--file-reporter|--coverage-path|--flavor|--total-shards|--shard-index)$/ }),
+  tool(/^deno\s+test(?=\s|$)/, { narrow: /^--filter$/, value: /^(?:-c|--config|--import-map|--reporter|--seed)$/ }),
+  { start: /^make(?=\s)/, scope: make },
+  { start: /^(?:nx|turbo|lerna)(?=\s)/, scope: (args, name) => monorepo(name, args) },
+];
+function testRun(part) {
+  const own = part.replace(LAUNCHER, '');
+  for (const { start, scope } of TOOLS) {
+    const hit = own.match(start);
+    if (!hit) continue;
+    const result = scope(own.slice(hit[0].length).split(' ').filter(Boolean), hit[0]);
+    return result ? { own, result } : null;
+  }
+  return null;
+}
+
+export function checkScope(command, declared = []) {
+  const text = String(command ?? '').replace(/\s+/g, ' ').trim();
+  if (!text || NOT_A_RUN.test(text) || VERSION_ONLY.test(text) || LIST_ONLY.test(text)) return null;
+  const bare = unquoted(text), runs = partsOf(bare).map(testRun).filter(Boolean);
+  // A command the repository declares is its whole check, however it is written;
+  // a line that also runs a whole suite is a whole run.
+  if (runs.length) return declared.includes(text) || runs.some(run => run.result === 'suite') ? 'suite' : 'partial';
+  // A script the repository declares: it cannot be narrowed from here.
+  const named = declared.find(d => partsOf(bare).some(part => part.startsWith(unquoted(d))));
+  return named && !NOT_TESTS.test(named) ? 'suite' : null;
+}
+// The test step of a command, without what surrounds it: the same step costs the same.
+export function suitePart(command) {
+  const runs = partsOf(unquoted(String(command ?? '').replace(/\s+/g, ' ').trim())).map(testRun).filter(Boolean);
+  return (runs.find(run => run.result === 'suite') ?? runs[0])?.own ?? String(command ?? '').trim();
+}

package/packages/piagent-core/managed/tool-boundary.mjs

@@ -4,9 +4,7 @@ import { BoundaryTerminals } from './terminal-boundary.mjs';
 import { ToolFreshness } from './tool-freshness.mjs';
 import { BoundaryQueue } from './boundary-queue.mjs';
 import { workspaceWorkerPins, verifyWorkspaceWorker } from './workspace-worker-pins.mjs'; import { snapshotRuntime } from './runtime-snapshot.mjs';
-import fs from 'node:fs';
-import os from 'node:os';
-import path from 'node:path';
+import fs from 'node:fs'; import os from 'node:os'; import path from 'node:path';
 import { execFileSync, spawn } from 'node:child_process';
 import net from 'node:net';
 import { StringDecoder } from 'node:string_decoder';
@@ -208,7 +206,7 @@ export class ManagedToolBoundary {
   // readOnly: the project cannot be written. commands: bash is offered all
   // the same (a helper that runs checks); it writes only to its temporary
   // directory, and has no network.
-  constructor({ cwd, sdkRoot, protectedRoots = [], readOnly = false, commands = false, node = process.execPath, identity, userHome: home, searchTools = true, skills: skillFolders = [], proxyPorts }) {
+  constructor({ cwd, sdkRoot, protectedRoots = [], readOnly = false, commands = false, node = process.execPath, identity, userHome: home, searchTools = true, skills: skillFolders = [], readRoots = [], proxyPorts }) {
     // macOS: Seatbelt. Linux, and Windows through WSL2: bubblewrap (linux-sandbox.mjs).
     this.linux = process.platform === 'linux';
     if (process.platform !== 'darwin' && !(this.linux && BWRAP)) throw new Error('managed-sandbox-unavailable');
@@ -249,6 +247,8 @@ export class ManagedToolBoundary {
     const skills = [...new Set(skillFolders.flatMap(dir => { try { return [fs.realpathSync(dir)]; } catch { return []; } }))]
       .filter(dir => dir !== '/' && !/[\x00-\x1f\x7f]/.test(dir) && !narrowed.some(root => inside(root, dir)) && !inside(userHome, dir)
         && (!inside(dir, userHome) || agentFolders.some(root => inside(dir, root)) || !path.relative(userHome, dir).startsWith('.')));
+    // readRoots: folders the runtime opens for reading only (the general helper's borrowed git objects).
+    skills.push(...readRoots.map(dir => fs.realpathSync(dir)).filter(dir => dir !== '/' && !narrowed.some(root => inside(root, dir))));
     this.userHome = userHome;
     // Only for commands the user approved (run_with_network); credentials stay
     // denied, and so do reference folders: what a command with network can

package/packages/piagent-core/managed/workflow.mjs

@@ -119,22 +119,6 @@ export function reviewFindings(text) {
   }
   return null;
 }
-// The verify helper re-checks a result on its own: claims against the code and
-// primary sources, the repository's checks on the current code.
-export const VERIFY_PROMPT = `You verify a result for the company coding assistant, independently of whoever produced it. For each claim or requirement in the brief: read the code it is about, run the repository checks that cover it with bash, and confirm external facts against primary sources (official documentation, the project's own repository) with web_search and web_fetch. Commands run offline and the project is read-only for them: a check that must write into the project or reach the network fails for that reason. Report such a claim as unverifiable and say why; do not work around the sandbox. Never mark a claim pass without evidence you saw. ${BRIEF_CHECK} End your answer with one JSON object in a \`\`\`json block: {"verdicts":[{"claim":"what was checked","status":"pass|fail|unverifiable","evidence":"file:line, the command and its result, or the source URL"}],${BRIEF_ISSUES_JSON},"summary":"one sentence"}. Use an empty brief_issues list when the brief is sound. You cannot change files or delegate.`;
-// The verifier's verdicts from its answer; null when it gave no valid JSON.
-export function verifyVerdicts(text) {
-  const blocks = [...String(text).matchAll(/```json\s*([\s\S]*?)```/g)].map(m => m[1]);
-  for (const raw of blocks.reverse()) {
-    try {
-      const value = JSON.parse(raw);
-      if (!Array.isArray(value?.verdicts)) continue;
-      return value.verdicts.filter(v => ['pass', 'fail', 'unverifiable'].includes(v?.status) && typeof v.claim === 'string' && v.claim.trim()).slice(0, 40)
-        .map(v => ({ status: v.status, claim: clip(v.claim, 500), evidence: clip(v.evidence, 500) }));
-    } catch { /* not this block */ }
-  }
-  return null;
-}
 const where = f => f.file ? ` ${f.file}${f.line ? ':' + f.line : ''}` : '';
 export const findingText = f => `[${f.severity}]${where(f)} — ${f.issue}${f.evidence ? `\n   Evidence: ${f.evidence}` : ''}`;
 
@@ -170,10 +154,10 @@ export class RunProcess {
       reviews: 0, blocking: 0, blockingOpen: 0, fixLoops: 0, planUpdated: false, planRefusals: new Set(), planSkipped: false, unplannedChange: false,
       unknownTools: 0, changed: false, verified: false, docsOnly: false, approvalDeclined: false, reviewed: false, reviewUnavailable: false, outcome: null, legacyOutcome: null,
       // The objection ledger (ledger.mjs), disagreements handed to the
-      // member, the claims verify marked failed, the reviews the main agent
+      // member, the reviews the main agent
       // asked for, and where the harness last sent the agent back (to read
       // its answer and see whether the code moved).
-      ledger: [], disputes: [], verifyFails: [], claimsAsked: false, claimsAt: null, claimsRechecked: false, claimsDone: false, mainReviews: 0, minorFindings: 0,
+      ledger: [], disputes: [], mainReviews: 0, minorFindings: 0,
       sentAt: null, sentDigest: null, rejudged: false, reviewSettled: false,
       // How much of the suite the member wants run (check-questions.mjs).
       scopeChoice: null, scopeWords: null, fullAsked: asksFullChecks(request), pushAllowedOn: undefined,
@@ -356,27 +340,6 @@ export async function completionGate(managed, run, signal) {
         }
       }
     }
-    // Claims the verify subagent marked failed, under a required verify: back
-    // to the agent once, then checked again with its answer; still failing,
-    // the member decides.
-    if (policy.verify === 'require' && run.verifyFails.length && !run.claimsDone) {
-      const fails = run.verifyFails, list = fails.map((v, i) => `${i + 1}. ${v.claim}${v.evidence ? `\n   Evidence: ${v.evidence}` : ''}`).join('\n'), claims = fails.slice(0, 10).map(v => ({ claim: v.claim }));
-      if (!run.claimsAsked) {
-        run.claimsAsked = true; run.claimsAt = session.messages.length;
-        await send(`Harness: the verify subagent marked ${fails.length} claim(s) as failed:\n${list}\nFix the cause, or reject a verdict with resolve_objection (what you checked and why). The verify subagent then checks these claims again with your answer.`, { phase: 'claims', claims });
-        continue;
-      }
-      if (!run.claimsRechecked) {
-        run.claimsRechecked = true;
-        await note("Harness: the verify subagent checks the failed claims again with the main agent's answer.", { phase: 'rejudge', role: 'verify' });
-        try { await managed.delegate({ role: 'verify', task: `Check these claims again on the current code; they were marked failed before:\n${list}\n\nThe main agent's answer:\n${answerSince(run.claimsAt) || '(no answer)'}${decisionsText(run, 'verify')}\n\nA claim passes only on evidence you see yourself. It stays failed when it does not hold and the result the member asked for depends on it. When the answer shows the claim is not part of what the member asked and the result does not depend on it, mark it unverifiable and say why.` }, signal, { harness: true }); }
-        catch { if (stopped()) { interrupted = run.changed; break; } }
-        continue;
-      }
-      run.claimsDone = true; run.disputes.push({ source: 'verify' });
-      for (const item of ledgerOf(run)) if (item.source === 'verify' && ['open', 'accepted', 'rejected'].includes(item.status)) setStatus(item, 'disputed');
-      await note(`Harness: the main agent and the verify subagent still disagree after two rounds; the member decides.\n${list}`, { phase: 'dispute', role: 'verify', claims });
-    }
     // Plan "require": a checklist left with open steps is the next round's
     // (continuation.mjs), after this run's checks and review.
     // A rejected premise objection goes back to its helper; then what the

package/packages/piagent-core/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@piagent/core",
-  "version": "1.51.1",
+  "version": "1.52.0",
   "type": "module",
   "private": true,
   "license": "MIT",

package/packages/piagent-core/runtime/managed-failure.d.mts

@@ -1,4 +1,4 @@
-export type ManagedFailure = { role: "main" | "scout" | "research" | "verify" | "review"; code: string; kind: string; requestId: string | null; local: boolean };
+export type ManagedFailure = { role: "main" | "scout" | "research" | "advisor" | "general" | "review"; code: string; kind: string; requestId: string | null; local: boolean };
 export function failureKind(code: string): string;
 export function failureIsLocal(code: string): boolean;
 export function failureCode(raw: unknown): string;

package/packages/piagent-core/runtime/managed-failure.mjs

@@ -113,7 +113,7 @@ const CODES = {
   // Studio is stopped or restarting behind it, or the way to it failed.
   'studio-gateway-unavailable': ['unreachable', "Studio's gateway answered that Studio is not reachable"],
 };
-const ROLES = { main: 'main agent', scout: 'scout subagent', research: 'research subagent', verify: 'verify subagent', review: 'review subagent' };
+const ROLES = { main: 'main agent', scout: 'scout subagent', research: 'research subagent', advisor: 'advisor subagent', general: 'general subagent', review: 'review subagent' };
 const REQUEST = /\b([0-9a-f]{8}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{4}-[0-9a-f]{12})\b/;
 const PROVIDER_SERVER_ERROR = /^(?:Error Code )?(?:server_error|api_error|internal_error|internal_server_error|overloaded_error|undefined):|An error occurred while processing your request|"type"\s*:\s*"(?:api_error|overloaded_error)"|\bOverloaded\b/i;
 const NETWORK = /fetch failed|econnrefused|econnreset|enotfound|ehostunreach|etimedout|socket hang up|network|connection error|terminated|timed? ?out|aborted due to timeout/i;
@@ -203,8 +203,8 @@ export function parseFailure(raw) {
   const text = String(raw ?? '');
   if (!text.trim()) return null;
   const code = failureCode(text);
-  const role = /^Agent Watch (main agent|(?:scout|research|verify|review) subagent): /.exec(text)?.[1]?.split(' ')[0]
-    ?? /(scout|research|verify|review) subagent/.exec(text)?.[1] ?? 'main';
+  const role = /^Agent Watch (main agent|(?:scout|research|advisor|general|review) subagent): /.exec(text)?.[1]?.split(' ')[0]
+    ?? /(scout|research|advisor|general|review) subagent/.exec(text)?.[1] ?? 'main';
   const request = failureIsLocal(code) ? null : REQUEST.exec(text)?.[1] ?? null;
   return { role, code, kind: failureKind(code), requestId: request, local: failureIsLocal(code) };
 }