@piagent/platform 1.2.0 → 1.2.1

package/scripts/quality-benchmark.sh

@@ -31,6 +31,14 @@ if [[ -z "$PROJECT_PATH" ]]; then
   usage
   exit 2
 fi
+# The project path is positional and comes first, so omitting it hands the first
+# flag to `cd` and the run dies somewhere further down complaining about an
+# option. Say what is actually wrong instead.
+if [[ "$PROJECT_PATH" == -* ]]; then
+  echo "FAIL: the project path comes first, before any flag; received: $PROJECT_PATH" >&2
+  usage >&2
+  exit 2
+fi
 shift || true
 
 PROJECT_PATH="$(cd "$PROJECT_PATH" && pwd)"
@@ -45,6 +53,17 @@ COST=""
 DURATION=""
 NOTES=""
 
+# A flag left without a value otherwise consumes the next flag as its value, and
+# the run continues on a record that says something nobody typed.
+require_value() {
+  local option="$1"
+  local value="${2:-}"
+  if [[ -z "$value" || "$value" == --* ]]; then
+    echo "Missing value for $option" >&2
+    exit 2
+  fi
+}
+
 while [[ $# -gt 0 ]]; do
   case "$1" in
     --init)
@@ -56,39 +75,48 @@ while [[ $# -gt 0 ]]; do
       shift
       ;;
     --scenario)
-      SCENARIO="${2:-}"
+      require_value "$1" "${2:-}"
+      SCENARIO="$2"
       shift 2
       ;;
     --surface|--agent)
-      SURFACE="${2:-}"
+      require_value "$1" "${2:-}"
+      SURFACE="$2"
       shift 2
       ;;
     --result)
-      RESULT="${2:-}"
+      require_value "$1" "${2:-}"
+      RESULT="$2"
       shift 2
       ;;
     --task-file)
-      TASK_FILE="${2:-}"
+      require_value "$1" "${2:-}"
+      TASK_FILE="$2"
       shift 2
       ;;
     --verify)
-      VERIFY_CMD="${2:-}"
+      require_value "$1" "${2:-}"
+      VERIFY_CMD="$2"
       shift 2
       ;;
     --tokens)
-      TOKENS="${2:-}"
+      require_value "$1" "${2:-}"
+      TOKENS="$2"
       shift 2
       ;;
     --cost)
-      COST="${2:-}"
+      require_value "$1" "${2:-}"
+      COST="$2"
       shift 2
       ;;
     --duration)
-      DURATION="${2:-}"
+      require_value "$1" "${2:-}"
+      DURATION="$2"
       shift 2
       ;;
     --notes)
-      NOTES="${2:-}"
+      require_value "$1" "${2:-}"
+      NOTES="$2"
       shift 2
       ;;
     -h|--help)

package/scripts/setup.sh

@@ -85,21 +85,24 @@ SKIP_AGENTS=false
 SKIP_REVIEW=false
 DRY_RUN=false
 
+require_value() {
+  local option="$1"
+  local value="${2:-}"
+  if [[ -z "$value" || "$value" == --* ]]; then
+    echo "Missing value for $option" >&2
+    exit 2
+  fi
+}
+
 while [[ $# -gt 0 ]]; do
   case "$1" in
     --profile)
-      if [[ $# -lt 2 ]]; then
-        echo "Missing value for --profile" >&2
-        exit 2
-      fi
+      require_value "$1" "${2:-}"
       PROFILE_INPUT="$2"
       shift 2
       ;;
     --package-source)
-      if [[ $# -lt 2 ]]; then
-        echo "Missing value for --package-source" >&2
-        exit 2
-      fi
+      require_value "$1" "${2:-}"
       PACKAGE_SOURCE="$2"
       shift 2
       ;;
@@ -124,7 +127,8 @@ while [[ $# -gt 0 ]]; do
       shift
       ;;
     --mcp-preset)
-      MCP_PRESET="${2:-}"
+      require_value "$1" "${2:-}"
+      MCP_PRESET="$2"
       MCP_PRESET_EXPLICIT=true
       shift 2
       ;;
@@ -137,11 +141,13 @@ while [[ $# -gt 0 ]]; do
       shift
       ;;
     --subagents-preset)
-      SUBAGENTS_PRESET="${2:-}"
+      require_value "$1" "${2:-}"
+      SUBAGENTS_PRESET="$2"
       shift 2
       ;;
     --subagents-model-scope)
-      SUBAGENTS_MODEL_SCOPE="${2:-}"
+      require_value "$1" "${2:-}"
+      SUBAGENTS_MODEL_SCOPE="$2"
       shift 2
       ;;
     --with-web-access)
@@ -157,11 +163,13 @@ while [[ $# -gt 0 ]]; do
       shift
       ;;
     --model-scope)
-      MODEL_SCOPE_PRESET="${2:-}"
+      require_value "$1" "${2:-}"
+      MODEL_SCOPE_PRESET="$2"
       shift 2
       ;;
     --default-model)
-      DEFAULT_MODEL="${2:-}"
+      require_value "$1" "${2:-}"
+      DEFAULT_MODEL="$2"
       shift 2
       ;;
     --no-model-scope)

package/scripts/uninstall-global.sh

@@ -39,16 +39,22 @@ todos, and project memory. Those are operator data, not platform state.
 USAGE
 }
 
+require_value() {
+  local option="$1"
+  local value="${2:-}"
+  if [[ -z "$value" || "$value" == --* ]]; then
+    echo "Missing value for $option" >&2
+    exit 2
+  fi
+}
+
 while [[ $# -gt 0 ]]; do
   case "$1" in
     --apply) APPLY=true; shift ;;
     --with-addons) WITH_ADDONS=true; shift ;;
     --with-host) WITH_HOST=true; shift ;;
     --project)
-      if [[ $# -lt 2 || -z "${2:-}" ]]; then
-        echo "Missing value for --project" >&2
-        exit 2
-      fi
+      require_value "$1" "${2:-}"
       PROJECT_PATH="$2"
       shift 2
       ;;

package/scripts/verify-local.sh

@@ -164,6 +164,7 @@ required_files=(
   "$ROOT/scripts/quality-benchmark.sh"
   "$ROOT/scripts/runtime-policy-smoke.sh"
   "$ROOT/scripts/pi-session-stats.sh"
+  "$ROOT/scripts/pi-usage-history.mjs"
   "$ROOT/scripts/pi-auto.sh"
   "$ROOT/scripts/pi-model-catalog.sh"
   "$ROOT/scripts/configure-model-scope.sh"
@@ -469,6 +470,23 @@ require_documented "piagent-capabilities" "$ROOT/README.md" "$ROOT/docs/capabili
 require_documented ".pi-subagents/" "$ROOT/.gitignore" "$ROOT/docs/subagents-and-multiagent.md" "$ROOT/docs/distribution-standard.md" "$ROOT/scripts/init-project.sh"
 test -s "$ROOT/tests/policy-core.test.mjs"
 
+# Every gate below this line is a grep, and grep skips a file it decides is
+# binary. One control byte written into a string literal — a NUL used as a key
+# separator is the easy way to do it by accident — takes the whole file out of
+# every one of them, and out of the diff a reviewer reads on a pull request. The
+# file still runs, so nothing else notices. Escapes carry the same bytes and keep
+# the file readable.
+non_text_sources="$(
+  cd "$ROOT" && git ls-files -z -- '*.js' '*.mjs' '*.ts' '*.json' '*.md' '*.sh' '*.html' '*.css' \
+    | LC_ALL=C xargs -0 -I{} sh -c 'grep -qI "" "{}" 2>/dev/null || echo "{}"'
+)"
+if [[ -n "$non_text_sources" ]]; then
+  echo "Source files contain control bytes, so grep-based gates and diffs skip them:"
+  echo "$non_text_sources" | sed 's/^/  /'
+  echo "Write the byte as an escape (\\u0000, \\x03) instead of embedding it."
+  exit 1
+fi
+
 public_wording_pattern="$(
   node --input-type=module <<'NODE'
 const terms = [
@@ -527,6 +545,7 @@ node --check "$ROOT/packages/piagent-core/capabilities/capability-core.js" >/dev
 node --check "$ROOT/packages/piagent-core/capabilities/capability-sources.js" >/dev/null
 node --check "$ROOT/scripts/capability-catalog.mjs" >/dev/null
 node --check "$ROOT/scripts/piagent-cli.mjs" >/dev/null
+node --check "$ROOT/scripts/pi-usage-history.mjs" >/dev/null
 node --check "$ROOT/scripts/migrate-project-state.mjs" >/dev/null
 node --check "$ROOT/scripts/import-agent-instructions.mjs" >/dev/null
 node --check "$ROOT/scripts/check-runtime-advisories.mjs" >/dev/null

package/scripts/verify-release-identity.mjs

@@ -80,6 +80,35 @@ for (const page of docsPages) {
   if (!html.includes(`${expectedTag} docs`)) fail(`docs-site/${page} version badge does not identify ${expectedTag}`);
 }
 
+// A version written into an install command does not come from the build, so it
+// goes stale silently and keeps telling readers to install the previous release.
+// The badge check above cannot see these: they are sentences, not generated
+// markup.
+//
+// Only the command shapes are matched, not every version-looking string. Prose
+// naming an old release is usually saying something true about history — when a
+// behaviour arrived, which release a mistake shipped in — and rewriting those to
+// the current number would make them false. Files that exist to list past
+// versions are exempt outright.
+const VERSION_HISTORY_FILES = new Set(["CHANGELOG.md", "docs/publishing-for-teams.md"]);
+const RELEASE_TAG_MENTION = /(?:@piagent\/platform@|Vt-mmm\/piagent@v?|--version )(\d+\.\d+\.\d+)/g;
+
+function proseFiles() {
+  const files = fs.readdirSync(path.join(root, "docs")).filter((name) => name.endsWith(".md")).map((name) => `docs/${name}`);
+  files.push("README.md");
+  for (const name of fs.readdirSync(path.join(root, "docs-site", "content"))) {
+    if (name.endsWith(".html")) files.push(`docs-site/content/${name}`);
+  }
+  return files.filter((file) => !VERSION_HISTORY_FILES.has(file));
+}
+
+for (const file of proseFiles()) {
+  const text = fs.readFileSync(path.join(root, file), "utf8");
+  for (const [mention, named] of text.matchAll(RELEASE_TAG_MENTION)) {
+    if (named !== version) fail(`${file} tells the reader to install ${named} (${mention.trim()}), but this release is ${version}`);
+  }
+}
+
 if (options.tag) {
   if (options.tag !== expectedTag) fail(`release tag ${options.tag} does not match package version ${expectedTag}`);
   if (!/^[0-9a-fA-F]{40}$/.test(options.commit)) fail("--commit must be a 40-character commit SHA");