@pi-unipi/updater 2.0.4 → 2.0.6

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-unipi/updater",
-  "version": "2.0.4",
+  "version": "2.0.6",
   "description": "Auto-updater, changelog browser, and readme browser for Unipi — checks npm registry, renders CHANGELOG.md and README.md files in TUI overlays",
   "type": "module",
   "license": "MIT",

package/src/checker.ts

@@ -8,6 +8,7 @@
 import { getInstalledPackageVersion } from "@pi-unipi/core";
 import { loadConfig } from "./settings.js";
 import { readLastCheck, writeLastCheck, isCheckDue } from "./cache.js";
+import { compareVersions, isNewerVersion } from "./version.js";
 import type { UpdateCheckResult } from "../types.js";
 
 /** NPM registry URL for the unipi umbrella package */
@@ -20,6 +21,16 @@ function getInstalledVersion(): string {
   return getInstalledPackageVersion(dir, "@pi-unipi/unipi");
 }
 
+
+/** Build an update result without ever reporting downgrades as updates. */
+function toUpdateResult(latestVersion: string, currentVersion: string): UpdateCheckResult {
+  return {
+    updateAvailable: isNewerVersion(latestVersion, currentVersion),
+    latestVersion,
+    currentVersion,
+  };
+}
+
 /**
  * Check for updates from npm registry.
  * Respects check interval — skips if last check was recent.
@@ -31,15 +42,14 @@ export async function checkForUpdates(): Promise<UpdateCheckResult> {
   try {
     const config = loadConfig();
 
-    // Check if we need to fetch (interval not elapsed)
-    if (!isCheckDue(config.checkIntervalMs)) {
-      const cache = readLastCheck();
-      if (cache) {
-        return {
-          updateAvailable: cache.latestVersion !== currentVersion,
-          latestVersion: cache.latestVersion,
-          currentVersion,
-        };
+    // Check if we need to fetch (interval not elapsed). If the cached npm
+    // version is older than the installed version, ignore the interval and
+    // refresh: this happens immediately after a local/source release before
+    // the updater cache has seen the new npm dist-tag.
+    const cache = readLastCheck();
+    if (cache && !isCheckDue(config.checkIntervalMs)) {
+      if (compareVersions(cache.latestVersion, currentVersion) >= 0) {
+        return toUpdateResult(cache.latestVersion, currentVersion);
       }
     }
 
@@ -66,16 +76,13 @@ export async function checkForUpdates(): Promise<UpdateCheckResult> {
       latestVersion,
     });
 
-    return {
-      updateAvailable: latestVersion !== currentVersion,
-      latestVersion,
-      currentVersion,
-    };
+    return toUpdateResult(latestVersion, currentVersion);
   } catch (err: unknown) {
-    // Network error — return cached info if available
+    // Network error — return cached info if available, but never suggest a
+    // downgrade from a stale cache.
     const cache = readLastCheck();
     return {
-      updateAvailable: false,
+      updateAvailable: cache ? isNewerVersion(cache.latestVersion, currentVersion) : false,
       latestVersion: cache?.latestVersion ?? "",
       currentVersion,
       error: err instanceof Error ? err.message : String(err) || "Unknown error",

package/src/version.ts

@@ -0,0 +1,36 @@
+/**
+ * @pi-unipi/updater — version comparison helpers
+ */
+
+/**
+ * Compare two semver-ish version strings.
+ * Returns 1 when a > b, -1 when a < b, 0 when equal.
+ *
+ * This intentionally handles the simple versions Unipi publishes (x.y.z)
+ * without adding a runtime dependency. Non-numeric suffixes are ignored for
+ * ordering, so `2.0.5` and `v2.0.5` compare equal.
+ */
+export function compareVersions(a: string, b: string): number {
+  const parse = (version: string): number[] => version
+    .replace(/^v/, "")
+    .split(/[.-]/)
+    .slice(0, 3)
+    .map((part) => {
+      const parsed = Number.parseInt(part, 10);
+      return Number.isNaN(parsed) ? 0 : parsed;
+    });
+
+  const left = parse(a);
+  const right = parse(b);
+  for (let i = 0; i < 3; i++) {
+    const diff = (left[i] ?? 0) - (right[i] ?? 0);
+    if (diff > 0) return 1;
+    if (diff < 0) return -1;
+  }
+  return 0;
+}
+
+/** Return true only when `latest` is newer than `current`. */
+export function isNewerVersion(latest: string, current: string): boolean {
+  return compareVersions(latest, current) > 0;
+}