@pi-unipi/unipi 2.4.0 → 2.4.2

package/packages/milestone/coexist.ts

@@ -1,114 +0,0 @@
-/**
- * @pi-unipi/milestone — Coexist triggers
- *
- * Hooks into workflow skill completions to offer milestone integration.
- * Non-blocking — if MILESTONES.md doesn't exist, triggers silently skip.
- */
-
-import * as path from "node:path";
-import { MILESTONE_DIRS, tryRead } from "@pi-unipi/core";
-import { parseMilestones, updateItemStatus, writeMilestones } from "./milestone.js";
-import type { MilestoneDoc } from "./types.js";
-
-/**
- * After brainstorm completes: check if new spec items map to milestones.
- * Offers to mark matching items as planned.
- */
-export function onBrainstormComplete(specPath: string): void {
-  const cwd = process.cwd();
-  const milestonesPath = path.join(cwd, MILESTONE_DIRS.MILESTONES);
-
-  // Silently skip if no MILESTONES.md
-  if (!tryRead(milestonesPath)) return;
-
-  const specContent = tryRead(specPath);
-  if (!specContent) return;
-
-  // Extract checklist items from the new spec
-  const specItems: string[] = [];
-  for (const line of specContent.split("\n")) {
-    const match = line.match(/^-\s+\[([ xX])\]\s+(.+)$/);
-    if (match) {
-      specItems.push(match[2].trim().toLowerCase());
-    }
-  }
-
-  if (specItems.length === 0) return;
-
-  // Check against milestones
-  const doc = parseMilestones(milestonesPath);
-  const matched: string[] = [];
-
-  for (const phase of doc.phases) {
-    for (const item of phase.items) {
-      const normalized = item.text.toLowerCase().trim();
-      if (specItems.includes(normalized) && !item.checked) {
-        matched.push(`"${item.text}" in ${phase.name}`);
-      }
-    }
-  }
-
-  if (matched.length > 0) {
-    // Removed console.log — milestone matches are informational.
-    // Use /unipi:milestone-update to sync manually.
-  }
-}
-
-/**
- * After plan completes: check if plan tasks map to milestone items.
- * Logs matching items for awareness.
- */
-export function onPlanComplete(planPath: string): void {
-  const cwd = process.cwd();
-  const milestonesPath = path.join(cwd, MILESTONE_DIRS.MILESTONES);
-
-  // Silently skip if no MILESTONES.md
-  if (!tryRead(milestonesPath)) return;
-
-  const planContent = tryRead(planPath);
-  if (!planContent) return;
-
-  // Extract task names from plan (### Task N — Name pattern)
-  const planTasks: string[] = [];
-  for (const line of planContent.split("\n")) {
-    const match = line.match(/^###\s+Task\s+\d+\s*[—–-]\s*(.+)$/);
-    if (match) {
-      planTasks.push(match[1].trim().toLowerCase());
-    }
-  }
-
-  if (planTasks.length === 0) return;
-
-  // Check against milestones
-  const doc = parseMilestones(milestonesPath);
-  const matched: string[] = [];
-
-  for (const phase of doc.phases) {
-    for (const item of phase.items) {
-      const normalized = item.text.toLowerCase().trim();
-      // Check if any plan task contains the milestone item text or vice versa
-      for (const task of planTasks) {
-        if (task.includes(normalized) || normalized.includes(task)) {
-          matched.push(`"${item.text}" → plan task`);
-          break;
-        }
-      }
-    }
-  }
-
-  if (matched.length > 0) {
-    // Removed console.log — plan-milestone matches are informational.
-  }
-}
-
-/**
- * After consolidate: reference milestone sync that already happened.
- */
-export function onConsolidate(): void {
-  const cwd = process.cwd();
-  const milestonesPath = path.join(cwd, MILESTONE_DIRS.MILESTONES);
-
-  if (!tryRead(milestonesPath)) return;
-
-  // Removed console.log — milestone auto-sync is silent.
-}

package/packages/notify/src/__tests__/ask-user-prompt-message.test.ts

@@ -1,159 +0,0 @@
-/**
- * Test: Notify — buildAskUserPromptMessage
- *
- * Tests the internal helper directly by importing from its module.
- * The test fixtures use `satisfies AskUserPromptEventPayload` to
- * enforce compile-time alignment with the upstream event contract.
- *
- * Run: node --experimental-strip-types --test
- */
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import {
-  buildAskUserPromptMessage,
-  type AskUserPromptEventPayload,
-} from "../../ask-user-prompt-message.ts";
-
-describe("buildAskUserPromptMessage", () => {
-  it("standard lossless payload", () => {
-    const payload = {
-      questions: [
-        {
-          question: "Which library?",
-          header: "Lib",
-          multiSelect: false,
-          options: [
-            { label: "React", description: "UI library", hasPreview: false },
-            { label: "Vue", description: "Another UI library", hasPreview: false },
-          ],
-        },
-      ],
-    } satisfies AskUserPromptEventPayload;
-
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: Which library? — React, Vue");
-  });
-
-  it("multiple questions appends (+N more) suffix", () => {
-    const payload = {
-      questions: [
-        {
-          question: "First question",
-          header: "Q1",
-          multiSelect: false,
-          options: [{ label: "A", description: "Option A", hasPreview: false }],
-        },
-        {
-          question: "Second question",
-          header: "Q2",
-          multiSelect: false,
-          options: [{ label: "B", description: "Option B", hasPreview: false }],
-        },
-      ],
-    } satisfies AskUserPromptEventPayload;
-
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: First question (+1 more) — A");
-  });
-
-  it("malformed payload (empty question object) falls back to A question", () => {
-    // 故意构造非法 payload，验证运行时降级路径
-    const payload = { questions: [{}] } as unknown as AskUserPromptEventPayload;
-
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: A question");
-  });
-
-  it("empty payload falls back to A question", () => {
-    assert.equal(buildAskUserPromptMessage({}), "Agent asks: A question");
-  });
-
-  it("null payload falls back to A question", () => {
-    assert.equal(buildAskUserPromptMessage(null), "Agent asks: A question");
-  });
-
-  it("missing question string in first question falls back", () => {
-    const payload = {
-      questions: [
-        {
-          question: "",
-          header: "H",
-          multiSelect: false,
-          options: [{ label: "Opt", description: "D", hasPreview: false }],
-        },
-      ],
-    } satisfies AskUserPromptEventPayload;
-
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: A question — Opt");
-  });
-
-  it("whitespace-only question is treated as missing", () => {
-    const payload = {
-      questions: [
-        {
-          question: "   ",
-          header: "H",
-          multiSelect: false,
-          options: [{ label: "Opt", description: "D", hasPreview: false }],
-        },
-      ],
-    } satisfies AskUserPromptEventPayload;
-
-    // nonEmptyString uses trim().length check, so whitespace-only falls back
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: A question — Opt");
-  });
-
-  it("empty option labels do not produce stray commas", () => {
-    const payload = {
-      questions: [
-        {
-          question: "Pick one?",
-          header: "Pick",
-          multiSelect: false,
-          options: [
-            { label: "React", description: "UI lib", hasPreview: false },
-            { label: "", description: "Empty label", hasPreview: false },
-            { label: "Vue", description: "Another UI lib", hasPreview: false },
-          ],
-        },
-      ],
-    } satisfies AskUserPromptEventPayload;
-
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: Pick one? — React, Vue");
-  });
-
-  it("no options produces bare question", () => {
-    const payload = {
-      questions: [
-        {
-          question: "Just type?",
-          header: "Free",
-          multiSelect: false,
-          options: [],
-        },
-      ],
-    } satisfies AskUserPromptEventPayload;
-
-    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: Just type?");
-  });
-
-  it("legacy flat UniPi payload preserves question and context", () => {
-    const payload = {
-      question: "Proceed with deploy?",
-      context: "Production, with smoke tests",
-      optionCount: 2,
-      allowMultiple: false,
-      allowFreeform: true,
-    };
-
-    assert.equal(
-      buildAskUserPromptMessage(payload),
-      "Agent asks: Proceed with deploy? — Production, with smoke tests",
-    );
-  });
-
-  it("legacy flat UniPi payload works without context", () => {
-    assert.equal(
-      buildAskUserPromptMessage({ question: "Proceed?", context: "" }),
-      "Agent asks: Proceed?",
-    );
-  });
-});

package/packages/notify/src/__tests__/event-bus.test.ts

@@ -1,119 +0,0 @@
-/**
- * Test: Notify — event bus registration
- *
- * Verifies that the notify plugin correctly uses pi.events.on() for custom
- * unipi events and pi.on() for pi lifecycle events — same pattern enforced
- * by subagents/badge-generation.test.ts.
- *
- * BUG 2 (Wrong event bus):
- * Cross-module events emitted via pi.events.emit() must be listened via
- * pi.events.on(), NOT pi.on() (which only dispatches lifecycle events).
- */
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-import { readFileSync, existsSync } from "node:fs";
-import { join } from "node:path";
-
-const ROOT = join(import.meta.dirname, "../../../../");
-
-function readSource(relativePath: string): string {
-  const fullPath = join(ROOT, relativePath);
-  if (!existsSync(fullPath)) throw new Error(`File not found: ${fullPath}`);
-  return readFileSync(fullPath, "utf-8");
-}
-
-// ─── Known lifecycle events (mirrors LIFECYCLE_EVENTS in events.ts) ──
-
-const LIFECYCLE_EVENTS = new Set([
-  "agent_end",
-  "agent_settled",
-  "session_shutdown",
-]);
-
-// ─── Test: events.ts correctly uses pi.events.on() for custom events ──
-
-describe("notify — event bus registration", () => {
-  it("events.ts defines LIFECYCLE_EVENTS with correct lifecycle events", () => {
-    const src = readSource("packages/notify/events.ts");
-
-    const lifecycleMatch = src.match(
-      /const LIFECYCLE_EVENTS\s*=\s*new Set\((\[.*?\])\)/s,
-    );
-    assert.ok(lifecycleMatch, "LIFECYCLE_EVENTS should be defined");
-
-    const parsed = [...lifecycleMatch[1].matchAll(/"([^"]+)"/g)].map(
-      (match) => match[1],
-    );
-    assert.deepStrictEqual(
-      parsed.sort(),
-      [...LIFECYCLE_EVENTS].sort(),
-      "LIFECYCLE_EVENTS should contain exactly agent_end, agent_settled, and session_shutdown",
-    );
-  });
-
-  it("unipi:* events use pi.events.on(), NOT pi.on()", () => {
-    const src = readSource("packages/notify/events.ts");
-
-    assert.match(
-      src,
-      /pi\.events\.on\(def\.hook,\s*handler\)/,
-      "Custom unipi events should use pi.events.on(def.hook, handler)",
-    );
-
-    assert.doesNotMatch(
-      src,
-      /(?:\(pi\s+as\s+any\)|pi)\.on\s*\(\s*UNIPI_EVENTS\./,
-      "Should NOT use pi.on() for custom unipi events",
-    );
-  });
-
-  it("lifecycle events (agent_end, agent_settled, session_shutdown) still use pi.on()", () => {
-    const src = readSource("packages/notify/events.ts");
-
-    assert.ok(
-      src.includes("LIFECYCLE_EVENTS.has(eventKey)") &&
-        src.includes("(pi as any).on(def.hook, handler)"),
-      "Lifecycle events should be routed through pi.on() in the registration loop",
-    );
-  });
-
-  it("MODULE_READY listener uses pi.events.on()", () => {
-    const src = readSource("packages/notify/events.ts");
-
-    assert.match(
-      src,
-      /pi\.events\s*\.\s*on\s*\(\s*UNIPI_EVENTS\.MODULE_READY/,
-      "MODULE_READY should use pi.events.on()",
-    );
-
-    assert.doesNotMatch(
-      src,
-      /(?:\(pi\s+as\s+any\)|pi)\.on\s*\(\s*UNIPI_EVENTS\.MODULE_READY/,
-      "MODULE_READY should NOT use pi.on()",
-    );
-  });
-});
-
-// ─── Test: index.ts only uses pi.on() for lifecycle events ──────────
-
-describe("notify — index.ts event registration", () => {
-  it("all pi.on() calls in index.ts use lifecycle events only", () => {
-    const src = readSource("packages/notify/index.ts");
-
-    const validLifecycleEvents = [
-      "resources_discover",
-      "session_start",
-      "session_shutdown",
-    ];
-
-    const piOnPattern = /pi\.on\("([^"]+)"/g;
-    let match: RegExpExecArray | null;
-    while ((match = piOnPattern.exec(src)) !== null) {
-      assert.ok(
-        validLifecycleEvents.includes(match[1]),
-        `index.ts: pi.on("${match[1]}") should be a lifecycle event`,
-      );
-    }
-  });
-});

package/packages/notify/src/__tests__/permission-prompt-message.test.ts

@@ -1,172 +0,0 @@
-/**
- * Tests for buildPermissionPromptMessage — the `permissions:ui_prompt`
- * payload projection used by the `permission_request` notify event.
- *
- * The test fixtures use `satisfies PermissionPromptEventPayload` to
- * enforce the payload contract at compile time.
- */
-
-import { describe, it } from "node:test";
-import assert from "node:assert/strict";
-
-import {
-  buildPermissionPromptMessage,
-  type PermissionPromptEventPayload,
-} from "../../permission-prompt-message.ts";
-
-describe("buildPermissionPromptMessage", () => {
-  it("formats a standard bash permission payload", () => {
-    const payload = {
-      requestId: "req-1",
-      source: "tool",
-      surface: "bash",
-      value: "npm test",
-      agentName: "Current agent",
-      message: "Allow this command?",
-    } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Current agent requested bash 'npm test'. Allow this command?",
-    );
-  });
-
-  it("falls back to \"Agent\" when agentName is absent", () => {
-    const payload = {
-      surface: "edit",
-      value: "src/index.ts",
-    } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Agent requested edit 'src/index.ts'.",
-    );
-  });
-
-  it("marks forwarded subagent prompts", () => {
-    const payload = {
-      surface: "mcp",
-      value: "github.create_issue",
-      agentName: "explore",
-      forwarding: { from: "subagent-1" },
-    } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "explore requested mcp 'github.create_issue'. (forwarded)",
-    );
-  });
-
-  it("does not mark prompts when forwarding is explicitly falsy", () => {
-    for (const forwarding of [false, null, "", 0, {}, []]) {
-      const payload = {
-        surface: "read",
-        value: "/etc/hosts",
-        forwarding,
-      } satisfies PermissionPromptEventPayload;
-
-      const result = buildPermissionPromptMessage(payload);
-      assert.equal(
-        result.includes("(forwarded)"),
-        false,
-        `expected no forwarded marker for ${JSON.stringify(forwarding)}`,
-      );
-    }
-  });
-
-  it("uses surface alone when no value is provided", () => {
-    const payload = { surface: "bash" } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Agent requested bash access.",
-    );
-  });
-
-  it("uses value alone when no surface is provided", () => {
-    const payload = { value: "rm -rf build" } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Agent requested 'rm -rf build'.",
-    );
-  });
-
-  it("falls back to the message when surface and value are missing", () => {
-    const payload = {
-      requestId: "req-2",
-      message: "Allow access to the workspace?",
-    } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Allow access to the workspace?",
-    );
-  });
-
-  it("does not duplicate the message when it equals the request clause", () => {
-    const payload = {
-      surface: "bash",
-      value: "npm test",
-      agentName: "Current agent",
-      message: "Current agent requested bash 'npm test'.",
-    } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Current agent requested bash 'npm test'.",
-    );
-  });
-
-  it("returns a generic fallback for an empty payload", () => {
-    assert.equal(
-      buildPermissionPromptMessage({}),
-      "Pi is waiting for a permission decision.",
-    );
-  });
-
-  it("handles null, undefined and non-object payloads without throwing", () => {
-    for (const payload of [null, undefined, 42, "nope", true]) {
-      assert.equal(
-        buildPermissionPromptMessage(payload),
-        "Pi is waiting for a permission decision.",
-      );
-    }
-  });
-
-  it("treats empty and whitespace-only strings as absent", () => {
-    const payload = {
-      surface: "   ",
-      value: "",
-      agentName: "  ",
-      message: "\t\n",
-    } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Pi is waiting for a permission decision.",
-    );
-  });
-
-  it("ignores non-string surface/value/message fields", () => {
-    const payload = {
-      surface: 123,
-      value: { cmd: "ls" },
-      message: ["a"],
-    } as unknown as PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Pi is waiting for a permission decision.",
-    );
-  });
-
-  it("still reports a forwarded prompt with no other detail", () => {
-    const payload = { forwarding: true } satisfies PermissionPromptEventPayload;
-
-    assert.equal(
-      buildPermissionPromptMessage(payload),
-      "Pi is waiting for a permission decision. (forwarded)",
-    );
-  });
-});