@pi-unipi/unipi 2.0.5 → 2.0.7

package/packages/memory/package.json

@@ -0,0 +1,62 @@
+{
+  "name": "@pi-unipi/memory",
+  "version": "2.0.7",
+  "description": "Persistent cross-session memory with vector search for Pi coding agent",
+  "type": "module",
+  "license": "MIT",
+  "author": "Neuron Mr White",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/Neuron-Mr-White/unipi.git",
+    "directory": "packages/memory"
+  },
+  "homepage": "https://github.com/Neuron-Mr-White/unipi#readme",
+  "bugs": {
+    "url": "https://github.com/Neuron-Mr-White/unipi/issues"
+  },
+  "keywords": [
+    "pi-package",
+    "pi-extension",
+    "pi-coding-agent",
+    "unipi",
+    "memory",
+    "vector-search",
+    "sqlite-vec"
+  ],
+  "pi": {
+    "extensions": [
+      "index.ts"
+    ],
+    "skills": [
+      "skills"
+    ]
+  },
+  "files": [
+    "index.ts",
+    "storage.ts",
+    "search.ts",
+    "embedding.ts",
+    "settings.ts",
+    "tools.ts",
+    "commands.ts",
+    "tui/**/*",
+    "skills/**/*",
+    "README.md"
+  ],
+  "dependencies": {
+    "better-sqlite3": "^12.9.0",
+    "sqlite-vec": "^0.1.9",
+    "js-yaml": "^4.1.0",
+    "@pi-unipi/core": "*",
+    "@pi-unipi/info-screen": "*"
+  },
+  "peerDependencies": {
+    "@mariozechner/pi-coding-agent": "*",
+    "@sinclair/typebox": "*"
+  },
+  "devDependencies": {
+    "@types/better-sqlite3": "^7.6.0",
+    "@types/js-yaml": "^4.0.0",
+    "@types/node": "^25.6.0"
+  }
+}

package/packages/milestone/package.json

@@ -0,0 +1,50 @@
+{
+  "name": "@pi-unipi/milestone",
+  "version": "2.0.7",
+  "description": "Lifecycle layer for project-level goals — MILESTONES.md tracking, session hooks, auto-sync",
+  "type": "module",
+  "license": "MIT",
+  "author": "Neuron Mr White",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/Neuron-Mr-White/unipi.git",
+    "directory": "packages/milestone"
+  },
+  "keywords": [
+    "pi-package",
+    "pi-extension",
+    "pi-coding-agent",
+    "unipi",
+    "milestone",
+    "goals",
+    "progress"
+  ],
+  "files": [
+    "*.ts",
+    "skills/**/*",
+    "README.md"
+  ],
+  "pi": {
+    "extensions": [
+      "index.ts"
+    ],
+    "skills": [
+      "skills"
+    ]
+  },
+  "publishConfig": {
+    "access": "public"
+  },
+  "dependencies": {
+    "@pi-unipi/core": "*"
+  },
+  "peerDependencies": {
+    "@mariozechner/pi-coding-agent": "*",
+    "@mariozechner/pi-tui": "*",
+    "@sinclair/typebox": "*"
+  },
+  "devDependencies": {
+    "@types/node": "^25.6.0",
+    "typescript": "^6.0.0"
+  }
+}

package/packages/notify/ask-user-prompt-message.ts

@@ -0,0 +1,75 @@
+/**
+ * @pi-unipi/notify — Internal helper: build notification message from
+ * ask-user prompt event payloads.
+ *
+ * Supports both UniPi's flat `unipi:ask-user:prompt` payload and the
+ * lossless `rpiv:ask-user:prompt` questionnaire projection.
+ *
+ * @internal — not part of the public API. Shared by the event listener and tests.
+ */
+
+export interface AskUserPromptEventPayload {
+  questions: ReadonlyArray<AskUserPromptQuestion>;
+}
+
+export interface AskUserPromptQuestion {
+  question: string;
+  header: string;
+  multiSelect: boolean;
+  options: ReadonlyArray<AskUserPromptOption>;
+}
+
+export interface AskUserPromptOption {
+  label: string;
+  description: string;
+  hasPreview: boolean;
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return value !== null && typeof value === "object";
+}
+
+function nonEmptyString(value: unknown, fallback: string): string {
+  return typeof value === "string" && value.trim().length > 0 ? value : fallback;
+}
+
+function buildFlatPromptMessage(payload: Record<string, unknown>): string {
+  const question = nonEmptyString(payload.question, "A question");
+  const context = nonEmptyString(payload.context, "");
+  return context ? `Agent asks: ${question} — ${context}` : `Agent asks: ${question}`;
+}
+
+/** Build a human-readable notification message from an ask-user prompt payload. */
+export function buildAskUserPromptMessage(payload: unknown): string {
+  const p = isRecord(payload) ? payload : {};
+
+  const questions = Array.isArray(p.questions)
+    ? p.questions.filter(isRecord)
+    : [];
+
+  if (questions.length === 0 && ("question" in p || "context" in p)) {
+    return buildFlatPromptMessage(p);
+  }
+
+  const firstQ = questions[0];
+
+  const baseQuestion = firstQ
+    ? nonEmptyString(firstQ.question, "A question")
+    : "A question";
+
+  const suffix = questions.length > 1 ? ` (+${questions.length - 1} more)` : "";
+
+  const optionLabels =
+    firstQ && Array.isArray(firstQ.options)
+      ? firstQ.options
+          .filter(isRecord)
+          .map((o) => nonEmptyString(o.label, ""))
+          .filter((label) => label.length > 0)
+      : [];
+
+  const options = optionLabels.join(", ");
+
+  return options
+    ? `Agent asks: ${baseQuestion}${suffix} — ${options}`
+    : `Agent asks: ${baseQuestion}${suffix}`;
+}

package/packages/notify/events.ts

@@ -13,11 +13,28 @@ import { sendNativeNotification, SuppressedError } from "./platforms/native.js";
 import { sendGotifyNotification } from "./platforms/gotify.js";
 import { sendTelegramNotification } from "./platforms/telegram.js";
 import { sendNtfyNotification } from "./platforms/ntfy.js";
+import { buildAskUserPromptMessage } from "./ask-user-prompt-message.js";
 import { summarizeLastMessage } from "./summarize.js";
 
+// Event emitted by @juicesharp/rpiv-ask-user-question before showing its UI.
+// Keep this as a local string until that package publishes an importable
+// `./events` contract in npm.
+const ASK_USER_PROMPT_EVENT = "rpiv:ask-user:prompt" as const;
+
 /** Stored session context for modelRegistry access */
 let sessionCtx: ExtensionContext | null = null;
 
+/** Unsubscribe functions for pi.events.on() listeners. Cleared before each registration to avoid accumulation across reloads. */
+const unsubs: Array<() => void> = [];
+
+/** Unregister all previously registered pi.events.on() listeners. */
+function unregisterAll(): void {
+  for (const unsub of unsubs) {
+    try { unsub(); } catch { /* ignore */ }
+  }
+  unsubs.length = 0;
+}
+
 /** Store session context (called from index.ts on session_start) */
 export function setSessionContext(ctx: ExtensionContext): void {
   sessionCtx = ctx;
@@ -42,6 +59,12 @@ export const BUILTIN_EVENTS: Record<
   ask_user_prompt: { hook: UNIPI_EVENTS.ASK_USER_PROMPT, label: "Question Asked" },
 };
 
+/**
+ * Pi lifecycle event types (dispatched by ExtensionRunner).
+ * These must use pi.on() — not pi.events.on() — to receive events.
+ */
+const LIFECYCLE_EVENTS = new Set(["agent_end", "session_shutdown"]);
+
 /**
  * Register event listeners for all enabled notification events.
  * Attaches listeners to pi hooks and routes notifications to platforms.
@@ -51,6 +74,9 @@ export function registerEventListeners(
   config: NotifyConfig,
   cwd: string
 ): void {
+  // Remove all previously registered EventBus listeners to prevent accumulation
+  // across reloads (EventBus persists but module instances are replaced).
+  unregisterAll();
   // Register built-in events (except agent_end which has custom logic)
   for (const [eventKey, def] of Object.entries(BUILTIN_EVENTS)) {
     if (eventKey === "agent_end") continue; // handled separately below
@@ -69,7 +95,29 @@ export function registerEventListeners(
       );
     };
 
-    (pi as any).on(def.hook, handler);
+    // pi lifecycle events (agent_end, session_shutdown) are dispatched via
+    // ExtensionRunner — must use pi.on(). These are stored in
+    // extension.handlers and automatically replaced on reload, so they
+    // do NOT accumulate like EventBus listeners.
+    if (LIFECYCLE_EVENTS.has(eventKey)) {
+      (pi as any).on(def.hook, handler);
+    } else {
+      unsubs.push(pi.events.on(def.hook, handler));
+    }
+  }
+
+  // Listen for rpiv:ask-user:prompt from @juicesharp/rpiv-ask-user-question
+  const askUserConfig = config.events["ask_user_prompt"];
+  if (askUserConfig?.enabled) {
+    unsubs.push(pi.events.on(ASK_USER_PROMPT_EVENT, (payload: unknown) => {
+      const title = `Pi — ${BUILTIN_EVENTS.ask_user_prompt.label}`;
+      const message = buildAskUserPromptMessage(payload);
+      dispatchNotification(pi, title, message, askUserConfig.platforms, "ask_user_prompt", config, cwd).catch(
+        () => {
+          // Silently ignore — background notification failure is non-blocking.
+        }
+      );
+    }));
   }
 
   // agent_end — custom handler with session name and recap support
@@ -130,7 +178,7 @@ export function registerEventListeners(
       // For now, modules register their own events through MODULE_READY
     }
   };
-  (pi as any).on(UNIPI_EVENTS.MODULE_READY, moduleHandler);
+  unsubs.push(pi.events.on(UNIPI_EVENTS.MODULE_READY, moduleHandler));
 }
 
 /** Get all platforms that are currently enabled in config */
@@ -144,7 +192,9 @@ function getEnabledPlatforms(config: NotifyConfig, ntfyEnabled: boolean): Notify
 }
 
 /** No-op — cleanup handled by session teardown */
-export function unregisterEventListeners(): void {}
+export function unregisterEventListeners(): void {
+  unregisterAll();
+}
 
 /**
  * Dispatch a notification to the configured platforms.
@@ -291,9 +341,7 @@ function buildEventMessage(eventKey: string, payload: unknown): string {
     case "session_shutdown":
       return "Session ending";
     case "ask_user_prompt":
-      return p.context
-        ? `Agent asks: ${String(p.question || "")} — ${String(p.context)}`
-        : `Agent asks: ${String(p.question || "A question")}`;
+      return buildAskUserPromptMessage(payload);
     default:
       return p.message ? String(p.message) : "Event occurred";
   }

package/packages/notify/package.json

@@ -0,0 +1,60 @@
+{
+  "name": "@pi-unipi/notify",
+  "version": "2.0.7",
+  "description": "Cross-platform notification extension for Pi — native OS, Gotify, and Telegram notifications for agent lifecycle events",
+  "type": "module",
+  "license": "MIT",
+  "author": "Neuron Mr White",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/Neuron-Mr-White/unipi.git",
+    "directory": "packages/notify"
+  },
+  "keywords": [
+    "pi-package",
+    "pi-extension",
+    "pi-coding-agent",
+    "unipi",
+    "notify",
+    "notifications"
+  ],
+  "scripts": {
+    "test": "tsc --noEmit && node --experimental-strip-types --test src/__tests__/*.test.ts",
+    "typecheck": "tsc --noEmit"
+  },
+  "files": [
+    "index.ts",
+    "tools.ts",
+    "commands.ts",
+    "settings.ts",
+    "events.ts",
+    "ask-user-prompt-message.ts",
+    "ntfy-config.ts",
+    "summarize.ts",
+    "types.ts",
+    "platforms/*",
+    "tui/*",
+    "skills/**/*",
+    "README.md"
+  ],
+  "pi": {
+    "extensions": [
+      "index.ts"
+    ],
+    "skills": [
+      "skills"
+    ]
+  },
+  "publishConfig": {
+    "access": "public"
+  },
+  "dependencies": {
+    "@pi-unipi/core": "*",
+    "node-notifier": "^10.0.1"
+  },
+  "peerDependencies": {
+    "@mariozechner/pi-coding-agent": "*",
+    "@mariozechner/pi-tui": "*",
+    "@sinclair/typebox": "*"
+  }
+}

package/packages/notify/src/__tests__/ask-user-prompt-message.test.ts

@@ -0,0 +1,159 @@
+/**
+ * Test: Notify — buildAskUserPromptMessage
+ *
+ * Tests the internal helper directly by importing from its module.
+ * The test fixtures use `satisfies AskUserPromptEventPayload` to
+ * enforce compile-time alignment with the upstream event contract.
+ *
+ * Run: node --experimental-strip-types --test
+ */
+
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import {
+  buildAskUserPromptMessage,
+  type AskUserPromptEventPayload,
+} from "../../ask-user-prompt-message.ts";
+
+describe("buildAskUserPromptMessage", () => {
+  it("standard lossless payload", () => {
+    const payload = {
+      questions: [
+        {
+          question: "Which library?",
+          header: "Lib",
+          multiSelect: false,
+          options: [
+            { label: "React", description: "UI library", hasPreview: false },
+            { label: "Vue", description: "Another UI library", hasPreview: false },
+          ],
+        },
+      ],
+    } satisfies AskUserPromptEventPayload;
+
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: Which library? — React, Vue");
+  });
+
+  it("multiple questions appends (+N more) suffix", () => {
+    const payload = {
+      questions: [
+        {
+          question: "First question",
+          header: "Q1",
+          multiSelect: false,
+          options: [{ label: "A", description: "Option A", hasPreview: false }],
+        },
+        {
+          question: "Second question",
+          header: "Q2",
+          multiSelect: false,
+          options: [{ label: "B", description: "Option B", hasPreview: false }],
+        },
+      ],
+    } satisfies AskUserPromptEventPayload;
+
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: First question (+1 more) — A");
+  });
+
+  it("malformed payload (empty question object) falls back to A question", () => {
+    // 故意构造非法 payload，验证运行时降级路径
+    const payload = { questions: [{}] } as unknown as AskUserPromptEventPayload;
+
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: A question");
+  });
+
+  it("empty payload falls back to A question", () => {
+    assert.equal(buildAskUserPromptMessage({}), "Agent asks: A question");
+  });
+
+  it("null payload falls back to A question", () => {
+    assert.equal(buildAskUserPromptMessage(null), "Agent asks: A question");
+  });
+
+  it("missing question string in first question falls back", () => {
+    const payload = {
+      questions: [
+        {
+          question: "",
+          header: "H",
+          multiSelect: false,
+          options: [{ label: "Opt", description: "D", hasPreview: false }],
+        },
+      ],
+    } satisfies AskUserPromptEventPayload;
+
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: A question — Opt");
+  });
+
+  it("whitespace-only question is treated as missing", () => {
+    const payload = {
+      questions: [
+        {
+          question: "   ",
+          header: "H",
+          multiSelect: false,
+          options: [{ label: "Opt", description: "D", hasPreview: false }],
+        },
+      ],
+    } satisfies AskUserPromptEventPayload;
+
+    // nonEmptyString uses trim().length check, so whitespace-only falls back
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: A question — Opt");
+  });
+
+  it("empty option labels do not produce stray commas", () => {
+    const payload = {
+      questions: [
+        {
+          question: "Pick one?",
+          header: "Pick",
+          multiSelect: false,
+          options: [
+            { label: "React", description: "UI lib", hasPreview: false },
+            { label: "", description: "Empty label", hasPreview: false },
+            { label: "Vue", description: "Another UI lib", hasPreview: false },
+          ],
+        },
+      ],
+    } satisfies AskUserPromptEventPayload;
+
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: Pick one? — React, Vue");
+  });
+
+  it("no options produces bare question", () => {
+    const payload = {
+      questions: [
+        {
+          question: "Just type?",
+          header: "Free",
+          multiSelect: false,
+          options: [],
+        },
+      ],
+    } satisfies AskUserPromptEventPayload;
+
+    assert.equal(buildAskUserPromptMessage(payload), "Agent asks: Just type?");
+  });
+
+  it("legacy flat UniPi payload preserves question and context", () => {
+    const payload = {
+      question: "Proceed with deploy?",
+      context: "Production, with smoke tests",
+      optionCount: 2,
+      allowMultiple: false,
+      allowFreeform: true,
+    };
+
+    assert.equal(
+      buildAskUserPromptMessage(payload),
+      "Agent asks: Proceed with deploy? — Production, with smoke tests",
+    );
+  });
+
+  it("legacy flat UniPi payload works without context", () => {
+    assert.equal(
+      buildAskUserPromptMessage({ question: "Proceed?", context: "" }),
+      "Agent asks: Proceed?",
+    );
+  });
+});

package/packages/notify/src/__tests__/event-bus.test.ts

@@ -0,0 +1,118 @@
+/**
+ * Test: Notify — event bus registration
+ *
+ * Verifies that the notify plugin correctly uses pi.events.on() for custom
+ * unipi events and pi.on() for pi lifecycle events — same pattern enforced
+ * by subagents/badge-generation.test.ts.
+ *
+ * BUG 2 (Wrong event bus):
+ * Cross-module events emitted via pi.events.emit() must be listened via
+ * pi.events.on(), NOT pi.on() (which only dispatches lifecycle events).
+ */
+
+import { describe, it } from "node:test";
+import assert from "node:assert/strict";
+import { readFileSync, existsSync } from "node:fs";
+import { join } from "node:path";
+
+const ROOT = join(import.meta.dirname, "../../../../");
+
+function readSource(relativePath: string): string {
+  const fullPath = join(ROOT, relativePath);
+  if (!existsSync(fullPath)) throw new Error(`File not found: ${fullPath}`);
+  return readFileSync(fullPath, "utf-8");
+}
+
+// ─── Known lifecycle events (mirrors LIFECYCLE_EVENTS in events.ts) ──
+
+const LIFECYCLE_EVENTS = new Set([
+  "agent_end",
+  "session_shutdown",
+]);
+
+// ─── Test: events.ts correctly uses pi.events.on() for custom events ──
+
+describe("notify — event bus registration", () => {
+  it("events.ts defines LIFECYCLE_EVENTS with correct lifecycle events", () => {
+    const src = readSource("packages/notify/events.ts");
+
+    const lifecycleMatch = src.match(
+      /const LIFECYCLE_EVENTS\s*=\s*new Set\((\[.*?\])\)/s,
+    );
+    assert.ok(lifecycleMatch, "LIFECYCLE_EVENTS should be defined");
+
+    const parsed = [...lifecycleMatch[1].matchAll(/"([^"]+)"/g)].map(
+      (match) => match[1],
+    );
+    assert.deepStrictEqual(
+      parsed.sort(),
+      [...LIFECYCLE_EVENTS].sort(),
+      "LIFECYCLE_EVENTS should contain exactly agent_end and session_shutdown",
+    );
+  });
+
+  it("unipi:* events use pi.events.on(), NOT pi.on()", () => {
+    const src = readSource("packages/notify/events.ts");
+
+    assert.match(
+      src,
+      /pi\.events\.on\(def\.hook,\s*handler\)/,
+      "Custom unipi events should use pi.events.on(def.hook, handler)",
+    );
+
+    assert.doesNotMatch(
+      src,
+      /(?:\(pi\s+as\s+any\)|pi)\.on\s*\(\s*UNIPI_EVENTS\./,
+      "Should NOT use pi.on() for custom unipi events",
+    );
+  });
+
+  it("lifecycle events (agent_end, session_shutdown) still use pi.on()", () => {
+    const src = readSource("packages/notify/events.ts");
+
+    assert.ok(
+      src.includes("LIFECYCLE_EVENTS.has(eventKey)") &&
+        src.includes("(pi as any).on(def.hook, handler)"),
+      "Lifecycle events should be routed through pi.on() in the registration loop",
+    );
+  });
+
+  it("MODULE_READY listener uses pi.events.on()", () => {
+    const src = readSource("packages/notify/events.ts");
+
+    assert.match(
+      src,
+      /pi\.events\s*\.\s*on\s*\(\s*UNIPI_EVENTS\.MODULE_READY/,
+      "MODULE_READY should use pi.events.on()",
+    );
+
+    assert.doesNotMatch(
+      src,
+      /(?:\(pi\s+as\s+any\)|pi)\.on\s*\(\s*UNIPI_EVENTS\.MODULE_READY/,
+      "MODULE_READY should NOT use pi.on()",
+    );
+  });
+});
+
+// ─── Test: index.ts only uses pi.on() for lifecycle events ──────────
+
+describe("notify — index.ts event registration", () => {
+  it("all pi.on() calls in index.ts use lifecycle events only", () => {
+    const src = readSource("packages/notify/index.ts");
+
+    const validLifecycleEvents = [
+      "resources_discover",
+      "session_start",
+      "session_shutdown",
+    ];
+
+    const piOnPattern = /pi\.on\("([^"]+)"/g;
+    let match: RegExpExecArray | null;
+    while ((match = piOnPattern.exec(src)) !== null) {
+      assert.ok(
+        validLifecycleEvents.includes(match[1]),
+        `index.ts: pi.on("${match[1]}") should be a lifecycle event`,
+      );
+    }
+  });
+});