@pi-unipi/subagents 0.2.3 → 0.2.5

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-unipi/subagents",
-  "version": "0.2.3",
+  "version": "0.2.5",
   "description": "Subagents for UniPi — parallel execution, file locking, workflow integration",
   "type": "module",
   "main": "dist/index.js",

package/src/__tests__/badge-generation.test.ts

@@ -60,9 +60,14 @@ describe("Badge generation — tool availability", () => {
 // ─── Test: Prompt no longer references non-existent tool ───────────
 
 describe("Badge generation — prompt fix", () => {
-  it("prompt asks agent to OUTPUT the title directly (not call a tool)", () => {
+  it("prompt includes conversation context inline", () => {
     const src = readSource("packages/subagents/src/index.ts");
 
+    assert.ok(
+      src.includes("Conversation:"),
+      "Prompt should include conversation context inline",
+    );
+
     assert.ok(
       src.includes("Reply with ONLY the title"),
       "Prompt should ask agent to reply with only the title",
@@ -93,6 +98,56 @@ describe("Badge generation — onComplete callback", () => {
   });
 });
 
+// ─── Test: Agent configuration ────────────────────────────────────
+
+describe("Badge generation — agent configuration", () => {
+  it("badge generation uses 'name-gen' agent type (not 'explore')", () => {
+    const src = readSource("packages/subagents/src/index.ts");
+
+    assert.ok(
+      src.includes('manager.spawn(pi, sessionCtx, "name-gen", prompt'),
+      "Badge generation should spawn a 'name-gen' agent",
+    );
+
+    assert.ok(
+      !src.includes('manager.spawn(pi, sessionCtx, "explore"'),
+      "Should NOT use 'explore' — that type can be overridden by user custom agents",
+    );
+  });
+
+  it("'name-gen' type is defined in BUILTIN_CONFIGS with empty tools", () => {
+    const src = readSource("packages/subagents/src/types.ts");
+
+    assert.ok(
+      src.includes('"name-gen"'),
+      "types.ts should define name-gen agent config",
+    );
+
+    assert.ok(
+      src.includes('builtinToolNames: []'),
+      "name-gen should have empty tool list",
+    );
+  });
+
+  it("background agent is isolated (no extensions, no skills, minimal system prompt)", () => {
+    const src = readSource("packages/subagents/src/index.ts");
+
+    assert.ok(
+      src.includes("isolated: true"),
+      "Should spawn with isolated: true to avoid loading extensions/skills",
+    );
+  });
+
+  it("background agent maxTurns is 1 (single response)", () => {
+    const src = readSource("packages/subagents/src/index.ts");
+
+    assert.ok(
+      src.includes("maxTurns: 1"),
+      "Badge generation agent should have maxTurns: 1",
+    );
+  });
+});
+
 // ─── Test: Cross-module event bus — the critical fix ───────────────
 
 describe("Badge generation — event bus (CRITICAL FIX)", () => {
@@ -150,6 +205,7 @@ describe("Badge generation — event bus (CRITICAL FIX)", () => {
     const validLifecycleEvents = [
       "session_start", "session_shutdown", "input",
       "tool_call", "tool_execution_start",
+      "agent_end", "before_agent_start",
     ];
 
     // Check that pi.on() is only used with lifecycle events
@@ -173,11 +229,26 @@ describe("Badge generation — event bus (CRITICAL FIX)", () => {
 // ─── Test: Event flow ──────────────────────────────────────────────
 
 describe("Badge generation — event flow", () => {
-  it("utility emits BADGE_GENERATE_REQUEST on first input", () => {
+  it("utility emits BADGE_GENERATE_REQUEST after agent responds (deferred from input)", () => {
     const src = readSource("packages/utility/src/index.ts");
 
+    // BADGE_GENERATE_REQUEST should be emitted in agent_end handler, not input
     assert.ok(src.includes("BADGE_GENERATE_REQUEST"));
     assert.ok(src.includes('source: "input-hook"'));
+
+    // input handler should NOT emit BADGE_GENERATE_REQUEST directly
+    const inputBlock = src.match(/pi\.on\("input"[\s\S]*?(?=pi\.on\(|$)/)?.[0] ?? "";
+    assert.ok(
+      !inputBlock.includes("BADGE_GENERATE_REQUEST"),
+      "input handler should NOT emit BADGE_GENERATE_REQUEST — deferred to agent_end",
+    );
+
+    // agent_end handler should emit BADGE_GENERATE_REQUEST
+    const agentEndBlock = src.match(/pi\.on\("agent_end"[\s\S]*?(?=pi\.on\(|$)/)?.[0] ?? "";
+    assert.ok(
+      agentEndBlock.includes("BADGE_GENERATE_REQUEST"),
+      "agent_end handler should emit BADGE_GENERATE_REQUEST with full conversation context",
+    );
   });
 
   it("BADGE_GENERATE_REQUEST event is defined in core", () => {

package/src/agent-runner.ts

@@ -172,12 +172,16 @@ export async function runAgent(
   let toolNames = getToolNamesForType(type, agentConfig);
 
   // Create resource loader
+  // Respect agentConfig.extensions/skills flags: if explicitly false, skip loading.
+  // This prevents explore/work agents from loading all parent extensions.
   const agentDir = getAgentDir();
+  const skipExtensions = options.isolated || agentConfig?.extensions === false;
+  const skipSkills = options.isolated || agentConfig?.skills === false;
   const loader = new DefaultResourceLoader({
     cwd: effectiveCwd,
     agentDir,
-    noExtensions: options.isolated,
-    noSkills: options.isolated,
+    noExtensions: skipExtensions,
+    noSkills: skipSkills,
     noPromptTemplates: true,
     noThemes: true,
     noContextFiles: true,
@@ -213,15 +217,19 @@ export async function runAgent(
   });
   session.setActiveToolsByName(activeTools);
 
-  // Bind extensions
-  await session.bindExtensions({
-    onError: (err) => {
-      options.onToolActivity?.({
-        type: "end",
-        toolName: `extension-error:${err.extensionPath}`,
-      });
-    },
-  });
+  // Bind extensions — only if extensions were loaded.
+  // Skipping for agents with extensions: false avoids firing session_start
+  // on an empty extension set, preventing unnecessary MODULE_READY cascade.
+  if (!skipExtensions) {
+    await session.bindExtensions({
+      onError: (err) => {
+        options.onToolActivity?.({
+          type: "end",
+          toolName: `extension-error:${err.extensionPath}`,
+        });
+      },
+    });
+  }
 
   options.onSessionCreated?.(session);
 

package/src/index.ts

@@ -148,6 +148,19 @@ export default function (pi: ExtensionAPI) {
       // Build notification details
       const details = buildNotificationDetails(record, agentActivity.get(record.id));
 
+      // Badge generation: extract name from agent result and set directly.
+      // Mark resultConsumed BEFORE the notification check so the main agent
+      // never sees this subagent.
+      if (record.description === "Generate session name" && record.result && record.status === "completed") {
+        const name = record.result.split("\n")[0]?.trim().slice(0, 50) ?? "";
+        if (name && !name.startsWith("Error") && !name.includes("error")) {
+          try {
+            pi.setSessionName(name);
+          } catch { /* best effort */ }
+        }
+        record.resultConsumed = true;
+      }
+
       // Send styled notification via message renderer
       const status = getStatusLabel(record.status, record.error);
       const durationMs = record.completedAt ? record.completedAt - record.startedAt : 0;
@@ -179,16 +192,6 @@ export default function (pi: ExtensionAPI) {
         );
       }
 
-      // Badge generation: extract name from agent result and set directly
-      if (record.description === "Generate session name" && record.result && record.status === "completed") {
-        const name = record.result.split("\n")[0]?.trim().slice(0, 50) ?? "";
-        if (name && !name.startsWith("Error") && !name.includes("error")) {
-          try {
-            pi.setSessionName(name);
-          } catch { /* best effort */ }
-        }
-      }
-
       pi.events.emit("subagents:completed", {
         id: record.id,
         type: record.type,
@@ -354,8 +357,8 @@ export default function (pi: ExtensionAPI) {
 
     const summary = event?.conversationSummary ?? "";
     const prompt = summary
-      ? `Generate a concise session title (MAX 5 WORDS) for this conversation:\n\n"${summary}"\n\nReply with ONLY the title. No quotes, no explanation, no punctuation.`
-      : `Generate a concise session title (MAX 5 WORDS) for the current session. Reply with ONLY the title. No quotes, no explanation, no punctuation.`;
+      ? `Based on this conversation, generate a concise session title (MAX 5 WORDS). Reply with ONLY the title. No quotes, no explanation, no punctuation.\n\nConversation:\n${summary}`
+      : `Generate a concise session title (MAX 5 WORDS) for this session. Reply with ONLY the title. No quotes, no explanation, no punctuation.`;
 
     // Try with configured model, fallback to inherit
     let modelInput: string | undefined = undefined;
@@ -382,11 +385,12 @@ export default function (pi: ExtensionAPI) {
       // If result is a string (error), resolvedModel stays undefined → inherit parent
     }
 
-    manager.spawn(pi, sessionCtx, "explore", prompt, {
+    manager.spawn(pi, sessionCtx, "name-gen", prompt, {
       description: "Generate session name",
       model: resolvedModel,
       isBackground: true,
-      maxTurns: 3,
+      isolated: true,
+      maxTurns: 1,
     });
   });
 

package/src/types.ts

@@ -44,6 +44,17 @@ export const BUILTIN_CONFIGS: Record<string, AgentConfig> = {
     promptMode: "append",
     source: "builtin",
   },
+  "name-gen": {
+    name: "name-gen",
+    displayName: "Name Generator",
+    description: "Minimal agent for generating session names from conversation context.",
+    builtinToolNames: [],
+    extensions: false,
+    skills: false,
+    systemPrompt: "You are a session name generator. Generate concise titles from conversation context. Reply with ONLY the title.",
+    promptMode: "replace",
+    source: "builtin",
+  },
 } as const;
 
 /** Memory scope for persistent agent memory. */