@pi-unipi/notify 2.2.0 → 2.2.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-unipi/notify",
-  "version": "2.2.0",
+  "version": "2.2.2",
   "description": "Cross-platform notification extension for Pi — native OS, Gotify, and Telegram notifications for agent lifecycle events",
   "type": "module",
   "main": "index.ts",
@@ -24,15 +24,7 @@
     "typecheck": "tsc --noEmit"
   },
   "files": [
-    "index.ts",
-    "tools.ts",
-    "commands.ts",
-    "settings.ts",
-    "events.ts",
-    "ask-user-prompt-message.ts",
-    "ntfy-config.ts",
-    "summarize.ts",
-    "types.ts",
+    "*.ts",
     "platforms/*",
     "tui/*",
     "skills/**/*",

package/permission-prompt-message.ts

@@ -0,0 +1,95 @@
+/**
+ * @pi-unipi/notify — Internal helper: build notification message from
+ * permission prompt event payloads.
+ *
+ * Handles the `permissions:ui_prompt` broadcast emitted by
+ * `@gotgenes/pi-permission-system` immediately before a human-facing
+ * permission prompt is shown.
+ *
+ * @internal — not part of the public API. Shared by the event listener and tests.
+ */
+
+export interface PermissionPromptEventPayload {
+  /** Correlation id for the permission request */
+  requestId?: string;
+  /** Originating subsystem of the request */
+  source?: string;
+  /** Surface being requested — e.g. "bash", "mcp", "read", "edit" */
+  surface?: string | null;
+  /** Command / path / tool / skill being requested */
+  value?: string | null;
+  /** Current or requesting agent, when available */
+  agentName?: string | null;
+  /** Human-readable permission prompt text */
+  message?: string;
+  /** Present for forwarded subagent prompts */
+  forwarding?: unknown;
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return value !== null && typeof value === "object";
+}
+
+/** Return a trimmed non-empty string, or `undefined` for anything else. */
+function cleanString(value: unknown): string | undefined {
+  if (typeof value !== "string") return undefined;
+  const trimmed = value.trim();
+  return trimmed.length > 0 ? trimmed : undefined;
+}
+
+/**
+ * `forwarding` is documented as "present for forwarded subagent prompts".
+ * Treat an explicitly falsy value (false / null / "" / 0) as not forwarded so
+ * that publishers which always include the key are handled correctly.
+ */
+function isForwarded(value: unknown): boolean {
+  if (value === undefined || value === null) return false;
+  if (typeof value === "boolean") return value;
+  if (typeof value === "string") return value.trim().length > 0;
+  if (typeof value === "number") return value !== 0;
+  if (Array.isArray(value)) return value.length > 0;
+  if (isRecord(value)) return Object.keys(value).length > 0;
+  return true;
+}
+
+/**
+ * Build the "what was requested" clause from `agentName` / `surface` / `value`.
+ * Returns `undefined` when there is nothing meaningful to say.
+ */
+function buildRequestClause(
+  agentName: string | undefined,
+  surface: string | undefined,
+  value: string | undefined,
+): string | undefined {
+  if (!surface && !value) return undefined;
+
+  const who = agentName ?? "Agent";
+
+  if (surface && value) return `${who} requested ${surface} '${value}'.`;
+  if (surface) return `${who} requested ${surface} access.`;
+  return `${who} requested '${value}'.`;
+}
+
+/** Build a human-readable notification message from a permission prompt payload. */
+export function buildPermissionPromptMessage(payload: unknown): string {
+  const p = isRecord(payload) ? payload : {};
+
+  const agentName = cleanString(p.agentName);
+  const surface = cleanString(p.surface);
+  const value = cleanString(p.value);
+  const message = cleanString(p.message);
+
+  const parts: string[] = [];
+
+  const requestClause = buildRequestClause(agentName, surface, value);
+  if (requestClause) parts.push(requestClause);
+
+  // Only append the prompt text when it adds information beyond the clause.
+  if (message && message !== requestClause) parts.push(message);
+
+  if (parts.length === 0) parts.push("Pi is waiting for a permission decision.");
+
+  if (isForwarded(p.forwarding)) parts.push("(forwarded)");
+
+  return parts.join(" ");
+}

package/tui/gotify-setup.ts

@@ -7,7 +7,7 @@
  */
 
 import type { Component } from "@earendil-works/pi-tui";
-import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+import { matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { sendGotifyNotification } from "../platforms/gotify.js";
 import { updateConfig, loadConfig } from "../settings.js";
@@ -59,7 +59,7 @@ export class GotifySetupOverlay implements Component {
       case "instructions":
         if (data === "\r" || data === " ") {
           this.phase = this.serverUrl ? "app-token" : "server-url";
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -79,7 +79,7 @@ export class GotifySetupOverlay implements Component {
       case "priority":
         if (data === "\r" && this.isValidPriority()) {
           this.testConnection();
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.onClose?.();
         } else if (data === "\x7f" || data === "\b") {
           this.priority = this.priority.slice(0, -1);
@@ -92,7 +92,7 @@ export class GotifySetupOverlay implements Component {
         break;
 
       case "testing":
-        if (data === "\x1b") {
+        if (matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -100,7 +100,7 @@ export class GotifySetupOverlay implements Component {
       case "success":
       case "error":
       case "test-failed":
-        if (data === "\r" || data === " " || data === "\x1b") {
+        if (data === "\r" || data === " " || matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -137,7 +137,7 @@ export class GotifySetupOverlay implements Component {
     }
     if (data === "\r") {
       onEnter();
-    } else if (data === "\x1b") {
+    } else if (matchesKey(data, "escape")) {
       this.onClose?.();
     } else if (data === "\x7f" || data === "\b") {
       if (target === "server-url") {

package/tui/ntfy-setup.ts

@@ -7,7 +7,7 @@
  */
 
 import type { Component } from "@earendil-works/pi-tui";
-import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+import { matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { sendNtfyNotification } from "../platforms/ntfy.js";
 import { loadNtfyConfig, saveNtfyConfig, getNtfyConfigScope } from "../ntfy-config.js";
@@ -70,7 +70,7 @@ export class NtfySetupOverlay implements Component {
       case "instructions":
         if (data === "\r" || data === " ") {
           this.phase = "scope";
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -85,7 +85,7 @@ export class NtfySetupOverlay implements Component {
         } else if (data === "\r" || data === " ") {
           this.scope = this.scopeIndex === 1 ? "project" : "global";
           this.phase = this.serverUrl ? "topic" : "server-url";
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -114,7 +114,7 @@ export class NtfySetupOverlay implements Component {
       case "priority":
         if (data === "\r" && this.isValidPriority()) {
           this.testConnection();
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.onClose?.();
         } else if (data === "\x7f" || data === "\b") {
           this.priority = this.priority.slice(0, -1);
@@ -127,7 +127,7 @@ export class NtfySetupOverlay implements Component {
         break;
 
       case "testing":
-        if (data === "\x1b") {
+        if (matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -135,7 +135,7 @@ export class NtfySetupOverlay implements Component {
       case "success":
       case "error":
       case "test-failed":
-        if (data === "\r" || data === " " || data === "\x1b") {
+        if (data === "\r" || data === " " || matchesKey(data, "escape")) {
           this.onClose?.();
         }
         break;
@@ -173,7 +173,7 @@ export class NtfySetupOverlay implements Component {
     }
     if (data === "\r") {
       onEnter();
-    } else if (data === "\x1b") {
+    } else if (matchesKey(data, "escape")) {
       // Escape during token phase — skip token (optional field)
       if (target === "token") {
         this.phase = "priority";

package/tui/recap-model-selector.ts

@@ -6,7 +6,7 @@
  */
 
 import type { Component } from "@earendil-works/pi-tui";
-import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+import { matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { readModelCache, type CachedModel, boxInnerWidth } from "@pi-unipi/core";
 import { loadConfig, saveConfig } from "../settings.js";
@@ -56,7 +56,7 @@ export class RecapModelSelectorOverlay implements Component {
         this.filterMode = false;
         return;
       }
-      if (data === "\x1b") {
+      if (matchesKey(data, "escape")) {
         // Escape — clear filter and exit filter mode
         this.filter = "";
         this.filterMode = false;

package/tui/telegram-setup.ts

@@ -6,7 +6,7 @@
  */
 
 import type { Component } from "@earendil-works/pi-tui";
-import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
+import { matchesKey, truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { pollForChatId } from "../platforms/telegram.js";
 import { updateConfig } from "../settings.js";
@@ -48,7 +48,7 @@ export class TelegramSetupOverlay implements Component {
       case "instructions":
         if (data === "\r" || data === " ") {
           this.phase = "token";
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.cleanup();
           this.onClose?.();
         }
@@ -75,7 +75,7 @@ export class TelegramSetupOverlay implements Component {
         }
         if (data === "\r" && this.botToken.length > 0) {
           this.startPolling();
-        } else if (data === "\x1b") {
+        } else if (matchesKey(data, "escape")) {
           this.cleanup();
           this.onClose?.();
         } else if (data === "\x7f" || data === "\b") {
@@ -85,7 +85,7 @@ export class TelegramSetupOverlay implements Component {
         }
         break;
       case "polling":
-        if (data === "\x1b") {
+        if (matchesKey(data, "escape")) {
           this.cleanup();
           this.onClose?.();
         }
@@ -93,7 +93,7 @@ export class TelegramSetupOverlay implements Component {
       case "success":
       case "error":
       case "timeout":
-        if (data === "\r" || data === " " || data === "\x1b") {
+        if (data === "\r" || data === " " || matchesKey(data, "escape")) {
           this.cleanup();
           this.onClose?.();
         }