@pi-unipi/notify 2.1.3 → 2.2.1

package/README.md

@@ -28,6 +28,8 @@ Notify subscribes to Pi lifecycle events and routes notifications based on your
 | `agent_settled` | Off | Agent fully settles after retries, compaction, and queued continuations |
 | `memory_consolidated` | Off | Memory auto-saved |
 | `session_shutdown` | Off | Session ends |
+| `ask_user_prompt` | Off | Agent asked a question and is waiting for an answer |
+| `permission_request` | Off | A permission prompt is about to be shown (requires [`@gotgenes/pi-permission-system`](https://www.npmjs.com/package/@gotgenes/pi-permission-system)) |
 
 Notify registers with the info-screen dashboard, showing enabled platforms and last notification time. The footer subscribes to `NOTIFICATION_SENT` events to display notification stats.
 

package/events.ts

@@ -14,6 +14,7 @@ import { sendGotifyNotification } from "./platforms/gotify.js";
 import { sendTelegramNotification } from "./platforms/telegram.js";
 import { sendNtfyNotification } from "./platforms/ntfy.js";
 import { buildAskUserPromptMessage } from "./ask-user-prompt-message.js";
+import { buildPermissionPromptMessage } from "./permission-prompt-message.js";
 import { summarizeLastMessage } from "./summarize.js";
 
 // Event emitted by @juicesharp/rpiv-ask-user-question before showing its UI.
@@ -21,6 +22,13 @@ import { summarizeLastMessage } from "./summarize.js";
 // `./events` contract in npm.
 const ASK_USER_PROMPT_EVENT = "rpiv:ask-user:prompt" as const;
 
+// Event emitted by @gotgenes/pi-permission-system immediately before the
+// user-facing permission UI is invoked. Fires only for prompts a human must
+// answer — policy auto-allow/deny and session approvals do not emit it.
+// Kept as a local string (like the rpiv event above) because it belongs to a
+// third-party package rather than the unipi event contract.
+const PERMISSION_UI_PROMPT_EVENT = "permissions:ui_prompt" as const;
+
 /** Stored session context for modelRegistry access */
 let sessionCtx: ExtensionContext | null = null;
 
@@ -58,6 +66,7 @@ export const BUILTIN_EVENTS: Record<
   memory_consolidated: { hook: UNIPI_EVENTS.MEMORY_CONSOLIDATED, label: "Memory Saved" },
   session_shutdown: { hook: "session_shutdown", label: "Session End" },
   ask_user_prompt: { hook: UNIPI_EVENTS.ASK_USER_PROMPT, label: "Question Asked" },
+  permission_request: { hook: PERMISSION_UI_PROMPT_EVENT, label: "Permission Request" },
 };
 
 /**
@@ -298,6 +307,8 @@ function buildEventMessage(eventKey: string, payload: unknown): string {
       return "Session ending";
     case "ask_user_prompt":
       return buildAskUserPromptMessage(payload);
+    case "permission_request":
+      return buildPermissionPromptMessage(payload);
     default:
       return p.message ? String(p.message) : "Event occurred";
   }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-unipi/notify",
-  "version": "2.1.3",
+  "version": "2.2.1",
   "description": "Cross-platform notification extension for Pi — native OS, Gotify, and Telegram notifications for agent lifecycle events",
   "type": "module",
   "main": "index.ts",
@@ -24,15 +24,7 @@
     "typecheck": "tsc --noEmit"
   },
   "files": [
-    "index.ts",
-    "tools.ts",
-    "commands.ts",
-    "settings.ts",
-    "events.ts",
-    "ask-user-prompt-message.ts",
-    "ntfy-config.ts",
-    "summarize.ts",
-    "types.ts",
+    "*.ts",
     "platforms/*",
     "tui/*",
     "skills/**/*",
@@ -42,7 +34,7 @@
     "access": "public"
   },
   "dependencies": {
-    "@pi-unipi/core": "*",
+    "@pi-unipi/core": "2.2.0",
     "node-notifier": "^10.0.1"
   },
   "peerDependencies": {

package/permission-prompt-message.ts

@@ -0,0 +1,95 @@
+/**
+ * @pi-unipi/notify — Internal helper: build notification message from
+ * permission prompt event payloads.
+ *
+ * Handles the `permissions:ui_prompt` broadcast emitted by
+ * `@gotgenes/pi-permission-system` immediately before a human-facing
+ * permission prompt is shown.
+ *
+ * @internal — not part of the public API. Shared by the event listener and tests.
+ */
+
+export interface PermissionPromptEventPayload {
+  /** Correlation id for the permission request */
+  requestId?: string;
+  /** Originating subsystem of the request */
+  source?: string;
+  /** Surface being requested — e.g. "bash", "mcp", "read", "edit" */
+  surface?: string | null;
+  /** Command / path / tool / skill being requested */
+  value?: string | null;
+  /** Current or requesting agent, when available */
+  agentName?: string | null;
+  /** Human-readable permission prompt text */
+  message?: string;
+  /** Present for forwarded subagent prompts */
+  forwarding?: unknown;
+}
+
+function isRecord(value: unknown): value is Record<string, unknown> {
+  return value !== null && typeof value === "object";
+}
+
+/** Return a trimmed non-empty string, or `undefined` for anything else. */
+function cleanString(value: unknown): string | undefined {
+  if (typeof value !== "string") return undefined;
+  const trimmed = value.trim();
+  return trimmed.length > 0 ? trimmed : undefined;
+}
+
+/**
+ * `forwarding` is documented as "present for forwarded subagent prompts".
+ * Treat an explicitly falsy value (false / null / "" / 0) as not forwarded so
+ * that publishers which always include the key are handled correctly.
+ */
+function isForwarded(value: unknown): boolean {
+  if (value === undefined || value === null) return false;
+  if (typeof value === "boolean") return value;
+  if (typeof value === "string") return value.trim().length > 0;
+  if (typeof value === "number") return value !== 0;
+  if (Array.isArray(value)) return value.length > 0;
+  if (isRecord(value)) return Object.keys(value).length > 0;
+  return true;
+}
+
+/**
+ * Build the "what was requested" clause from `agentName` / `surface` / `value`.
+ * Returns `undefined` when there is nothing meaningful to say.
+ */
+function buildRequestClause(
+  agentName: string | undefined,
+  surface: string | undefined,
+  value: string | undefined,
+): string | undefined {
+  if (!surface && !value) return undefined;
+
+  const who = agentName ?? "Agent";
+
+  if (surface && value) return `${who} requested ${surface} '${value}'.`;
+  if (surface) return `${who} requested ${surface} access.`;
+  return `${who} requested '${value}'.`;
+}
+
+/** Build a human-readable notification message from a permission prompt payload. */
+export function buildPermissionPromptMessage(payload: unknown): string {
+  const p = isRecord(payload) ? payload : {};
+
+  const agentName = cleanString(p.agentName);
+  const surface = cleanString(p.surface);
+  const value = cleanString(p.value);
+  const message = cleanString(p.message);
+
+  const parts: string[] = [];
+
+  const requestClause = buildRequestClause(agentName, surface, value);
+  if (requestClause) parts.push(requestClause);
+
+  // Only append the prompt text when it adds information beyond the clause.
+  if (message && message !== requestClause) parts.push(message);
+
+  if (parts.length === 0) parts.push("Pi is waiting for a permission decision.");
+
+  if (isForwarded(p.forwarding)) parts.push("(forwarded)");
+
+  return parts.join(" ");
+}

package/settings.ts

@@ -28,6 +28,7 @@ export const DEFAULT_CONFIG: NotifyConfig = {
     memory_consolidated: { enabled: false, platforms: [] },
     session_shutdown: { enabled: false, platforms: [] },
     ask_user_prompt: { enabled: false, platforms: [] },
+    permission_request: { enabled: false, platforms: [] },
   },
   native: {
     enabled: true,

package/skills/configure-notify/SKILL.md

@@ -36,7 +36,9 @@ Help users configure the `@pi-unipi/notify` notification system.
     "agent_end": { "enabled": false, "platforms": [] },
     "agent_settled": { "enabled": false, "platforms": [] },
     "memory_consolidated": { "enabled": false, "platforms": [] },
-    "session_shutdown": { "enabled": false, "platforms": [] }
+    "session_shutdown": { "enabled": false, "platforms": [] },
+    "ask_user_prompt": { "enabled": false, "platforms": [] },
+    "permission_request": { "enabled": false, "platforms": [] }
   },
   "native": {
     "enabled": true,
@@ -155,9 +157,34 @@ ntfy uses dedicated `ntfy.json` files at both global and project scope, with ful
 | `agent_settled` | Off | Agent fully settles after retries, compaction, and queued continuations |
 | `memory_consolidated` | Off | Memory auto-saved |
 | `session_shutdown` | Off | Session ends |
+| `ask_user_prompt` | Off | Agent asked a question and is waiting for an answer |
+| `permission_request` | Off | A permission prompt is about to be shown |
 
 Each event can override `platforms` — empty array means use `defaultPlatforms`.
 
+### `permission_request`
+
+Fires on the `permissions:ui_prompt` broadcast from
+[`@gotgenes/pi-permission-system`](https://www.npmjs.com/package/@gotgenes/pi-permission-system),
+emitted immediately before the user-facing permission UI is invoked. Policy
+auto-allow, policy deny, session approvals, and infrastructure auto-allowed
+requests do **not** emit it, so this event does not produce notification spam.
+Forwarded subagent prompts are handled too — the parent UI session emits the
+event right before showing the forwarded dialog, and the notification is
+suffixed with `(forwarded)`.
+
+The notification is formatted defensively from the payload's `agentName`,
+`surface`, `value` and `message` fields:
+
+```text
+Pi — Permission Request
+Current agent requested bash 'npm test'. Allow this command?
+```
+
+Enable it when you run Pi in a background pane and don't want to miss a
+permission prompt. If the permission system is not installed the event simply
+never fires.
+
 ## Agent workflow
 
 ### Reading current config

package/tui/gotify-setup.ts

@@ -11,6 +11,7 @@ import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { sendGotifyNotification } from "../platforms/gotify.js";
 import { updateConfig, loadConfig } from "../settings.js";
+import { boxInnerWidth } from "@pi-unipi/core";
 
 type SetupPhase =
   | "instructions"
@@ -235,7 +236,7 @@ export class GotifySetupOverlay implements Component {
   }
 
   render(width: number): string[] {
-    const innerWidth = Math.max(22, width - 2);
+    const innerWidth = boxInnerWidth(width);
     const lines: string[] = [];
 
     lines.push(this.borderLine(innerWidth, "top"));

package/tui/ntfy-setup.ts

@@ -11,6 +11,7 @@ import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { sendNtfyNotification } from "../platforms/ntfy.js";
 import { loadNtfyConfig, saveNtfyConfig, getNtfyConfigScope } from "../ntfy-config.js";
+import { boxInnerWidth } from "@pi-unipi/core";
 
 type SetupPhase =
   | "instructions"
@@ -281,7 +282,7 @@ export class NtfySetupOverlay implements Component {
   }
 
   render(width: number): string[] {
-    const innerWidth = Math.max(22, width - 2);
+    const innerWidth = boxInnerWidth(width);
     const lines: string[] = [];
 
     lines.push(this.borderLine(innerWidth, "top"));

package/tui/recap-model-selector.ts

@@ -8,7 +8,7 @@
 import type { Component } from "@earendil-works/pi-tui";
 import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
-import { readModelCache, type CachedModel } from "@pi-unipi/core";
+import { readModelCache, type CachedModel, boxInnerWidth } from "@pi-unipi/core";
 import { loadConfig, saveConfig } from "../settings.js";
 
 const DEFAULT_MODEL = "openrouter/openai/gpt-oss-20b";
@@ -170,7 +170,7 @@ export class RecapModelSelectorOverlay implements Component {
   }
 
   render(width: number): string[] {
-    const innerWidth = Math.max(40, width - 2);
+    const innerWidth = boxInnerWidth(width);
     const lines: string[] = [];
 
     lines.push(this.borderLine(innerWidth, "top"));

package/tui/settings-overlay.ts

@@ -15,6 +15,7 @@ import {
 } from "../settings.js";
 import { loadNtfyConfig, saveNtfyConfig, getNtfyConfigScope } from "../ntfy-config.js";
 import type { NotifyConfig, NtfyConfig } from "../types.js";
+import { boxInnerWidth } from "@pi-unipi/core";
 
 /** Section types */
 type Section = "platforms" | "events" | "recap";
@@ -174,7 +175,7 @@ export class NotifySettingsOverlay implements Component {
   }
 
   render(width: number): string[] {
-    const innerWidth = Math.max(22, width - 2);
+    const innerWidth = boxInnerWidth(width);
     const lines: string[] = [];
 
     lines.push(this.borderLine(innerWidth, "top"));

package/tui/telegram-setup.ts

@@ -10,6 +10,7 @@ import { truncateToWidth, visibleWidth } from "@earendil-works/pi-tui";
 import type { Theme } from "@earendil-works/pi-coding-agent";
 import { pollForChatId } from "../platforms/telegram.js";
 import { updateConfig } from "../settings.js";
+import { boxInnerWidth } from "@pi-unipi/core";
 
 type SetupPhase = "instructions" | "token" | "polling" | "success" | "error" | "timeout";
 
@@ -224,7 +225,7 @@ export class TelegramSetupOverlay implements Component {
   }
 
   render(width: number): string[] {
-    const innerWidth = Math.max(22, width - 2);
+    const innerWidth = boxInnerWidth(width);
     const lines: string[] = [];
 
     lines.push(this.borderLine(innerWidth, "top"));