@pi-unipi/kanboard 3.0.0-alpha.2 → 3.0.0-alpha.21

package/src/settings.ts

@@ -2,7 +2,8 @@
  * @pi-unipi/kanboard — settings (hub section "Kanboard").
  */
 
-import { getSettings, registerCommandRunner, registerSettings, setSettings } from "@pi-unipi/core";
+import { existsSync, readFileSync } from "node:fs";
+import { getSettings, globalSettingsPath, projectSettingsPath, registerCommandRunner, registerSettings, setSettings } from "@pi-unipi/core";
 
 export type ChainGate = "in_review" | "done";
 
@@ -25,12 +26,20 @@ export interface KanboardSettings {
   requireAuth: boolean;
   /** Reuse <home>/token so board links survive daemon restarts. */
   keepToken: boolean;
-  /** Tasks one session may queue (0 = unlimited). */
-  queueMax: number;
   /** Distinct sessions running tasks per project (min 1). */
   maxSessions: number;
-  /** `add` calls allowed per -do/runner window (0 = unlimited). */
+  /** `add` calls allowed per turn (0 = unlimited). */
   turnAddLimit: number;
+  /** Task slots a /unipi:kanboard-do grants (each `start` uses one). */
+  doTasks: number;
+  /** Board writes a /unipi:kanboard-do grants. */
+  doWrites: number;
+  /** Whether a blocked-by-confusion task may ask the user (ask) or must
+   *  assume-and-note (avoid, the default). */
+  blocking: "avoid" | "ask";
+  /** Progress reminders when the agent works board tasks by hand: `start`
+   *  before the first edit, `finish` (or block) before the turn ends. */
+  reminders: boolean;
 }
 
 export const DEFAULT_SETTINGS: KanboardSettings = {
@@ -43,9 +52,12 @@ export const DEFAULT_SETTINGS: KanboardSettings = {
   openBrowser: false,
   requireAuth: false,
   keepToken: false,
-  queueMax: 10,
   maxSessions: 2,
   turnAddLimit: 20,
+  doTasks: 5,
+  doWrites: 10,
+  blocking: "avoid",
+  reminders: true,
 };
 
 export const KANBOARD_NAMESPACE = "kanboard";
@@ -59,11 +71,11 @@ export function registerKanboardSettings(): void {
   registerSettings({
     namespace: KANBOARD_NAMESPACE,
     label: "Kanboard",
-    defaults: DEFAULT_SETTINGS as unknown as Record<string, unknown>,
+    defaults: { ...DEFAULT_SETTINGS } as unknown as Record<string, unknown>,
     schema: [
       {
         title: "Kanboard",
-        description: "Deferred-work board: task runner, daemon and skill",
+        description: "The session's work board: daemon, -do budgets and skill",
         fields: [
           {
             key: "chainGate",
@@ -100,12 +112,16 @@ export function registerKanboardSettings(): void {
             label: "Keep the access token across restarts",
             description: "Reuse one token so board links stay valid; rotate it below.",
           },
-          { key: "queueMax", type: "number", label: "-do queue limit", min: 0, zeroLabel: "unlimited", description: "Tasks a session may queue for the runner" },
           { key: "maxSessions", type: "number", label: "Sessions working at once (per project)", min: 1, description: "Distinct sessions holding in_progress tasks" },
-          { key: "turnAddLimit", type: "number", label: "New tasks per turn", min: 0, zeroLabel: "unlimited", description: "`add` calls allowed per -do turn or runner task" },
-          { key: "open", type: "action", label: "Open board…", description: "Start the daemon and print the URL", command: ACTION_OPEN },
-          { key: "stopDaemon", type: "action", label: "Stop daemon", description: "Terminate the running kanboard daemon", command: ACTION_STOP_DAEMON },
-          { key: "rotateToken", type: "action", label: "Rotate access token", description: "Drop the persistent token; a fresh one mints on the next daemon start", command: ACTION_ROTATE_TOKEN },
+          { key: "turnAddLimit", type: "number", label: "New tasks per turn", min: 0, zeroLabel: "unlimited", description: "`add` calls allowed per turn" },
+          {
+            key: "reminders",
+            type: "boolean",
+            label: "Progress reminders",
+            description: "Remind the agent to `start` a mentioned Todo task before editing (text only, never blocks; off in child sessions)",
+          },
+          { key: "doTasks", type: "number", label: "-do task slots", min: 0, zeroLabel: "off", description: "Task slots a /unipi:kanboard-do grants; each `start` uses one" },
+          { key: "doWrites", type: "number", label: "-do write budget", min: 0, zeroLabel: "off", description: "Board writes a /unipi:kanboard-do grants (add, edit, link, order, move, note on tasks you don't hold)" },
         ],
       },
     ],
@@ -127,9 +143,18 @@ export function readKanboardSettings(cwd: string = process.cwd()): KanboardSetti
     openBrowser: raw.openBrowser === true,
     requireAuth: raw.requireAuth === true,
     keepToken: raw.keepToken === true,
-    queueMax: typeof raw.queueMax === "number" && raw.queueMax >= 0 ? raw.queueMax : DEFAULT_SETTINGS.queueMax,
     maxSessions: typeof raw.maxSessions === "number" && raw.maxSessions >= 1 ? raw.maxSessions : DEFAULT_SETTINGS.maxSessions,
     turnAddLimit: typeof raw.turnAddLimit === "number" && raw.turnAddLimit >= 0 ? raw.turnAddLimit : DEFAULT_SETTINGS.turnAddLimit,
+    // Migration: getSettings merges defaults, so a stored doCredits hides
+    // behind the doWrites default. Look at the stored layer for the legacy key
+    // (project first, then global) — the next settings write persists doWrites.
+    doTasks: typeof raw.doTasks === "number" && raw.doTasks >= 0 ? raw.doTasks : DEFAULT_SETTINGS.doTasks,
+    doWrites:
+      typeof raw.doWrites === "number" && raw.doWrites >= 0 && storedDoWritesSet(cwd)
+        ? raw.doWrites
+        : (storedLegacyDoCredits(cwd) ?? DEFAULT_SETTINGS.doWrites),
+    blocking: raw.blocking === "ask" ? "ask" : "avoid",
+    reminders: raw.reminders !== false,
   };
 }
 
@@ -137,6 +162,35 @@ export function writeKanboardSettings(patch: Partial<KanboardSettings>, cwd: str
   setSettings(KANBOARD_NAMESPACE, patch as unknown as Record<string, unknown>, "global", cwd);
 }
 
+/** Whether any stored layer carries an explicit doWrites (defaults don't count). */
+function storedDoWritesSet(cwd: string): boolean {
+  for (const file of [projectSettingsPath(cwd, KANBOARD_NAMESPACE), globalSettingsPath(KANBOARD_NAMESPACE)]) {
+    try {
+      if (!existsSync(file)) continue;
+      const parsed = JSON.parse(readFileSync(file, "utf-8")) as Record<string, unknown>;
+      if (typeof parsed.doWrites === "number") return true;
+    } catch {
+      // A corrupt file has no legacy value either.
+    }
+  }
+  return false;
+}
+
+/** The pre-slot doCredits value from the stored layers, if any. */
+function storedLegacyDoCredits(cwd: string): number | undefined {
+  for (const file of [projectSettingsPath(cwd, KANBOARD_NAMESPACE), globalSettingsPath(KANBOARD_NAMESPACE)]) {
+    try {
+      if (!existsSync(file)) continue;
+      const parsed = JSON.parse(readFileSync(file, "utf-8")) as Record<string, unknown>;
+      const value = parsed.doCredits;
+      if (typeof value === "number" && value >= 0) return value;
+    } catch {
+      // A corrupt file has no legacy value either.
+    }
+  }
+  return undefined;
+}
+
 /** Re-exported so index.ts and tests share one registration path. */
 export function registerKanboardRunners(runners: {
   open: (ctx: unknown) => void | Promise<void>;
@@ -150,9 +204,9 @@ export function registerKanboardRunners(runners: {
 
 /**
  * Limits reach the Rust CLI through the environment — refresh the process-wide
- * values so the agent's bash calls and the runner's CLI calls both see them.
+ * values so the agent's bash calls and spawned CLI calls both see them.
+ * (queueMax died with the runner; the binary's queue limit is untouched.)
  */
 export function applyLimitEnv(settings: KanboardSettings): void {
-  process.env.UNIPI_KANBOARD_QUEUE_MAX = String(settings.queueMax);
   process.env.UNIPI_KANBOARD_MAX_SESSIONS = String(settings.maxSessions);
 }

package/src/shapes.ts

@@ -32,6 +32,8 @@ export interface KanboardRun {
   mode?: string;
   goal?: string | null;
   started?: string;
+  /** "system" (runner claim) or "agent" (`start` self-claim). */
+  owner?: string;
 }
 
 export interface KanboardActivity {
@@ -43,6 +45,8 @@ export interface KanboardActivity {
 export interface KanboardTask {
   id: string;
   title: string;
+  /** Title derived from the first body line when `title` is empty (Rust `Task::display_title`). */
+  displayTitle?: string;
   body?: string;
   status: string;
   priority?: string;
@@ -113,6 +117,7 @@ export function asTask(command: string, value: unknown): KanboardTask {
     ...record,
     id: requireString(command, record, "id"),
     title: requireString(command, record, "title"),
+    displayTitle: typeof record.displayTitle === "string" ? record.displayTitle : undefined,
     status: requireString(command, record, "status"),
     deps: optionalArray<string>(record.deps) ?? [],
     activity: optionalArray<KanboardActivity>(record.activity) ?? [],