@pi-chamber/web 0.1.9 → 0.2.0

package/bin/cli.test.js

@@ -289,6 +289,17 @@ describe('cli args', () => {
     expect(parsed.options.port).toBe(3002);
   });
 
+  it('parses startup lan bind and port flags', () => {
+    const parsed = parseArgs(['startup', 'enable', '--lan', '--port', '3002', '--ui-password', 'secret']);
+
+    expect(parsed.command).toBe('startup');
+    expect(parsed.startupAction).toBe('enable');
+    expect(parsed.options.lan).toBe(true);
+    expect(parsed.options.host).toBe('0.0.0.0');
+    expect(parsed.options.port).toBe(3002);
+    expect(parsed.options.uiPassword).toBe('secret');
+  });
+
   it('parses tunnel auto-start server options', () => {
     const parsed = parseArgs(['tunnel', 'start', '--port', '3002', '--api-only', '--lan', '--ui-password', 'secret']);
 
@@ -321,6 +332,43 @@ describe('cli args', () => {
   });
 });
 
+describe('startup enable command helper', () => {
+  it('formats stored serve flags for a local port', async () => {
+    const { formatStartupServeCommand } = await import('./lib/cli-startup.js');
+    expect(formatStartupServeCommand({ port: 8080 })).toBe('pichamber serve --foreground --port 8080');
+  });
+
+  it('formats lan, port, and password flags without echoing the secret', async () => {
+    const { formatStartupServeCommand } = await import('./lib/cli-startup.js');
+    expect(formatStartupServeCommand({
+      lan: true,
+      host: '0.0.0.0',
+      port: 3002,
+      uiPassword: 'secret',
+    })).toBe('pichamber serve --foreground --port 3002 --lan --ui-password');
+  });
+
+  it('documents lan, port, and ui-password in startup help', async () => {
+    const { showStartupHelp } = await import('./lib/cli-args.js');
+    const lines = [];
+    const original = console.log;
+    console.log = (message) => {
+      lines.push(String(message));
+    };
+    try {
+      showStartupHelp();
+    } finally {
+      console.log = original;
+    }
+
+    const text = lines.join('\n');
+    expect(text).toContain('--lan');
+    expect(text).toContain('--port <port>');
+    expect(text).toContain('--ui-password');
+    expect(text).toContain('pichamber startup enable --lan --port 3002 --ui-password');
+  });
+});
+
 describe('cli API target resolution', () => {
   it('uses an explicit port without discovery', async () => {
     await expect(resolveTargetPort(

package/bin/lib/DOCUMENTATION.md

@@ -8,9 +8,9 @@ This directory contains non-entrypoint PiChamber CLI implementation. `../cli.js`
 - `commands-lifecycle.js`: stop and restart behavior.
 - `commands-status.js`: running-instance and tunnel status presentation.
 - `commands-logs.js`: log discovery, tailing, and follow behavior.
-- `commands-startup.js`: native startup service management.
+- `commands-startup.js`: native startup service management. `startup enable` stores serve flags (`--port`, `--lan`/`--host`, `--ui-password`, `--api-only`) in the login service. `pichamber startup --help` documents those flags. LAN binds require a UI password, matching `pichamber serve`.
 - `commands-connect-url.js`: authenticated direct/relay pairing links.
-- `commands-update.js`: package update and restart coordination.
+- `commands-update.js`: package update and restart coordination. Updates only a global install owned by the running CLI. A Linux user systemd unit is restarted in place; the command does not spawn a replacement server on the same port.
 - `commands-tunnel.js`: tunnel lifecycle and profile management.
 
 ## Rules

package/bin/lib/cli-args.js

@@ -522,7 +522,8 @@ EXAMPLES:
   pichamber serve --foreground # Start in foreground (for systemd Type=simple)
   pichamber connect-url --port 3000 --qr
   pichamber connect-url --server https://pichamber.example.com
-  pichamber startup enable     # Start PiChamber at user login
+  pichamber startup enable --lan --port 3002 --ui-password
+                               # Login service on LAN at 0.0.0.0:3002
   pichamber tunnel help        # Show tunnel lifecycle help
   pichamber logs               # Follow logs for latest running instance
 `);
@@ -535,25 +536,51 @@ function showStartupHelp() {
 USAGE:
   pichamber startup <SUBCOMMAND> [OPTIONS]
 
+DESCRIPTION:
+  Installs a user-login service that runs pichamber serve --foreground.
+  Flags passed to startup enable are stored in that service. Re-run enable
+  to replace the stored command.
+
 SUBCOMMANDS:
   status      Show startup integration status
   enable      Install and start native user startup integration
   disable     Stop and remove native user startup integration
 
-OPTIONS:
-  -p, --port              Web server port used by startup service
-  --host                  Bind address used by startup service
-  --ui-password           Protect browser UI with single password
-  --api-only              Start API routes only, without serving browser UI assets
-  --no-env-snapshot       Do not save current environment for startup service
-  --json                  Output machine-readable JSON
+ENABLE FLAGS:
+  These become the serve command the login service runs.
+
+  -p, --port <port>       Listen port (default: ${DEFAULT_PORT})
+  --host <address>        Bind address (default: 127.0.0.1, this machine only)
+  --hostname <address>    Alias for --host
+  --lan                   Same as --host 0.0.0.0 — reachable on your LAN/Wi-Fi
+  --ui-password [secret]  Required with --lan (omit the value to generate one)
+  --api-only              API routes only, no browser UI
+  --no-env-snapshot       Do not copy the current shell environment
+  --json                  Machine-readable JSON
   -q, --quiet             Suppress non-essential output
 
+LAN ACCESS:
+  Other devices on the same network need --lan and a UI password:
+
+    pichamber startup enable --lan --port 3002 --ui-password
+
+  Then open http://<this-computer-lan-ip>:3002 on those devices.
+
 EXAMPLES:
   pichamber startup enable
-  pichamber startup enable --port 3000
-  pichamber startup enable --port 3000 --api-only --host 0.0.0.0
-  pichamber startup status --json
+      This machine only, port ${DEFAULT_PORT}
+
+  pichamber startup enable --port 8080
+      This machine only, port 8080
+
+  pichamber startup enable --lan --port 3002 --ui-password
+      LAN/Wi-Fi on port 3002 (password generated if omitted)
+
+  pichamber startup enable --host 0.0.0.0 --port 3002 --ui-password secret
+      Same as --lan, with an explicit password
+
+  pichamber startup status
+  pichamber startup disable
 `);
 }
 

package/bin/lib/cli-startup.js

@@ -5,7 +5,7 @@ import { spawnSync } from 'child_process';
 import { DEFAULT_PORT } from './cli-args.js';
 import { EXIT_CODE, TunnelCliError } from './cli-errors.js';
 import { getDataDir } from './cli-paths.js';
-import { hasUiPasswordConfigured } from './cli-network.js';
+import { assertAuthenticatedNetworkExposure, hasUiPasswordConfigured, resolveServeUiPassword } from './cli-network.js';
 
 const STARTUP_SERVICE_ID = 'dev.pichamber.web';
 
@@ -161,11 +161,24 @@ function resolveCliEntrypoint() {
   const entry = typeof process.argv[1] === 'string' && process.argv[1].trim().length > 0
     ? process.argv[1]
     : path.join(__dirname, 'cli.js');
-  try {
-    return fs.realpathSync(entry);
-  } catch {
-    return path.resolve(entry);
+  // Keep the invoked path, not realpath(). pnpm/npm shims point at a stable
+  // node_modules entry; resolving through the store pins a versioned folder
+  // that breaks after `pichamber update`.
+  return path.resolve(entry);
+}
+
+function isUserStartupServiceActive() {
+  if (process.platform !== 'linux') return false;
+  const result = runStartupCommand('systemctl', ['--user', 'is-active', 'pichamber.service'], { allowFailure: true });
+  return (result.stdout || '').trim() === 'active';
+}
+
+function restartUserStartupService() {
+  if (process.platform !== 'linux') {
+    throw new Error('Startup service restart is only supported on Linux systemd user units.');
   }
+  runStartupCommand('systemctl', ['--user', 'daemon-reload']);
+  runStartupCommand('systemctl', ['--user', 'restart', 'pichamber.service']);
 }
 
 function buildStartupArgs(options = {}) {
@@ -179,6 +192,22 @@ function buildStartupArgs(options = {}) {
   return args;
 }
 
+function formatStartupServeCommand(options = {}) {
+  const parts = ['pichamber', 'serve', '--foreground', '--port', String(options.port || DEFAULT_PORT)];
+  if (options.lan === true && (typeof options.host !== 'string' || options.host === '0.0.0.0')) {
+    parts.push('--lan');
+  } else if (typeof options.host === 'string' && options.host.length > 0) {
+    parts.push('--host', options.host);
+  }
+  if (options.apiOnly === true) {
+    parts.push('--api-only');
+  }
+  if (options.explicitUiPassword === true || hasUiPasswordConfigured(options.uiPassword)) {
+    parts.push('--ui-password');
+  }
+  return parts.join(' ');
+}
+
 function writeMacosStartupWrapper(options = {}) {
   const wrapperPath = getMacosStartupWrapperPath();
   const args = buildStartupArgs(options).map(startupShellQuote).join(' ');
@@ -299,28 +328,43 @@ function enableStartupService(options = {}) {
     throw new TunnelCliError(`Startup integration is not supported on ${paths.platform}.`, EXIT_CODE.USAGE_ERROR);
   }
 
+  const resolvedUiPassword = resolveServeUiPassword(options);
+  const serveOptions = {
+    ...options,
+    ...(resolvedUiPassword.password ? { uiPassword: resolvedUiPassword.password } : {}),
+  };
+  assertAuthenticatedNetworkExposure({
+    host: serveOptions.host,
+    uiPassword: serveOptions.uiPassword,
+  });
+  const finish = (status) => (
+    resolvedUiPassword.generated === true
+      ? { ...status, generatedUiPassword: resolvedUiPassword.password }
+      : status
+  );
+
   if (paths.platform === 'macos') {
     removeStartupEnvFile();
     fs.mkdirSync(path.dirname(paths.servicePath), { recursive: true, mode: 0o700 });
     fs.mkdirSync(path.join(os.homedir(), 'Library', 'Logs', 'PiChamber'), { recursive: true, mode: 0o700 });
-    fs.writeFileSync(paths.servicePath, buildMacosLaunchAgent(options), { mode: 0o600 });
+    fs.writeFileSync(paths.servicePath, buildMacosLaunchAgent(serveOptions), { mode: 0o600 });
     runStartupCommand('/bin/launchctl', ['bootout', `gui/${process.getuid()}`, paths.servicePath], { allowFailure: true });
     runStartupCommand('/bin/launchctl', ['bootstrap', `gui/${process.getuid()}`, paths.servicePath]);
     runStartupCommand('/bin/launchctl', ['kickstart', '-k', `gui/${process.getuid()}/${STARTUP_SERVICE_ID}`], { allowFailure: true });
-    return getStartupStatus();
+    return finish(getStartupStatus());
   }
 
   if (paths.platform === 'linux') {
-    writeStartupEnvFile(options, { quoteValue: systemdEnvFileQuote });
+    writeStartupEnvFile(serveOptions, { quoteValue: systemdEnvFileQuote });
     fs.mkdirSync(path.dirname(paths.servicePath), { recursive: true, mode: 0o700 });
-    fs.writeFileSync(paths.servicePath, buildSystemdUserService(options), { mode: 0o600 });
+    fs.writeFileSync(paths.servicePath, buildSystemdUserService(serveOptions), { mode: 0o600 });
     runStartupCommand('systemctl', ['--user', 'daemon-reload']);
     runStartupCommand('systemctl', ['--user', 'enable', '--now', 'pichamber.service']);
-    return getStartupStatus();
+    return finish(getStartupStatus());
   }
 
-  const envFilePath = writeStartupEnvFile(options);
-  const startupArgs = buildStartupArgs(options).map(powershellQuote).join(', ');
+  const envFilePath = writeStartupEnvFile(serveOptions);
+  const startupArgs = buildStartupArgs(serveOptions).map(powershellQuote).join(', ');
   const powerShellCommand = [
     `$envFile=${powershellQuote(envFilePath)}`,
     `if (Test-Path $envFile) { Get-Content $envFile | ForEach-Object { if ($_ -match '^([^=]+)=(.*)$') { $v=$matches[2]; if ($v.StartsWith("'") -and $v.EndsWith("'")) { $v=$v.Substring(1,$v.Length-2).Replace("'\\''","'") }; [Environment]::SetEnvironmentVariable($matches[1], $v, 'Process') } } }`,
@@ -336,7 +380,7 @@ function enableStartupService(options = {}) {
     '/TR', taskArgs,
   ]);
   runStartupCommand('schtasks.exe', ['/Run', '/TN', STARTUP_SERVICE_ID], { allowFailure: true });
-  return getStartupStatus();
+  return finish(getStartupStatus());
 }
 
 function disableStartupService() {
@@ -368,4 +412,7 @@ export {
   getStartupStatus,
   enableStartupService,
   disableStartupService,
+  isUserStartupServiceActive,
+  restartUserStartupService,
+  formatStartupServeCommand,
 };

package/bin/lib/commands-startup.js

@@ -1,5 +1,5 @@
 import { EXIT_CODE, TunnelCliError } from './cli-errors.js';
-import { getStartupStatus, enableStartupService, disableStartupService } from './cli-startup.js';
+import { getStartupStatus, enableStartupService, disableStartupService, formatStartupServeCommand } from './cli-startup.js';
 import {
   intro as clackIntro,
   outro as clackOutro,
@@ -27,7 +27,18 @@ async function startupCommand(options, action = 'status') {
     status = getStartupStatus();
   }
 
-  const result = { action: normalized, ...status };
+  const generatedUiPassword = typeof status.generatedUiPassword === 'string' && status.generatedUiPassword.length > 0
+    ? status.generatedUiPassword
+    : undefined;
+  const { generatedUiPassword: _generatedUiPassword, ...publicStatus } = status;
+  void _generatedUiPassword;
+  const serveCommand = normalized === 'enable' ? formatStartupServeCommand(options) : undefined;
+  const result = {
+    action: normalized,
+    ...publicStatus,
+    ...(serveCommand ? { serveCommand } : {}),
+    ...(generatedUiPassword ? { password: generatedUiPassword } : {}),
+  };
   if (!result.supported) {
     throw new TunnelCliError(
       `Startup integration is not supported on ${result.platform}.`,
@@ -46,7 +57,7 @@ async function startupCommand(options, action = 'status') {
   }
 
   if (isQuietMode(options)) {
-    process.stdout.write(`startup ${result.enabled ? 'enabled' : 'disabled'} platform:${result.platform} supported:${result.supported ? 'yes' : 'no'}${result.servicePath ? ` path:${result.servicePath}` : ''}\n`);
+    process.stdout.write(`startup ${result.enabled ? 'enabled' : 'disabled'} platform:${result.platform} supported:${result.supported ? 'yes' : 'no'}${result.servicePath ? ` path:${result.servicePath}` : ''}${serveCommand ? ` command:${serveCommand}` : ''}${generatedUiPassword ? ` pass:${generatedUiPassword}` : ''}\n`);
     return;
   }
 
@@ -55,8 +66,12 @@ async function startupCommand(options, action = 'status') {
   if (typeof result.activeState === 'string') {
     logStatus(result.active ? 'success' : result.activeState === 'failed' ? 'error' : 'warning', `service ${result.activeState}`);
   }
-  if (normalized === 'enable') {
-    logStatus('info', 'service command', 'pichamber serve --foreground');
+  if (serveCommand) {
+    logStatus('info', 'service command', serveCommand);
+  }
+  if (generatedUiPassword) {
+    logStatus('success', 'UI password', generatedUiPassword);
+    logStatus('warning', 'save this password', 'it is not shown again');
   }
   clackOutro(normalized === 'status' ? 'status complete' : `${normalized} complete`);
 }

package/bin/lib/commands-update.js

@@ -6,6 +6,10 @@ import {
   removePidFile,
   stopInstanceProcess,
 } from './cli-process.js';
+import {
+  isUserStartupServiceActive as defaultIsUserStartupServiceActive,
+  restartUserStartupService as defaultRestartUserStartupService,
+} from './cli-startup.js';
 import {
   intro as clackIntro,
   outro as clackOutro,
@@ -17,7 +21,23 @@ import {
   logStatus,
 } from '../cli-output.js';
 
-function createUpdateCommand({ importFromFilePath, packageManagerPath, serveCommand }) {
+const UNOWNED_INSTALL_MESSAGE = [
+  'This PiChamber copy is not a global package-manager install.',
+  'Install one copy, then update that same copy:',
+  '  bun add -g @pi-chamber/web',
+  '  npm install -g @pi-chamber/web',
+  '  pnpm add -g @pi-chamber/web',
+  '  yarn global add @pi-chamber/web',
+].join('\n');
+
+function createUpdateCommand({
+  importFromFilePath,
+  packageManagerPath,
+  serveCommand,
+  isInsideSystemdService = () => Boolean(process.env.INVOCATION_ID) || Boolean(process.env.PICHAMBER_SYSTEMD_UNIT),
+  isUserStartupServiceActive = defaultIsUserStartupServiceActive,
+  restartUserStartupService = defaultRestartUserStartupService,
+}) {
   return async function updateCommand(options = {}) {
     const showOutput = shouldRenderHumanOutput(options);
     const updateSpin = createSpinner(options);
@@ -25,7 +45,7 @@ function createUpdateCommand({ importFromFilePath, packageManagerPath, serveComm
     const {
       checkForUpdates,
       executeUpdate,
-      detectPackageManager,
+      resolveTrustedUpdatePackageManager,
       getCurrentVersion,
     } = await importFromFilePath(packageManagerPath);
 
@@ -94,9 +114,8 @@ function createUpdateCommand({ importFromFilePath, packageManagerPath, serveComm
       throw new Error(msg);
     }
 
-    const isSystemdService = Boolean(process.env.INVOCATION_ID) || Boolean(process.env.PICHAMBER_SYSTEMD_UNIT);
-    if (isSystemdService) {
-      const msg = 'systemd deployments must be updated through package management and service restart (e.g. systemctl --user restart pichamber.service).';
+    if (isInsideSystemdService()) {
+      const msg = 'pichamber update cannot replace this process while it is running as a systemd service. Run it from a terminal instead.';
       updateSpin?.error('systemd service deployment detected');
       if (isJsonMode(options)) {
         printJson({
@@ -113,12 +132,29 @@ function createUpdateCommand({ importFromFilePath, packageManagerPath, serveComm
       throw new Error(msg);
     }
 
+    const pm = resolveTrustedUpdatePackageManager();
+    if (!pm) {
+      updateSpin?.error('No global package-manager install');
+      if (isJsonMode(options)) {
+        printJson({
+          currentVersion,
+          latestVersion: updateInfo.version || 'latest',
+          updated: false,
+          error: UNOWNED_INSTALL_MESSAGE,
+        });
+        return;
+      }
+      if (showOutput) {
+        clackOutro('update skipped');
+      }
+      throw new Error(UNOWNED_INSTALL_MESSAGE);
+    }
+
     if (showOutput && !updateSpin) {
-      logStatus('info', `updating ${updateInfo.currentVersion || currentVersion} -> ${updateInfo.version || 'latest'}`);
+      logStatus('info', `updating ${updateInfo.currentVersion || currentVersion} -> ${updateInfo.version || 'latest'} with ${pm}`);
     }
     updateSpin?.message(`Updating to ${updateInfo.version || 'latest'}...`);
 
-    const pm = detectPackageManager();
     const result = executeUpdate(pm, { silent: isJsonMode(options) || isQuietMode(options) });
     if (!result.success) {
       updateSpin?.error('Update failed');
@@ -128,34 +164,54 @@ function createUpdateCommand({ importFromFilePath, packageManagerPath, serveComm
       throw new Error(`Update failed with exit code ${result.exitCode}`);
     }
 
-    const runningInstances = await discoverRunningInstances();
-    if (runningInstances.length > 0) {
-      updateSpin?.message(`Stopping ${runningInstances.length} running instance(s)...`);
-      for (const instance of runningInstances) {
-        try {
-          const requested = await requestServerShutdown(instance.port, instance.host);
-          await stopInstanceProcess(instance.pid, {
-            shutdownWaitMs: requested ? 5000 : 0,
-            gracefulTimeoutMs: 2500,
-            forceTimeoutMs: 3000,
-          });
-          removePidFile(instance.pidFilePath);
-        } catch {
+    let restartedCount = 0;
+    let startupServiceRestarted = false;
+
+    if (isUserStartupServiceActive()) {
+      updateSpin?.message('Restarting systemd user service...');
+      try {
+        restartUserStartupService();
+        startupServiceRestarted = true;
+      } catch (error) {
+        const detail = error instanceof Error ? error.message : String(error);
+        const msg = `Package updated but failed to restart pichamber.service. Run: systemctl --user restart pichamber.service (${detail})`;
+        updateSpin?.error('Startup service restart failed');
+        if (showOutput) {
+          clackOutro('update incomplete');
         }
+        throw new Error(msg);
       }
+    } else {
+      const runningInstances = await discoverRunningInstances();
+      if (runningInstances.length > 0) {
+        updateSpin?.message(`Stopping ${runningInstances.length} running instance(s)...`);
+        for (const instance of runningInstances) {
+          try {
+            const requested = await requestServerShutdown(instance.port, instance.host);
+            await stopInstanceProcess(instance.pid, {
+              shutdownWaitMs: requested ? 5000 : 0,
+              gracefulTimeoutMs: 2500,
+              forceTimeoutMs: 3000,
+            });
+            removePidFile(instance.pidFilePath);
+          } catch {
+          }
+        }
 
-      updateSpin?.message(`Restarting ${runningInstances.length} instance(s)...`);
-      for (const instance of runningInstances) {
-        const storedOptions = readInstanceOptions(instance.instanceFilePath) || { port: instance.port };
-        await serveCommand({
-          port: storedOptions.port || instance.port,
-          host: storedOptions.host,
-          explicitPort: true,
-          uiPassword: storedOptions.uiPassword,
-          suppressStartupSummary: true,
-          suppressUiPasswordWarning: true,
-          quiet: true,
-        });
+        updateSpin?.message(`Restarting ${runningInstances.length} instance(s)...`);
+        for (const instance of runningInstances) {
+          const storedOptions = readInstanceOptions(instance.instanceFilePath) || { port: instance.port };
+          await serveCommand({
+            port: storedOptions.port || instance.port,
+            host: storedOptions.host,
+            explicitPort: true,
+            uiPassword: storedOptions.uiPassword,
+            suppressStartupSummary: true,
+            suppressUiPasswordWarning: true,
+            quiet: true,
+          });
+        }
+        restartedCount = runningInstances.length;
       }
     }
 
@@ -168,7 +224,9 @@ function createUpdateCommand({ importFromFilePath, packageManagerPath, serveComm
         currentVersion,
         latestVersion: updateInfo.version || 'latest',
         updated: true,
-        restartedCount: runningInstances.length,
+        packageManager: pm,
+        restartedCount,
+        startupServiceRestarted,
       });
       return;
     }
@@ -181,4 +239,3 @@ function createUpdateCommand({ importFromFilePath, packageManagerPath, serveComm
 }
 
 export { createUpdateCommand };
-

package/bin/lib/commands-update.test.js

@@ -21,22 +21,32 @@ async function withTempPiChamberDataDir(fn) {
   }
 }
 
+function createTestUpdateCommand(overrides = {}) {
+  const executeUpdate = overrides.executeUpdate || vi.fn(() => ({ success: true, exitCode: 0 }));
+  const serveCommand = overrides.serveCommand || vi.fn();
+  const restartUserStartupService = overrides.restartUserStartupService || vi.fn();
+  const updateCommand = createUpdateCommand({
+    packageManagerPath: '/fake/package-manager.js',
+    serveCommand,
+    isInsideSystemdService: overrides.isInsideSystemdService || (() => false),
+    isUserStartupServiceActive: overrides.isUserStartupServiceActive || (() => false),
+    restartUserStartupService,
+    importFromFilePath: vi.fn(async () => ({
+      checkForUpdates: overrides.checkForUpdates || vi.fn(async () => ({ available: true, version: '9.9.9' })),
+      resolveTrustedUpdatePackageManager: overrides.resolveTrustedUpdatePackageManager || vi.fn(() => 'npm'),
+      executeUpdate,
+      getCurrentVersion: vi.fn(() => '1.0.0'),
+    })),
+  });
+  return { updateCommand, executeUpdate, serveCommand, restartUserStartupService };
+}
+
 describe('update command', () => {
   it('uses the package-manager helpers on the update-available path', async () => {
     await withTempPiChamberDataDir(async () => {
       const originalWrite = process.stdout.write;
       process.stdout.write = vi.fn(() => true);
-      const executeUpdate = vi.fn(() => ({ success: true, exitCode: 0 }));
-      const updateCommand = createUpdateCommand({
-        packageManagerPath: '/fake/package-manager.js',
-        serveCommand: vi.fn(),
-        importFromFilePath: vi.fn(async () => ({
-          checkForUpdates: vi.fn(async () => ({ available: true, version: '9.9.9' })),
-          detectPackageManager: vi.fn(() => 'npm'),
-          executeUpdate,
-          getCurrentVersion: vi.fn(() => '1.0.0'),
-        })),
-      });
+      const { updateCommand, executeUpdate } = createTestUpdateCommand();
 
       try {
         await updateCommand({ json: true });
@@ -50,48 +60,53 @@ describe('update command', () => {
 
   it('handles failed update execution safely without touching instances', async () => {
     await withTempPiChamberDataDir(async () => {
-      const executeUpdate = vi.fn(() => ({ success: false, exitCode: 1 }));
-      const updateCommand = createUpdateCommand({
-        packageManagerPath: '/fake/package-manager.js',
-        serveCommand: vi.fn(),
-        importFromFilePath: vi.fn(async () => ({
-          checkForUpdates: vi.fn(async () => ({ available: true, version: '9.9.9' })),
-          detectPackageManager: vi.fn(() => 'npm'),
-          executeUpdate,
-          getCurrentVersion: vi.fn(() => '1.0.0'),
-        })),
+      const { updateCommand, executeUpdate, serveCommand, restartUserStartupService } = createTestUpdateCommand({
+        executeUpdate: vi.fn(() => ({ success: false, exitCode: 1 })),
       });
 
       await expect(updateCommand({ quiet: true })).rejects.toThrow('Update failed with exit code 1');
       expect(executeUpdate).toHaveBeenCalledWith('npm', { silent: true });
+      expect(serveCommand).not.toHaveBeenCalled();
+      expect(restartUserStartupService).not.toHaveBeenCalled();
     });
   });
 
   it('skips in-app update when running inside a systemd service unit', async () => {
     await withTempPiChamberDataDir(async () => {
-      const prevInvocationId = process.env.INVOCATION_ID;
-      process.env.INVOCATION_ID = 'test-invocation-123';
-      try {
-        const executeUpdate = vi.fn();
-        const updateCommand = createUpdateCommand({
-          packageManagerPath: '/fake/package-manager.js',
-          serveCommand: vi.fn(),
-          importFromFilePath: vi.fn(async () => ({
-            checkForUpdates: vi.fn(async () => ({ available: true, version: '9.9.9' })),
-            detectPackageManager: vi.fn(() => 'npm'),
-            executeUpdate,
-            getCurrentVersion: vi.fn(() => '1.0.0'),
-          })),
-        });
+      const { updateCommand, executeUpdate } = createTestUpdateCommand({
+        isInsideSystemdService: () => true,
+      });
+
+      await expect(updateCommand({ quiet: true })).rejects.toThrow('pichamber update cannot replace this process while it is running as a systemd service');
+      expect(executeUpdate).not.toHaveBeenCalled();
+    });
+  });
+
+  it('refuses to guess a package manager when the running copy is not a global install', async () => {
+    await withTempPiChamberDataDir(async () => {
+      const { updateCommand, executeUpdate } = createTestUpdateCommand({
+        resolveTrustedUpdatePackageManager: vi.fn(() => null),
+      });
 
-        await expect(updateCommand({ quiet: true })).rejects.toThrow('systemd deployments must be updated through package management');
-        expect(executeUpdate).not.toHaveBeenCalled();
+      await expect(updateCommand({ quiet: true })).rejects.toThrow('This PiChamber copy is not a global package-manager install.');
+      expect(executeUpdate).not.toHaveBeenCalled();
+    });
+  });
+
+  it('restarts a systemd user unit instead of spawning a new server', async () => {
+    await withTempPiChamberDataDir(async () => {
+      const originalWrite = process.stdout.write;
+      process.stdout.write = vi.fn(() => true);
+      const { updateCommand, serveCommand, restartUserStartupService } = createTestUpdateCommand({
+        isUserStartupServiceActive: () => true,
+      });
+
+      try {
+        await updateCommand({ json: true });
+        expect(restartUserStartupService).toHaveBeenCalledTimes(1);
+        expect(serveCommand).not.toHaveBeenCalled();
       } finally {
-        if (typeof prevInvocationId === 'string') {
-          process.env.INVOCATION_ID = prevInvocationId;
-        } else {
-          delete process.env.INVOCATION_ID;
-        }
+        process.stdout.write = originalWrite;
       }
     });
   });

package/dist/assets/CommitSection-LewzHfDH.js

@@ -0,0 +1 @@
+import{R as C,j as e}from"./vendor-react-DYyjh7Q0.js";import{f as z,T as y,y as _,B as c,I as a,z as v,aW as I}from"./SessionSwitcherDropdown-DNjCJjzF.js";import{u as H}from"./index-DQr8-8RF.js";const N=38,h=200,k=({value:t,onChange:o,placeholder:m,disabled:i=!1,hasTouchInput:r=!1,isMobile:u=!1})=>{const n=C.useRef(null),j=H(s=>s.inputSpellcheckEnabled);return C.useLayoutEffect(()=>{const s=n.current;if(!s)return;const l=document.activeElement===s,d=()=>{s.style.height=`${N}px`;const p=s.scrollHeight,x=Math.min(Math.max(p,N),h);s.style.height=`${x}px`,s.style.overflowY=p>h?"auto":"hidden",p>h&&!l&&(s.scrollTop=s.scrollHeight)};d();const f=window.requestAnimationFrame(d);return()=>{window.cancelAnimationFrame(f)}},[t]),e.jsx("textarea",{ref:n,value:t,onChange:s=>o(s.target.value),placeholder:m??"Commit message",rows:1,disabled:i,autoCorrect:r?"on":"off",autoCapitalize:r?"sentences":"off",spellCheck:u||j,className:z("w-full rounded-lg border border-border/60 bg-surface-elevated px-3 py-2 typography-ui-label text-foreground placeholder:text-muted-foreground","resize-none outline-none transition-[border-color,box-shadow] duration-150","focus-visible:ring-2 focus-visible:ring-[var(--interactive-focus-ring)]",i&&"opacity-50"),style:{minHeight:N,maxHeight:h}})},F=({highlights:t,onInsert:o})=>{if(t.length===0)return null;const m=()=>{o(t)};return e.jsxs("div",{className:"space-y-2 rounded-xl border border-border/60 bg-transparent px-3 py-2",children:[e.jsxs("div",{className:"flex items-center justify-between gap-2",children:[e.jsx("p",{className:"typography-micro text-muted-foreground",children:"Highlights"}),e.jsxs(y,{children:[e.jsx(_,{asChild:!0,children:e.jsx(c,{variant:"ghost",size:"icon",className:"size-6",onClick:m,"aria-label":"Insert  aria label",children:e.jsx(a,{name:"arrow-down",className:"size-4"})})}),e.jsx(v,{sideOffset:8,children:"Insert  tooltip"})]})]}),e.jsx("ul",{className:"space-y-1",children:t.map((i,r)=>e.jsx("li",{className:"typography-meta text-foreground",children:i},`${i}-${r}`))})]})},q=({stagedCount:t,commitMessage:o,onCommitMessageChange:m,generatedHighlights:i,onInsertHighlights:r,onGenerateMessage:u,isGeneratingMessage:n,onCommit:j,onCommitAndPush:s,commitAction:l,hasPendingIndexMutation:d=!1,gitmojiEnabled:f,onOpenGitmojiPicker:p})=>{const x=t>0,b=o.trim()&&x&&l===null&&!d,{isMobile:g,hasTouchInput:w}=I();return e.jsxs("section",{className:"border-0 bg-transparent rounded-none",children:[e.jsxs("div",{className:"flex w-full items-baseline gap-2 px-0 pt-2 pb-1",children:[e.jsx("h3",{className:"typography-ui-header font-semibold text-foreground",children:"Commit"}),x?null:e.jsx("span",{className:"min-w-0 truncate typography-meta text-muted-foreground",children:"Stage files to enable commit."})]}),e.jsxs("div",{className:"flex flex-col gap-3 px-0 pt-1 pb-3",children:[e.jsx(F,{highlights:i,onInsert:r}),e.jsx(k,{value:o,onChange:m,placeholder:"Commit message",disabled:l!==null,hasTouchInput:w,isMobile:g}),f&&e.jsxs(c,{variant:"outline",size:"sm",onClick:p,className:"w-fit",type:"button",children:[e.jsx(a,{name:"emotion-happy",className:"size-4"}),"Add gitmoji"]}),e.jsxs("div",{className:"@container/commit-actions flex items-center gap-2 min-w-0",children:[e.jsxs(c,{variant:"outline",size:"sm",onClick:u,disabled:n||l!==null||d||t===0,type:"button","aria-label":"Generate commit message",className:"commit-actions__btn",children:[n?e.jsx(a,{name:"loader-4",className:"size-4 animate-spin"}):e.jsx(a,{name:"ai-generate-2",className:"size-4 text-primary"}),e.jsx("span",{className:"commit-actions__label",children:"Generate"})]}),e.jsx("div",{className:"flex-1"}),e.jsx(c,{size:"sm",variant:"outline",onClick:j,disabled:!b||n,className:"commit-actions__btn whitespace-nowrap","aria-label":"Commit  aria label",children:l==="commit"?e.jsxs(e.Fragment,{children:[e.jsx(a,{name:"loader-4",className:"size-4 animate-spin"}),e.jsx("span",{className:"commit-actions__label",children:"Committing..."})]}):e.jsxs(e.Fragment,{children:[e.jsx(a,{name:"git-commit",className:"size-4"}),e.jsx("span",{className:"commit-actions__label",children:"Commit"})]})}),g?e.jsxs(y,{children:[e.jsx(_,{asChild:!0,children:e.jsx(c,{variant:"default",size:"sm",onClick:()=>s(),disabled:!b||n,className:"h-7 w-7 p-0","aria-label":"Commit and sync",children:l==="commitAndPush"?e.jsx(a,{name:"loader-4",className:"size-4 animate-spin"}):e.jsx(a,{name:"arrow-up",className:"size-3.5"})})}),e.jsx(v,{side:"top",children:e.jsx("p",{children:"Commit & sync"})})]}):e.jsx(c,{size:"sm",variant:"default",onClick:()=>s(),disabled:!b||n,className:"commit-actions__btn","aria-label":"Commit and sync",children:l==="commitAndPush"?e.jsxs(e.Fragment,{children:[e.jsx(a,{name:"loader-4",className:"size-4 animate-spin"}),e.jsx("span",{className:"commit-actions__label commit-actions__label--push",children:"Syncing..."})]}):e.jsxs(e.Fragment,{children:[e.jsx(a,{name:"arrow-up",className:"size-3.5"}),e.jsx("span",{className:"commit-actions__label commit-actions__label--push",children:"Commit & sync"})]})})]})]})]})};export{q as C};