@pi-archimedes/subagent 2.10.1 → 2.10.2

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-archimedes/subagent",
-  "version": "2.10.1",
+  "version": "2.10.2",
   "repository": {
     "type": "git",
     "url": "https://github.com/danielcherubini/pi-archimedes.git"
@@ -15,8 +15,8 @@
   ],
   "main": "./src/index.ts",
   "dependencies": {
-    "@pi-archimedes/core": "2.10.1",
-    "@pi-archimedes/todo": "2.10.1"
+    "@pi-archimedes/core": "2.10.2",
+    "@pi-archimedes/todo": "2.10.2"
   },
   "peerDependencies": {
     "@earendil-works/pi-ai": ">=0.1.0",

package/src/local-config.test.ts

@@ -5,6 +5,9 @@ import {
   existsSync,
   readdirSync,
   writeFileSync,
+  readFileSync,
+  lstatSync,
+  symlinkSync,
 } from "node:fs";
 import { join } from "node:path";
 import { tmpdir } from "node:os";
@@ -15,6 +18,9 @@ import {
   writeLocalThinking,
   deleteLocalThinking,
   deleteLocalAgent,
+  writeLocalField,
+  deleteLocalField,
+  setLocalConfig,
 } from "./local-config.js";
 
 // Redirect getAgentDir() to a temp directory via PI_CODING_AGENT_DIR.
@@ -204,4 +210,53 @@ describe("local-config", () => {
     expect(files).not.toContain("agents.local.json.tmp");
     expect(existsSync(join(testDir, "agents.local.json"))).toBe(true);
   });
+
+  describe("symlink preservation", () => {
+    const linkPath = join(testDir, "agents.local.json");
+    const targetPath = join(testDir, "agents.local.json.target");
+
+    // Fresh per-test setup: a target file pre-seeded with { "preexisting":
+    // "keep-me" } and a symlink agents.local.json → target.
+    beforeEach(() => {
+      rmSync(linkPath, { force: true });
+      rmSync(join(testDir, "agents.local.json.tmp"), { force: true });
+      rmSync(targetPath, { force: true });
+      writeFileSync(targetPath, JSON.stringify({ preexisting: "keep-me" }), "utf-8");
+      symlinkSync(targetPath, linkPath);
+    });
+
+    it("writeLocalField preserves the symlink and updates the target", () => {
+      writeLocalField("general", "model", "test-model");
+      expect(lstatSync(linkPath).isSymbolicLink()).toBe(true);
+      const data = JSON.parse(readFileSync(targetPath, "utf-8"));
+      expect(data.general.model).toBe("test-model");
+      expect(data.preexisting).toBe("keep-me");
+    });
+
+    it("deleteLocalField preserves the symlink and removes the entry", () => {
+      writeLocalField("general", "model", "test-model");
+      deleteLocalField("general", "model");
+      expect(lstatSync(linkPath).isSymbolicLink()).toBe(true);
+      const data = JSON.parse(readFileSync(targetPath, "utf-8"));
+      expect(data.general).toBeUndefined();
+      expect(data.preexisting).toBe("keep-me");
+    });
+
+    it("regular file still works (no symlink regression) and leaves no .tmp", () => {
+      rmSync(linkPath);
+      writeFileSync(linkPath, JSON.stringify({ preexisting: "keep-me" }), "utf-8");
+      writeLocalField("general", "thinking", "high");
+      expect(lstatSync(linkPath).isSymbolicLink()).toBe(false);
+      const data = JSON.parse(readFileSync(linkPath, "utf-8"));
+      expect(data.general.thinking).toBe("high");
+      expect(readdirSync(testDir)).not.toContain("agents.local.json.tmp");
+    });
+
+    it("setLocalConfig is a full replace through the symlink", () => {
+      setLocalConfig({ alpha: { model: "m" } });
+      expect(lstatSync(linkPath).isSymbolicLink()).toBe(true);
+      const data = JSON.parse(readFileSync(targetPath, "utf-8"));
+      expect(data).toEqual({ alpha: { model: "m" } });
+    });
+  });
 });

package/src/local-config.ts

@@ -1,12 +1,7 @@
-import {
-  readFileSync,
-  writeFileSync,
-  existsSync,
-  renameSync,
-  unlinkSync,
-} from "node:fs";
+import { readFileSync, existsSync } from "node:fs";
 import { join } from "node:path";
 import { getAgentDir } from "@earendil-works/pi-coding-agent";
+import { writeAtomicPreservingSymlinks } from "@pi-archimedes/core/settings-io";
 
 /** Fields that can be overridden per agent in agents.local.json. */
 export type LocalField = "model" | "thinking";
@@ -35,25 +30,12 @@ export function readLocalConfig(): LocalConfig {
   return readLocalConfigRaw();
 }
 
-/**
- * Write the full config atomically: write to .tmp then rename.
- * Falls back to a direct write if rename fails; cleans up .tmp on failure.
- * Follows the pattern in packages/core/src/settings-io.ts.
- */
+/** Write the full config atomically (backup+restore safe). Delegates to the shared core helper, which preserves symlinked config files. */
 function writeConfigAtomic(config: LocalConfig): void {
-  const path = getLocalConfigPath();
-  const tmpPath = path + ".tmp";
-  writeFileSync(tmpPath, JSON.stringify(config, null, 2), "utf-8");
-  try {
-    renameSync(tmpPath, path);
-  } catch {
-    try {
-      unlinkSync(tmpPath);
-    } catch {
-      // ignore — tmp file may not exist
-    }
-    writeFileSync(path, JSON.stringify(config, null, 2), "utf-8");
-  }
+  writeAtomicPreservingSymlinks(
+    getLocalConfigPath(),
+    JSON.stringify(config, null, 2),
+  );
 }
 
 /** Set the local override for a field on a given agent, preserving existing entries. */