@pi-archimedes/session-name 2.8.0 → 2.9.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-archimedes/session-name",
-  "version": "2.8.0",
+  "version": "2.9.0",
   "repository": {
     "type": "git",
     "url": "https://github.com/danielcherubini/pi-archimedes.git"
@@ -18,17 +18,17 @@
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@pi-archimedes/core": "2.8.0"
+    "@pi-archimedes/core": "2.9.0"
   },
   "peerDependencies": {
-    "@earendil-works/pi-coding-agent": ">=0.1.0",
-    "@earendil-works/pi-ai": ">=0.1.0",
-    "@earendil-works/pi-tui": ">=0.1.0"
+    "@earendil-works/pi-coding-agent": ">=0.86.0",
+    "@earendil-works/pi-ai": ">=0.86.0",
+    "@earendil-works/pi-tui": ">=0.86.0"
   },
   "devDependencies": {
-    "@earendil-works/pi-ai": "^0.85.1",
-    "@earendil-works/pi-coding-agent": "^0.85.1",
-    "@earendil-works/pi-tui": "^0.85.1",
+    "@earendil-works/pi-ai": "^0.87.0",
+    "@earendil-works/pi-coding-agent": "^0.87.0",
+    "@earendil-works/pi-tui": "^0.87.0",
     "typescript": "^6.0.0"
   },
   "pi": {

package/src/index.test.ts

@@ -0,0 +1,187 @@
+import { describe, expect, it, vi } from "vitest";
+import { generateTitle } from "./index.js";
+
+function createMockPi(sessionName: string | undefined = undefined) {
+  let currentName = sessionName;
+  return {
+    getSessionName: vi.fn(() => currentName),
+    setSessionName: vi.fn((name: string) => {
+      currentName = name;
+    }),
+    on: vi.fn(),
+  };
+}
+
+function createMockCtx(options: {
+  streamSimpleResult?: any;
+  branch?: any[];
+  model?: any;
+  hasConfiguredAuth?: boolean;
+}) {
+  const defaultBranch = [
+    {
+      type: "message",
+      entry: undefined,
+      message: {
+        role: "user",
+        content: [{ type: "text", text: "How do I fix this bug?" }],
+      },
+    },
+    {
+      type: "message",
+      entry: undefined,
+      message: {
+        role: "assistant",
+        content: [{ type: "text", text: "Here is how you fix the bug." }],
+      },
+    },
+  ];
+
+  const defaultModel = { provider: "anthropic", id: "claude-3-5-sonnet" };
+
+  return {
+    sessionManager: {
+      getBranch: vi.fn(() => options.branch ?? defaultBranch),
+      getSessionFile: vi.fn(() => "/tmp/session.json"),
+    },
+    modelRegistry: {
+      getAll: vi.fn(() => [defaultModel]),
+      hasConfiguredAuth: vi.fn(() => options.hasConfiguredAuth ?? true),
+      streamSimple: vi.fn(() => ({
+        result: vi.fn().mockResolvedValue(
+          options.streamSimpleResult ?? {
+            stopReason: "stop",
+            content: [{ type: "text", text: "Bug Fix Discussion" }],
+          },
+        ),
+      })),
+    },
+    model: options.model ?? defaultModel,
+  };
+}
+
+describe("generateTitle", () => {
+  it("generates title, trims quotes and whitespace, and calls pi.setSessionName", async () => {
+    const pi = createMockPi();
+    const ctx = createMockCtx({
+      streamSimpleResult: {
+        stopReason: "stop",
+        content: [{ type: "text", text: '  "Fixing the Login Bug" \n' }],
+      },
+    });
+    const onSuccess = vi.fn();
+    const onFailure = vi.fn();
+
+    await generateTitle(pi as any, ctx as any, onSuccess, onFailure);
+
+    expect(ctx.modelRegistry.streamSimple).toHaveBeenCalledTimes(1);
+    expect(ctx.modelRegistry.streamSimple).toHaveBeenCalledWith(
+      ctx.model,
+      expect.objectContaining({
+        messages: [
+          expect.objectContaining({
+            role: "user",
+            content: [
+              expect.objectContaining({
+                type: "text",
+                text: expect.stringContaining("How do I fix this bug?"),
+              }),
+            ],
+          }),
+        ],
+      }),
+      expect.objectContaining({
+        reasoning: "minimal",
+        cacheRetention: "none",
+        sessionId: expect.any(String),
+      }),
+    );
+    expect(pi.setSessionName).toHaveBeenCalledWith("Fixing the Login Bug");
+    expect(onSuccess).toHaveBeenCalledTimes(1);
+    expect(onFailure).not.toHaveBeenCalled();
+  });
+
+  it("triggers onFailure when streamSimple returns stopReason === 'error'", async () => {
+    const pi = createMockPi();
+    const ctx = createMockCtx({
+      streamSimpleResult: {
+        stopReason: "error",
+        content: [],
+      },
+    });
+    const onSuccess = vi.fn();
+    const onFailure = vi.fn();
+
+    await generateTitle(pi as any, ctx as any, onSuccess, onFailure);
+
+    expect(ctx.modelRegistry.streamSimple).toHaveBeenCalledTimes(1);
+    expect(pi.setSessionName).not.toHaveBeenCalled();
+    expect(onSuccess).not.toHaveBeenCalled();
+    expect(onFailure).toHaveBeenCalledTimes(1);
+  });
+
+  it("does not call onFailure when streamSimple returns stopReason === 'aborted'", async () => {
+    const pi = createMockPi();
+    const ctx = createMockCtx({
+      streamSimpleResult: {
+        stopReason: "aborted",
+        content: [{ type: "text", text: "Partial Title" }],
+      },
+    });
+    const onSuccess = vi.fn();
+    const onFailure = vi.fn();
+
+    await generateTitle(pi as any, ctx as any, onSuccess, onFailure);
+
+    expect(ctx.modelRegistry.streamSimple).toHaveBeenCalledTimes(1);
+    expect(pi.setSessionName).not.toHaveBeenCalled();
+    expect(onSuccess).not.toHaveBeenCalled();
+    expect(onFailure).not.toHaveBeenCalled();
+  });
+
+  it("skips title generation without incrementing failCount if model lacks configured auth", async () => {
+    const pi = createMockPi();
+    const ctx = createMockCtx({
+      hasConfiguredAuth: false,
+    });
+    const onSuccess = vi.fn();
+    const onFailure = vi.fn();
+
+    await generateTitle(pi as any, ctx as any, onSuccess, onFailure);
+
+    expect(ctx.modelRegistry.hasConfiguredAuth).toHaveBeenCalledWith(ctx.model);
+    expect(ctx.modelRegistry.streamSimple).not.toHaveBeenCalled();
+    expect(pi.setSessionName).not.toHaveBeenCalled();
+    expect(onSuccess).not.toHaveBeenCalled();
+    expect(onFailure).not.toHaveBeenCalled();
+  });
+
+  it("aborts without setting session name if race condition occurs (session name already set)", async () => {
+    let getSessionNameCallCount = 0;
+    const pi = {
+      getSessionName: vi.fn(() => {
+        getSessionNameCallCount++;
+        // First check in generateTitle before setting name returns existing name
+        // (Wait, step 8 checks if (pi.getSessionName()) return;)
+        return "Already Named";
+      }),
+      setSessionName: vi.fn(),
+      on: vi.fn(),
+    };
+    const ctx = createMockCtx({
+      streamSimpleResult: {
+        stopReason: "stop",
+        content: [{ type: "text", text: "New Title" }],
+      },
+    });
+    const onSuccess = vi.fn();
+    const onFailure = vi.fn();
+
+    await generateTitle(pi as any, ctx as any, onSuccess, onFailure);
+
+    expect(ctx.modelRegistry.streamSimple).toHaveBeenCalledTimes(1);
+    expect(pi.setSessionName).not.toHaveBeenCalled();
+    expect(onSuccess).not.toHaveBeenCalled();
+    expect(onFailure).not.toHaveBeenCalled();
+  });
+});

package/src/index.ts

@@ -1,5 +1,3 @@
-import { complete } from "@earendil-works/pi-ai/compat";
-import type { ProviderHeaders } from "@earendil-works/pi-ai";
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
 import { loadConfig } from "@pi-archimedes/core/settings-io";
 import type { SettingItem } from "@earendil-works/pi-tui";
@@ -76,7 +74,7 @@ export function resolveModel<T extends { provider: string; id: string }>(
  * Generate and set a session title. Runs asynchronously without blocking
  * the agent_end handler so the UI stays responsive.
  */
-async function generateTitle(
+export async function generateTitle(
   pi: ExtensionAPI,
   ctx: ExtensionContext,
   onSuccess: () => void,
@@ -151,31 +149,37 @@ async function generateTitle(
     const model = settingsModel ?? ctx.model;
     if (!model) return;
 
-    // 4. Check auth
+    // 4. Check auth — skip without incrementing failCount if not configured
     if (!ctx.modelRegistry.hasConfiguredAuth(model)) return;
 
-    // 5. Get API key and headers
-    const auth = await ctx.modelRegistry.getApiKeyAndHeaders(model);
-    if (!auth.ok) return;
-
-    // 6. Make API call
-    const opts: { reasoning: "minimal"; cacheRetention: "none"; sessionId: string; apiKey?: string; headers?: ProviderHeaders } = {
-      reasoning: "minimal",
-      cacheRetention: "none",
-      sessionId: crypto.randomUUID(),
-    };
-    if (auth.apiKey) opts.apiKey = auth.apiKey;
-    if (auth.headers) opts.headers = auth.headers;
-
-    const response = await complete(model, {
-      messages: [
-        {
-          role: "user" as const,
-          content: [{ type: "text" as const, text: titlePrompt }],
-          timestamp: Date.now(),
-        },
-      ],
-    }, opts);
+    // 5. Stream simple with built-in auth resolution
+    const stream = ctx.modelRegistry.streamSimple(
+      model,
+      {
+        messages: [
+          {
+            role: "user",
+            content: [{ type: "text", text: titlePrompt }],
+            timestamp: Date.now(),
+          },
+        ],
+      },
+      {
+        reasoning: "minimal",
+        cacheRetention: "none",
+        sessionId: crypto.randomUUID(),
+      },
+    );
+
+    const response = await stream.result();
+    // User/system cancellation is not a failure; don't burn the retry budget
+    if (response.stopReason === "aborted") {
+      return;
+    }
+    if (response.stopReason === "error") {
+      onFailure();
+      return;
+    }
 
     // 7. Extract and clean title
     const title = response.content