@pi-archimedes/session-name 2.10.1 → 2.10.3

package/README.md

@@ -31,7 +31,8 @@ After installing Pi, choose one installation command above, then `cd` into your
 - After the first user + assistant exchange settles, it takes the first exchange (500 characters per side), asks a model to write a 3–8-word title, caps it at 80 characters, and sets the session name — with a final re-check so a name you set yourself can never be overwritten.
 - **Manual names win.** If you named the session (`--name` or `/name`), naming is skipped, and it re-checks before writing.
 - **It uses your current model unless you configure another.** The title is a separate model call outside the main run — with its own cost, **not reflected in the footer's totals**. A `model` setting (e.g. a cheap model) avoids spending your main model on titles.
-- **Skips and retries** — Ephemeral sessions (no session file) are skipped; if the model has no configured auth, the call is skipped. Transient failures print to the console and re-try on later `agent_end` events, giving up for the session after three. It is non-blocking and unobtrusive, but "silent" is too strong: failures are logged.
+- **Failures tell you.** A failed title request is retried on a later turn, and the provider's error is logged as `[archimedes] session-name failed: <provider error>`. After three failures in one session it stops trying and shows a single warning: *Session naming failed 3 times. Check the model configuration or use /name.* The warning is skipped when there's no UI to show it in (`pi -p`) or if you named the session in the meantime. Cancelling a request doesn't count as a failure, and neither does a session that's replaced or torn down while a title is in flight.
+- **Skips** — Ephemeral sessions (no session file) are skipped, and so is a model with no configured auth. Neither counts against the three attempts.
 
 ## Settings
 
@@ -40,6 +41,7 @@ After installing Pi, choose one installation command above, then `cd` into your
 | Setting | Type | Default | Description |
 |---------|------|---------|-------------|
 | `model` | string | _(current model)_ | Model used for title generation (e.g. `openai/gpt-4o-mini`). Canonical `provider/id`, bare IDs, and thinking-suffix forms are all resolved. Empty = current model. |
+| `reasoning` | string \| null | `minimal` | Thinking level for the title request: `minimal`, `low`, `medium`, `high`, `xhigh`, `max`. Set `null` to omit the option entirely — that's the fix for a provider that rejects thinking levels outright, which shows up as the naming warning plus a `400 Invalid request parameters` line in the log. Spell it exactly: an unrecognised value isn't validated, and on some providers it means *more* thinking rather than none. |
 
 On/off is managed by the suite: toggle via `/plugins` (`archimedes.sessionName.enabled`, default on).
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-archimedes/session-name",
-  "version": "2.10.1",
+  "version": "2.10.3",
   "repository": {
     "type": "git",
     "url": "https://github.com/danielcherubini/pi-archimedes.git"
@@ -18,7 +18,7 @@
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@pi-archimedes/core": "2.10.1"
+    "@pi-archimedes/core": "2.10.3"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": ">=0.86.0",

package/src/index.test.ts

@@ -1,5 +1,6 @@
+import { loadConfig } from "@pi-archimedes/core/settings-io";
 import { describe, expect, it, vi } from "vitest";
-import { generateTitle } from "./index.js";
+import { generateTitle, registerSessionName } from "./index.js";
 
 function createMockPi(sessionName: string | undefined = undefined) {
   let currentName = sessionName;
@@ -60,6 +61,10 @@ function createMockCtx(options: {
   };
 }
 
+vi.mock("@pi-archimedes/core/settings-io", () => ({
+  loadConfig: vi.fn((_namespace, defaults) => defaults),
+}));
+
 describe("generateTitle", () => {
   it("generates title, trims quotes and whitespace, and calls pi.setSessionName", async () => {
     const pi = createMockPi();
@@ -101,6 +106,16 @@ describe("generateTitle", () => {
     expect(onFailure).not.toHaveBeenCalled();
   });
 
+  it.each(["low", null])("uses configured reasoning %s", async (reasoning) => {
+    vi.mocked(loadConfig).mockReturnValueOnce({ reasoning });
+    const ctx = createMockCtx({});
+    await generateTitle(createMockPi() as any, ctx as any, vi.fn(), vi.fn());
+
+    const options = (ctx.modelRegistry.streamSimple as any).mock.calls[0][2];
+    if (reasoning === null) expect(options).not.toHaveProperty("reasoning");
+    else expect(options.reasoning).toBe(reasoning);
+  });
+
   it("triggers onFailure when streamSimple returns stopReason === 'error'", async () => {
     const pi = createMockPi();
     const ctx = createMockCtx({
@@ -120,6 +135,26 @@ describe("generateTitle", () => {
     expect(onFailure).toHaveBeenCalledTimes(1);
   });
 
+  it.each([
+    ["This extension ctx is stale after session replacement or reload.", 0],
+    ["Unexpected lookup failure", 1],
+  ] as const)("handles lookup errors: %s", async (message, failures) => {
+    const pi = createMockPi();
+    pi.getSessionName.mockImplementation(() => { throw new Error(message); });
+    const onSuccess = vi.fn();
+    const onFailure = vi.fn();
+    const log = vi.spyOn(console, "error").mockImplementation(() => {});
+    try {
+      await generateTitle(pi as any, createMockCtx({}) as any, onSuccess, onFailure);
+      expect(onFailure).toHaveBeenCalledTimes(failures);
+      expect(log).toHaveBeenCalledTimes(failures);
+      expect(onSuccess).not.toHaveBeenCalled();
+      expect(pi.setSessionName).not.toHaveBeenCalled();
+    } finally {
+      log.mockRestore();
+    }
+  });
+
   it("does not call onFailure when streamSimple returns stopReason === 'aborted'", async () => {
     const pi = createMockPi();
     const ctx = createMockCtx({
@@ -185,3 +220,38 @@ describe("generateTitle", () => {
     expect(onFailure).not.toHaveBeenCalled();
   });
 });
+
+describe("registerSessionName", () => {
+  it.each(["UI", "no UI", "named", "stale", "stale UI", "broken UI"])("reports exhaustion safely: %s", async (scenario) => {
+    const pi = createMockPi();
+    registerSessionName(pi as any);
+    const agentEnd = pi.on.mock.calls.find(([event]) => event === "agent_end")![1];
+    const error = { stopReason: "error", content: [], errorMessage: "400 boom" };
+    const notify = vi.fn();
+    const ctx = { ...createMockCtx({ streamSimpleResult: error }), hasUI: scenario !== "no UI", ui: { notify } };
+    const log = vi.spyOn(console, "error").mockImplementation(() => {});
+    try {
+      await agentEnd({}, ctx);
+      await agentEnd({}, ctx);
+      let finish!: (response: any) => void;
+      const pending = new Promise((resolve) => { finish = resolve; });
+      ctx.modelRegistry.streamSimple.mockReturnValueOnce({ result: vi.fn(() => pending) });
+      await agentEnd({}, ctx);
+      // Change the session/UI while the third request is still pending.
+      if (scenario === "named") pi.setSessionName("Manual name");
+      if (scenario === "stale") pi.getSessionName.mockImplementation(() => { throw new Error("stale context"); });
+      if (scenario === "stale UI") Object.defineProperty(ctx, "hasUI", { get: () => { throw new Error("stale UI"); } });
+      if (scenario === "broken UI") notify.mockImplementation(() => { throw new Error("UI failed"); });
+      finish(error);
+      await pending;
+      await agentEnd({}, ctx);
+      expect(ctx.modelRegistry.streamSimple).toHaveBeenCalledTimes(3);
+      expect(log).toHaveBeenCalledTimes(3);
+      expect(log).toHaveBeenCalledWith("[archimedes] session-name failed:", "400 boom");
+      expect(notify).toHaveBeenCalledTimes(scenario === "UI" || scenario === "broken UI" ? 1 : 0);
+      if (scenario === "UI") expect(notify).toHaveBeenCalledWith(expect.stringContaining("/name"), "warning");
+    } finally {
+      log.mockRestore();
+    }
+  });
+});

package/src/index.ts

@@ -1,4 +1,5 @@
 import type { ExtensionAPI, ExtensionContext } from "@earendil-works/pi-coding-agent";
+import type { ThinkingLevel } from "@earendil-works/pi-ai";
 import { loadConfig } from "@pi-archimedes/core/settings-io";
 import type { SettingItem } from "@earendil-works/pi-tui";
 
@@ -8,10 +9,12 @@ export interface SessionNameSettings {
   // suite-managed by meta's plugin gate (archimedes.sessionName.enabled — see ADR 0012); session-name never reads this
   enabled?: boolean | undefined;
   model?: string | undefined;
+  reasoning?: ThinkingLevel | null | undefined;
 }
 
 const DEFAULT_SESSION_NAME_CONFIG: SessionNameSettings = {
   model: undefined,
+  reasoning: "minimal",
 };
 
 const NAMESPACE = "archimedes.sessionName";
@@ -165,7 +168,7 @@ export async function generateTitle(
         ],
       },
       {
-        reasoning: "minimal",
+        ...(settings.reasoning != null ? { reasoning: settings.reasoning } : {}),
         cacheRetention: "none",
         sessionId: crypto.randomUUID(),
       },
@@ -177,6 +180,7 @@ export async function generateTitle(
       return;
     }
     if (response.stopReason === "error") {
+      console.error("[archimedes] session-name failed:", response.errorMessage ?? "title request failed");
       onFailure();
       return;
     }
@@ -203,6 +207,8 @@ export async function generateTitle(
     pi.setSessionName(title);
     onSuccess();
   } catch (e) {
+    // Session replacement or print-mode teardown makes an in-flight title irrelevant.
+    if (e instanceof Error && e.message.includes("stale after session replacement")) return;
     console.error("[archimedes] session-name failed:", e);
     onFailure();
   }
@@ -234,7 +240,15 @@ export function registerSessionName(pi: ExtensionAPI) {
 
     // Fire-and-forget: spawn title generation in background so handler
     // returns immediately and the UI becomes responsive.
-    void generateTitle(pi, ctx, () => { hasNamed = true; }, () => { failCount++; });
+    void generateTitle(pi, ctx, () => { hasNamed = true; }, () => {
+      failCount++;
+      if (failCount !== 3) return;
+      try {
+        if (ctx.hasUI && !pi.getSessionName()) {
+          ctx.ui.notify("Session naming failed 3 times. Check the model configuration or use /name.", "warning");
+        }
+      } catch { /* Reporting must not count as another naming failure. */ }
+    });
   });
 }