@pi-archimedes/notify 2.8.0 → 2.9.1

package/README.md

@@ -29,9 +29,9 @@ After installing Pi, choose one installation command above, then `cd` into your
 ## Triggers
 
 - **Settled runs** — on Pi's `agent_settled` event: the run has fully settled (no automatic retry, compaction, or queued continuation still to fire), not merely "a turn ended".
-- **Blocking prompts** — on `ui_prompt_start`: any extension prompt is waiting on you (a tabbed ask, a sudo password prompt, an MCP OAuth loader) — direct **or** subagent-relayed, since the event fires in the parent process.
+- **Blocking prompts** — on `ui_prompt_start`: any extension prompt is waiting on you (a tabbed ask, a sudo password or command-confirm prompt) — direct **or** subagent-relayed, since the event fires in the parent process.
 
-The alert fires after a fixed `delayMs` (30 s by default) from the trigger. It is a delay, not an idle timer: nothing measures how long you've been reading. Any input in the terminal cancels pending alerts immediately, a new agent run cancels them, and a prompt that closes without you typing (say, the OAuth loader finishing from the browser) cancels its own timer — so a long-gone question can't ring.
+The alert fires after a fixed `delayMs` (30 s by default) from the trigger. It is a delay, not an idle timer: nothing measures how long you've been reading. Any input in the terminal cancels pending alerts immediately, a new agent run cancels them, and a prompt that closes without you typing (say, a confirm dialog that times out and auto-declines) cancels its own timer — so a long-gone question can't ring.
 
 ## Terminal delivery
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-archimedes/notify",
-  "version": "2.8.0",
+  "version": "2.9.1",
   "repository": {
     "type": "git",
     "url": "https://github.com/danielcherubini/pi-archimedes.git"
@@ -18,15 +18,15 @@
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@pi-archimedes/core": "2.8.0"
+    "@pi-archimedes/core": "2.9.1"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": ">=0.84.4",
     "@earendil-works/pi-tui": ">=0.1.0"
   },
   "devDependencies": {
-    "@earendil-works/pi-coding-agent": "^0.85.1",
-    "@earendil-works/pi-tui": "^0.85.1",
+    "@earendil-works/pi-coding-agent": "^0.87.0",
+    "@earendil-works/pi-tui": "^0.87.0",
     "typescript": "^6.0.0"
   },
   "pi": {

package/src/index.ts

@@ -66,7 +66,7 @@ export function notifyOSC9(message: string): void {
 /** OSC 99 — Kitty terminal */
 export function notifyOSC99(title: string, body: string): void {
   const seq1 = `\x1b]99;i=1:d=0;${title}\x1b\\`;
-  const seq2 = `\x1b]99;i=1:p=${body}\x1b\\`;
+  const seq2 = `\x1b]99;i=1:p=body;${body}\x1b\\`;
   process.stderr.write(wrapForTmux(seq1));
   process.stderr.write(wrapForTmux(seq2));
 }
@@ -185,16 +185,16 @@ function fireNotification(trigger: TriggerType | null): void {
 /** Register the notify extension with the Pi agent. */
 export function registerNotify(pi: ExtensionAPI): void {
   pi.on("agent_settled", () => scheduleNotify(TRIGGER.AGENT_SETTLED));
-  // Any blocking extension UI prompt (ask, sudo, mcp OAuth) — fires in the
+  // Any blocking extension UI prompt (ask, sudo) — fires in the
   // parent process for direct and subagent-relayed prompts alike.
   pi.on("ui_prompt_start", (_event) => scheduleNotify(TRIGGER.UI_PROMPT));
   pi.on("input", () => cancelPending());
   pi.on("before_agent_start", () => cancelPending());
   pi.on("agent_start", () => cancelPending());
-  // A prompt that closes without terminal input (e.g. the mcp OAuth
-  // loader finishing from the browser's `done()`) cancels the question
-  // timer so a long-gone prompt does not fire a stale "question needs
-  // your answer". Scoped so it never wipes a pending "task complete" timer.
+  // A prompt that closes without terminal input (e.g. a ctx.ui.confirm
+  // that times out and auto-declines) cancels the question timer so a
+  // long-gone prompt does not fire a stale "question needs your answer".
+  // Scoped so it never wipes a pending "task complete" timer.
   pi.on("ui_prompt_end", () => {
     if (pendingTrigger === TRIGGER.UI_PROMPT) {
       cancelPending();

package/src/notify-osc99.test.ts

@@ -0,0 +1,21 @@
+import { afterEach, describe, expect, it, vi } from "vitest";
+import { notifyOSC99 } from "./index.js";
+
+describe("notifyOSC99", () => {
+	afterEach(() => {
+		vi.restoreAllMocks();
+		vi.unstubAllEnvs();
+	});
+
+	it("emits the body text as the OSC 99 body payload, not as the payload type", () => {
+		vi.stubEnv("TMUX", "");
+		const write = vi.spyOn(process.stderr, "write").mockImplementation(() => true);
+
+		notifyOSC99("Pi", "Task complete — waiting for input");
+
+		expect(write.mock.calls.map(([chunk]) => chunk)).toEqual([
+			"\x1b]99;i=1:d=0;Pi\x1b\\",
+			"\x1b]99;i=1:p=body;Task complete — waiting for input\x1b\\",
+		]);
+	});
+});