@pi-archimedes/notify 2.2.0 → 2.4.0

package/README.md

@@ -33,11 +33,12 @@ When the agent finishes a task (`agent_end`) or a question is asked (`ASK_REQUES
 
 | Setting | Type | Default | Description |
 |---------|------|---------|-------------|
-| `enabled` | bool | `true` | Enable desktop notifications |
 | `notifyOnAgentEnd` | bool | `true` | Notify when agent finishes a task |
 | `notifyOnQuestion` | bool | `true` | Notify when a question needs your answer |
 | `delayMs` | number | `30000` | Milliseconds to wait before sending notification (default 30 seconds) |
 
+On/off is managed by the suite: toggle via `/plugins` (`archimedes.notify.enabled`, default on).
+
 Settings are stored in `~/.pi/agent/settings.json` under the `archimedes.notify` namespace.
 
 ## Terminal compatibility

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@pi-archimedes/notify",
-  "version": "2.2.0",
+  "version": "2.4.0",
   "type": "module",
   "keywords": [
     "pi-package"
@@ -14,13 +14,15 @@
     ".": "./src/index.ts"
   },
   "dependencies": {
-    "@pi-archimedes/core": "2.2.0"
+    "@pi-archimedes/core": "2.4.0"
   },
   "peerDependencies": {
     "@earendil-works/pi-coding-agent": ">=0.1.0",
     "@earendil-works/pi-tui": ">=0.1.0"
   },
   "devDependencies": {
+    "@earendil-works/pi-coding-agent": "^0.84.2",
+    "@earendil-works/pi-tui": "^0.84.2",
     "typescript": "^6.0.0"
   },
   "pi": {

package/src/default-export.test.ts

@@ -0,0 +1,25 @@
+import { describe, expect, it, vi } from "vitest";
+import defaultExport from "./index.js";
+
+describe("notify default export (standalone factory)", () => {
+	it("is a function that registers the notify handlers (registerNotify subscribes its own session events)", () => {
+		expect(typeof defaultExport).toBe("function");
+
+		const on = vi.fn();
+		const pi = { on } as any;
+
+		defaultExport(pi);
+
+		const events = on.mock.calls.map((c: Array<unknown>) => c[0]);
+		expect(events).toEqual(
+			expect.arrayContaining([
+				"agent_end",
+				"input",
+				"before_agent_start",
+				"agent_start",
+				"session_start",
+				"session_shutdown",
+			]),
+		);
+	});
+});

package/src/index.ts

@@ -4,17 +4,25 @@ import { loadConfig, saveConfig } from "@pi-archimedes/core/settings-io";
 import { getBus, Events } from "@pi-archimedes/core/bus";
 import { execFile } from "node:child_process";
 
+// ── Trigger constants ────────────────────────────────────────────────────────
+
+const TRIGGER = {
+  AGENT_END: "agent_end",
+  ASK_REQUEST: "ask_request",
+} as const;
+type TriggerType = (typeof TRIGGER)[keyof typeof TRIGGER];
+
 // ── Config ──────────────────────────────────────────────────────────────────
 
 export interface NotifyConfig {
-  enabled: boolean;
+  // suite-managed by meta's plugin gate (archimedes.notify.enabled — see ADR 0012); notify never reads this
+  enabled?: boolean;
   notifyOnAgentEnd: boolean;
   notifyOnQuestion: boolean;
   delayMs: number;
 }
 
 export const DEFAULT_NOTIFY_CONFIG: NotifyConfig = {
-  enabled: true,
   notifyOnAgentEnd: true,
   notifyOnQuestion: true,
   delayMs: 30_000,
@@ -124,7 +132,7 @@ export function notify(title: string, body: string): void {
 // ── Circuit breaker state ───────────────────────────────────────────────────
 
 let notifyTimer: ReturnType<typeof setTimeout> | null = null;
-let pendingTrigger: "agent_end" | "ask_request" | null = null;
+let pendingTrigger: TriggerType | null = null;
 
 // ── Circuit breaker logic ───────────────────────────────────────────────────
 
@@ -138,22 +146,18 @@ export function cancelPending(): void {
 }
 
 /** Schedule a delayed notification (circuit breaker). */
-export function scheduleNotify(trigger: "agent_end" | "ask_request"): void {
+export function scheduleNotify(trigger: TriggerType): void {
   // Cancel any existing timer first
   cancelPending();
 
   // Load config fresh on each trigger
   const config = loadNotifyConfig();
 
-  if (!config.enabled) {
-    return;
-  }
-
-  if (trigger === "agent_end" && !config.notifyOnAgentEnd) {
+  if (trigger === TRIGGER.AGENT_END && !config.notifyOnAgentEnd) {
     return;
   }
 
-  if (trigger === "ask_request" && !config.notifyOnQuestion) {
+  if (trigger === TRIGGER.ASK_REQUEST && !config.notifyOnQuestion) {
     return;
   }
 
@@ -169,8 +173,8 @@ export function scheduleNotify(trigger: "agent_end" | "ask_request"): void {
 }
 
 /** Fire the actual notification based on the pending trigger. */
-function fireNotification(trigger: "agent_end" | "ask_request" | null): void {
-  if (trigger === "agent_end") {
+function fireNotification(trigger: TriggerType | null): void {
+  if (trigger === TRIGGER.AGENT_END) {
     notify("Pi", "Task complete — waiting for input");
   } else {
     notify("Pi", "A question needs your answer");
@@ -181,14 +185,14 @@ function fireNotification(trigger: "agent_end" | "ask_request" | null): void {
 
 /** Register the notify extension with the Pi agent. */
 export function registerNotify(pi: ExtensionAPI): void {
-  pi.on("agent_end", () => scheduleNotify("agent_end"));
+  pi.on("agent_end", () => scheduleNotify(TRIGGER.AGENT_END));
   pi.on("input", () => cancelPending());
   pi.on("before_agent_start", () => cancelPending());
   pi.on("agent_start", () => cancelPending());
 
   // Listen for ask requests from the bus (ask package emits this)
   const unsubAskRequest = getBus().on(Events.ASK_REQUEST, () =>
-    scheduleNotify("ask_request"),
+    scheduleNotify(TRIGGER.ASK_REQUEST),
   );
 
   // Listen for raw terminal keystrokes — cancel on any key press
@@ -205,18 +209,19 @@ export function registerNotify(pi: ExtensionAPI): void {
   });
 }
 
+// ── Default export (for standalone pi.extensions loading) ─────────────────
+
+// registerNotify subscribes its own session_start/session_shutdown (and
+// agent/input) handlers internally, so the default factory just registers it.
+export default function (pi: ExtensionAPI): void {
+  registerNotify(pi);
+}
+
 // ── Settings UI ─────────────────────────────────────────────────────────────
 
 /** Build settings UI items for the notify package. */
 export function getNotifySettingsItems(config: NotifyConfig): SettingItem[] {
   return [
-    {
-      id: "enabled",
-      label: "Notifications",
-      description: "Enable desktop notifications",
-      currentValue: config.enabled ? "On" : "Off",
-      values: ["On", "Off"],
-    },
     {
       id: "notifyOnAgentEnd",
       label: "Notify on task complete",