@phuetz/code-buddy 1.0.0 → 1.2.0

package/dist/goals/goal-manager.d.ts

@@ -0,0 +1,77 @@
+/**
+ * GoalManager — per-session goal state + continuation decisions.
+ *
+ * The interactive UI holds one GoalManager per session key (lazily resolved
+ * on every operation, so `--resume`/`--continue` reattach automatically and
+ * sessionless runs stay durable via a cwd-derived key).
+ *
+ * Network-free by design: the judge is injected into `evaluateAfterTurn` so
+ * the manager (and its tests) never touch a provider.
+ */
+import { GoalJudgeFn } from './goal-judge.js';
+import type { GoalPlan } from './goal-decomposer.js';
+import { GoalState, GoalStatus, GoalVerdict } from './goal-state.js';
+import { GoalStore } from './goal-store.js';
+export interface GoalTurnDecision {
+    status: GoalStatus | null;
+    shouldContinue: boolean;
+    continuationPrompt: string | null;
+    verdict: GoalVerdict | 'inactive';
+    reason: string;
+    /** User-visible one-liner (✓ / ⏸ / ↻). Empty when nothing to show. */
+    message: string;
+}
+export interface GoalsConfig {
+    maxTurns: number;
+    judgeModel: string;
+    plannerModel: string;
+    judgeMaxTokens: number;
+    judgeTimeoutMs: number;
+}
+export declare class GoalManager {
+    readonly sessionKey: string;
+    private store;
+    private defaultMaxTurns;
+    private _state;
+    constructor(sessionKey: string, store: GoalStore, defaultMaxTurns?: number);
+    get state(): GoalState | null;
+    isActive(): boolean;
+    hasGoal(): boolean;
+    statusLine(): string;
+    set(goal: string, options?: {
+        maxTurns?: number;
+        goalPlan?: GoalPlan;
+        goalPlanAttempted?: boolean;
+    }): GoalState;
+    attachGoalPlan(plan: GoalPlan): GoalState | null;
+    markGoalPlanAttempted(error?: string): GoalState | null;
+    pause(reason?: string): GoalState | null;
+    resume(options?: {
+        resetBudget?: boolean;
+    }): GoalState | null;
+    clear(): void;
+    markDone(reason: string): void;
+    addSubgoal(text: string): string;
+    removeSubgoal(index1Based: number): string;
+    clearSubgoals(): number;
+    renderSubgoals(): string;
+    /**
+     * Run the judge and update state. Both real user prompts and continuation
+     * prompts we fed ourselves increment `turnsUsed` — both consume budget.
+     */
+    evaluateAfterTurn(lastResponse: string, deps: {
+        judge: GoalJudgeFn;
+    }): Promise<GoalTurnDecision>;
+    nextContinuationPrompt(): string | null;
+}
+export declare function resolveGoalsConfig(): GoalsConfig;
+/**
+ * Resolve the key goals are persisted under. Prefers the live session id
+ * (so `--resume`/`--continue` reattach, Hermes `goal:<session_id>`
+ * semantics); falls back to a cwd-derived key so sessionless interactive
+ * runs are still durable.
+ */
+export declare function resolveGoalSessionKey(): string;
+export declare function getGoalManager(sessionKey?: string): GoalManager;
+/** Test seam: clear cached managers and optionally redirect persistence. */
+export declare function resetGoalManagers(store?: GoalStore | null): void;

package/dist/goals/goal-manager.js

@@ -0,0 +1,289 @@
+/**
+ * GoalManager — per-session goal state + continuation decisions.
+ *
+ * The interactive UI holds one GoalManager per session key (lazily resolved
+ * on every operation, so `--resume`/`--continue` reattach automatically and
+ * sessionless runs stay durable via a cwd-derived key).
+ *
+ * Network-free by design: the judge is injected into `evaluateAfterTurn` so
+ * the manager (and its tests) never touch a provider.
+ */
+import crypto from 'crypto';
+import path from 'path';
+import { getSettingsHierarchy } from '../config/settings-hierarchy.js';
+import { getSessionStore } from '../persistence/session-store.js';
+import { logger } from '../utils/logger.js';
+import { DEFAULT_JUDGE_MAX_TOKENS, DEFAULT_JUDGE_TIMEOUT_MS, DEFAULT_MAX_TURNS, applyJudgeOutcome, buildContinuationPrompt, createGoalState, formatGoalStatusLine, getGoalJudgeCriteria, renderSubgoalsBlock, } from './goal-state.js';
+import { GoalStore } from './goal-store.js';
+export class GoalManager {
+    sessionKey;
+    store;
+    defaultMaxTurns;
+    _state;
+    constructor(sessionKey, store, defaultMaxTurns = DEFAULT_MAX_TURNS) {
+        this.sessionKey = sessionKey;
+        this.store = store;
+        this.defaultMaxTurns = defaultMaxTurns;
+        const loaded = this.store.load(sessionKey);
+        // A cleared tombstone reads as "no goal" (kept on disk for audit).
+        this._state = loaded && loaded.status !== 'cleared' ? loaded : null;
+    }
+    // --- introspection ------------------------------------------------
+    get state() {
+        return this._state;
+    }
+    isActive() {
+        return this._state?.status === 'active';
+    }
+    hasGoal() {
+        return this._state !== null && ['active', 'paused'].includes(this._state.status);
+    }
+    statusLine() {
+        return formatGoalStatusLine(this._state);
+    }
+    // --- mutation -----------------------------------------------------
+    set(goal, options = {}) {
+        const text = (goal || '').trim();
+        if (!text) {
+            throw new Error('goal text is empty');
+        }
+        const state = createGoalState(text, options.maxTurns ?? this.defaultMaxTurns);
+        if (options.goalPlan)
+            state.goalPlan = options.goalPlan;
+        if (typeof options.goalPlanAttempted === 'boolean') {
+            state.goalPlanAttempted = options.goalPlanAttempted;
+        }
+        this._state = state;
+        this.store.save(this.sessionKey, state);
+        return state;
+    }
+    attachGoalPlan(plan) {
+        if (!this.hasGoal() || !this._state)
+            return null;
+        this._state.goalPlan = plan;
+        this._state.goalPlanAttempted = true;
+        delete this._state.goalPlanLastError;
+        this.store.save(this.sessionKey, this._state);
+        return this._state;
+    }
+    markGoalPlanAttempted(error) {
+        if (!this.hasGoal() || !this._state)
+            return null;
+        this._state.goalPlanAttempted = true;
+        if (error) {
+            this._state.goalPlanLastError = error;
+        }
+        else {
+            delete this._state.goalPlanLastError;
+        }
+        this.store.save(this.sessionKey, this._state);
+        return this._state;
+    }
+    pause(reason = 'user-paused') {
+        if (!this._state || !['active', 'paused'].includes(this._state.status))
+            return null;
+        this._state.status = 'paused';
+        this._state.pausedReason = reason;
+        this.store.save(this.sessionKey, this._state);
+        return this._state;
+    }
+    resume(options = {}) {
+        if (!this._state || this._state.status !== 'paused')
+            return null;
+        this._state.status = 'active';
+        delete this._state.pausedReason;
+        delete this._state.lastVerdict;
+        delete this._state.lastReason;
+        this._state.consecutiveParseFailures = 0;
+        if (options.resetBudget ?? true) {
+            this._state.turnsUsed = 0;
+        }
+        this.store.save(this.sessionKey, this._state);
+        return this._state;
+    }
+    clear() {
+        if (!this._state)
+            return;
+        this._state.status = 'cleared';
+        this.store.save(this.sessionKey, this._state);
+        this._state = null;
+    }
+    markDone(reason) {
+        if (!this._state)
+            return;
+        this._state.status = 'done';
+        this._state.lastVerdict = 'done';
+        this._state.lastReason = reason;
+        this.store.save(this.sessionKey, this._state);
+    }
+    // --- /subgoal user controls ---------------------------------------
+    addSubgoal(text) {
+        if (!this.hasGoal() || !this._state) {
+            throw new Error('no active goal');
+        }
+        const clean = (text || '').trim();
+        if (!clean) {
+            throw new Error('subgoal text is empty');
+        }
+        this._state.subgoals.push(clean);
+        this.store.save(this.sessionKey, this._state);
+        return clean;
+    }
+    removeSubgoal(index1Based) {
+        if (!this.hasGoal() || !this._state) {
+            throw new Error('no active goal');
+        }
+        if (!Number.isSafeInteger(index1Based) || index1Based < 1) {
+            throw new Error('index must be a positive integer');
+        }
+        const idx = index1Based - 1;
+        if (idx < 0 || idx >= this._state.subgoals.length) {
+            throw new Error(`index out of range (1..${this._state.subgoals.length})`);
+        }
+        const [removed] = this._state.subgoals.splice(idx, 1);
+        this.store.save(this.sessionKey, this._state);
+        return removed ?? '';
+    }
+    clearSubgoals() {
+        if (!this.hasGoal() || !this._state) {
+            throw new Error('no active goal');
+        }
+        const prev = this._state.subgoals.length;
+        this._state.subgoals = [];
+        this.store.save(this.sessionKey, this._state);
+        return prev;
+    }
+    renderSubgoals() {
+        if (!this._state)
+            return '(no active goal)';
+        if (!this._state.subgoals.length) {
+            return '(no subgoals — use /subgoal <text> to add criteria)';
+        }
+        return renderSubgoalsBlock(this._state.subgoals);
+    }
+    // --- the main entry point called after every turn -----------------
+    /**
+     * Run the judge and update state. Both real user prompts and continuation
+     * prompts we fed ourselves increment `turnsUsed` — both consume budget.
+     */
+    async evaluateAfterTurn(lastResponse, deps) {
+        const state = this._state;
+        if (!state || state.status !== 'active') {
+            return {
+                status: state?.status ?? null,
+                shouldContinue: false,
+                continuationPrompt: null,
+                verdict: 'inactive',
+                reason: 'no active goal',
+                message: '',
+            };
+        }
+        const criteria = getGoalJudgeCriteria(state);
+        const outcome = await deps.judge({
+            goal: state.goal,
+            lastResponse,
+            ...(criteria.length ? { subgoals: criteria } : {}),
+        });
+        const decision = applyJudgeOutcome(state, outcome);
+        this.store.save(this.sessionKey, state);
+        return decision;
+    }
+    nextContinuationPrompt() {
+        if (!this._state || this._state.status !== 'active')
+            return null;
+        return buildContinuationPrompt(this._state);
+    }
+}
+// ============================================================================
+// Config
+// ============================================================================
+export function resolveGoalsConfig() {
+    let raw = {};
+    try {
+        const hierarchy = getSettingsHierarchy(process.cwd());
+        hierarchy.loadAllLevels?.();
+        const settings = hierarchy.getAllSettings();
+        if (settings && typeof settings.goals === 'object' && settings.goals !== null) {
+            raw = settings.goals;
+        }
+    }
+    catch (error) {
+        logger.debug('goals: settings hierarchy unavailable, using defaults', { error: String(error) });
+    }
+    const maxTurns = positiveInt(process.env.CODEBUDDY_GOAL_MAX_TURNS, 0)
+        || positiveInt(raw.maxTurns, DEFAULT_MAX_TURNS);
+    const judgeModel = nonEmptyString(process.env.CODEBUDDY_GOAL_JUDGE_MODEL)
+        || nonEmptyString(raw.judgeModel);
+    const plannerModel = nonEmptyString(process.env.CODEBUDDY_GOAL_PLANNER_MODEL)
+        || nonEmptyString(raw.plannerModel);
+    return {
+        maxTurns,
+        judgeModel,
+        plannerModel,
+        judgeMaxTokens: positiveInt(raw.judgeMaxTokens, DEFAULT_JUDGE_MAX_TOKENS),
+        judgeTimeoutMs: positiveInt(raw.judgeTimeoutMs, DEFAULT_JUDGE_TIMEOUT_MS),
+    };
+}
+function positiveInt(value, fallback) {
+    const n = parsePositiveSafeInteger(value);
+    return Number.isSafeInteger(n) && n > 0 ? n : fallback;
+}
+function nonEmptyString(value) {
+    if (typeof value !== 'string')
+        return '';
+    return value.trim();
+}
+function parsePositiveSafeInteger(value) {
+    if (typeof value === 'number')
+        return value;
+    if (typeof value !== 'string')
+        return Number.NaN;
+    const trimmed = value.trim();
+    if (!/^[1-9]\d*$/.test(trimmed))
+        return Number.NaN;
+    return Number(trimmed);
+}
+// ============================================================================
+// Singleton registry (one manager per session key)
+// ============================================================================
+const registry = new Map();
+let storeOverride = null;
+/**
+ * Resolve the key goals are persisted under. Prefers the live session id
+ * (so `--resume`/`--continue` reattach, Hermes `goal:<session_id>`
+ * semantics); falls back to a cwd-derived key so sessionless interactive
+ * runs are still durable.
+ */
+export function resolveGoalSessionKey() {
+    try {
+        const sessionId = getSessionStore().getCurrentSessionId();
+        if (sessionId)
+            return sessionId;
+    }
+    catch (error) {
+        logger.debug('goals: session store unavailable, using cwd key', { error: String(error) });
+    }
+    const cwdHash = crypto.createHash('sha256').update(path.resolve(process.cwd())).digest('hex');
+    return `dir-${cwdHash.slice(0, 12)}`;
+}
+export function getGoalManager(sessionKey) {
+    const key = sessionKey ?? resolveGoalSessionKey();
+    let manager = registry.get(key);
+    if (!manager) {
+        const store = storeOverride ?? new GoalStore();
+        manager = new GoalManager(key, store, resolveGoalsConfig().maxTurns);
+        registry.set(key, manager);
+        if (registry.size > 20) {
+            const firstKey = registry.keys().next().value;
+            if (firstKey)
+                registry.delete(firstKey);
+        }
+    }
+    return manager;
+}
+/** Test seam: clear cached managers and optionally redirect persistence. */
+export function resetGoalManagers(store = null) {
+    registry.clear();
+    storeOverride = store;
+}
+//# sourceMappingURL=goal-manager.js.map

package/dist/goals/goal-state.d.ts

@@ -0,0 +1,99 @@
+/**
+ * Persistent session goals — the Ralph loop for Code Buddy.
+ *
+ * A goal is a free-form user objective that stays active across turns. After
+ * each turn completes, a small judge call asks an auxiliary model "is this
+ * goal satisfied by the assistant's last response?". If not, Code Buddy feeds
+ * a continuation prompt back into the same session and keeps working until
+ * the goal is done, the turn budget is exhausted, the user pauses/clears it,
+ * or a real user message preempts the loop.
+ *
+ * Ported from Hermes Agent's goal system (hermes_cli/goals.py). Invariants:
+ * - The continuation prompt is a plain user message — no system-prompt
+ *   mutation, no toolset swap, prompt caching stays intact.
+ * - Judge failures are fail-OPEN ("continue"): a broken judge must not wedge
+ *   progress; the turn budget is the backstop.
+ * - A real user message mid-loop preempts the continuation prompt; the judge
+ *   re-runs after that turn.
+ */
+import type { GoalPlan } from './goal-decomposer.js';
+export type GoalStatus = 'active' | 'paused' | 'done' | 'cleared';
+export type GoalVerdict = 'done' | 'continue' | 'skipped';
+export interface GoalState {
+    goal: string;
+    status: GoalStatus;
+    turnsUsed: number;
+    maxTurns: number;
+    createdAt: number;
+    lastTurnAt: number;
+    lastVerdict?: GoalVerdict;
+    lastReason?: string;
+    /** Why we auto-paused (budget exhausted, judge parse failures, interrupt). */
+    pausedReason?: string;
+    /** Judge-output parse failures in a row. API/transport errors don't count. */
+    consecutiveParseFailures: number;
+    /**
+     * User-added criteria appended mid-loop via /subgoal. When non-empty both
+     * the judge prompt and the continuation prompt include them. Defaults to
+     * empty so old persisted state loads unchanged.
+     */
+    subgoals: string[];
+    /**
+     * Optional Hermes-style decomposition graph generated for complex goals.
+     * Its acceptance criteria are fed to the judge alongside user-added
+     * subgoals, while remaining separate so /subgoal stays a manual control.
+     */
+    goalPlan?: GoalPlan;
+    /** True once an LLM planning attempt was made for this goal. */
+    goalPlanAttempted?: boolean;
+    /** Last planning failure, kept for status/debug without retrying forever. */
+    goalPlanLastError?: string;
+}
+export declare const DEFAULT_MAX_TURNS = 20;
+export declare const DEFAULT_JUDGE_TIMEOUT_MS = 30000;
+export declare const DEFAULT_JUDGE_MAX_TOKENS = 4096;
+export declare const JUDGE_GOAL_SNIPPET_CHARS = 2000;
+export declare const JUDGE_SUBGOALS_SNIPPET_CHARS = 2000;
+export declare const JUDGE_RESPONSE_SNIPPET_CHARS = 4000;
+export declare const MAX_CONSECUTIVE_PARSE_FAILURES = 3;
+export declare const CONTINUATION_PROMPT_TEMPLATE: string;
+export declare const CONTINUATION_PROMPT_WITH_SUBGOALS_TEMPLATE: string;
+export declare const CONTINUATION_PROMPT_WITH_PLAN_TEMPLATE: string;
+export declare const JUDGE_SYSTEM_PROMPT: string;
+export declare const JUDGE_USER_PROMPT_TEMPLATE: string;
+export declare const JUDGE_USER_PROMPT_WITH_SUBGOALS_TEMPLATE: string;
+export declare function truncateText(text: string, limit: number): string;
+/** Render subgoals as a numbered `- N. text` block. Empty string when none. */
+export declare function renderSubgoalsBlock(subgoals: string[]): string;
+export declare function getGoalJudgeCriteria(state: Pick<GoalState, 'goalPlan' | 'subgoals'>): string[];
+export declare function createGoalState(goal: string, maxTurns?: number): GoalState;
+/**
+ * Defensive deserialization of a persisted goal state. Returns null when the
+ * payload isn't a usable goal. Old payloads without `subgoals` load unchanged.
+ */
+export declare function normalizeGoalState(raw: unknown): GoalState | null;
+/** Printable one-liner for /goal status. */
+export declare function formatGoalStatusLine(state: GoalState | null): string;
+/** The canonical user-role continuation message for an active goal. */
+export declare function buildContinuationPrompt(state: GoalState): string;
+export interface GoalJudgeOutcome {
+    verdict: GoalVerdict;
+    reason: string;
+    parseFailed: boolean;
+}
+export interface GoalTurnDecisionCore {
+    status: GoalStatus;
+    shouldContinue: boolean;
+    continuationPrompt: string | null;
+    verdict: GoalVerdict;
+    reason: string;
+    /** User-visible one-liner (✓ / ⏸ / ↻). */
+    message: string;
+}
+/**
+ * Apply a judge outcome to an active goal — the exact Hermes ladder.
+ * MUTATES `state` (turn counter, verdict bookkeeping, status transitions)
+ * and returns the decision; the caller persists the state wherever it
+ * lives (GoalStore file, peer-session record, …).
+ */
+export declare function applyJudgeOutcome(state: GoalState, outcome: GoalJudgeOutcome, nowMs?: number): GoalTurnDecisionCore;