@phucprime/react-native-image-editor 1.0.2 → 1.0.3

package/android/libs/README.md

@@ -0,0 +1,7 @@
+The real problem was that photo-editor-android.jar is a plain JAR (not an AAR). When distributed as a JAR, the Android build system has no way to generate an R.java for its package com.ahmedadeltito.photoeditorsdk — that only happens for AAR/library modules. The JAR's compiled bytecode hardcodes references to com.ahmedadeltito.photoeditorsdk.R$layout, which never gets created in the final APK.
+
+The previous attempt (adding a R.java stub) was the right idea but Android's build system ignores hand-written R.java files — it generates and owns the R classes itself and overwrites them.
+
+The working fix: Used a Python script to directly rewrite the constant pool in PhotoEditorSDK.class inside the JAR — replacing every com/ahmedadeltito/photoeditorsdk/R reference with ui/photoeditor/R (your library's actual namespace). Now at runtime, the SDK correctly resolves ui.photoeditor.R$layout.photo_editor_sdk_image_item_list and ui.photoeditor.R$id.photo_editor_sdk_image_iv, which exist in your compiled resources.
+
+The two layout XMLs created in the previous step (photo_editor_sdk_image_item_list.xml and photo_editor_sdk_text_item_list.xml) are still needed — they provide the actual layouts the SDK inflates.

package/android/src/main/res/layout/photo_editor_sdk_image_item_list.xml

@@ -0,0 +1,16 @@
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/photo_editor_sdk_image_rl"
+    android:layout_width="match_parent"
+    android:layout_height="wrap_content">
+
+    <ImageView
+        android:id="@+id/photo_editor_sdk_image_iv"
+        android:layout_width="wrap_content"
+        android:layout_height="80dp"
+        android:layout_centerHorizontal="true"
+        android:layout_margin="12dp"
+        android:adjustViewBounds="true"
+        android:gravity="center"
+        android:scaleType="fitCenter" />
+
+</RelativeLayout>

package/android/src/main/res/layout/photo_editor_sdk_text_item_list.xml

@@ -0,0 +1,13 @@
+<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
+    android:id="@+id/photo_editor_sdk_text_rl"
+    android:layout_width="wrap_content"
+    android:layout_height="wrap_content">
+
+    <TextView
+        android:id="@+id/photo_editor_sdk_text_tv"
+        android:layout_width="wrap_content"
+        android:layout_height="wrap_content"
+        android:padding="10dp"
+        android:textSize="18sp" />
+
+</RelativeLayout>

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@phucprime/react-native-image-editor",
-  "version": "1.0.2",
+  "version": "1.0.3",
   "description": "React Native: Native Image Editor for iOS and Android with drawing, text, stickers, cropping and more",
   "main": "lib/index.js",
   "types": "lib/index.d.ts",
@@ -70,12 +70,12 @@
     }
   },
   "devDependencies": {
-    "@types/react": "^18.2.0 || ^19.0.0",
-    "prettier": "^3.2.0",
+    "@types/react": "18.2.0 || 19.0.0",
+    "prettier": "3.2.0",
     "react-native": "0.78.2",
-    "typescript": "^5.3.0"
+    "typescript": "5.9.3"
   },
   "engines": {
     "node": ">=16.0.0"
   }
-}
+}

package/react-native-image-editor.podspec

@@ -15,6 +15,14 @@ Pod::Spec.new do |s|
   s.source_files = "ios/**/*.{h,m,mm,swift}"
   s.dependency "iOSPhotoEditor"
 
+  # Always enforce C++17 so that C++ standard-library headers (<utility>, <vector>,
+  # <chrono>, …) resolve correctly when the pod is compiled alongside React Native's
+  # C++ TurboModule/JSI headers, regardless of architecture or RN version.
+  s.pod_target_xcconfig = {
+    "CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
+    "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
+  }
+
   # Use install_modules_dependencies helper to install the dependencies if React Native version >=0.71.0.
   if respond_to?(:install_modules_dependencies, true)
     install_modules_dependencies(s)
@@ -24,11 +32,6 @@ Pod::Spec.new do |s|
     # Don't install the dependencies when we run `pod install` in the old architecture.
     if ENV["RCT_NEW_ARCH_ENABLED"] == "1"
       s.compiler_flags = folly_compiler_flags + " -DRCT_NEW_ARCH_ENABLED=1"
-      s.pod_target_xcconfig = {
-        "HEADER_SEARCH_PATHS" => "\"$(PODS_ROOT)/boost\"",
-        "OTHER_CPLUSPLUSFLAGS" => "-DFOLLY_NO_CONFIG -DFOLLY_MOBILE=1 -DFOLLY_USE_LIBCPP=1",
-        "CLANG_CXX_LANGUAGE_STANDARD" => "c++17",
-      }
       s.dependency "React-Codegen"
       s.dependency "RCT-Folly"
       s.dependency "RCTRequired"

package/ios/RNPhotoEditor.m

@@ -1,24 +0,0 @@
-#import <React/RCTBridgeModule.h>
-
-#ifdef RCT_NEW_ARCH_ENABLED
-#import <RNPhotoEditorSpec/RNPhotoEditorSpec.h>
-#endif
-
-@interface RCT_EXTERN_MODULE (RNPhotoEditor, NSObject)
-
-RCT_EXTERN_METHOD(Edit : (NSDictionary *)props onDone : (RCTResponseSenderBlock)
-                      onDone onCancel : (RCTResponseSenderBlock)onCancel)
-
-+ (BOOL)requiresMainQueueSetup {
-  return YES;
-}
-
-@end
-
-#ifdef RCT_NEW_ARCH_ENABLED
-// Conform to the codegen-generated protocol for TurboModule support.
-// The actual implementation is in RNPhotoEditor.swift; this declaration
-// tells the compiler the Swift class satisfies the protocol.
-@interface RNPhotoEditor () <NativeRNPhotoEditorSpec>
-@end
-#endif