@phuc1403/musketeer 0.3.0 → 0.5.0

package/manifest.json

@@ -1,253 +1,301 @@
-{
-  "version": 1,
-  "musketeers": {
-    "core": {
-      "label": "core",
-      "description": "Always-on foundation: research, handoff, skill-creator, git (+ git-manager) + statusline, usage-context & format-json hooks.",
-      "locked": true,
-      "deps": [],
-      "files": [
-        "skills/research/**",
-        "skills/handoff/**",
-        "skills/skill-creator/**",
-        "skills/git/**",
-        "skills/install.ps1",
-        "skills/install.sh",
-        "agents/researcher.md",
-        "agents/git-manager.md",
-        "statusline.cjs",
-        "hooks/usage-context-awareness.cjs",
-        "hooks/lib/**",
-        "hooks/format-json-hook.js"
-      ],
-      "settings": [
-        {
-          "event": "statusLine",
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/statusline.cjs\"",
-          "padding": 0
-        },
-        {
-          "event": "UserPromptSubmit",
-          "matcher": null,
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/usage-context-awareness.cjs\"",
-          "order": 1
-        },
-        {
-          "event": "PostToolUse",
-          "matcher": null,
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/usage-context-awareness.cjs\"",
-          "order": 1
-        },
-        {
-          "event": "PostToolUse",
-          "matcher": "Write|Edit|MultiEdit",
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/format-json-hook.js\"",
-          "order": 2
-        }
-      ],
-      "prereqs": ["node", "git", "gh", "python", "venv-anthropic", "claude-cli"]
-    },
-    "architecture": {
-      "label": "architecture",
-      "description": "DDD architecture authoring: adr-writer, architecture-characteristic-writer, context-map (CML) + validation hook.",
-      "locked": false,
-      "deps": [],
-      "files": [
-        "skills/adr-writer/**",
-        "skills/architecture-characteristic-writer/**",
-        "skills/context-map/**",
-        "hooks/validate-cml-hook.js"
-      ],
-      "settings": [
-        {
-          "event": "PostToolUse",
-          "matcher": "Write|Edit|MultiEdit",
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/validate-cml-hook.js\"",
-          "order": 1
-        }
-      ],
-      "prereqs": ["java", "cm-cli", "adr-tools"]
-    },
-    "hallmark": {
-      "label": "hallmark",
-      "description": "Hallmark design system: hallmark rubric, hallmark-explore, hallmark-loop + auditor/explorer agents.",
-      "locked": false,
-      "deps": [],
-      "files": [
-        "skills/hallmark/**",
-        "skills/hallmark-explore/**",
-        "skills/hallmark-loop/**",
-        "agents/hallmark-auditor.md",
-        "agents/hallmark-explorer.md"
-      ],
-      "settings": [],
-      "prereqs": ["python", "playwright-mcp"]
-    },
-    "code-review": {
-      "label": "code-review",
-      "description": "Adversarial code review skill + code-reviewer agent (commit / pending / PR modes).",
-      "locked": false,
-      "deps": [],
-      "files": [
-        "skills/code-review/**",
-        "agents/code-reviewer.md"
-      ],
-      "settings": [],
-      "prereqs": ["git", "gh"]
-    },
-    "dotnet": {
-      "label": "dotnet",
-      "description": ".NET extras: tdd, knowledge-crunching + EF migration-guard & CONTEXT auto-load hooks. Muster also always merges 4 quality-gate MSBuild properties into root Directory.Build.props (any dotnet-selected project, set MUSKETEER_SKIP_DOTNET_PROPS=1 to skip) and scaffolds a generic src/tests Clean Architecture skeleton when the project is genuinely blank.",
-      "locked": false,
-      "deps": [],
-      "files": [
-        "skills/tdd/**",
-        "skills/knowledge-crunching/**",
-        "hooks/block-migration-edits.cjs",
-        "hooks/inject-context.cjs"
-      ],
-      "settings": [
-        {
-          "event": "PreToolUse",
-          "matcher": "Write|Edit|MultiEdit",
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/block-migration-edits.cjs\"",
-          "order": 1,
-          "statusMessage": "Checking for EF migration edits"
-        },
-        {
-          "event": "SessionStart",
-          "matcher": "startup|resume|clear|compact",
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/inject-context.cjs\"",
-          "order": 1,
-          "statusMessage": "Loading domain CONTEXT"
-        }
-      ],
-      "prereqs": []
-    },
-    "design-docs": {
-      "label": "design-docs",
-      "description": "SessionStart hook that injects architecture/context-map/adr docs/ outputs into context.",
-      "locked": false,
-      "deps": [],
-      "files": [
-        "hooks/inject-design-docs.cjs"
-      ],
-      "settings": [
-        {
-          "event": "SessionStart",
-          "matcher": "startup|resume|clear|compact",
-          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/inject-design-docs.cjs\"",
-          "order": 1,
-          "statusMessage": "Injecting design artifacts"
-        }
-      ],
-      "prereqs": []
-    }
-  },
-  "prereqs": {
-    "node": {
-      "detect": "node --version",
-      "minVersion": "18",
-      "kind": "package",
-      "install": {
-        "win": "winget install -e --id OpenJS.NodeJS.LTS",
-        "mac": "brew install node",
-        "linux": {
-          "apt": "sudo apt-get install -y nodejs npm",
-          "dnf": "sudo dnf install -y nodejs",
-          "pacman": "sudo pacman -S --noconfirm nodejs npm"
-        }
-      }
-    },
-    "git": {
-      "detect": "git --version",
-      "kind": "package",
-      "install": {
-        "win": "winget install -e --id Git.Git",
-        "mac": "brew install git",
-        "linux": {
-          "apt": "sudo apt-get install -y git",
-          "dnf": "sudo dnf install -y git",
-          "pacman": "sudo pacman -S --noconfirm git"
-        }
-      }
-    },
-    "python": {
-      "detect": "python --version",
-      "minVersion": "3.8",
-      "kind": "package",
-      "install": {
-        "win": "winget install -e --id Python.Python.3.12",
-        "mac": "brew install python@3.12",
-        "linux": {
-          "apt": "sudo apt-get install -y python3 python3-pip python3-venv",
-          "dnf": "sudo dnf install -y python3 python3-pip",
-          "pacman": "sudo pacman -S --noconfirm python python-pip"
-        }
-      }
-    },
-    "venv-anthropic": {
-      "kind": "venv",
-      "needs": ["python"]
-    },
-    "claude-cli": {
-      "detect": "claude --version",
-      "kind": "package",
-      "install": {
-        "win": "powershell -NoProfile -Command \"irm https://claude.ai/install.ps1 | iex\"",
-        "mac": "brew install --cask claude-code",
-        "linux": "curl -fsSL https://claude.ai/install.sh | bash"
-      }
-    },
-    "java": {
-      "detect": "java -version",
-      "minVersion": "8",
-      "kind": "package",
-      "install": {
-        "win": "winget install -e --id Microsoft.OpenJDK.17",
-        "mac": "brew install --cask temurin",
-        "linux": {
-          "apt": "sudo apt-get install -y openjdk-17-jdk",
-          "dnf": "sudo dnf install -y java-17-openjdk",
-          "pacman": "sudo pacman -S --noconfirm jdk-openjdk"
-        }
-      }
-    },
-    "cm-cli": {
-      "kind": "note",
-      "needs": ["java"]
-    },
-    "adr-tools": {
-      "detect": "adr config",
-      "kind": "package",
-      "needs": ["git"],
-      "install": {
-        "mac": "brew install adr-tools",
-        "linux": {
-          "apt": "sudo apt-get install -y adr-tools"
-        }
-      }
-    },
-    "gh": {
-      "detect": "gh --version",
-      "kind": "package",
-      "install": {
-        "win": "winget install -e --id GitHub.cli",
-        "mac": "brew install gh",
-        "linux": {
-          "apt": "sudo apt-get install -y gh",
-          "dnf": "sudo dnf install -y gh",
-          "pacman": "sudo pacman -S --noconfirm github-cli"
-        }
-      }
-    },
-    "playwright-mcp": {
-      "kind": "mcp",
-      "needs": ["node", "claude-cli"]
-    },
-    "anthropic-api-key": {
-      "kind": "secret",
-      "guideOnly": true
-    }
-  }
-}
+{
+  "version": 1,
+  "musketeers": {
+    "core": {
+      "label": "core",
+      "description": "Always-on foundation: research, handoff, skill-creator, git (+ git-manager) + statusline, usage-context & format-json hooks.",
+      "locked": true,
+      "deps": [],
+      "files": [
+        "skills/research/**",
+        "skills/handoff/**",
+        "skills/skill-creator/**",
+        "skills/git/**",
+        "skills/install.ps1",
+        "skills/install.sh",
+        "agents/researcher.md",
+        "agents/git-manager.md",
+        "statusline.cjs",
+        "hooks/usage-context-awareness.cjs",
+        "hooks/lib/**",
+        "hooks/format-json-hook.js"
+      ],
+      "settings": [
+        {
+          "event": "statusLine",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/statusline.cjs\"",
+          "padding": 0
+        },
+        {
+          "event": "UserPromptSubmit",
+          "matcher": null,
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/usage-context-awareness.cjs\"",
+          "order": 1
+        },
+        {
+          "event": "PostToolUse",
+          "matcher": null,
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/usage-context-awareness.cjs\"",
+          "order": 1
+        },
+        {
+          "event": "PostToolUse",
+          "matcher": "Write|Edit|MultiEdit",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/format-json-hook.js\"",
+          "order": 2
+        }
+      ],
+      "prereqs": ["node", "git", "gh", "python", "venv-anthropic", "claude-cli"]
+    },
+    "architecture": {
+      "label": "architecture",
+      "description": "DDD architecture authoring: adr-writer, architecture-characteristic-writer, context-map (CML) + validation hook.",
+      "locked": false,
+      "deps": [],
+      "files": [
+        "skills/adr-writer/**",
+        "skills/architecture-characteristic-writer/**",
+        "skills/context-map/**",
+        "hooks/validate-cml-hook.js",
+        "hooks/validate-characteristics-hook.cjs",
+        "hooks/lib/characteristics/**",
+        "hooks/sync-adr-toc.cjs",
+        "hooks/warn-missing-characteristics.cjs",
+        "hooks/block-unsafe-adr-title.cjs",
+        "hooks/init-adr-dir.cjs",
+        "hooks/inject-adr-env.cjs"
+      ],
+      "settings": [
+        {
+          "event": "PostToolUse",
+          "matcher": "Write|Edit|MultiEdit",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/validate-cml-hook.js\"",
+          "order": 1
+        },
+        {
+          "event": "PostToolUse",
+          "matcher": "Write|Edit|MultiEdit",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/validate-characteristics-hook.cjs\"",
+          "order": 2,
+          "statusMessage": "Checking architecture characteristics"
+        },
+        {
+          "event": "PostToolUse",
+          "matcher": "Bash",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/sync-adr-toc.cjs\"",
+          "order": 2,
+          "statusMessage": "Syncing ADR index"
+        },
+        {
+          "event": "PreToolUse",
+          "matcher": "Bash",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/inject-adr-env.cjs\"",
+          "order": 3,
+          "statusMessage": "Filling in adr new env vars"
+        },
+        {
+          "event": "PreToolUse",
+          "matcher": "Bash",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/warn-missing-characteristics.cjs\"",
+          "order": 4
+        },
+        {
+          "event": "PreToolUse",
+          "matcher": "Bash",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/block-unsafe-adr-title.cjs\"",
+          "order": 5,
+          "statusMessage": "Checking ADR title safety"
+        },
+        {
+          "event": "PreToolUse",
+          "matcher": "Bash",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/init-adr-dir.cjs\"",
+          "order": 6,
+          "statusMessage": "Checking ADR directory setup"
+        }
+      ],
+      "prereqs": ["java", "cm-cli", "adr-tools"]
+    },
+    "hallmark": {
+      "label": "hallmark",
+      "description": "Hallmark design system: hallmark rubric, hallmark-explore, hallmark-loop + auditor/explorer agents.",
+      "locked": false,
+      "deps": [],
+      "files": [
+        "skills/hallmark/**",
+        "skills/hallmark-explore/**",
+        "skills/hallmark-loop/**",
+        "agents/hallmark-auditor.md",
+        "agents/hallmark-explorer.md"
+      ],
+      "settings": [],
+      "prereqs": ["python", "playwright-mcp"]
+    },
+    "code-review": {
+      "label": "code-review",
+      "description": "Adversarial code review skill + code-reviewer agent (commit / pending / PR modes).",
+      "locked": false,
+      "deps": [],
+      "files": [
+        "skills/code-review/**",
+        "agents/code-reviewer.md"
+      ],
+      "settings": [],
+      "prereqs": ["git", "gh"]
+    },
+    "dotnet": {
+      "label": "dotnet",
+      "description": ".NET extras: tdd, knowledge-crunching + EF migration-guard & CONTEXT auto-load hooks. Muster also always merges 4 quality-gate MSBuild properties into root Directory.Build.props (any dotnet-selected project, set MUSKETEER_SKIP_DOTNET_PROPS=1 to skip) and scaffolds a generic src/tests Clean Architecture skeleton when the project is genuinely blank.",
+      "locked": false,
+      "deps": [],
+      "files": [
+        "skills/tdd/**",
+        "skills/knowledge-crunching/**",
+        "hooks/block-migration-edits.cjs",
+        "hooks/inject-context.cjs"
+      ],
+      "settings": [
+        {
+          "event": "PreToolUse",
+          "matcher": "Write|Edit|MultiEdit",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/block-migration-edits.cjs\"",
+          "order": 1,
+          "statusMessage": "Checking for EF migration edits"
+        },
+        {
+          "event": "SessionStart",
+          "matcher": "startup|resume|clear|compact",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/inject-context.cjs\"",
+          "order": 1,
+          "statusMessage": "Loading domain CONTEXT"
+        }
+      ],
+      "prereqs": []
+    },
+    "design-docs": {
+      "label": "design-docs",
+      "description": "SessionStart hook that injects architecture/context-map/adr docs/ outputs into context.",
+      "locked": false,
+      "deps": [],
+      "files": [
+        "hooks/inject-design-docs.cjs"
+      ],
+      "settings": [
+        {
+          "event": "SessionStart",
+          "matcher": "startup|resume|clear|compact",
+          "command": "node \"${CLAUDE_PROJECT_DIR}/.claude/hooks/inject-design-docs.cjs\"",
+          "order": 1,
+          "statusMessage": "Injecting design artifacts"
+        }
+      ],
+      "prereqs": []
+    }
+  },
+  "prereqs": {
+    "node": {
+      "detect": "node --version",
+      "minVersion": "18",
+      "kind": "package",
+      "install": {
+        "win": "winget install -e --id OpenJS.NodeJS.LTS",
+        "mac": "brew install node",
+        "linux": {
+          "apt": "sudo apt-get install -y nodejs npm",
+          "dnf": "sudo dnf install -y nodejs",
+          "pacman": "sudo pacman -S --noconfirm nodejs npm"
+        }
+      }
+    },
+    "git": {
+      "detect": "git --version",
+      "kind": "package",
+      "install": {
+        "win": "winget install -e --id Git.Git",
+        "mac": "brew install git",
+        "linux": {
+          "apt": "sudo apt-get install -y git",
+          "dnf": "sudo dnf install -y git",
+          "pacman": "sudo pacman -S --noconfirm git"
+        }
+      }
+    },
+    "python": {
+      "detect": "python --version",
+      "minVersion": "3.8",
+      "kind": "package",
+      "install": {
+        "win": "winget install -e --id Python.Python.3.12",
+        "mac": "brew install python@3.12",
+        "linux": {
+          "apt": "sudo apt-get install -y python3 python3-pip python3-venv",
+          "dnf": "sudo dnf install -y python3 python3-pip",
+          "pacman": "sudo pacman -S --noconfirm python python-pip"
+        }
+      }
+    },
+    "venv-anthropic": {
+      "kind": "venv",
+      "needs": ["python"]
+    },
+    "claude-cli": {
+      "detect": "claude --version",
+      "kind": "package",
+      "install": {
+        "win": "powershell -NoProfile -Command \"irm https://claude.ai/install.ps1 | iex\"",
+        "mac": "brew install --cask claude-code",
+        "linux": "curl -fsSL https://claude.ai/install.sh | bash"
+      }
+    },
+    "java": {
+      "detect": "java -version",
+      "minVersion": "8",
+      "kind": "package",
+      "install": {
+        "win": "winget install -e --id Microsoft.OpenJDK.17",
+        "mac": "brew install --cask temurin",
+        "linux": {
+          "apt": "sudo apt-get install -y openjdk-17-jdk",
+          "dnf": "sudo dnf install -y java-17-openjdk",
+          "pacman": "sudo pacman -S --noconfirm jdk-openjdk"
+        }
+      }
+    },
+    "cm-cli": {
+      "kind": "note",
+      "needs": ["java"]
+    },
+    "adr-tools": {
+      "detect": "adr config",
+      "kind": "package",
+      "needs": ["git"],
+      "install": {
+        "mac": "brew install adr-tools",
+        "linux": {
+          "apt": "sudo apt-get install -y adr-tools"
+        }
+      }
+    },
+    "gh": {
+      "detect": "gh --version",
+      "kind": "package",
+      "install": {
+        "win": "winget install -e --id GitHub.cli",
+        "mac": "brew install gh",
+        "linux": {
+          "apt": "sudo apt-get install -y gh",
+          "dnf": "sudo dnf install -y gh",
+          "pacman": "sudo pacman -S --noconfirm github-cli"
+        }
+      }
+    },
+    "playwright-mcp": {
+      "kind": "mcp",
+      "needs": ["node", "claude-cli"]
+    },
+    "anthropic-api-key": {
+      "kind": "secret",
+      "guideOnly": true
+    }
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@phuc1403/musketeer",
-  "version": "0.3.0",
+  "version": "0.5.0",
   "description": "Distributable custom Claude Code harness — one declarative command scaffolds a curated company of musketeers (skills/agents/hooks) into any project's .claude/.",
   "type": "commonjs",
   "bin": {

package/template/.claude/hooks/block-unsafe-adr-title.cjs

@@ -0,0 +1,70 @@
+#!/usr/bin/env node
+// PreToolUse guard: block an `adr new` title that adr-tools' own script cannot
+// handle safely.
+//
+// adr-new builds the ADR file with `sed -e "s|TITLE|$title|"`, substituting the
+// title in unescaped and using `|` as the delimiter. Two failure modes follow,
+// verified directly against /usr/bin/adr-new:
+//   - `|` in the title breaks sed's own syntax: it exits 1, but only after
+//     creating a zero-byte ADR file that already burned that number.
+//   - `&` in a sed replacement means "the whole match" — it does NOT error.
+//     "Use Kafka & Queues" silently becomes the title "Use Kafka TITLE Queues",
+//     written straight into the file and the generated index.
+// A title starting with `-` is a third case: adr-new parses its own flags with
+// getopts, so without a `--` separator the title is read as an unknown option
+// and the ADR is silently never created (clean failure, still worth catching
+// early with a clearer reason than adr-tools' own "no title given").
+//
+// Blocking, not warning: `|` wastes an ADR number and `&` corrupts data with no
+// error at all, so there is nothing later in the pipeline that will catch it.
+
+let raw = "";
+process.stdin.on("data", (chunk) => (raw += chunk));
+process.stdin.on("end", () => {
+  let input;
+  try {
+    input = JSON.parse(raw || "{}");
+  } catch {
+    process.exit(0); // unparseable payload — fail open, don't block legit work
+  }
+
+  const command = (input && input.tool_input && input.tool_input.command) || "";
+  if (!/\badr\s+new\b/.test(command)) process.exit(0);
+
+  // The skill always places `--` immediately before a quoted title. Extract
+  // that argument; anything else about the command's shape is not this hook's
+  // concern.
+  const afterDashDash = command.match(/--\s+(["'])((?:(?!\1).)*)\1/);
+  const title = afterDashDash ? afterDashDash[2] : null;
+
+  let reason = null;
+  if (!afterDashDash) {
+    reason =
+      "no `--` before the title (or no quoted title found after it). Without `--`, " +
+      "adr-new's getopts can read a title starting with `-` as a flag and silently " +
+      "create nothing. Always: adr new [-s STEM]... -- \"Title\".";
+  } else if (title.includes("|")) {
+    reason =
+      "the title contains `|`. adr-new substitutes it into `sed -e \"s|TITLE|$title|\"`, " +
+      "using `|` as sed's own delimiter — this breaks sed's syntax and exits non-zero, " +
+      "but only after creating a zero-byte ADR file that already consumed that number.";
+  } else if (title.includes("&")) {
+    reason =
+      "the title contains `&`. In a sed replacement `&` means \"the whole match\", so " +
+      "adr-new writes it as literal text into the title (e.g. \"Use Kafka & Queues\" " +
+      "becomes \"Use Kafka TITLE Queues\") and exits 0 — nothing else will catch this.";
+  }
+
+  if (reason) {
+    process.stdout.write(
+      JSON.stringify({
+        hookSpecificOutput: {
+          hookEventName: "PreToolUse",
+          permissionDecision: "deny",
+          permissionDecisionReason: `Refusing this \`adr new\` call: ${reason} Rename the title and retry.`,
+        },
+      })
+    );
+  }
+  process.exit(0);
+});