@phuc1403/musketeer 0.2.0 → 0.2.1

package/README.md

@@ -28,14 +28,17 @@ musketeers are in this project; promote = upgrade the binary._
 
 ## Musketeers (v1)
 
-| Musketeer | Default | What it adds |
-|-----------|---------|--------------|
-| **core** | always (locked) | research, handoff, skill-creator · statusline, usage-context, format-json hooks |
-| **architecture** | checked | adr-writer, architecture-characteristic-writer, context-map · CML validation hook |
-| **hallmark** | checked | hallmark, hallmark-explore, hallmark-loop · auditor/explorer agents |
-| **code-review** | checked | code-review skill + code-reviewer agent |
-| **dotnet** | checked | tdd, knowledge-crunching · EF migration guard hook |
-| **design-docs** | checked | inject-design-docs SessionStart hook |
+| Musketeer | Default in muster | What it adds |
+|-----------|-------------------|--------------|
+| **core** | always on (locked, hidden) | research, handoff, skill-creator · statusline, usage-context, format-json hooks |
+| **architecture** | off | adr-writer, architecture-characteristic-writer, context-map · CML validation hook |
+| **hallmark** | off | hallmark, hallmark-explore, hallmark-loop · auditor/explorer agents |
+| **code-review** | off | code-review skill + code-reviewer agent |
+| **dotnet** | off | tdd, knowledge-crunching · EF migration guard hook |
+| **design-docs** | off | inject-design-docs SessionStart hook |
+
+The muster starts every musketeer **unselected**, except ones you already installed (pre-checked from
+`.musketeer.json`). **core** is always included and isn't shown as a toggle — it can't be removed.
 
 Vocabulary: **musketeer** = a selectable unit · **muster** = the picker · **company** = your recruited set.
 

package/manifest.json

@@ -5,7 +5,6 @@
       "label": "core",
       "description": "Always-on foundation: research, handoff, skill-creator + statusline, usage-context & format-json hooks.",
       "locked": true,
-      "defaultChecked": true,
       "deps": [],
       "files": [
         "skills/research/**",
@@ -50,7 +49,6 @@
       "label": "architecture",
       "description": "DDD architecture authoring: adr-writer, architecture-characteristic-writer, context-map (CML) + validation hook.",
       "locked": false,
-      "defaultChecked": true,
       "deps": [],
       "files": [
         "skills/adr-writer/**",
@@ -72,7 +70,6 @@
       "label": "hallmark",
       "description": "Hallmark design system: hallmark rubric, hallmark-explore, hallmark-loop + auditor/explorer agents.",
       "locked": false,
-      "defaultChecked": true,
       "deps": [],
       "files": [
         "skills/hallmark/**",
@@ -88,7 +85,6 @@
       "label": "code-review",
       "description": "Adversarial code review skill + code-reviewer agent (commit / pending / PR modes).",
       "locked": false,
-      "defaultChecked": true,
       "deps": [],
       "files": [
         "skills/code-review/**",
@@ -101,7 +97,6 @@
       "label": "dotnet",
       "description": ".NET extras: tdd, knowledge-crunching + EF migration-guard hook.",
       "locked": false,
-      "defaultChecked": true,
       "deps": [],
       "files": [
         "skills/tdd/**",
@@ -123,7 +118,6 @@
       "label": "design-docs",
       "description": "SessionStart hook that injects architecture/context-map/adr docs/ outputs into context.",
       "locked": false,
-      "defaultChecked": true,
       "deps": [],
       "files": [
         "hooks/inject-design-docs.cjs"

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@phuc1403/musketeer",
-  "version": "0.2.0",
+  "version": "0.2.1",
   "description": "Distributable custom Claude Code harness — one declarative command scaffolds a curated company of musketeers (skills/agents/hooks) into any project's .claude/.",
   "type": "commonjs",
   "bin": {

package/src/muster.js

@@ -1,30 +1,63 @@
 'use strict';
 
 // The muster — the interactive picker. Uses @clack/prompts (ESM-only), loaded
-// via dynamic import() for CommonJS interop. `core` is always re-added after
-// selection (clack has no per-option lock), enforcing the locked-on invariant.
+// via dynamic import() for CommonJS interop. The selection rules live in the pure
+// helpers below (planSelection / withLocked) so they can be unit-tested without a TTY.
 
 /**
+ * Compute the muster's option list and initial selection. Pure — no I/O.
+ *
+ * Rules:
+ *   * Locked musketeers (core) are NOT selectable — always-on, hidden from the
+ *     toggle list so they can't be unchecked. They're force-added by withLocked().
+ *   * Every other musketeer defaults to UNSELECTED. Only musketeers already
+ *     installed (present in the lockfile) start pre-checked, so re-running shows
+ *     the current company and confirming unchanged is a no-op.
+ *
  * @param {object} manifest
  * @param {{musketeers:string[]}} prev current lockfile company
- * @returns {Promise<?string[]>} chosen ids (incl. core), or null if cancelled
+ * @returns {{lockedIds:string[], options:Array<{value:string,label:string,hint:string}>, initialValues:string[]}}
  */
-async function pick(manifest, prev) {
-  const clack = await import('@clack/prompts');
+function planSelection(manifest, prev) {
   const entries = Object.entries(manifest.musketeers);
-  const installed = new Set(prev.musketeers);
-  const hasLock = prev.musketeers.length > 0;
+  const installed = new Set((prev && prev.musketeers) || []);
 
-  // Pre-checked: locked always; else current install (if any) else defaultChecked.
-  const initialValues = entries
-    .filter(([id, m]) => m.locked || (hasLock ? installed.has(id) : m.defaultChecked))
-    .map(([id]) => id);
+  const lockedIds = entries.filter(([, m]) => m.locked).map(([id]) => id);
+  const selectable = entries.filter(([, m]) => !m.locked);
 
-  const options = entries.map(([id, m]) => ({
+  const options = selectable.map(([id, m]) => ({
     value: id,
-    label: m.locked ? `${m.label} (core — always included)` : m.label,
+    label: m.label,
     hint: m.description,
   }));
+  const initialValues = selectable
+    .filter(([id]) => installed.has(id))
+    .map(([id]) => id);
+
+  return { lockedIds, options, initialValues };
+}
+
+/**
+ * Finalize a raw multiselect result: dedupe and force every locked musketeer on
+ * (enforces locked-on — "core can't be removed").
+ * @param {string[]} selectedIds
+ * @param {string[]} lockedIds
+ * @returns {string[]}
+ */
+function withLocked(selectedIds, lockedIds) {
+  const chosen = new Set(Array.isArray(selectedIds) ? selectedIds : []);
+  for (const id of lockedIds || []) chosen.add(id);
+  return [...chosen];
+}
+
+/**
+ * @param {object} manifest
+ * @param {{musketeers:string[]}} prev current lockfile company
+ * @returns {Promise<?string[]>} chosen ids (incl. locked), or null if cancelled
+ */
+async function pick(manifest, prev) {
+  const clack = await import('@clack/prompts');
+  const { lockedIds, options, initialValues } = planSelection(manifest, prev);
 
   clack.intro('musketeer — muster');
   const selected = await clack.multiselect({
@@ -39,10 +72,9 @@ async function pick(manifest, prev) {
     return null;
   }
 
-  const chosen = new Set(Array.isArray(selected) ? selected : []);
-  chosen.add('core'); // enforce locked-on
-  clack.outro(`Company: ${[...chosen].join(', ')}`);
-  return [...chosen];
+  const chosen = withLocked(selected, lockedIds);
+  clack.outro(`Company: ${chosen.join(', ')}`);
+  return chosen;
 }
 
-module.exports = { pick };
+module.exports = { pick, planSelection, withLocked };

package/src/schema.js

@@ -10,8 +10,7 @@
  *     "<id>": {
  *       label: string,
  *       description: string,
- *       locked: boolean,
- *       defaultChecked: boolean,
+ *       locked: boolean,            // always-on; hidden from the muster toggle list
  *       files: string[],            // globs relative to template/.claude/
  *       deps: string[],             // other musketeer ids (intra-package edges)
  *       settings: SettingFragment[],
@@ -80,7 +79,6 @@ function validateMusketeer(id, m) {
   if (typeof m.label !== 'string') fail(`${ctx}.label must be a string`);
   if (typeof m.description !== 'string') fail(`${ctx}.description must be a string`);
   if (typeof m.locked !== 'boolean') fail(`${ctx}.locked must be a boolean`);
-  if (typeof m.defaultChecked !== 'boolean') fail(`${ctx}.defaultChecked must be a boolean`);
   if (!isStringArray(m.files)) fail(`${ctx}.files must be a string[]`);
   if (!isStringArray(m.deps)) fail(`${ctx}.deps must be a string[]`);
   if (!isStringArray(m.prereqs)) fail(`${ctx}.prereqs must be a string[]`);