@phren/cli 0.0.6 → 0.0.8

package/mcp/dist/mcp-hooks.js

@@ -2,7 +2,7 @@ import { mcpResponse } from "./mcp-types.js";
 import { z } from "zod";
 import * as fs from "fs";
 import * as path from "path";
-import { readInstallPreferences, writeInstallPreferences } from "./init-preferences.js";
+import { readInstallPreferences, updateInstallPreferences } from "./init-preferences.js";
 import { readCustomHooks, getHookTarget, HOOK_EVENT_VALUES } from "./hooks.js";
 import { hookConfigPath } from "./shared.js";
 import { PROJECT_HOOK_EVENTS, isProjectHookEnabled, readProjectConfig, writeProjectHookConfig } from "./project-config.js";
@@ -161,16 +161,15 @@ export function register(server, ctx) {
             if (!normalized) {
                 return mcpResponse({ ok: false, error: `Invalid tool "${tool}". Use: ${HOOK_TOOLS.join(", ")}` });
             }
-            const prefs = readInstallPreferences(phrenPath);
-            writeInstallPreferences(phrenPath, {
+            updateInstallPreferences(phrenPath, (prefs) => ({
                 hookTools: {
                     ...(prefs.hookTools && typeof prefs.hookTools === "object" ? prefs.hookTools : {}),
                     [normalized]: enabled,
                 },
-            });
+            }));
             return mcpResponse({ ok: true, message: `${enabled ? "Enabled" : "Disabled"} hooks for ${normalized}.`, data: { tool: normalized, enabled } });
         }
-        writeInstallPreferences(phrenPath, { hooksEnabled: enabled });
+        updateInstallPreferences(phrenPath, () => ({ hooksEnabled: enabled }));
         return mcpResponse({ ok: true, message: `${enabled ? "Enabled" : "Disabled"} hooks globally.`, data: { global: true, enabled } });
     });
     // ── add_custom_hook ──────────────────────────────────────────────────────
@@ -202,12 +201,26 @@ export function register(server, ctx) {
                 const { hostname } = new URL(trimmed);
                 const h = hostname.toLowerCase().replace(/^\[|\]$/g, ""); // strip IPv6 brackets
                 const ssrfBlocked = h === "localhost" ||
-                    h === "::1" ||
+                    // IPv4 private/loopback ranges
                     /^127\./.test(h) ||
                     /^10\./.test(h) ||
                     /^172\.(1[6-9]|2\d|3[01])\./.test(h) ||
                     /^192\.168\./.test(h) ||
                     /^169\.254\./.test(h) ||
+                    // IPv6 loopback
+                    h === "::1" ||
+                    // IPv6 ULA (fc00::/7 covers fc:: and fd::)
+                    h.startsWith("fc") ||
+                    h.startsWith("fd") ||
+                    // IPv6 link-local (fe80::/10)
+                    h.startsWith("fe80:") ||
+                    // IPv4-mapped IPv6 (::ffff:10.x.x.x, ::ffff:127.x.x.x, etc.)
+                    /^::ffff:/i.test(h) ||
+                    // Raw numeric IPv4 forms not normalized by all URL parsers:
+                    // decimal (2130706433), hex (0x7f000001), octal (0177.0.0.1 prefix)
+                    /^(0x[0-9a-f]+|0\d+)$/i.test(h) ||
+                    // Pure decimal integer that encodes an IPv4 address (8+ digits covers 0.0.0.0+)
+                    /^\d{8,10}$/.test(h) ||
                     h.endsWith(".local") ||
                     h.endsWith(".internal");
                 if (ssrfBlocked) {
@@ -226,10 +239,13 @@ export function register(server, ctx) {
             newHook = { event, command: command, ...(timeout !== undefined ? { timeout } : {}) };
         }
         return ctx.withWriteQueue(async () => {
-            const prefs = readInstallPreferences(phrenPath);
-            const existing = Array.isArray(prefs.customHooks) ? prefs.customHooks : [];
-            writeInstallPreferences(phrenPath, { ...prefs, customHooks: [...existing, newHook] });
-            return mcpResponse({ ok: true, message: `Added custom hook for "${event}": ${"webhook" in newHook ? "[webhook] " : ""}${getHookTarget(newHook)}`, data: { hook: newHook, total: existing.length + 1 } });
+            let totalAfter = 0;
+            updateInstallPreferences(phrenPath, (prefs) => {
+                const existing = Array.isArray(prefs.customHooks) ? prefs.customHooks : [];
+                totalAfter = existing.length + 1;
+                return { customHooks: [...existing, newHook] };
+            });
+            return mcpResponse({ ok: true, message: `Added custom hook for "${event}": ${"webhook" in newHook ? "[webhook] " : ""}${getHookTarget(newHook)}`, data: { hook: newHook, total: totalAfter } });
         });
     });
     // ── remove_custom_hook ───────────────────────────────────────────────────
@@ -242,15 +258,19 @@ export function register(server, ctx) {
         }),
     }, async ({ event, command }) => {
         return ctx.withWriteQueue(async () => {
-            const prefs = readInstallPreferences(phrenPath);
-            const existing = Array.isArray(prefs.customHooks) ? prefs.customHooks : [];
-            const remaining = existing.filter(h => h.event !== event || (command && !getHookTarget(h).includes(command)));
-            const removed = existing.length - remaining.length;
+            let removed = 0;
+            let remainingCount = 0;
+            updateInstallPreferences(phrenPath, (prefs) => {
+                const existing = Array.isArray(prefs.customHooks) ? prefs.customHooks : [];
+                const remaining = existing.filter(h => h.event !== event || (command != null && !getHookTarget(h).includes(command)));
+                removed = existing.length - remaining.length;
+                remainingCount = remaining.length;
+                return { customHooks: remaining };
+            });
             if (removed === 0) {
                 return mcpResponse({ ok: false, error: `No custom hooks matched event="${event}"${command ? ` command containing "${command}"` : ""}.` });
             }
-            writeInstallPreferences(phrenPath, { ...prefs, customHooks: remaining });
-            return mcpResponse({ ok: true, message: `Removed ${removed} custom hook(s) for "${event}".`, data: { removed, remaining: remaining.length } });
+            return mcpResponse({ ok: true, message: `Removed ${removed} custom hook(s) for "${event}".`, data: { removed, remaining: remainingCount } });
         });
     });
 }

package/mcp/dist/mcp-memory.js

@@ -41,7 +41,6 @@ export function register(server, ctx) {
             flushEntryScores(phrenPath);
             const feedbackWeights = {
                 helpful: 1.0,
-                not_helpful: -0.3,
                 reprompt: -0.5,
                 regression: -1.0,
             };

package/mcp/dist/mcp-ops.js

@@ -11,16 +11,9 @@ import { PROJECT_OWNERSHIP_MODES, parseProjectOwnershipMode } from "./project-co
 import { resolveRuntimeProfile } from "./runtime-profile.js";
 import { getMachineName } from "./machine-identity.js";
 import { getProjectConsolidationStatus, CONSOLIDATION_ENTRY_THRESHOLD } from "./content-validate.js";
-/** Translate a PhrenResult<string> into a standard McpToolResult shape. */
-function phrenResultToMcp(result) {
-    if (result.ok) {
-        return { ok: true, message: result.data };
-    }
-    return { ok: false, error: result.error, errorCode: result.code };
-}
 export function register(server, ctx) {
-    const { phrenPath, profile, withWriteQueue, updateFileInIndex } = ctx;
-    // ── get_consolidation_status ───────────────────────────────────────────────
+    const { phrenPath, profile, withWriteQueue } = ctx;
+    // ── add_project ────────────────────────────────────────────────────────────
     server.registerTool("add_project", {
         title: "◆ phren · add project",
         description: "Bootstrap a project into phren from a repo or working directory. " +
@@ -221,11 +214,13 @@ export function register(server, ctx) {
         const { runDoctor } = await import("./link-doctor.js");
         const result = await runDoctor(phrenPath, true, check_data ?? false);
         const lines = result.checks.map((c) => `${c.ok ? "ok" : "FAIL"} ${c.name}: ${c.detail}`);
+        const failCount = result.checks.filter((c) => !c.ok).length;
         return mcpResponse({
             ok: result.ok,
+            ...(result.ok ? {} : { error: `${failCount} check(s) could not be auto-fixed: ${lines.filter((l) => l.startsWith("FAIL")).join("; ")}` }),
             message: result.ok
                 ? `Doctor fix complete: all ${result.checks.length} checks passed`
-                : `Doctor fix complete: ${result.checks.filter((c) => !c.ok).length} issue(s) remain`,
+                : `Doctor fix complete: ${failCount} issue(s) remain`,
             data: {
                 machine: result.machine,
                 profile: result.profile,

package/mcp/dist/mcp-search.js

@@ -131,7 +131,13 @@ export function register(server, ctx) {
         }),
     }, async ({ id: rawId }) => {
         // Normalize ID: decode URL encoding and normalize path separators
-        const id = normalizeMemoryId(rawId);
+        let id;
+        try {
+            id = normalizeMemoryId(rawId);
+        }
+        catch {
+            return mcpResponse({ ok: false, error: `Invalid memory ID format: "${rawId}" contains malformed URL encoding.` });
+        }
         const match = id.match(/^mem:([^/]+)\/(.+)$/);
         if (!match) {
             return mcpResponse({ ok: false, error: `Invalid memory ID format "${rawId}". Expected mem:project/path/to/file.md.` });

package/mcp/dist/mcp-session.js

@@ -294,7 +294,7 @@ export function getSessionArtifacts(phrenPath, sessionId, project) {
     const shortId = sessionId.slice(0, 8);
     try {
         const projectDirs = getProjectDirs(phrenPath);
-        const targetProjects = project ? [project] : projectDirs;
+        const targetProjects = project ? [project] : projectDirs.map((d) => path.basename(d));
         for (const proj of targetProjects) {
             // Findings with matching sessionId
             const findingsResult = readFindings(phrenPath, proj);
@@ -364,15 +364,16 @@ export function computeSessionDiff(phrenPath, project, lastSessionEnd) {
                 superseded++;
         }
     }
-    // Count completed tasks since last session
-    const tasksPath = path.join(projectDir, "TASKS.md");
+    // Count tasks completed since last session by checking Done items with recent activity dates
     let tasksCompleted = 0;
-    if (fs.existsSync(tasksPath)) {
-        const taskContent = fs.readFileSync(tasksPath, "utf8");
-        const doneMatch = taskContent.match(/## Done[\s\S]*/);
-        if (doneMatch) {
-            const doneLines = doneMatch[0].split("\n").filter(l => l.startsWith("- "));
-            tasksCompleted = doneLines.length;
+    const tasksResult = readTasks(phrenPath, project);
+    if (tasksResult.ok) {
+        for (const item of tasksResult.data.items.Done) {
+            // lastActivity is updated on completion; fall back to createdAt
+            const itemDate = item.lastActivity?.slice(0, 10) ?? item.createdAt?.slice(0, 10);
+            if (itemDate && itemDate >= cutoff) {
+                tasksCompleted++;
+            }
         }
     }
     return { newFindings, superseded, tasksCompleted };
@@ -443,12 +444,12 @@ export function register(server, ctx) {
             try {
                 const tasks = readTasks(phrenPath, activeProject);
                 if (tasks.ok) {
-                    const queueItems = tasks.data.items.Queue
+                    const activeItems = tasks.data.items.Active
                         .filter((entry) => isMemoryScopeVisible(normalizeMemoryScope(entry.scope), activeScope))
                         .slice(0, 5)
                         .map((entry) => `- [ ] ${entry.line}`);
-                    if (queueItems.length > 0) {
-                        parts.push(`## Active task (${activeProject})\n${queueItems.join("\n")}`);
+                    if (activeItems.length > 0) {
+                        parts.push(`## Active task (${activeProject})\n${activeItems.join("\n")}`);
                     }
                 }
             }

package/mcp/dist/mcp-skills.js

@@ -120,9 +120,12 @@ export function register(server, ctx) {
             }
             fs.mkdirSync(destDir, { recursive: true });
             const existing = findLocalSkill(phrenPath, scope, safeName);
-            const dest = existing
+            const dest = path.resolve(existing
                 ? existing.path
-                : path.join(destDir, `${safeName}.md`);
+                : path.join(destDir, `${safeName}.md`));
+            if (!dest.startsWith(phrenPath + path.sep) && dest !== phrenPath) {
+                return mcpResponse({ ok: false, error: "Skill path escapes phren store." });
+            }
             const existed = Boolean(existing) || fs.existsSync(dest);
             fs.writeFileSync(dest, content);
             updateFileInIndex(dest);

package/mcp/dist/mcp-tasks.js

@@ -159,9 +159,12 @@ export function register(server, ctx) {
                     data: { project, includedSections: view.includedSections, totalItems: view.totalItems, summary: true },
                 });
             }
+            const sectionCounts = view.includedSections
+                .map((s) => `${s}: ${view.doc.items[s].length}/${doc.items[s].length}`)
+                .join(", ");
             const paginationNote = view.truncated
-                ? `\n\n_Showing ${offset ?? 0}–${(offset ?? 0) + view.totalItems} of ${view.totalUnpaged} items. Use offset/limit to page._`
-                : (offset ? `\n\n_Page offset: ${offset}. ${view.totalItems} items returned._` : "");
+                ? `\n\n_${sectionCounts} (offset ${offset ?? 0}). Use offset/limit to page._`
+                : (offset ? `\n\n_Page offset: ${offset}. ${sectionCounts}._` : "");
             return mcpResponse({
                 ok: true,
                 message: `## ${project}\n${taskMarkdown(view.doc)}${paginationNote}`,
@@ -231,7 +234,7 @@ export function register(server, ctx) {
             const { added, errors } = result.data;
             if (added.length > 0)
                 refreshTaskIndex(updateFileInIndex, phrenPath, project);
-            return mcpResponse({ ok: added.length > 0, message: `Added ${added.length} of ${items.length} tasks to ${project}`, data: { project, added, errors } });
+            return mcpResponse({ ok: added.length > 0, ...(added.length === 0 ? { error: `No tasks added: ${errors.join("; ")}` } : {}), message: `Added ${added.length} of ${items.length} tasks to ${project}`, data: { project, added, errors } });
         });
     });
     server.registerTool("complete_task", {
@@ -303,7 +306,7 @@ export function register(server, ctx) {
             }
             if (completed.length > 0)
                 refreshTaskIndex(updateFileInIndex, phrenPath, project);
-            return mcpResponse({ ok: completed.length > 0, message: `Completed ${completed.length}/${items.length} items`, data: { project, completed, errors } });
+            return mcpResponse({ ok: completed.length > 0, ...(completed.length === 0 ? { error: `No tasks completed: ${errors.join("; ")}` } : {}), message: `Completed ${completed.length}/${items.length} items`, data: { project, completed, errors } });
         });
     });
     server.registerTool("remove_task", {