@pheem49/mint 1.8.2 → 1.10.0

package/crates/mint-core/src/orchestration.rs

@@ -71,15 +71,14 @@ pub async fn resolve_github_links(message: &str, config: &MintConfig) -> String
                 .collect();
 
             let repo_key = format!("{owner}/{repo_clean}");
-            if resolved_repos.insert(repo_key.clone()) {
-                if let Ok(summary) =
+            if resolved_repos.insert(repo_key.clone())
+                && let Ok(summary) =
                     crate::code_tools::fetch_github_repo_summary(owner, &repo_clean).await
-                {
-                    resolved_msg.push_str(&format!(
+            {
+                resolved_msg.push_str(&format!(
                         "\n\n--- Auto-Resolved GitHub Metadata for {} ---\n{}\n--------------------------------------------",
                         repo_key, summary
                     ));
-                }
             }
         }
     }
@@ -210,18 +209,18 @@ fn enrich_request(
     let mut enriched = request.clone();
 
     let mut profile_instructions = String::new();
-    if let Ok(Some(name)) = memory.get_profile("name") {
-        if !name.trim().is_empty() {
-            profile_instructions.push_str(&format!("User Name: {}\n", name.trim()));
-        }
+    if let Ok(Some(name)) = memory.get_profile("name")
+        && !name.trim().is_empty()
+    {
+        profile_instructions.push_str(&format!("User Name: {}\n", name.trim()));
     }
-    if let Ok(Some(preferences)) = memory.get_profile("preferences") {
-        if !preferences.trim().is_empty() {
-            profile_instructions.push_str(&format!(
-                "User Preferences & Profile:\n{}\n",
-                preferences.trim()
-            ));
-        }
+    if let Ok(Some(preferences)) = memory.get_profile("preferences")
+        && !preferences.trim().is_empty()
+    {
+        profile_instructions.push_str(&format!(
+            "User Preferences & Profile:\n{}\n",
+            preferences.trim()
+        ));
     }
 
     if !profile_instructions.is_empty() {
@@ -239,8 +238,8 @@ fn enrich_request(
         "\n\n[Active Environment Context]\n\
          You are running on: {}\n\
          Using AI Model: {}\n",
-         config.ai_provider,
-         config.active_model()
+        config.ai_provider,
+        config.active_model()
     );
     enriched.system_instruction.push_str(&active_model_info);
 
@@ -303,6 +302,7 @@ pub fn build_system_prompt(config: &MintConfig) -> String {
         "note_write",
         "run_plugin",
         "mcp_tool",
+        "mcp_list_tools",
         "run_shell",
         "verify",
         "apply_patch",
@@ -314,6 +314,10 @@ pub fn build_system_prompt(config: &MintConfig) -> String {
         allowed_actions.push("browser_click");
         allowed_actions.push("browser_type");
         allowed_actions.push("browser_read");
+        allowed_actions.push("browser_mouse_move");
+        allowed_actions.push("browser_mouse_click");
+        allowed_actions.push("browser_key_press");
+        allowed_actions.push("browser_screenshot");
     }
 
     allowed_actions.retain(|action| !config.disabled_tools.contains(&action.to_string()));
@@ -355,15 +359,27 @@ pub fn build_system_prompt(config: &MintConfig) -> String {
         input_formats.push("- browser_open: {\"url\":\"https://example.com\"}");
     }
     if allowed_actions.contains(&"browser_click") {
-        input_formats.push("- browser_click: {\"selector\":\"button.submit-btn\"}");
+        input_formats.push("- browser_click: {\"selector\":\"button.submit-btn\"} (CSS selector, or text=Login, contains=Submit, xpath=//button)");
     }
     if allowed_actions.contains(&"browser_type") {
         input_formats
-            .push("- browser_type: {\"selector\":\"input.search-bar\", \"text\":\"search query\"}");
+            .push("- browser_type: {\"selector\":\"input.search-bar\", \"text\":\"search query\"} (CSS selector, or text=Placeholder, contains=Label)");
     }
     if allowed_actions.contains(&"browser_read") {
         input_formats.push("- browser_read: {}");
     }
+    if allowed_actions.contains(&"browser_mouse_move") {
+        input_formats.push("- browser_mouse_move: {\"x\":640,\"y\":360}");
+    }
+    if allowed_actions.contains(&"browser_mouse_click") {
+        input_formats.push("- browser_mouse_click: {\"x\":640,\"y\":360,\"button\":\"left\"}");
+    }
+    if allowed_actions.contains(&"browser_key_press") {
+        input_formats.push("- browser_key_press: {\"key\":\"Enter\"} (keys: Enter,Tab,Escape,Backspace,Delete,ArrowUp,ArrowDown,ArrowLeft,ArrowRight,F1-F12,Space)");
+    }
+    if allowed_actions.contains(&"browser_screenshot") {
+        input_formats.push("- browser_screenshot: {}");
+    }
     if allowed_actions.contains(&"memory_recall") {
         input_formats.push("- memory_recall: {\"query\":\"what did user say about X\"}");
     }
@@ -411,8 +427,19 @@ pub fn build_system_prompt(config: &MintConfig) -> String {
     if allowed_actions.contains(&"run_plugin") {
         input_formats.push("- run_plugin: {\"name\":\"gmail|google_calendar|notion|docker|spotify|obsidian|system_metrics\",\"instruction\":\"instruction string\"}");
     }
+    let mcp_str;
     if allowed_actions.contains(&"mcp_tool") {
-        input_formats.push("- mcp_tool: {\"server\":\"configured-server\",\"tool\":\"tool-name\",\"arguments\":{}}");
+        let servers = crate::mcp::list_mcp_servers()
+            .map(|m| m.keys().cloned().collect::<Vec<String>>().join(", "))
+            .unwrap_or_default();
+        mcp_str = format!(
+            "- mcp_tool: {{\"server\":\"<name>\",\"tool\":\"tool-name\",\"arguments\":{{}}}} (Available configured servers: {})",
+            servers
+        );
+        input_formats.push(&mcp_str);
+    }
+    if allowed_actions.contains(&"mcp_list_tools") {
+        input_formats.push("- mcp_list_tools: {\"server\":\"configured-server\"}");
     }
     if allowed_actions.contains(&"run_shell") {
         input_formats.push(
@@ -448,7 +475,7 @@ pub fn build_system_prompt(config: &MintConfig) -> String {
         );
     }
     if allowed_actions.contains(&"apply_patch") && allowed_actions.contains(&"write_file") {
-        rules.push("3. Use apply_patch for all edits to existing files. write_file is only for creating new files inside the workspace.");
+        rules.push("3. Use apply_patch for all edits to existing files (write_file is only for creating new files). For edits across multiple sections of a file, supply separate small hunks in the 'hunks' array (one hunk per edit location). Keep oldText in each hunk minimal (only 1-3 exact lines needed to pinpoint the edit). NEVER bundle multiple separate edits into a single giant hunk that spans the entire file.");
     }
     if allowed_actions.contains(&"run_shell")
         || allowed_actions.contains(&"write_file")
@@ -469,16 +496,28 @@ pub fn build_system_prompt(config: &MintConfig) -> String {
         rules.push("7a. Use browser_open to navigate the virtual browser to a URL.");
     }
     if allowed_actions.contains(&"browser_click") {
-        rules.push("7b. Use browser_click to click elements on the page.");
+        rules.push("7b. Use browser_click to click elements. Selector can be: CSS selector (button.class, #id, [attr=val]), text=ExactText to find by visible text, contains=PartialText for partial match, or xpath=//expr for XPath. Prefer text= or contains= when the element has visible text but no unique CSS class.");
     }
     if allowed_actions.contains(&"browser_type") {
-        rules.push("7c. Use browser_type to enter text/input into form fields or search boxes.");
+        rules.push("7c. Use browser_type to enter text into form fields or search boxes. Selector supports the same formats as browser_click.");
     }
     if allowed_actions.contains(&"browser_read") {
         rules.push(
             "7d. Use browser_read to read the text content of the active page to analyze it.",
         );
     }
+    if allowed_actions.contains(&"browser_mouse_move") {
+        rules.push("7e. Use browser_mouse_move to move the real mouse cursor to absolute (x,y) coordinates.");
+    }
+    if allowed_actions.contains(&"browser_mouse_click") {
+        rules.push("7f. Use browser_mouse_click to perform a native mouse click at (x,y) coordinates. Use browser_screenshot first to find the target position.");
+    }
+    if allowed_actions.contains(&"browser_key_press") {
+        rules.push("7g. Use browser_key_press to press a keyboard key (e.g. Enter, Tab, Escape, ArrowDown). Use after browser_type or browser_mouse_click to interact with focused elements.");
+    }
+    if allowed_actions.contains(&"browser_screenshot") {
+        rules.push("7h. Use browser_screenshot to capture the current page as a PNG image (base64). Use it to inspect the visual state of the page before deciding where to click.");
+    }
     if allowed_actions.contains(&"memory_recall") {
         rules.push("8. Use memory_recall to search past interactions before asking the user to repeat context.");
     }
@@ -659,6 +698,14 @@ struct AgentInput {
     selector: String,
     #[serde(default)]
     text: String,
+    #[serde(default)]
+    x: Option<f64>,
+    #[serde(default)]
+    y: Option<f64>,
+    #[serde(default)]
+    button: String,
+    #[serde(default)]
+    key: String,
 }
 
 #[derive(Debug, Deserialize, Serialize)]
@@ -685,7 +732,8 @@ fn resolve_agent_config(
         return (config.clone(), "".to_string(), None, None);
     }
 
-    let enabled_agents: Vec<&crate::config::AgentConfig> = config.agents.iter().filter(|a| a.enabled).collect();
+    let enabled_agents: Vec<&crate::config::AgentConfig> =
+        config.agents.iter().filter(|a| a.enabled).collect();
     if enabled_agents.is_empty() {
         return (config.clone(), "".to_string(), None, None);
     }
@@ -694,7 +742,9 @@ fn resolve_agent_config(
         enabled_agents.iter().find(|a| a.id == id).copied()
     } else {
         // Multi-Agent Pipeline Collaboration (Planner -> Coder -> Reviewer)
-        let plan_created = trajectory.iter().any(|step| step.contains("- Action: create_plan"));
+        let plan_created = trajectory
+            .iter()
+            .any(|step| step.contains("- Action: create_plan"));
         if !plan_created {
             if let Some(planner) = enabled_agents.iter().find(|a| a.id == "planner") {
                 Some(*planner)
@@ -708,7 +758,9 @@ fn resolve_agent_config(
             });
             if edits_made {
                 if let Some(last_step) = trajectory.last() {
-                    if last_step.contains("- Action: write_file") || last_step.contains("- Action: apply_patch") {
+                    if last_step.contains("- Action: write_file")
+                        || last_step.contains("- Action: apply_patch")
+                    {
                         if let Some(reviewer) = enabled_agents.iter().find(|a| a.id == "reviewer") {
                             Some(*reviewer)
                         } else {
@@ -741,21 +793,26 @@ fn resolve_agent_config(
     cfg_clone.local_model_name = agent.model.clone();
     cfg_clone.ollama_model = agent.model.clone();
 
-    if let Some(key) = &agent.api_key {
-        if !key.trim().is_empty() {
-            match agent.provider.as_str() {
-                "gemini" => cfg_clone.api_key = key.clone(),
-                "openai" => cfg_clone.openai_api_key = key.clone(),
-                "anthropic" => cfg_clone.anthropic_api_key = key.clone(),
-                "openrouter" => cfg_clone.openrouter_api_key = key.clone(),
-                "deepseek" => cfg_clone.deepseek_api_key = key.clone(),
-                "huggingface" => cfg_clone.hf_api_key = key.clone(),
-                _ => {}
-            }
+    if let Some(key) = &agent.api_key
+        && !key.trim().is_empty()
+    {
+        match agent.provider.as_str() {
+            "gemini" => cfg_clone.api_key = key.clone(),
+            "openai" => cfg_clone.openai_api_key = key.clone(),
+            "anthropic" => cfg_clone.anthropic_api_key = key.clone(),
+            "openrouter" => cfg_clone.openrouter_api_key = key.clone(),
+            "deepseek" => cfg_clone.deepseek_api_key = key.clone(),
+            "huggingface" => cfg_clone.hf_api_key = key.clone(),
+            _ => {}
         }
     }
 
-    (cfg_clone, agent.system_instruction.clone(), Some(agent.name.clone()), Some(agent.model.clone()))
+    (
+        cfg_clone,
+        agent.system_instruction.clone(),
+        Some(agent.name.clone()),
+        Some(agent.model.clone()),
+    )
 }
 
 pub async fn orchestrate_agent_loop<Approve, Progress, Chunk>(
@@ -763,6 +820,7 @@ pub async fn orchestrate_agent_loop<Approve, Progress, Chunk>(
     task: &str,
     root: &Path,
     image_data_uri: Option<String>,
+    video_data_uri: Option<String>,
     chat_id: Option<&str>,
     agent_id: Option<&str>,
     fast_mode: bool,
@@ -784,30 +842,32 @@ where
         ))
     })?;
     let resolved_task = resolve_github_links(task, config).await;
-    let skills = crate::skills::learned_skills_context(Some(&root)).unwrap_or_default();
-    let mut observation = initial_observation(&resolved_task, &root, &skills);
-    let mut pending_image = image_data_uri;
-
-    let mut system_prompt = build_system_prompt(config);
     let chat_id = chat_id
         .map(str::trim)
         .filter(|chat_id| !chat_id.is_empty())
         .unwrap_or(DEFAULT_CONVERSATION_ID);
+    let skills =
+        crate::skills::learned_skills_context(Some(&root), Some(chat_id)).unwrap_or_default();
+    let mut observation = initial_observation(&resolved_task, &root, &skills);
+    let mut pending_image = image_data_uri;
+    let mut pending_video = video_data_uri;
+
+    let mut system_prompt = build_system_prompt(config);
 
     if let Ok(memory) = MemoryStore::open_default() {
         let mut profile_instructions = String::new();
-        if let Ok(Some(name)) = memory.get_profile("name") {
-            if !name.trim().is_empty() {
-                profile_instructions.push_str(&format!("User Name: {}\n", name.trim()));
-            }
+        if let Ok(Some(name)) = memory.get_profile("name")
+            && !name.trim().is_empty()
+        {
+            profile_instructions.push_str(&format!("User Name: {}\n", name.trim()));
         }
-        if let Ok(Some(preferences)) = memory.get_profile("preferences") {
-            if !preferences.trim().is_empty() {
-                profile_instructions.push_str(&format!(
-                    "User Preferences & Profile:\n{}\n",
-                    preferences.trim()
-                ));
-            }
+        if let Ok(Some(preferences)) = memory.get_profile("preferences")
+            && !preferences.trim().is_empty()
+        {
+            profile_instructions.push_str(&format!(
+                "User Preferences & Profile:\n{}\n",
+                preferences.trim()
+            ));
         }
 
         if !profile_instructions.is_empty() {
@@ -844,7 +904,8 @@ where
     let mut trajectory: Vec<String> = Vec::new();
 
     for step in 1..=MAX_STEPS {
-        let (active_config, agent_instruction, active_agent_name, active_model_name) = resolve_agent_config(config, agent_id, &trajectory);
+        let (active_config, agent_instruction, active_agent_name, active_model_name) =
+            resolve_agent_config(config, agent_id, &trajectory);
 
         progress(AgentProgress::Thinking {
             elapsed_secs: started_at.elapsed().as_secs(),
@@ -858,12 +919,14 @@ where
                 "\n\n[Active Environment Context]\n\
                  You are running on: {}\n\
                  Using AI Model: {}\n",
-                 active_config.ai_provider,
-                 model_name
+                active_config.ai_provider, model_name
             ));
         }
         if !agent_instruction.is_empty() {
-            active_system_prompt.push_str(&format!("\n\nYour Current Role & System Instructions:\n{}", agent_instruction));
+            active_system_prompt.push_str(&format!(
+                "\n\nYour Current Role & System Instructions:\n{}",
+                agent_instruction
+            ));
         }
 
         let (response, fallback) = send_chat_with_fallback(
@@ -874,6 +937,7 @@ where
                 chat_id: Some(chat_id.to_owned()),
                 image_data_uri: pending_image.take(),
                 audio_data_uri: None,
+                video_data_uri: pending_video.take(),
                 document_attachment: None,
                 workspace_path: None,
                 agent_id: None,
@@ -903,6 +967,7 @@ where
                         chat_id: Some(chat_id.to_owned()),
                         image_data_uri: None,
                         audio_data_uri: None,
+                        video_data_uri: None,
                         document_attachment: None,
                         workspace_path: None,
                         agent_id: None,
@@ -1261,14 +1326,14 @@ where
             if crate::is_browser_running(config).await {
                 let result = crate::browser::navigate(config, url)
                     .await
-                    .map_err(|e| OrchestrationError::Agent(e))?;
+                    .map_err(OrchestrationError::Agent)?;
                 Ok(result)
             } else {
                 let opened = if cfg!(target_os = "macos") {
                     std::process::Command::new("open").arg(url).spawn().is_ok()
                 } else if cfg!(target_os = "windows") {
                     std::process::Command::new("cmd")
-                        .args(&["/C", "start", url])
+                        .args(["/C", "start", url])
                         .spawn()
                         .is_ok()
                 } else {
@@ -1300,7 +1365,7 @@ where
             };
             let result = crate::browser::click(config, selector)
                 .await
-                .map_err(|e| OrchestrationError::Agent(e))?;
+                .map_err(OrchestrationError::Agent)?;
             Ok(result)
         }
         "browser_type" => {
@@ -1324,15 +1389,63 @@ where
             };
             let result = crate::browser::type_text(config, selector, text)
                 .await
-                .map_err(|e| OrchestrationError::Agent(e))?;
+                .map_err(OrchestrationError::Agent)?;
             Ok(result)
         }
         "browser_read" => {
             let result = crate::browser::read_page_text(config)
                 .await
-                .map_err(|e| OrchestrationError::Agent(e))?;
+                .map_err(OrchestrationError::Agent)?;
             Ok(result)
         }
+        "browser_mouse_move" => {
+            let x = input.x.ok_or_else(|| {
+                OrchestrationError::Agent("browser_mouse_move requires 'x'".into())
+            })?;
+            let y = input.y.ok_or_else(|| {
+                OrchestrationError::Agent("browser_mouse_move requires 'y'".into())
+            })?;
+            let result = crate::browser::mouse_move(config, x, y)
+                .await
+                .map_err(OrchestrationError::Agent)?;
+            Ok(result)
+        }
+        "browser_mouse_click" => {
+            let x = input.x.ok_or_else(|| {
+                OrchestrationError::Agent("browser_mouse_click requires 'x'".into())
+            })?;
+            let y = input.y.ok_or_else(|| {
+                OrchestrationError::Agent("browser_mouse_click requires 'y'".into())
+            })?;
+            let button = if input.button.is_empty() {
+                "left"
+            } else {
+                &input.button
+            };
+            let result = crate::browser::mouse_click(config, x, y, button)
+                .await
+                .map_err(OrchestrationError::Agent)?;
+            Ok(result)
+        }
+        "browser_key_press" => {
+            let key = if !input.key.is_empty() {
+                &input.key
+            } else {
+                return Err(OrchestrationError::Agent(
+                    "browser_key_press requires 'key'".into(),
+                ));
+            };
+            let result = crate::browser::key_press(config, key)
+                .await
+                .map_err(OrchestrationError::Agent)?;
+            Ok(result)
+        }
+        "browser_screenshot" => {
+            let data = crate::browser::screenshot(config)
+                .await
+                .map_err(OrchestrationError::Agent)?;
+            Ok(format!("data:image/png;base64,{data}"))
+        }
         "memory_recall" => {
             let query = required(&input.query, "query")?;
             let query_lower = query.to_ascii_lowercase();
@@ -1486,7 +1599,7 @@ where
                 path: file_name.to_owned(),
                 content: input.file_content.clone(),
             })
-            .map_err(|e| OrchestrationError::Agent(e))?;
+            .map_err(OrchestrationError::Agent)?;
 
             match approved {
                 ApprovalOutcome::Approved => {
@@ -1509,7 +1622,7 @@ where
                 name: name.to_owned(),
                 instruction: instruction.to_owned(),
             })
-            .map_err(|e| OrchestrationError::Agent(e))?;
+            .map_err(OrchestrationError::Agent)?;
 
             match approved {
                 ApprovalOutcome::Approved => Ok(execute_native_plugin(config, name, instruction)
@@ -1527,7 +1640,7 @@ where
                 tool: tool.to_owned(),
                 arguments: input.arguments.clone(),
             })
-            .map_err(|e| OrchestrationError::Agent(e))?;
+            .map_err(OrchestrationError::Agent)?;
 
             match approved {
                 ApprovalOutcome::Approved => Ok(serde_json::to_string_pretty(
@@ -1541,6 +1654,25 @@ where
                 ApprovalOutcome::Intercepted(obs) => Ok(obs),
             }
         }
+        "mcp_list_tools" => {
+            let server = required(&input.server, "server")?;
+            let approved = approve_cb(&AgentApproval::McpTool {
+                server: server.to_owned(),
+                tool: "list_tools".to_owned(),
+                arguments: serde_json::json!({}),
+            })
+            .map_err(OrchestrationError::Agent)?;
+
+            match approved {
+                ApprovalOutcome::Approved => Ok(serde_json::to_string_pretty(
+                    &crate::mcp::list_server_tools(config, server)
+                        .map_err(|e| OrchestrationError::Agent(e.to_string()))?,
+                )
+                .map_err(|e| OrchestrationError::Agent(e.to_string()))?),
+                ApprovalOutcome::Denied => Ok(format!("User denied MCP list tools: {}", server)),
+                ApprovalOutcome::Intercepted(obs) => Ok(obs),
+            }
+        }
         "run_shell" => {
             let command = required(&input.command, "command")?;
             let mode = classify_shell_command(command).mode.as_str().to_owned();
@@ -1548,7 +1680,7 @@ where
                 command: command.to_owned(),
                 mode,
             })
-            .map_err(|e| OrchestrationError::Agent(e))?;
+            .map_err(OrchestrationError::Agent)?;
 
             match approved {
                 ApprovalOutcome::Approved => run_shell(root, config, command),
@@ -1593,7 +1725,7 @@ where
                 hunks: patch.hunks.clone(),
                 diff,
             })
-            .map_err(|e| OrchestrationError::Agent(e))?;
+            .map_err(OrchestrationError::Agent)?;
 
             match approved {
                 ApprovalOutcome::Approved => {
@@ -1629,7 +1761,7 @@ where
                 content: input.file_content.clone(),
                 diff,
             })
-            .map_err(|e| OrchestrationError::Agent(e))?;
+            .map_err(OrchestrationError::Agent)?;
 
             match approved {
                 ApprovalOutcome::Approved => {
@@ -1823,13 +1955,13 @@ fn view_image(path: &Path, config: &MintConfig) -> Result<String, OrchestrationE
     }
     let bytes = std::fs::read(&path)
         .map_err(|e| OrchestrationError::Agent(format!("cannot read image: {e}")))?;
-    Ok(serde_json::to_string_pretty(&serde_json::json!({
+    serde_json::to_string_pretty(&serde_json::json!({
         "path": path,
         "bytes": bytes.len(),
         "mime": mime,
         "dataUri": format!("data:{mime};base64,{}", BASE64_STANDARD.encode(bytes)),
     }))
-    .map_err(|e| OrchestrationError::Agent(e.to_string()))?)
+    .map_err(|e| OrchestrationError::Agent(e.to_string()))
 }
 
 fn run_shell(
@@ -1845,14 +1977,13 @@ fn run_shell(
 
     let mut hint = "";
     let cmd_lower = command.to_lowercase();
-    if output.success {
-        if cmd_lower.contains("open")
+    if output.success
+        && (cmd_lower.contains("open")
             || cmd_lower.contains("launch")
             || cmd_lower.contains("chrome")
-            || cmd_lower.contains("firefox")
-        {
-            hint = "\nNote: Opening URLs, files, folders, or launching applications are background processes. Even if there are warnings or stdout/stderr outputs, since the command exited successfully with status 0, the operation has succeeded and you should now use the 'finish' action to inform the user.";
-        }
+            || cmd_lower.contains("firefox"))
+    {
+        hint = "\nNote: Opening URLs, files, folders, or launching applications are background processes. Even if there are warnings or stdout/stderr outputs, since the command exited successfully with status 0, the operation has succeeded and you should now use the 'finish' action to inform the user.";
     }
 
     Ok(format!(
@@ -1897,7 +2028,9 @@ fn action_fingerprint(decision: &AgentDecision) -> String {
 }
 
 fn initial_observation(task: &str, root: &Path, skills: &str) -> String {
-    let now = chrono::Local::now().format("%Y-%m-%d %H:%M:%S %Z").to_string();
+    let now = chrono::Local::now()
+        .format("%Y-%m-%d %H:%M:%S %Z")
+        .to_string();
     let mut observation = format!(
         "Current Time: {now}\nTask: {task}\nWorkspace: {}\nLearned skills:\n{}\n",
         root.display(),
@@ -2247,6 +2380,7 @@ Example response:
         chat_id: None,
         image_data_uri: None,
         audio_data_uri: None,
+        video_data_uri: None,
         document_attachment: None,
         workspace_path: None,
         agent_id: None,
@@ -2271,19 +2405,19 @@ Example response:
         text_reply.to_string()
     };
 
-    if let Ok(value) = serde_json::from_str::<serde_json::Value>(&clean_json) {
-        if let Some(obj) = value.as_object() {
-            if let Some(new_name) = obj.get("name").and_then(|v| v.as_str()) {
-                let trimmed_name = new_name.trim();
-                if !trimmed_name.is_empty() && trimmed_name != current_name {
-                    memory.set_profile("name", trimmed_name)?;
-                }
+    if let Ok(value) = serde_json::from_str::<serde_json::Value>(&clean_json)
+        && let Some(obj) = value.as_object()
+    {
+        if let Some(new_name) = obj.get("name").and_then(|v| v.as_str()) {
+            let trimmed_name = new_name.trim();
+            if !trimmed_name.is_empty() && trimmed_name != current_name {
+                memory.set_profile("name", trimmed_name)?;
             }
-            if let Some(new_pref) = obj.get("preferences").and_then(|v| v.as_str()) {
-                let trimmed_pref = new_pref.trim();
-                if !trimmed_pref.is_empty() && trimmed_pref != current_pref {
-                    memory.set_profile("preferences", trimmed_pref)?;
-                }
+        }
+        if let Some(new_pref) = obj.get("preferences").and_then(|v| v.as_str()) {
+            let trimmed_pref = new_pref.trim();
+            if !trimmed_pref.is_empty() && trimmed_pref != current_pref {
+                memory.set_profile("preferences", trimmed_pref)?;
             }
         }
     }
@@ -2294,6 +2428,7 @@ Example response:
 #[cfg(test)]
 mod tests {
     use super::*;
+    use crate::config::AgentConfig;
 
     #[test]
     fn preserves_request_without_history() {
@@ -2306,13 +2441,17 @@ mod tests {
             chat_id: None,
             image_data_uri: None,
             audio_data_uri: None,
+            video_data_uri: None,
             document_attachment: None,
             workspace_path: None,
             agent_id: None,
         };
-        assert_eq!(
-            enrich_request(&store, &request).unwrap().system_instruction,
-            "system"
+        let config = MintConfig::default();
+        assert!(
+            enrich_request(&config, &store, &request)
+                .unwrap()
+                .system_instruction
+                .starts_with("system")
         );
     }
 
@@ -2418,6 +2557,7 @@ mod tests {
     #[test]
     fn test_resolve_agent_config() {
         let mut config = MintConfig::default();
+        config.enable_agent_collaboration = true;
         config.agents = vec![
             AgentConfig {
                 id: "planner".into(),
@@ -2447,12 +2587,13 @@ mod tests {
         assert_eq!(name, Some("Planner".to_string()));
         assert_eq!(model, Some("gpt-4o".to_string()));
 
-        let (cfg, instr, name, model) = resolve_agent_config(&config, None, &[]);
+        let (cfg, instr, name, _model) = resolve_agent_config(&config, None, &[]);
         assert_eq!(cfg.ai_provider, "openai");
         assert_eq!(instr, "Planner instruction");
         assert_eq!(name, Some("Planner".to_string()));
 
-        let trajectory = vec!["Step 1:\n- Action: create_plan\n- Observation: all planned".to_string()];
+        let trajectory =
+            vec!["Step 1:\n- Action: create_plan\n- Observation: all planned".to_string()];
         let (cfg, instr, name, model) = resolve_agent_config(&config, None, &trajectory);
         assert_eq!(cfg.ai_provider, "gemini");
         assert_eq!(instr, "Coder instruction");