@pheem49/mint 1.17.0 → 1.18.0

package/crates/mint-core/src/browser/input.rs

@@ -7,17 +7,12 @@ use crate::MintConfig;
 use serde_json::json;
 
 use super::cdp::cdp_call_raw;
-use super::lifecycle::ensure_page_open;
-use super::logging::log_action;
 use super::navigate::wait_for_page_load;
 use super::overlay::inject_overlay;
 
 /// Move the real browser mouse cursor to (x, y) via CDP Input.dispatchMouseEvent.
 /// Also ensures overlay exists and updates cursor position.
 pub async fn mouse_move(config: &MintConfig, x: f64, y: f64) -> Result<String, String> {
-    log_action("MOUSE_MOVE", &format!("Moving mouse to ({x:.0},{y:.0})"));
-    ensure_page_open(config).await?;
-
     // Ensure overlay exists
     inject_overlay(config).await;
 
@@ -50,13 +45,9 @@ pub async fn mouse_move(config: &MintConfig, x: f64, y: f64) -> Result<String, S
                 json!({ "expression": cursor_script, "returnByValue": false }),
             )
             .await;
-            log_action("MOUSE_MOVE_SUCCESS", &format!("Moved to ({x:.0},{y:.0})"));
             Ok(format!("mouse moved to ({x:.0},{y:.0})"))
         }
-        Err(e) => {
-            log_action("MOUSE_MOVE_ERROR", &format!("Failed: {e}"));
-            Err(e)
-        }
+        Err(e) => Err(e),
     }
 }
 
@@ -68,12 +59,6 @@ pub async fn mouse_click(
     y: f64,
     button: &str,
 ) -> Result<String, String> {
-    log_action(
-        "MOUSE_CLICK",
-        &format!("Clicking ({x:.0},{y:.0}) btn={button}"),
-    );
-    ensure_page_open(config).await?;
-
     let button_str = match button {
         "right" => "right",
         "middle" => "middle",
@@ -114,11 +99,7 @@ pub async fn mouse_click(
             "modifiers": 0
         }),
     )
-    .await
-    .map_err(|e| {
-        log_action("MOUSE_CLICK_ERROR", &format!("mousePressed: {e}"));
-        e
-    })?;
+    .await?;
 
     tokio::time::sleep(std::time::Duration::from_millis(50)).await;
 
@@ -135,16 +116,8 @@ pub async fn mouse_click(
             "modifiers": 0
         }),
     )
-    .await
-    .map_err(|e| {
-        log_action("MOUSE_CLICK_ERROR", &format!("mouseReleased: {e}"));
-        e
-    })?;
+    .await?;
 
-    log_action(
-        "MOUSE_CLICK_SUCCESS",
-        &format!("Clicked ({x:.0},{y:.0}) {button_str}"),
-    );
     // The click may have landed on a link or submit button and triggered a
     // full page navigation — see `wait_for_page_load`'s doc comment.
     wait_for_page_load(config).await;
@@ -155,24 +128,9 @@ pub async fn mouse_click(
 
 /// Type text using CDP Input.insertText (native, supports any Unicode text).
 pub async fn type_text_native(config: &MintConfig, text: &str) -> Result<String, String> {
-    log_action(
-        "TYPE",
-        &format!("Native typing: {} characters", text.chars().count()),
-    );
-    ensure_page_open(config).await?;
-
     match cdp_call_raw(config, "Input.insertText", json!({ "text": text })).await {
-        Ok(_) => {
-            log_action(
-                "TYPE_SUCCESS",
-                &format!("Typed {} characters natively", text.len()),
-            );
-            Ok(format!("typed {} characters", text.len()))
-        }
-        Err(e) => {
-            log_action("TYPE_ERROR", &format!("Native type failed: {e}"));
-            Err(e)
-        }
+        Ok(_) => Ok(format!("typed {} characters", text.len())),
+        Err(e) => Err(e),
     }
 }
 
@@ -183,9 +141,6 @@ pub async fn type_text_native(config: &MintConfig, text: &str) -> Result<String,
 /// PageUp, PageDown, Space, F1–F12.
 /// Also accepts single printable characters.
 pub async fn key_press(config: &MintConfig, key: &str) -> Result<String, String> {
-    log_action("KEY_PRESS", &format!("Pressing key '{key}'"));
-    ensure_page_open(config).await?;
-
     let (key_code, code) = key_to_cdp_params(key);
 
     // keyDown. For Enter specifically, `text`/`unmodifiedText` must be set to
@@ -208,12 +163,7 @@ pub async fn key_press(config: &MintConfig, key: &str) -> Result<String, String>
         key_down["text"] = json!("\r");
         key_down["unmodifiedText"] = json!("\r");
     }
-    cdp_call_raw(config, "Input.dispatchKeyEvent", key_down)
-        .await
-        .map_err(|e| {
-            log_action("KEY_PRESS_ERROR", &format!("keyDown failed: {e}"));
-            e
-        })?;
+    cdp_call_raw(config, "Input.dispatchKeyEvent", key_down).await?;
 
     // char event for printable single characters
     if key.chars().count() == 1 && !key.chars().next().map(|c| c.is_control()).unwrap_or(true) {
@@ -248,13 +198,8 @@ pub async fn key_press(config: &MintConfig, key: &str) -> Result<String, String>
             "location": 0
         }),
     )
-    .await
-    .map_err(|e| {
-        log_action("KEY_PRESS_ERROR", &format!("keyUp failed: {e}"));
-        e
-    })?;
+    .await?;
 
-    log_action("KEY_PRESS_SUCCESS", &format!("Pressed '{key}'"));
     if matches!(key, "Enter" | "\n" | "\r") {
         // Enter commonly submits the focused form — see `wait_for_page_load`'s
         // doc comment. Other keys (Tab, Escape, arrows, ...) don't trigger

package/crates/mint-core/src/browser/interact.rs

@@ -7,8 +7,6 @@ use serde_json::{Value, json};
 
 use super::cdp::{cdp_call_raw, response_error};
 use super::input::{mouse_click, type_text_native};
-use super::lifecycle::ensure_page_open;
-use super::logging::log_action;
 use super::overlay::inject_overlay;
 
 /// Click a CSS selector element using native CDP mouse events.
@@ -19,14 +17,8 @@ use super::overlay::inject_overlay;
 pub async fn click(config: &MintConfig, selector: &str) -> Result<String, String> {
     let selector = selector.trim();
     if selector.is_empty() || selector.len() > 500 {
-        log_action(
-            "CLICK_ERROR",
-            "Browser selector must contain between 1 and 500 characters",
-        );
         return Err("browser selector must contain between 1 and 500 characters".into());
     }
-    log_action("CLICK", &format!("Clicking element '{selector}'"));
-    ensure_page_open(config).await?;
 
     // Ensure overlay exists before doing any visual interaction
     inject_overlay(config).await;
@@ -40,14 +32,8 @@ pub async fn click(config: &MintConfig, selector: &str) -> Result<String, String
 pub async fn type_text(config: &MintConfig, selector: &str, text: &str) -> Result<String, String> {
     let selector = selector.trim();
     if selector.is_empty() || selector.len() > 500 {
-        log_action(
-            "TYPE_ERROR",
-            "Browser selector must contain between 1 and 500 characters",
-        );
         return Err("browser selector must contain between 1 and 500 characters".into());
     }
-    log_action("TYPE", &format!("Typing into '{selector}'"));
-    ensure_page_open(config).await?;
 
     edit_text(config, selector, text, false).await
 }

package/crates/mint-core/src/browser/mod.rs

@@ -1,45 +1,24 @@
-//! Browser automation for `mint auto`: drives a real Chrome/Chromium/Edge
-//! instance over the Chrome DevTools Protocol so the AI can navigate, read,
-//! click, type, and screenshot a page.
-//!
-//! Split by concern:
-//! - `session` — run-scoped tab leases, observations, verification, and recovery
-//! - `cdp` — the pinned, bounded CDP websocket transport
-//! - `lifecycle` — spawning/detecting the automation browser instance
-//! - `navigate` — navigation and page-state reading (tabs, text, screenshot)
-//! - `interact` — selector-driven click/type
-//! - `input` — native mouse/keyboard primitives (`interact` builds on these)
-//! - `overlay` — the visible green-aura + cursor overlay injected into the page
-//! - `logging` — the `browser-automation.log` tail `mint auto` reads from
+//! Browser automation and headless Chrome integration. Drives Chromium over CDP
+//! for bounded workflows (`mint browser run`) and CLI shell execution.
 
 mod cdp;
 mod evidence;
+pub mod headless;
 mod input;
 mod interact;
-mod lifecycle;
-mod logging;
 mod navigate;
 mod overlay;
 pub mod runtime;
 mod session;
 pub mod workflow;
 
-pub(crate) use lifecycle::BROWSER_TOOLS;
-pub use session::{
-    BrowserActionResult, BrowserObservation, BrowserSession, capture_metadata, execute_action,
-    run_session, with_tab,
-};
-pub(crate) use session::{finish_evidence as session_finish_evidence, selected_tab};
+pub(crate) use session::{capture_metadata, execute_action, run_session, selected_tab};
 
-use serde::Serialize;
+pub(crate) use input::{key_press, mouse_click, mouse_move};
+pub(crate) use interact::{click, get_element_coordinates, type_text};
+pub(crate) use navigate::{list_tabs, navigate, read_page_text, screenshot};
 
-pub use input::{key_press, mouse_click, mouse_move, type_text_native};
-pub use interact::{click, get_element_coordinates, type_text};
-pub use lifecycle::{
-    enable_browser_tools, ensure_page_open, is_browser_running, spawn_automation_browser,
-    spawn_automation_browser_with_url,
-};
-pub use navigate::{list_tabs, navigate, read_page_text, screenshot};
+use serde::Serialize;
 
 #[derive(Debug, Clone, Serialize)]
 #[serde(rename_all = "camelCase")]

package/crates/mint-core/src/browser/navigate.rs

@@ -6,13 +6,8 @@ use serde_json::json;
 
 use super::BrowserTab;
 use super::cdp::{cdp_call, cdp_call_raw, fetch_pages, response_error};
-use super::lifecycle::{ensure_page_open, is_browser_running};
-use super::logging::log_action;
 
 pub async fn list_tabs(config: &MintConfig) -> Result<Vec<BrowserTab>, String> {
-    if !is_browser_running(config).await {
-        return Err("Browser automation is not running. Please run 'mint auto' first.".to_string());
-    }
     Ok(fetch_pages(config)
         .await?
         .into_iter()
@@ -44,8 +39,6 @@ pub(super) fn validate_url(url: &str) -> Result<(), String> {
 
 pub async fn navigate(config: &MintConfig, url: &str) -> Result<String, String> {
     validate_url(url)?;
-    log_action("NAVIGATE", &format!("Navigating to {url}"));
-    ensure_page_open(config).await?;
     match cdp_call(config, "Page.navigate", json!({ "url": url })).await {
         Ok(response) => {
             if let Some(error) = response["result"]["errorText"].as_str() {
@@ -53,21 +46,13 @@ pub async fn navigate(config: &MintConfig, url: &str) -> Result<String, String>
             }
             if response["result"]["frameId"].as_str().is_some() {
                 wait_for_page_load(config).await;
-                log_action(
-                    "NAVIGATE_SUCCESS",
-                    &format!("Successfully navigated to {url}"),
-                );
                 Ok(format!("navigating to {url}"))
             } else {
                 let err = response_error(&response);
-                log_action("NAVIGATE_ERROR", &format!("Failed: {err}"));
                 Err(err)
             }
         }
-        Err(e) => {
-            log_action("NAVIGATE_ERROR", &format!("Websocket error: {e}"));
-            Err(e)
-        }
+        Err(e) => Err(e),
     }
 }
 
@@ -110,8 +95,6 @@ pub(super) async fn wait_for_page_load(config: &MintConfig) {
 }
 
 pub async fn read_page_text(config: &MintConfig) -> Result<String, String> {
-    log_action("READ", "Reading page text content");
-    ensure_page_open(config).await?;
     match cdp_call(
         config,
         "Runtime.evaluate",
@@ -144,19 +127,13 @@ pub async fn read_page_text(config: &MintConfig) -> Result<String, String> {
     {
         Ok(response) => {
             if let Some(val) = response["result"]["result"]["value"].as_str() {
-                log_action(
-                    "READ_SUCCESS",
-                    &format!("Successfully read {} characters", val.len()),
-                );
                 Ok(val.to_owned())
             } else {
                 let err = response_error(&response);
-                log_action("READ_ERROR", &format!("Failed: {err}"));
                 Err(err)
             }
         }
         Err(e) => {
-            log_action("READ_ERROR", &format!("Websocket error: {e}"));
             Err(e)
         }
     }
@@ -172,9 +149,6 @@ pub(super) async fn capture_page(
     config: &MintConfig,
     args: &serde_json::Value,
 ) -> Result<String, String> {
-    log_action("SCREENSHOT", "Capturing screenshot");
-    ensure_page_open(config).await?;
-
     let mode = args["mode"]
         .as_str()
         .filter(|s| !s.is_empty())
@@ -234,20 +208,12 @@ pub(super) async fn capture_page(
                 if data.len() > crate::media::tool_images::ORIGINAL_LIMIT.div_ceil(3) * 4 + 4 {
                     return Err("Screenshot exceeds 20 MiB; capture a smaller region.".into());
                 }
-                log_action(
-                    "SCREENSHOT_SUCCESS",
-                    &format!("Captured {} base64 bytes", data.len()),
-                );
                 Ok(data.to_owned())
             } else {
                 let err = response_error(&response);
-                log_action("SCREENSHOT_ERROR", &format!("Failed: {err}"));
                 Err(err)
             }
         }
-        Err(e) => {
-            log_action("SCREENSHOT_ERROR", &format!("Websocket error: {e}"));
-            Err(e)
-        }
+        Err(e) => Err(e),
     }
 }

package/crates/mint-core/src/browser/runtime.rs

@@ -40,12 +40,11 @@ impl Drop for ManagedBrowser {
 
 impl ManagedBrowser {
     pub fn metadata(&self) -> Value {
-        json!({"mode":if self.headless {"headless"} else {"headed"},"command":self.command,"diagnostics":self.diagnostics.lock().unwrap().as_str()})
+        json!({"mode":"headless","command":self.command,"diagnostics":self.diagnostics.lock().unwrap().as_str()})
     }
 
     pub async fn launch(config: &MintConfig) -> Result<Self, String> {
-        let headless =
-            config.extra.get("browserAgentMode").and_then(Value::as_str) != Some("headed");
+        let headless = true;
         let width = config
             .extra
             .get("browserViewportWidth")
@@ -240,7 +239,6 @@ impl ManagedBrowser {
                 let endpoint = format!("http://127.0.0.1:{port}/json/list");
                 if super::cdp::fetch_pages_endpoint(&endpoint).await.is_ok() {
                     runtime.endpoint = endpoint;
-                    super::logging::log_action("LAUNCH", &runtime.command);
                     return Ok(runtime);
                 }
             }