@pheem49/mint 1.15.0 → 1.16.0

package/src/renderer/shared/components/ChatMessageItem.test.tsx

@@ -0,0 +1,68 @@
+import { describe, expect, it } from 'vitest'
+import { renderToStaticMarkup } from 'react-dom/server'
+import { FormattedMessage } from './FormattedMessage'
+import ChatMessageItem, { type ChatMessageItemProps } from './ChatMessageItem'
+import type { AgentProgress } from '../types'
+import { compactAgentProgressForPersistence, reduceLiveAgentProgress } from '../agentProgress'
+
+const action = () => {}
+const base: ChatMessageItemProps = {
+  interaction: { id: 7, status: 'completed', aiText: 'Ready', userText: 'Hello', createdAt: '2026-10-10T00:00:00Z' },
+  copiedId: null, speakingText: null, agentActivitySnapshots: {}, thinkingExpanded: {},
+  onThinkingExpandedChange: action, handleCopyMessage: action, speak: action,
+  toggleActivity: action, renderFileChanges: () => null,
+}
+const unchanged = (next: Partial<ChatMessageItemProps>) => (ChatMessageItem as any).compare(base, { ...base, ...next })
+
+describe('message update isolation', () => {
+  it('updates a file summary when its initially expanded review is collapsed', () => {
+    expect(unchanged({ openReviewIds: { '7': false } })).toBe(false)
+  })
+  it('updates only the message whose file details or show-more state changed', () => {
+    expect(unchanged({ openFileDiffs: { '8-/other.ts': true } })).toBe(true)
+    expect(unchanged({ openFileDiffs: { '7-/own.ts': true } })).toBe(false)
+    expect(unchanged({ showAllFileChanges: { '8': true } })).toBe(true)
+    expect(unchanged({ showAllFileChanges: { '7': true } })).toBe(false)
+  })
+  it('does not retain stale user actions', () => {
+    expect(unchanged({ onEditMessage: () => {} })).toBe(false)
+  })
+})
+
+describe('pasted message line breaks on Desktop and Web', () => {
+  it('renders CR-only bullet lines from TUI history as separate list items', () => {
+    const html = renderToStaticMarkup(<FormattedMessage text={'Token weather\r\r• ☀ Clear\r• 134.4k / 200k\r• ▲ +98.3k last turn'} />)
+    expect(html.match(/class="chat-list-item chat-bullet-item"/g) ?? []).toHaveLength(3)
+    expect(html).toContain('☀ Clear')
+    expect(html).toContain('▲ +98.3k last turn')
+  })
+})
+
+describe('view_image results on Desktop and Web', () => {
+  const image = 'data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAAEAAAABCAQAAAC1HAwCAAAAC0lEQVR42mP8/x8AAwMCAO+jRZkAAAAASUVORK5CYII='
+  const progress: AgentProgress[] = [
+    { type: 'ToolStart', data: { callId: 'view-1', action: 'view_image', input: { path: '/workspace/screens/mobile.png' } } },
+    { type: 'ToolEnd', data: { callId: 'view-1', action: 'view_image', input: { path: '/workspace/screens/mobile.png' }, result: `${image}\n\n[Hook] Image inspected` } },
+    { type: 'ToolEnd', data: { action: 'view_image', input: { path: '/private/denied.png' }, status: 'failed', result: image } },
+    { type: 'ToolEnd', data: { action: 'read_file', input: { path: 'note.txt' }, result: image } },
+  ]
+  it.each(['completed', 'failed', 'interrupted'])('keeps viewed images visible in %s history with Activity collapsed', status => {
+    const saved = JSON.parse(JSON.stringify(compactAgentProgressForPersistence(progress)))
+    const html = renderToStaticMarkup(<ChatMessageItem {...base} interaction={{ ...base.interaction, status, agentActivity: saved }} />)
+    expect(html).toContain(`src="${image}"`)
+    expect(html).toContain('alt="Viewed image: mobile.png"')
+    expect(html).toContain('aria-label="Expand mobile.png"')
+    expect(html.match(/data-viewed-image=/g)).toHaveLength(1)
+    expect(html).not.toContain('Expand denied.png')
+  })
+  it('keeps a viewed image after many later tools complete in the same run', () => {
+    const later: AgentProgress[] = Array.from({ length: 40 }, (_, index) => ({ type: 'ToolEnd', data: { action: 'read_file', input: { path: `file-${index}.md` }, result: 'Read' } }))
+    const live = [...progress, ...later].reduce(reduceLiveAgentProgress, [] as AgentProgress[])
+    const html = renderToStaticMarkup(<ChatMessageItem {...base} agentActivitySnapshots={{ '7': live }} />)
+    expect(html).toContain('aria-label="Expand mobile.png"')
+  })
+  it.each(['https://example.com/private.png', 'data:text/html;base64,PHNjcmlwdD4=', 'data:image/png;base64,%%%invalid', 'Error: cannot read image', 'Image exists but is too large to inline'])('does not embed an unavailable or non-image result: %s', result => {
+    const html = renderToStaticMarkup(<ChatMessageItem {...base} interaction={{ ...base.interaction, agentActivity: [{ type: 'ToolEnd', data: { action: 'view_image', input: { path: 'unavailable.png' }, result } }] }} />)
+    expect(html).not.toContain('data-viewed-image=')
+  })
+})

package/src/renderer/shared/components/ChatMessageItem.tsx

@@ -1,13 +1,19 @@
 import React, { useMemo } from 'react'
-import { renderFormattedMessage, renderCopyIcon, renderSpeakerIcon } from '../utils/markdown'
+import { renderCopyIcon, renderSpeakerIcon } from '../utils/markdown'
 import { fallbackNotice } from '../utils/providers'
 import WeatherCard from './WeatherCard'
 import StockCard from './StockCard'
 import CalculationCard from './CalculationCard'
 import ImageSearchCard from './ImageSearchCard'
 import ImageGenCard from './ImageGenCard'
+import McpToolResults from './McpToolResults'
+import ViewedImages from './ViewedImages'
 import { parseUtcDate } from '../utils/ui'
 import { parseWebSearchSources } from '../utils/agentActivity'
+import { EMPTY_AGENT_PROGRESS } from '../agentProgress'
+import { FormattedMessage } from './FormattedMessage'
+import { ProgressActivity } from './ProgressActivity'
+import SourcesBlock from './SourcesBlock'
 
 export interface ChatMessageItemProps {
   interaction: any
@@ -22,9 +28,10 @@ export interface ChatMessageItemProps {
   onThinkingExpandedChange: (key: string, expanded: boolean) => void
   handleCopyMessage: (id: string | number, text: string) => void
   speak: (text: string) => void
-  renderCompletedActivity: (interaction: any) => React.ReactNode
+  toggleActivity: (id: string) => void
+  showAllFileChanges?: Record<string, boolean>
+  workspacePath?: string
   renderFileChanges: (interaction: any) => React.ReactNode
-  renderWebSearchSources: (interaction: any) => React.ReactNode
 }
 
 const ChatMessageItem = React.memo(
@@ -42,23 +49,22 @@ const ChatMessageItem = React.memo(
       onThinkingExpandedChange,
       handleCopyMessage,
       speak,
-      renderCompletedActivity,
+      toggleActivity,
       renderFileChanges,
-      renderWebSearchSources,
     } = props
 
     const isSystemEvent = interaction.provider === 'system' && interaction.model === 'provider_change'
 
     const memoizedUserContent = useMemo(() => {
       if (!interaction.userText) return null
-      return renderFormattedMessage(interaction.userText)
+      return <FormattedMessage text={interaction.userText} />
     }, [interaction.userText])
 
-    const progress = agentActivitySnapshots[String(interaction.id)] ?? interaction.agentActivity ?? []
+    const progress = agentActivitySnapshots[String(interaction.id)] ?? interaction.agentActivity ?? EMPTY_AGENT_PROGRESS
     const webSources = useMemo(() => parseWebSearchSources(progress), [progress])
     const memoizedAiContent = useMemo(() => {
       if (!interaction.aiText) return null
-      return renderFormattedMessage(interaction.aiText, webSources)
+      return <FormattedMessage text={interaction.aiText} sources={webSources} />
     }, [interaction.aiText, webSources])
 
     if (isSystemEvent) {
@@ -208,13 +214,16 @@ const ChatMessageItem = React.memo(
         )}
         <div className="message ai-message">
           <div className="bubble-wrapper">
-            {interaction.status === 'completed' && renderCompletedActivity(interaction)}
+            {interaction.status === 'completed' && <ProgressActivity progress={progress} id={String(interaction.id)}
+              historical isOpen={Boolean(openActivityIds?.[String(interaction.id)])} onToggle={toggleActivity} />}
             {interaction.status === 'completed' && renderFileChanges(interaction)}
             <div className="message-bubble">
               {interaction.status === 'queued' && <span>Queued for this session…</span>}
               {interaction.status === 'running' && <span>Mint is responding…</span>}
               {interaction.status === 'failed' && <span>This turn failed. Send the prompt again to retry.</span>}
               {interaction.status === 'interrupted' && <span>This turn was interrupted. Send the prompt again to retry.</span>}
+              <McpToolResults progress={progress} running={interaction.status === 'running'} interrupted={interaction.status === 'interrupted'} />
+              <ViewedImages progress={progress} />
               {fallbackWeatherData && <WeatherCard data={fallbackWeatherData} />}
               {fallbackStockData && <StockCard data={fallbackStockData} />}
               {fallbackCalcData && <CalculationCard data={fallbackCalcData} />}
@@ -222,7 +231,7 @@ const ChatMessageItem = React.memo(
               {fallbackImageGenData && <ImageGenCard data={fallbackImageGenData} />}
               {memoizedAiContent}
             </div>
-            {renderWebSearchSources(interaction)}
+            {webSources.length > 0 && <SourcesBlock sources={webSources} />}
             <div className="message-time" style={{ display: 'flex', alignItems: 'center', gap: '8px' }}>
               {interaction.status === 'completed' && <span className="provider-model-chip" data-provider={(interaction.provider || '').toLowerCase()} title={`${interaction.provider} • ${interaction.model}`}>
                 <span className="provider-chip-dot" aria-hidden="true" />
@@ -257,9 +266,14 @@ const ChatMessageItem = React.memo(
     )
   },
   (prevProps, nextProps) => {
+    if (prevProps.onEditMessage !== nextProps.onEditMessage
+      || prevProps.onThinkingExpandedChange !== nextProps.onThinkingExpandedChange
+      || prevProps.handleCopyMessage !== nextProps.handleCopyMessage
+      || prevProps.speak !== nextProps.speak
+      || prevProps.toggleActivity !== nextProps.toggleActivity) return false
     const p = prevProps.interaction
     const n = nextProps.interaction
-    if (p.id !== n.id || p.aiText !== n.aiText || p.userText !== n.userText || p.createdAt !== n.createdAt || p.status !== n.status || p.agentActivity !== n.agentActivity) {
+    if (p.id !== n.id || p.aiText !== n.aiText || p.userText !== n.userText || p.createdAt !== n.createdAt || p.status !== n.status || p.agentActivity !== n.agentActivity || p.provider !== n.provider || p.model !== n.model || p.fallbackProvider !== n.fallbackProvider || p.fallbackReason !== n.fallbackReason || p.chatId !== n.chatId) {
       return false
     }
 
@@ -287,13 +301,19 @@ const ChatMessageItem = React.memo(
     const nextOpenActivity = nextProps.openActivityIds?.[String(n.id)] ?? false
     if (prevOpenActivity !== nextOpenActivity) return false
 
-    const prevOpenReview = prevProps.openReviewIds?.[String(p.id)] ?? false
-    const nextOpenReview = nextProps.openReviewIds?.[String(n.id)] ?? false
+    const prevOpenReview = prevProps.openReviewIds?.[String(p.id)] ?? true
+    const nextOpenReview = nextProps.openReviewIds?.[String(n.id)] ?? true
     if (prevOpenReview !== nextOpenReview) return false
 
-    const prevOpenFileDiffs = prevProps.openFileDiffs
-    const nextOpenFileDiffs = nextProps.openFileDiffs
-    if (prevOpenFileDiffs !== nextOpenFileDiffs) return false
+    if (prevProps.workspacePath !== nextProps.workspacePath) return false
+    if (Boolean(prevProps.showAllFileChanges?.[String(p.id)]) !== Boolean(nextProps.showAllFileChanges?.[String(n.id)])) return false
+    if (prevProps.openFileDiffs !== nextProps.openFileDiffs) {
+      const prefix = `${p.id}-`
+      const keys = new Set([...Object.keys(prevProps.openFileDiffs ?? {}), ...Object.keys(nextProps.openFileDiffs ?? {})])
+      for (const key of keys) {
+        if (key.startsWith(prefix) && Boolean(prevProps.openFileDiffs?.[key]) !== Boolean(nextProps.openFileDiffs?.[key])) return false
+      }
+    }
 
     const prevSnap = prevProps.agentActivitySnapshots[String(p.id)]
     const nextSnap = nextProps.agentActivitySnapshots[String(n.id)]

package/src/renderer/shared/components/ChatPanel.test.tsx

@@ -0,0 +1,21 @@
+import { createElement } from 'react'
+import { renderToStaticMarkup } from 'react-dom/server'
+import { describe, expect, it } from 'vitest'
+import ChatPanel from './ChatPanel'
+import { chatPanelFixture } from '../../tests/chatPanelFixture'
+import { installRendererPlatform } from '../platform'
+import * as webAdapter from '../../src-web/tauri'
+
+describe('Web Sources entry point', () => {
+  it('shows Sources beside Tools in the real web chat header', () => {
+    installRendererPlatform(webAdapter)
+    const html = renderToStaticMarkup(createElement(ChatPanel, { ...chatPanelFixture(), showSessionSources: true } as any))
+    expect(html).toContain('aria-label="Open session sources"')
+    expect(html.indexOf('Open session sources')).toBeLessThan(html.indexOf('Open tools panel'))
+  })
+  it('leaves Desktop Sources in its existing titlebar', () => {
+    installRendererPlatform(webAdapter)
+    const html = renderToStaticMarkup(createElement(ChatPanel, { ...chatPanelFixture(), showSessionSources: false } as any))
+    expect(html).not.toContain('Open session sources')
+  })
+})