@pharaoh-so/mcp 0.3.59 → 0.3.61

package/project-memory/setup.mjs

@@ -4,6 +4,7 @@ import { basename, dirname, isAbsolute, join, relative, sep } from "node:path";
 import { bundledHook, installMemoryBundle, packagedMemoryBundle } from "./bundle.mjs";
 import { hasLegacyHooks, hasUserHooks, updateHooks, updateUserHooks } from "./hook-config.mjs";
 import { atomicWrite, checkout, git, hasMemoryGit } from "./local.mjs";
+import { MEMORY_HOOK_CLIENTS, readHookPreferences, writeHookPreferences } from "./preferences.mjs";
 import {
 	legacySettingsPath,
 	matchingMemoryHint,
@@ -13,8 +14,6 @@ import {
 	readHookSettings,
 } from "./user-target.mjs";
 
-const CLIENTS = ["claude-code", "codex"];
-
 function userSettings(client, home, env) {
 	const codex = client === "codex";
 	const directory =
@@ -82,7 +81,7 @@ function migrateCheckout(client, target, notices) {
 	}
 }
 
-function syncUserHooks(client, home, env, target, hookPath, node, alreadyActive) {
+function syncUserHooks(client, home, env, target, hookPath, node, alreadyActive, graphCues) {
 	let known = Boolean(alreadyActive);
 	try {
 		const settings = inspectSettings(userSettings(client, home, env));
@@ -95,7 +94,7 @@ function syncUserHooks(client, home, env, target, hookPath, node, alreadyActive)
 				hasLegacyHooks(settings.config, client, target.root);
 			writeSettings(
 				settings,
-				updateUserHooks(settings.config, client, hookPath, node),
+				updateUserHooks(settings.config, client, hookPath, node, graphCues),
 				target,
 				checkoutHook,
 			);
@@ -110,10 +109,118 @@ function writeActivation(path, active) {
 	else rmSync(path, { force: true });
 }
 
+/** Resolve explicit choices only after a supported client's MCP registration. */
+export async function chooseMemoryHooks({
+	credentials,
+	clients,
+	requested = false,
+	ask,
+	home = homedir(),
+	env = process.env,
+}) {
+	const choices = { accepted: [], declined: [], graphClients: [], notices: [] };
+	if (typeof process.getuid !== "function") {
+		if (requested)
+			choices.notices.push("Pharaoh: project memory hooks need a POSIX client with system Git.");
+		return choices;
+	}
+	if (credentials?.project_memory_status === "unavailable") {
+		if (requested)
+			choices.notices.push(
+				"Pharaoh: project memory eligibility could not be checked. Retry setup to enable hooks.",
+			);
+		return choices;
+	}
+	if (!projectMemoryHint(credentials).length) {
+		if (requested) choices.notices.push("Pharaoh: this session has no project memory hook grant.");
+		return credentials ? { ...choices, removeUnentitled: true } : choices;
+	}
+	if (!clients.length || !hasMemoryGit) {
+		if (requested && !hasMemoryGit)
+			choices.notices.push("Pharaoh: project memory hooks need a POSIX client with system Git.");
+		return choices;
+	}
+	const previous = readHookPreferences(home);
+	const active = readActiveMemoryClients(home);
+	const next = { ...previous };
+	for (const client of MEMORY_HOOK_CLIENTS) {
+		if (!clients.includes(client)) continue;
+		const label = client === "codex" ? "Codex" : "Claude Code";
+		let config;
+		try {
+			config = inspectSettings(userSettings(client, home, env)).config;
+		} catch {
+			// An unreadable settings file cannot establish a previous installation.
+		}
+		if (client === "claude-code" && config?.disableAllHooks === true) continue;
+		const choice = { ...previous[client] };
+		const memoryHook =
+			active[client] &&
+			hasUserHooks({ hooks: { UserPromptSubmit: config?.hooks?.UserPromptSubmit } }, client);
+		if (requested) choice.memory = true;
+		else if (choice.memory !== false && (choice.memory !== true || !memoryHook)) {
+			const answer = await ask(
+				`Enable Pharaoh project memory hooks in ${label} (recommended)? [Y/n] `,
+				true,
+			);
+			if (answer === null) continue;
+			choice.memory = answer;
+			if (!answer && choice.graph === true) delete choice.graph;
+		}
+		if (choice.memory === true) {
+			let graphEnabled =
+				choice.graph === true &&
+				["PreToolUse", "PostToolUse"].every((event) =>
+					hasUserHooks({ hooks: { [event]: config?.hooks?.[event] } }, client),
+				);
+			if (requested || choice.graph === undefined || (choice.graph === true && !graphEnabled)) {
+				const answer = await ask(
+					`Enable advisory Pharaoh worktree cues in ${label}? [y/N] `,
+					false,
+				);
+				if (answer !== null) {
+					choice.graph = answer;
+					graphEnabled = answer;
+				}
+			}
+			choices.accepted.push(client);
+			if (graphEnabled) choices.graphClients.push(client);
+		} else {
+			choices.declined.push(client);
+		}
+		next[client] = choice;
+	}
+	writeHookPreferences(next, home, previous);
+	return choices;
+}
+
+/** Apply the outcome against the saved choices, which can change after the prompt. */
+export function applyMemoryHookChoices(decision, options = {}) {
+	const { accepted, declined, graphClients, removeUnentitled } = decision;
+	const notices = [...decision.notices];
+	if (removeUnentitled)
+		return [...notices, ...syncMemoryHooks({ ...options, clients: MEMORY_HOOK_CLIENTS })];
+
+	if (declined.length) {
+		const saved = readHookPreferences(options.home);
+		const clients = declined.filter((client) => saved[client]?.memory === false);
+		if (clients.length) notices.push(...syncMemoryHooks({ ...options, clients }));
+	}
+	if (accepted.length) {
+		const saved = readHookPreferences(options.home);
+		const clients = accepted.filter((client) => saved[client]?.memory === true);
+		const cues = graphClients.filter((client) => saved[client]?.graph === true);
+		if (clients.length)
+			notices.push(...syncMemoryHooks({ ...options, clients, graphClients: cues, enable: true }));
+	}
+	return notices;
+}
+
 /** Run only during setup or explicit cleanup of the local memory hooks. */
 export function syncMemoryHooks({
 	credentials,
-	clients = [],
+	clients = MEMORY_HOOK_CLIENTS,
+	graphClients = [],
 	enable = false,
 	home = homedir(),
 	env = process.env,
@@ -150,8 +257,8 @@ export function syncMemoryHooks({
 		}
 	}
 
-	for (const client of CLIENTS) {
-		if (enable && !clients.includes(client)) continue;
+	for (const client of MEMORY_HOOK_CLIENTS) {
+		if (!clients.includes(client)) continue;
 		const next = { ...active, [client]: digest };
 		try {
 			// Enable the replacement before swapping any settings, so failed
@@ -159,7 +266,16 @@ export function syncMemoryHooks({
 			const replacing = enable && active[client] !== digest;
 			if (replacing) writeActivation(activePath, next);
 			try {
-				syncUserHooks(client, home, env, target, installed, node, active[client]);
+				syncUserHooks(
+					client,
+					home,
+					env,
+					target,
+					installed,
+					node,
+					active[client],
+					graphClients.includes(client),
+				);
 			} catch (error) {
 				if (replacing) writeActivation(activePath, active);
 				throw error;
@@ -176,8 +292,16 @@ export function syncMemoryHooks({
 	}
 
 	// Deactivate loaded user hooks even if known settings could not be edited.
-	if (!enable && Object.keys(active).length) writeActivation(activePath, {});
-	for (const client of enable ? configured : CLIENTS) migrateCheckout(client, target, notices);
+	if (!enable) {
+		const remaining = Object.fromEntries(
+			Object.entries(active).filter(([client]) => !clients.includes(client)),
+		);
+		if (Object.keys(remaining).length !== Object.keys(active).length)
+			writeActivation(activePath, remaining);
+	}
+	for (const client of enable ? configured : clients) {
+		if (MEMORY_HOOK_CLIENTS.includes(client)) migrateCheckout(client, target, notices);
+	}
 	if (configured.length) {
 		notices.push(
 			"Pharaoh project memory reminders are set up for your eligible repositories. Start a new local conversation.",