@pharaoh-so/mcp 0.3.14 → 0.3.16
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/.claude-plugin/plugin.json +1 -1
- package/commands/plan.md +142 -0
- package/commands/review.md +5 -0
- package/dist/install-skills.d.ts +6 -2
- package/dist/install-skills.js +156 -42
- package/package.json +2 -1
- package/skills/brainstorm/SKILL.md +1 -1
- package/skills/plan/SKILL.md +26 -24
- package/skills/audit-tests/SKILL.md +0 -89
- package/skills/debt/SKILL.md +0 -34
- package/skills/execute/SKILL.md +0 -58
- package/skills/explore/SKILL.md +0 -33
- package/skills/finish/SKILL.md +0 -80
- package/skills/health/SKILL.md +0 -37
- package/skills/investigate/SKILL.md +0 -35
- package/skills/onboard/SKILL.md +0 -33
- package/skills/orchestrate/SKILL.md +0 -145
- package/skills/pr/SKILL.md +0 -53
- package/skills/review-codex/SKILL.md +0 -81
- package/skills/review-receive/SKILL.md +0 -82
- package/skills/wiring/SKILL.md +0 -35
- package/skills/worktree/SKILL.md +0 -86
|
@@ -1,82 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: review-receive
|
|
3
|
-
prompt-name: receive-code-review
|
|
4
|
-
description: "Receive code review feedback with technical rigor. No performative agreement — verify suggestions against codebase reality before implementing. Push back with evidence when feedback is wrong. Clarify all unclear items before implementing any. External feedback is suggestions to evaluate, not orders to follow."
|
|
5
|
-
version: 0.2.0
|
|
6
|
-
homepage: https://pharaoh.so
|
|
7
|
-
user-invocable: true
|
|
8
|
-
metadata: {"emoji": "☥", "tags": ["code-review", "feedback", "technical-rigor", "pushback", "collaboration"]}
|
|
9
|
-
---
|
|
10
|
-
|
|
11
|
-
# Receiving Code Review
|
|
12
|
-
|
|
13
|
-
Code review requires technical evaluation, not emotional performance.
|
|
14
|
-
|
|
15
|
-
**Verify before implementing. Ask before assuming. Technical correctness over social comfort.**
|
|
16
|
-
|
|
17
|
-
## When to Use
|
|
18
|
-
|
|
19
|
-
When receiving code review feedback — from humans, external reviewers, or automated tools. Especially when feedback seems unclear or technically questionable.
|
|
20
|
-
|
|
21
|
-
## The Response Pattern
|
|
22
|
-
|
|
23
|
-
1. **READ:** complete feedback without reacting
|
|
24
|
-
2. **UNDERSTAND:** restate the requirement in your own words (or ask)
|
|
25
|
-
3. **VERIFY:** check against codebase reality
|
|
26
|
-
4. **EVALUATE:** technically sound for THIS codebase?
|
|
27
|
-
5. **RESPOND:** technical acknowledgment or reasoned pushback
|
|
28
|
-
6. **IMPLEMENT:** one item at a time, test each
|
|
29
|
-
|
|
30
|
-
## Forbidden Responses
|
|
31
|
-
|
|
32
|
-
Never respond with:
|
|
33
|
-
- "You're absolutely right!"
|
|
34
|
-
- "Great point!" / "Excellent feedback!"
|
|
35
|
-
- "Let me implement that now" (before verification)
|
|
36
|
-
- Any gratitude expression
|
|
37
|
-
|
|
38
|
-
Instead: restate the technical requirement, ask clarifying questions, push back with evidence if wrong, or just start fixing.
|
|
39
|
-
|
|
40
|
-
## Handling Unclear Feedback
|
|
41
|
-
|
|
42
|
-
If ANY item is unclear: **stop — do not implement anything yet.** Ask for clarification on unclear items before touching code. Items may be related; partial understanding produces wrong implementations.
|
|
43
|
-
|
|
44
|
-
## Evaluating External Feedback
|
|
45
|
-
|
|
46
|
-
Before implementing suggestions from external reviewers:
|
|
47
|
-
|
|
48
|
-
1. Is this technically correct for THIS codebase?
|
|
49
|
-
2. Does it break existing functionality?
|
|
50
|
-
3. Is there a reason for the current implementation?
|
|
51
|
-
4. Does the reviewer understand the full context?
|
|
52
|
-
5. Does it conflict with prior architectural decisions?
|
|
53
|
-
|
|
54
|
-
If a suggestion seems wrong, push back with technical reasoning — reference working tests, actual code, or codebase patterns.
|
|
55
|
-
|
|
56
|
-
## When to Push Back
|
|
57
|
-
|
|
58
|
-
- Suggestion breaks existing functionality
|
|
59
|
-
- Reviewer lacks full context
|
|
60
|
-
- Feature is unused (YAGNI)
|
|
61
|
-
- Technically incorrect for this stack
|
|
62
|
-
- Conflicts with established architectural decisions
|
|
63
|
-
|
|
64
|
-
**How:** technical reasoning, specific questions, references to working code. Never defensive — just factual.
|
|
65
|
-
|
|
66
|
-
## Implementation Order
|
|
67
|
-
|
|
68
|
-
For multi-item feedback:
|
|
69
|
-
|
|
70
|
-
1. Clarify anything unclear FIRST
|
|
71
|
-
2. Implement in priority order: blocking issues, simple fixes, complex fixes
|
|
72
|
-
3. Test each fix individually
|
|
73
|
-
4. Verify no regressions
|
|
74
|
-
|
|
75
|
-
## Acknowledging Correct Feedback
|
|
76
|
-
|
|
77
|
-
When feedback IS correct:
|
|
78
|
-
- "Fixed. [Brief description of what changed]"
|
|
79
|
-
- "Good catch — [specific issue]. Fixed in [location]."
|
|
80
|
-
- Or just fix it silently — the code shows you heard.
|
|
81
|
-
|
|
82
|
-
Actions speak. No performative agreement needed.
|
package/skills/wiring/SKILL.md
DELETED
|
@@ -1,35 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: wiring
|
|
3
|
-
prompt-name: validate-wiring
|
|
4
|
-
description: "Wiring validation for a codebase module using Pharaoh knowledge graph. Four-step pro-tier workflow: entry point reachability, caller verification via blast radius, test coverage per function, and dead code detection. Categorizes functions as CONNECTED, UNREACHABLE, DEAD, or UNTESTED. Produces a PASS or FAIL verdict with specific issues listed. Iron law: zero callers on a non-entry-point export means the code is not wired."
|
|
5
|
-
version: 0.2.0
|
|
6
|
-
homepage: https://pharaoh.so
|
|
7
|
-
user-invocable: true
|
|
8
|
-
metadata: {"emoji": "☥", "tags": ["wiring", "reachability", "dead-code", "pharaoh", "test-coverage", "entry-points", "validation"]}
|
|
9
|
-
---
|
|
10
|
-
|
|
11
|
-
# Validate Wiring
|
|
12
|
-
|
|
13
|
-
Verify that code in a module is properly connected. Uses `validate-wiring` — a 4-step pro-tier workflow that checks reachability from entry points, verifies functions have callers, confirms test coverage, and detects dead code. Produces a PASS / FAIL verdict with categorized findings. Requires Pro tools.
|
|
14
|
-
|
|
15
|
-
## When to Use
|
|
16
|
-
|
|
17
|
-
Invoke after adding new exports or functions, before merging code that adds a new module, or when dead code is suspected. Use it to answer "is this code actually being used?" with data instead of guesswork.
|
|
18
|
-
|
|
19
|
-
## Workflow
|
|
20
|
-
|
|
21
|
-
1. Call `check_reachability` for the target module to verify all exports are reachable from production entry points.
|
|
22
|
-
2. Call `get_blast_radius` for the target module to verify functions have callers.
|
|
23
|
-
3. Call `get_test_coverage` for the target module to check which functions are tested.
|
|
24
|
-
4. Call `get_unused_code` for the target module to detect any dead code.
|
|
25
|
-
|
|
26
|
-
Iron law: Zero callers on a non-entry-point export = the code is not wired.
|
|
27
|
-
|
|
28
|
-
## Output
|
|
29
|
-
|
|
30
|
-
A wiring report containing:
|
|
31
|
-
- **CONNECTED:** Functions reachable from entry points with test coverage
|
|
32
|
-
- **UNREACHABLE:** Exports with no path from entry points
|
|
33
|
-
- **DEAD:** Functions with zero callers (not entry points)
|
|
34
|
-
- **UNTESTED:** Reachable functions lacking test coverage
|
|
35
|
-
- **Verdict:** PASS (all exports wired and tested) or FAIL (with specific issues listed and recommended actions)
|
package/skills/worktree/SKILL.md
DELETED
|
@@ -1,86 +0,0 @@
|
|
|
1
|
-
---
|
|
2
|
-
name: worktree
|
|
3
|
-
prompt-name: git-worktree
|
|
4
|
-
description: "Set up isolated git worktrees for feature work. Smart directory selection with safety verification — checks for existing worktree directories, verifies gitignore, auto-detects project setup, and confirms clean test baseline before starting. Prevents accidentally committing worktree contents."
|
|
5
|
-
version: 0.2.0
|
|
6
|
-
homepage: https://pharaoh.so
|
|
7
|
-
user-invocable: true
|
|
8
|
-
metadata: {"emoji": "☥", "tags": ["git", "worktree", "isolation", "branching", "workspace"]}
|
|
9
|
-
---
|
|
10
|
-
|
|
11
|
-
# Git Worktrees
|
|
12
|
-
|
|
13
|
-
Create isolated workspaces sharing the same repository. Work on multiple branches simultaneously without switching.
|
|
14
|
-
|
|
15
|
-
## When to Use
|
|
16
|
-
|
|
17
|
-
Before starting feature work that needs isolation from the current workspace. Before executing implementation plans. Any time you need a clean branch without disturbing current work.
|
|
18
|
-
|
|
19
|
-
## Directory Selection
|
|
20
|
-
|
|
21
|
-
Follow this priority order:
|
|
22
|
-
|
|
23
|
-
1. **Check existing directories:** look for `.worktrees/` or `worktrees/` in the project root. If both exist, `.worktrees/` wins.
|
|
24
|
-
2. **Check project docs:** look for worktree directory preferences in CLAUDE.md or project config.
|
|
25
|
-
3. **Ask the user:** if no directory exists and no preference is documented.
|
|
26
|
-
|
|
27
|
-
## Safety Verification
|
|
28
|
-
|
|
29
|
-
For project-local worktree directories:
|
|
30
|
-
|
|
31
|
-
```bash
|
|
32
|
-
git check-ignore -q .worktrees 2>/dev/null
|
|
33
|
-
```
|
|
34
|
-
|
|
35
|
-
If the directory is NOT gitignored: add it to `.gitignore` and commit before creating worktrees. This prevents accidentally committing worktree contents to the repository.
|
|
36
|
-
|
|
37
|
-
Global directories (outside the project) don't need this check.
|
|
38
|
-
|
|
39
|
-
## Creation Steps
|
|
40
|
-
|
|
41
|
-
### 1. Create Worktree
|
|
42
|
-
|
|
43
|
-
```bash
|
|
44
|
-
git worktree add <path>/<branch-name> -b <branch-name>
|
|
45
|
-
cd <path>/<branch-name>
|
|
46
|
-
```
|
|
47
|
-
|
|
48
|
-
### 2. Install Dependencies
|
|
49
|
-
|
|
50
|
-
Auto-detect from project files:
|
|
51
|
-
|
|
52
|
-
| File | Command |
|
|
53
|
-
|------|---------|
|
|
54
|
-
| `package.json` + `pnpm-lock.yaml` | `pnpm install` |
|
|
55
|
-
| `package.json` | `npm install` |
|
|
56
|
-
| `Cargo.toml` | `cargo build` |
|
|
57
|
-
| `requirements.txt` | `pip install -r requirements.txt` |
|
|
58
|
-
| `go.mod` | `go mod download` |
|
|
59
|
-
|
|
60
|
-
### 3. Verify Clean Baseline
|
|
61
|
-
|
|
62
|
-
Run the project's test suite. If tests fail, report failures and ask whether to proceed or investigate. Don't start work on a broken baseline.
|
|
63
|
-
|
|
64
|
-
### 4. Report
|
|
65
|
-
|
|
66
|
-
```
|
|
67
|
-
Worktree ready at <full-path>
|
|
68
|
-
Tests passing (<N> tests, 0 failures)
|
|
69
|
-
Ready to implement <feature-name>
|
|
70
|
-
```
|
|
71
|
-
|
|
72
|
-
## Common Mistakes
|
|
73
|
-
|
|
74
|
-
| Mistake | Fix |
|
|
75
|
-
|---------|-----|
|
|
76
|
-
| Skipping gitignore verification | Always check before creating project-local worktrees |
|
|
77
|
-
| Assuming directory location | Follow priority: existing > docs > ask |
|
|
78
|
-
| Proceeding with failing baseline tests | Report failures, get permission first |
|
|
79
|
-
| Hardcoding setup commands | Auto-detect from project files |
|
|
80
|
-
|
|
81
|
-
## Red Flags
|
|
82
|
-
|
|
83
|
-
- Never create a worktree without verifying it's gitignored (project-local)
|
|
84
|
-
- Never skip baseline test verification
|
|
85
|
-
- Never proceed with failing tests without asking
|
|
86
|
-
- Never assume directory location when ambiguous
|