@pgsql/transform 18.1.1 → 18.3.1

package/README.md

@@ -12,25 +12,9 @@
    <a href="https://www.npmjs.com/package/@pgsql/transform"><img height="20" src="https://img.shields.io/github/package-json/v/constructive-io/pgsql-parser?filename=packages%2Ftransform%2Fpackage.json"/></a>
 </p>
 
-`@pgsql/transform` is a TypeScript library for transforming PostgreSQL ASTs between different PostgreSQL versions. It serves as a crucial component for building a single source of truth deparser that can handle SQL from multiple PostgreSQL versions while maintaining backward compatibility.
+AST-based SQL transformation, qualification, classification, and dependency-closure analysis for PostgreSQL. Works on plain SQL **and inside PL/pgSQL function bodies** (via `plpgsql-parser` hydration) — no regexes.
 
-## Transforming ASTs Between PG Versions
-
-The transform package enables you to:
-
-- **Transform legacy ASTs**: Convert ASTs from PostgreSQL versions 13-16 to version 17
-- **Build unified deparsers**: Create a single deparser pipeline that works with multiple PostgreSQL versions
-- **Maintain backward compatibility**: Support legacy codebases while leveraging the latest PostgreSQL features
-
-## Key Limitation
-
-This package only supports ASTs derived from SQL that is parseable by PostgreSQL 17. This means:
-
-- ✅ **Supported**: SQL from PG13-16 that remains valid in PG17
-- ❌ **Not supported**: Deprecated syntax from older versions that was removed
-- ❌ **Not supported**: SQL that cannot be parsed by the PG17 parser
-
-This design ensures all transformed ASTs can be reliably deparsed using the latest PostgreSQL grammar.
+> Looking for the PG13→17/18 version-upgrade AST transformer previously published under this name? It now lives at [`@pgsql/transform-ast`](../transform-ast).
 
 ## Installation
 
@@ -38,82 +22,46 @@ This design ensures all transformed ASTs can be reliably deparsed using the late
 npm install @pgsql/transform
 ```
 
-## 🚀 Quick Start
-
-### Multi-Version Transformer
-
-```typescript
-import { ASTTransformer } from '@pgsql/transform';
-
-const transformer = new ASTTransformer();
-
-// Transform any version to PG17
-const pg17Ast = transformer.transformToLatest(pg13Ast, 13);
+The parser runs on a WASM build of the real PostgreSQL parser; call `loadModule()` from `plpgsql-parser` once before using any synchronous API.
 
-// Transform between specific versions
-const pg15Ast = transformer.transform(pg13Ast, 13, 15);
+## Features
 
-// Convenience methods
-const result = transformer.transform13To17(pg13Ast);
-```
+### `transformSql` — schema-name rewriting
 
-### Direct Transformers
-
-For better performance when you know source and target versions:
+Rewrite schema names everywhere they can appear (DDL, DML, function bodies, trigger definitions, grants, policies, comments, type casts, string-embedded types inside PL/pgSQL, ...):
 
 ```typescript
-import { PG13ToPG17Transformer } from '@pgsql/transform';
+import { loadModule } from 'plpgsql-parser';
+import { transformSql } from '@pgsql/transform';
 
-const transformer = new PG13ToPG17Transformer();
-const pg17Ast = transformer.transform(pg13Ast);
+await loadModule();
+const mapping = new Map([['my-schema', 'my_schema']]);
+const { sql } = transformSql(inputSql, mapping);
 ```
 
-### Integration Example
+### `classifyStatements` — per-statement AST facts
 
 ```typescript
-import { parse } from '@pgsql/parser';
-import { deparse } from 'pgsql-deparser';
-import { PG13ToPG17Transformer } from '@pgsql/transform';
-
-// Parse with older version
-const pg13Ast = await parse('SELECT * FROM users', { version: 13 });
+import { classifyStatements } from '@pgsql/transform';
 
-// Transform to latest
-const transformer = new PG13ToPG17Transformer();
-const pg17Ast = transformer.transform(pg13Ast);
-
-// Deparse with latest grammar
-const sql = await deparse(pg17Ast);
+const facts = classifyStatements(sql);
+// per statement: kind (schema|table|view|index|type|function|trigger|policy|grant|...),
+// creates, references (incl. inside PL/pgSQL bodies), referencedSchemas, roles,
+// fkTargets, securityRelevant, securityDefiner, dynamicSql
 ```
 
-## 🔄 Transformation Chain
-
-**Incremental**: PG13 → PG14 → PG15 → PG16 → PG17
-- Step-by-step version upgrades
-- Useful for debugging transformation issues
-
-**Direct**: PG13 → PG17, PG14 → PG17, etc.
-- Single-step transformations
-- Optimized for performance
-
-## 📋 Supported Transformations
+### `qualifyUnqualified` — add schema qualification
 
-| From | To | Transformer |
-|------|----|-----------| 
-| PG13 | PG14, PG15, PG16, PG17 | `V13ToV14Transformer`, `PG13ToPG17Transformer` |
-| PG14 | PG15, PG16, PG17 | `V14ToV15Transformer`, `PG14ToPG17Transformer` |
-| PG15 | PG16, PG17 | `V15ToV16Transformer`, `PG15ToPG17Transformer` |
-| PG16 | PG17 | `V16ToV17Transformer`, `PG16ToPG17Transformer` |
+Qualify unqualified object references against an inventory of known objects, with multi-schema routing support.
 
-## 🏗️ Architecture
+### Round-trip validation
 
-The transform package fits into the broader pgsql-parser ecosystem:
+`normalizeTree` / `cleanTree` / `validateRoundTrip` — dependency-free AST normalization and mutation-aware parse→deparse→re-parse validation.
 
-1. **Parse** legacy SQL with version-specific parsers
-2. **Transform** ASTs to the latest version
-3. **Deparse** using the unified, latest-version deparser
+## Scripts
 
-This enables a single source of truth for SQL generation while supporting legacy codebases.
+- `npm run fixtures` — regenerate `__fixtures__/output/` golden files from `__fixtures__/input/`
+- `npm run scan-corpus <dir> [dir...]` — audit node-type coverage over a SQL corpus
 
 ---
 

package/esm/facts.js

@@ -0,0 +1,289 @@
+import { walk as walkSql } from '@pgsql/traverse';
+import { transformSync, walk as walkPlpgsql } from 'plpgsql-parser';
+const SECURITY_TAGS = new Set([
+    'CreatePolicyStmt',
+    'AlterPolicyStmt',
+    'GrantStmt',
+    'GrantRoleStmt',
+    'AlterDefaultPrivilegesStmt',
+    'SecLabelStmt',
+    'AlterOwnerStmt',
+    'CreateRoleStmt',
+    'AlterRoleStmt'
+]);
+const KIND_BY_TAG = {
+    CreateSchemaStmt: 'schema',
+    CreateStmt: 'table',
+    ViewStmt: 'view',
+    IndexStmt: 'index',
+    CompositeTypeStmt: 'type',
+    CreateEnumStmt: 'type',
+    CreateDomainStmt: 'type',
+    CreateRangeStmt: 'type',
+    DefineStmt: 'type',
+    CreateFunctionStmt: 'function',
+    CreateTrigStmt: 'trigger',
+    CreateEventTrigStmt: 'trigger',
+    CreatePolicyStmt: 'policy',
+    AlterPolicyStmt: 'policy',
+    GrantStmt: 'grant',
+    GrantRoleStmt: 'grant',
+    AlterDefaultPrivilegesStmt: 'grant',
+    CommentStmt: 'comment',
+    InsertStmt: 'seed_dml',
+    UpdateStmt: 'seed_dml',
+    DeleteStmt: 'seed_dml'
+};
+function qn(schema, name) {
+    return { schema: schema ?? null, name };
+}
+function nameListToQualified(names) {
+    if (!Array.isArray(names) || names.length === 0)
+        return null;
+    const parts = names
+        .map((n) => n?.String?.sval)
+        .filter((s) => typeof s === 'string');
+    if (parts.length === 0)
+        return null;
+    if (parts.length === 1)
+        return qn(null, parts[0]);
+    return qn(parts[parts.length - 2], parts[parts.length - 1]);
+}
+function isCatalogSchema(schema) {
+    return schema === 'pg_catalog' || schema === 'information_schema';
+}
+function pushRef(refs, ref) {
+    if (!ref || !ref.schema || isCatalogSchema(ref.schema))
+        return;
+    if (refs.some(r => r.schema === ref.schema && r.name === ref.name))
+        return;
+    refs.push(ref);
+}
+function collectRoles(node, roles) {
+    const push = (role) => {
+        if (typeof role === 'string' && role.length > 0 && !roles.includes(role)) {
+            roles.push(role);
+        }
+    };
+    if (Array.isArray(node?.grantees)) {
+        for (const g of node.grantees)
+            push(g?.RoleSpec?.rolename);
+    }
+    if (Array.isArray(node?.roles)) {
+        for (const r of node.roles)
+            push(r?.RoleSpec?.rolename);
+    }
+    push(node?.newowner?.rolename);
+    push(node?.role?.rolename);
+}
+/**
+ * Create a read-only visitor that accumulates references, roles and FK
+ * targets into the provided facts object.
+ */
+function createFactsVisitor(facts, bodyRefs) {
+    const push = (ref) => {
+        pushRef(facts.references, ref);
+        if (bodyRefs)
+            pushRef(bodyRefs, ref);
+    };
+    return {
+        RangeVar: (path) => {
+            const node = path.node;
+            if (node.schemaname) {
+                push(qn(node.schemaname, node.relname));
+            }
+        },
+        FuncCall: (path) => {
+            push(nameListToQualified(path.node.funcname));
+        },
+        TypeName: (path) => {
+            push(nameListToQualified(path.node.names));
+        },
+        ColumnRef: (path) => {
+            // schema.table.column references carry cross-schema information
+            const fields = path.node.fields;
+            if (Array.isArray(fields) && fields.length >= 3) {
+                const parts = fields
+                    .map((f) => f?.String?.sval)
+                    .filter((s) => typeof s === 'string');
+                if (parts.length >= 3) {
+                    push(qn(parts[0], parts[1]));
+                }
+            }
+        },
+        Constraint: (path) => {
+            const node = path.node;
+            if (node.contype === 'CONSTR_FOREIGN' && node.pktable) {
+                const target = qn(node.pktable.schemaname ?? null, node.pktable.relname);
+                if (!facts.fkTargets.some(t => t.schema === target.schema && t.name === target.name)) {
+                    facts.fkTargets.push(target);
+                }
+                if (target.schema)
+                    pushRef(facts.references, target);
+            }
+        }
+    };
+}
+function classifyOne(nodeTag, node) {
+    const facts = {
+        kind: KIND_BY_TAG[nodeTag] ?? 'other',
+        nodeTag,
+        creates: [],
+        references: [],
+        referencedSchemas: [],
+        roles: [],
+        fkTargets: [],
+        bodyReferences: [],
+        securityRelevant: SECURITY_TAGS.has(nodeTag),
+        securityDefiner: false,
+        dynamicSql: false
+    };
+    switch (nodeTag) {
+        case 'CreateSchemaStmt':
+            facts.creates.push(qn(null, node.schemaname));
+            break;
+        case 'CreateStmt':
+        case 'ViewStmt': {
+            const rel = nodeTag === 'ViewStmt' ? node.view : node.relation;
+            if (rel)
+                facts.creates.push(qn(rel.schemaname ?? null, rel.relname));
+            break;
+        }
+        case 'IndexStmt':
+            if (node.relation) {
+                facts.creates.push(qn(node.relation.schemaname ?? null, node.idxname ?? node.relation.relname));
+            }
+            break;
+        case 'CreateFunctionStmt': {
+            const name = nameListToQualified(node.funcname);
+            if (name)
+                facts.creates.push(name);
+            for (const opt of node.options ?? []) {
+                const def = opt?.DefElem;
+                if (def?.defname === 'security' && def?.arg?.Boolean?.boolval === true) {
+                    facts.securityDefiner = true;
+                }
+            }
+            break;
+        }
+        case 'CreateTrigStmt':
+            if (node.relation) {
+                // Trigger names are only unique per table; qualify with the table.
+                facts.creates.push(qn(node.relation.schemaname ?? null, `${node.relation.relname}.${node.trigname}`));
+            }
+            pushRef(facts.references, nameListToQualified(node.funcname));
+            break;
+        case 'CreatePolicyStmt':
+        case 'AlterPolicyStmt':
+            if (node.table) {
+                // Policy names are only unique per table; qualify with the table.
+                facts.creates.push(qn(node.table.schemaname ?? null, `${node.table.relname}.${node.policy_name}`));
+                // The guarded table lives on `node.table`; the generic RangeVar walker
+                // does not descend into it, so capture the reference explicitly.
+                if (node.table.schemaname) {
+                    pushRef(facts.references, qn(node.table.schemaname, node.table.relname));
+                }
+            }
+            break;
+        case 'CreateSeqStmt':
+            if (node.sequence) {
+                facts.creates.push(qn(node.sequence.schemaname ?? null, node.sequence.relname));
+            }
+            break;
+        case 'CompositeTypeStmt':
+            if (node.typevar) {
+                facts.creates.push(qn(node.typevar.schemaname ?? null, node.typevar.relname));
+            }
+            break;
+        case 'CreateEnumStmt':
+        case 'CreateDomainStmt':
+        case 'CreateRangeStmt': {
+            const name = nameListToQualified(node.typeName ?? node.domainname);
+            if (name)
+                facts.creates.push(name);
+            break;
+        }
+        case 'AlterTableStmt': {
+            if (node.relation) {
+                facts.creates.push(qn(node.relation.schemaname ?? null, node.relation.relname));
+            }
+            const cmds = node.cmds ?? [];
+            for (const cmd of cmds) {
+                const subtype = cmd?.AlterTableCmd?.subtype;
+                if (subtype === 'AT_EnableRowSecurity' || subtype === 'AT_ForceRowSecurity' ||
+                    subtype === 'AT_DisableRowSecurity' || subtype === 'AT_NoForceRowSecurity') {
+                    facts.kind = 'rls_enable';
+                    facts.securityRelevant = true;
+                }
+                else if (subtype === 'AT_AddConstraint') {
+                    const contype = cmd?.AlterTableCmd?.def?.Constraint?.contype;
+                    facts.kind = contype === 'CONSTR_FOREIGN' ? 'fk_constraint' : 'constraint';
+                }
+                else if (subtype === 'AT_ChangeOwner') {
+                    facts.securityRelevant = true;
+                    const owner = cmd?.AlterTableCmd?.newowner?.rolename;
+                    if (owner && !facts.roles.includes(owner))
+                        facts.roles.push(owner);
+                }
+            }
+            break;
+        }
+        case 'InsertStmt':
+        case 'UpdateStmt':
+        case 'DeleteStmt':
+            if (node.relation) {
+                facts.creates.push(qn(node.relation.schemaname ?? null, node.relation.relname));
+            }
+            break;
+        default:
+            break;
+    }
+    collectRoles(node, facts.roles);
+    return facts;
+}
+/**
+ * Classify each top-level statement in a SQL script into {@link StatementFacts}.
+ *
+ * Uses the same parser stack as the schema transformer (pgsql AST walk plus
+ * hydrated PL/pgSQL body walk), so references inside function bodies are
+ * included. The input SQL is never modified.
+ */
+export function classifyStatements(sql) {
+    const allFacts = [];
+    transformSync(sql, (ctx) => {
+        const stmts = ctx.sql?.stmts ?? [];
+        for (const stmt of stmts) {
+            const stmtNode = stmt?.stmt;
+            const nodeTag = stmtNode ? Object.keys(stmtNode)[0] : 'other';
+            const node = stmtNode?.[nodeTag] ?? {};
+            const facts = classifyOne(nodeTag, node);
+            if (stmtNode) {
+                walkSql(stmtNode, createFactsVisitor(facts));
+            }
+            allFacts.push(facts);
+        }
+        for (const fn of ctx.functions ?? []) {
+            const facts = allFacts[fn.stmtIndex];
+            if (!facts || !fn.plpgsql?.hydrated)
+                continue;
+            // Refs already found outside the body (signature types, defaults)
+            // constrain deploy order and are not body-only.
+            const outer = new Set(facts.references.map(r => `${r.schema ?? '?'}.${r.name}`));
+            walkPlpgsql(fn.plpgsql.hydrated, {
+                PLpgSQL_stmt_dynexecute: () => { facts.dynamicSql = true; },
+                PLpgSQL_stmt_dynfors: () => { facts.dynamicSql = true; }
+            }, {
+                walkSqlExpressions: true,
+                sqlVisitor: createFactsVisitor(facts, facts.bodyReferences)
+            });
+            facts.bodyReferences = facts.bodyReferences.filter(r => !outer.has(`${r.schema ?? '?'}.${r.name}`));
+        }
+    }, { hydrate: true });
+    for (const facts of allFacts) {
+        const selfRef = (r) => facts.creates.some(c => c.schema === r.schema && c.name === r.name);
+        facts.references = facts.references.filter(r => !selfRef(r));
+        facts.bodyReferences = facts.bodyReferences.filter(r => !selfRef(r));
+        facts.referencedSchemas = [...new Set(facts.references.map(r => r.schema).filter(Boolean))];
+    }
+    return allFacts;
+}

package/esm/index.js

@@ -1,22 +1,5 @@
-import * as PG13Types from './13/types';
-import * as PG14Types from './14/types';
-import * as PG15Types from './15/types';
-import * as PG16Types from './16/types';
-import * as PG17Types from './17/types';
-import * as PG18Types from './18/types';
-export { ASTTransformer } from './multi-version-transformer';
-export { V13ToV14Transformer } from './transformers/v13-to-v14';
-export { V14ToV15Transformer } from './transformers/v14-to-v15';
-export { V15ToV16Transformer } from './transformers/v15-to-v16';
-export { V16ToV17Transformer } from './transformers/v16-to-v17';
-export { V17ToV18Transformer } from './transformers/v17-to-v18';
-export { PG13ToPG17Transformer } from './transformers-direct/v13-to-v17';
-export { PG14ToPG17Transformer } from './transformers-direct/v14-to-v17';
-export { PG15ToPG17Transformer } from './transformers-direct/v15-to-v17';
-export { PG16ToPG17Transformer } from './transformers-direct/v16-to-v17';
-export { PG13ToPG18Transformer } from './transformers-direct/v13-to-v18';
-export { PG14ToPG18Transformer } from './transformers-direct/v14-to-v18';
-export { PG15ToPG18Transformer } from './transformers-direct/v15-to-v18';
-export { PG16ToPG18Transformer } from './transformers-direct/v16-to-v18';
-export { PG17ToPG18Transformer } from './transformers-direct/v17-to-v18';
-export { PG13Types, PG14Types, PG15Types, PG16Types, PG17Types, PG18Types };
+export { classifyStatements } from './facts';
+export { collectCreatedObjects, createQualifyVisitor, mergeInventories, qualifyUnqualified, } from './qualify';
+export { captureAstsFromSql, captureTransformAsts, firstDifference, normalizeParseTree, validateRoundTrip, } from './round-trip';
+export { CLEAN_TREE_VOLATILE_KEYS, cleanTree, normalizeTree, trimDefElemBody, } from './round-trip-core';
+export { createPlpgsqlVisitor, createSqlVisitor, escapeRegexp, extractPgpmHeader, shouldTransformSchema, transformComments, transformJsonStringValues, transformNameList, transformPlpgsqlTypeAst, transformPlpgsqlTypeString, transformRelation, transformSchemaName, transformSql, transformSqlStatement, transformVerifyCalls, validateNoUntransformedSchemas, walkPlpgsqlForSchemas, } from './transform';