@pezkuwi/dev 0.86.2 → 0.86.4

package/cjs/packageInfo.js

@@ -1,4 +1,4 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.packageInfo = void 0;
-exports.packageInfo = { name: '@pezkuwi/dev', path: typeof __dirname === 'string' ? __dirname : 'auto', type: 'cjs', version: '0.86.2' };
+exports.packageInfo = { name: '@pezkuwi/dev', path: typeof __dirname === 'string' ? __dirname : 'auto', type: 'cjs', version: '0.86.4' };

package/config/eslint.directives.js

@@ -0,0 +1,78 @@
+// Copyright 2017-2026 @pezkuwi/dev authors & contributors
+// SPDX-License-Identifier: Apache-2.0
+
+/** @type {Map<string, string>} */
+const sources = new Map();
+
+/**
+ * Widens the fix eslint core gives an unused disable directive.
+ *
+ * Core removes only the comment and puts a single space in its place
+ * (lib/linter/apply-disable-directives.js), so --fix turns
+ *
+ *   const a = 1;
+ *   // eslint-disable-next-line no-console
+ *   const b = 2;
+ *
+ * into a whitespace-only line between the two statements, which the layout
+ * rules then leave behind as a blank line. Measured on the consumers after the
+ * eslint 10 move: 23 such lines in api alone, each removed by hand.
+ *
+ * Only a fix that removes a whole directive comment is changed: alone on its
+ * line, the line goes; after code, the space before it goes; before code, the
+ * space after it goes. Removing one rule name out of several is left as core
+ * makes it, as is every message with a rule id.
+ *
+ * @param {import('eslint').Linter.LintMessage} message
+ * @param {string} text the source the message was produced from
+ * @returns {import('eslint').Linter.LintMessage}
+ */
+function widenDirectiveFix (message, text) {
+  if (message.ruleId !== null || message.fix?.text.trim() !== '') {
+    return message;
+  }
+
+  let [start, end] = message.fix.range;
+
+  if (!/^\/[/*]/.test(text.slice(start, end))) {
+    return message;
+  }
+
+  const lineStart = text.lastIndexOf('\n', start - 1) + 1;
+  const newline = text.indexOf('\n', end);
+  const lineEnd = newline === -1 ? text.length : newline;
+  const aloneBefore = text.slice(lineStart, start).trim() === '';
+  const aloneAfter = text.slice(end, lineEnd).trim() === '';
+
+  if (aloneBefore && aloneAfter) {
+    return { ...message, fix: { range: [lineStart, newline === -1 ? text.length : newline + 1], text: '' } };
+  } else if (aloneBefore) {
+    while (end < lineEnd && /[ \t]/.test(text[end] ?? '')) {
+      end++;
+    }
+  } else {
+    while (start > lineStart && /[ \t]/.test(text[start - 1] ?? '')) {
+      start--;
+    }
+  }
+
+  return { ...message, fix: { range: [start, end], text: '' } };
+}
+
+/** @type {import('eslint').Linter.Processor} */
+export const directiveLines = {
+  meta: { name: '@pezkuwi/dev/directive-lines' },
+  postprocess (lists, filename) {
+    const text = sources.get(filename) ?? '';
+
+    sources.delete(filename);
+
+    return lists.flat().map((m) => widenDirectiveFix(m, text));
+  },
+  preprocess (text, filename) {
+    sources.set(filename, text);
+
+    return [text];
+  },
+  supportsAutofix: true
+};

package/config/eslint.js

@@ -22,8 +22,11 @@ import simpleImportSortPlugin from 'eslint-plugin-simple-import-sort';
 import sortDestructureKeysPlugin from 'eslint-plugin-sort-destructure-keys';
 import globals from 'globals';
 
+import { directiveLines } from './eslint.directives.js';
 import { overrideAll, overrideJs, overrideJsx, overrideSpec } from './eslint.rules.js';
 import { standardRules } from './eslint.standard.js';
+import { withoutContextualAssertions } from './eslint.typeAssertion.js';
+import { withoutExportAllFix } from './eslint.typeExports.js';
 
 /**
  * eslint-plugin-header declares no options schema, and eslint 9+ rejects
@@ -93,7 +96,8 @@ export default [
     },
     plugins: {
       '@stylistic': stylisticPlugin,
-      '@typescript-eslint': tsPlugin,
+      // see eslint.typeAssertion.js and eslint.typeExports.js
+      '@typescript-eslint': withoutExportAllFix(withoutContextualAssertions(tsPlugin)),
       // eslint-plugin-header reports at the first token after the leading
       // comments, so a generated file's /* eslint-disable */ covers it; the
       // maintained fork reports at line 1 instead. The compat layer supplies the
@@ -124,6 +128,8 @@ export default [
   },
   {
     files: extsToGlobs(EXT_ALL),
+    // see eslint.directives.js
+    processor: directiveLines,
     rules: {
       ...eslintJs.configs.recommended.rules,
       ...standardRules,

package/config/eslint.typeAssertion.js

@@ -0,0 +1,65 @@
+// Copyright 2017-2026 @pezkuwi/dev authors & contributors
+// SPDX-License-Identifier: Apache-2.0
+
+const RULE = 'no-unnecessary-type-assertion';
+const ASSERTIONS = ['TSAsExpression', 'TSTypeAssertion'];
+
+/**
+ * typescript-eslint 8 added a second check to no-unnecessary-type-assertion:
+ * an `x as T` is reported as unnecessary when the place it is passed to would
+ * accept `x` as it is ("the receiver accepts the original type"), and the
+ * autofix deletes the assertion. That is unsound when the assertion also
+ * drives inference around it: in
+ *
+ *   const { validators } = found || { validators: {} as ValPoints };
+ *
+ * deleting `as ValPoints` leaves `validators` typed `{}`, and every use of it
+ * after that is an unresolved type. It also deletes assertions kept on
+ * purpose for another environment's typings (a Ledger transport under
+ * esm.sh). Measured across the consumers before this was added: 45 such
+ * reports, the first of them breaking the types of api-derive.
+ *
+ * This keeps the rule as it was before that check: an assertion to the type
+ * the expression already has is still reported and fixed, and so are non-null
+ * assertions the receiver makes unnecessary. Only the contextual report on
+ * `as` / `<T>` assertions is dropped.
+ *
+ * @template {object} P
+ * @param {P} plugin the @typescript-eslint plugin
+ * @returns {P}
+ */
+export function withoutContextualAssertions (plugin) {
+  const rules = /** @type {Record<string, import('eslint').Rule.RuleModule>} */ (/** @type {{ rules: unknown }} */ (plugin).rules);
+  const rule = rules[RULE];
+
+  return /** @type {P} */ ({
+    ...plugin,
+    rules: {
+      ...rules,
+      [RULE]: {
+        ...rule,
+        /** @param {import('eslint').Rule.RuleContext} context */
+        create (context) {
+          const filtered = Object.create(context, {
+            report: {
+              value: (/** @type {import('eslint').Rule.ReportDescriptor} */ descriptor) => {
+                if (
+                  'messageId' in descriptor &&
+                  descriptor.messageId === 'contextuallyUnnecessary' &&
+                  'node' in descriptor &&
+                  ASSERTIONS.includes(descriptor.node.type)
+                ) {
+                  return;
+                }
+
+                context.report(descriptor);
+              }
+            }
+          });
+
+          return rule.create(filtered);
+        }
+      }
+    }
+  });
+}

package/config/eslint.typeExports.js

@@ -0,0 +1,63 @@
+// Copyright 2017-2026 @pezkuwi/dev authors & contributors
+// SPDX-License-Identifier: Apache-2.0
+
+const RULE = 'consistent-type-exports';
+
+/**
+ * consistent-type-exports reports an `export * from './x'` whose module only
+ * exports types, and its autofix turns it into `export type * from './x'`.
+ * That changes what runs: `export *` loads the module, `export type *` is
+ * erased, so a module that only exports types but registers something when it
+ * loads (a Handlebars partial, an interface augmentation) silently stops being
+ * loaded. Measured on the consumers: the api typegen lost its `docs` partial
+ * this way and the build failed only at template time.
+ *
+ * Named re-exports do not have this problem: under verbatimModuleSyntax a
+ * type re-exported without `type` is already a compile error (TS1205).
+ *
+ * This keeps the report as it is and moves the `export *` fix into a
+ * suggestion, so --fix no longer applies it and an editor still offers it.
+ * Whoever accepts it decides whether the module needs a side-effect import.
+ *
+ * @template {object} P
+ * @param {P} plugin the @typescript-eslint plugin
+ * @returns {P}
+ */
+export function withoutExportAllFix (plugin) {
+  const rules = /** @type {Record<string, import('eslint').Rule.RuleModule>} */ (/** @type {{ rules: unknown }} */ (plugin).rules);
+  const rule = rules[RULE];
+
+  return /** @type {P} */ ({
+    ...plugin,
+    rules: {
+      ...rules,
+      [RULE]: {
+        ...rule,
+        /** @param {import('eslint').Rule.RuleContext} context */
+        create (context) {
+          const filtered = Object.create(context, {
+            report: {
+              value: (/** @type {import('eslint').Rule.ReportDescriptor} */ descriptor) => {
+                if ('node' in descriptor && descriptor.node.type === 'ExportAllDeclaration' && descriptor.fix) {
+                  const { fix, ...rest } = descriptor;
+
+                  context.report({
+                    ...rest,
+                    suggest: [{ desc: 'Use `export type *` (the module is no longer loaded: add a side-effect import if it registers anything)', fix }]
+                  });
+
+                  return;
+                }
+
+                context.report(descriptor);
+              }
+            }
+          });
+
+          return rule.create(filtered);
+        },
+        meta: { ...rule.meta, hasSuggestions: true }
+      }
+    }
+  });
+}

package/package.json

@@ -15,7 +15,7 @@
   },
   "sideEffects": false,
   "type": "module",
-  "version": "0.86.2",
+  "version": "0.86.4",
   "bin": {
     "pezkuwi-ci-ghact-build": "./scripts/pezkuwi-ci-ghact-build.mjs",
     "pezkuwi-ci-ghact-docs": "./scripts/pezkuwi-ci-ghact-docs.mjs",
@@ -63,8 +63,11 @@
       }
     },
     "./config/eslint": "./config/eslint.js",
+    "./config/eslint.directives": "./config/eslint.directives.js",
     "./config/eslint.rules": "./config/eslint.rules.js",
     "./config/eslint.standard": "./config/eslint.standard.js",
+    "./config/eslint.typeAssertion": "./config/eslint.typeAssertion.js",
+    "./config/eslint.typeExports": "./config/eslint.typeExports.js",
     "./config/prettier.cjs": "./config/prettier.cjs",
     "./config/prettier": "./config/prettier.cjs",
     "./config/rollup": "./config/rollup.js",
@@ -288,8 +291,8 @@
   "dependencies": {
     "@eslint/compat": "^2.1.1",
     "@eslint/js": "^10.0.1",
-    "@pezkuwi/dev-test": "^0.86.2",
-    "@pezkuwi/dev-ts": "^0.86.2",
+    "@pezkuwi/dev-test": "^0.86.4",
+    "@pezkuwi/dev-ts": "^0.86.4",
     "@rollup/plugin-alias": "^5.1.1",
     "@rollup/plugin-commonjs": "^29.0.3",
     "@rollup/plugin-dynamic-import-vars": "^2.1.5",

package/packageInfo.js

@@ -1 +1 @@
-export const packageInfo = { name: '@pezkuwi/dev', path: (import.meta && import.meta.url) ? new URL(import.meta.url).pathname.substring(0, new URL(import.meta.url).pathname.lastIndexOf('/') + 1) : 'auto', type: 'esm', version: '0.86.2' };
+export const packageInfo = { name: '@pezkuwi/dev', path: (import.meta && import.meta.url) ? new URL(import.meta.url).pathname.substring(0, new URL(import.meta.url).pathname.lastIndexOf('/') + 1) : 'auto', type: 'esm', version: '0.86.4' };

package/scripts/pezkuwi-dev-run-lint.mjs

@@ -7,8 +7,6 @@ import yargs from 'yargs';
 
 import { __dirname, execPm, GITHUB_REPO, logBin } from './util.mjs';
 
-const TS_CONFIG_BUILD = true;
-
 logBin('pezkuwi-dev-run-lint');
 
 // Since yargs can also be a promise, we just relax the type here completely
@@ -36,5 +34,11 @@ if (!argv['skip-eslint']) {
 }
 
 if (!argv['skip-tsc']) {
-  execPm(`pezkuwi-exec-tsc --noEmit --emitDeclarationOnly false --pretty${TS_CONFIG_BUILD ? ' --project tsconfig.build.json' : ''}`);
+  // The root tsconfig.build.json has `files: []` and only references the
+  // packages, so `tsc --project` on it checks no file at all. --build follows
+  // the references; it cannot be combined with --noEmit, so it writes the
+  // declarations the build would. Previous build output is removed first, since
+  // package configs without an `include` would otherwise pick it up as source.
+  execPm('pezkuwi-dev-clean-build');
+  execPm('pezkuwi-exec-tsc --build tsconfig.build.json --pretty');
 }