@pezkuwi/dev 0.86.1 → 0.86.3

package/cjs/packageInfo.js

@@ -1,4 +1,4 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.packageInfo = void 0;
-exports.packageInfo = { name: '@pezkuwi/dev', path: typeof __dirname === 'string' ? __dirname : 'auto', type: 'cjs', version: '0.86.1' };
+exports.packageInfo = { name: '@pezkuwi/dev', path: typeof __dirname === 'string' ? __dirname : 'auto', type: 'cjs', version: '0.86.3' };

package/config/eslint.js

@@ -24,6 +24,7 @@ import globals from 'globals';
 
 import { overrideAll, overrideJs, overrideJsx, overrideSpec } from './eslint.rules.js';
 import { standardRules } from './eslint.standard.js';
+import { withoutContextualAssertions } from './eslint.typeAssertion.js';
 
 /**
  * eslint-plugin-header declares no options schema, and eslint 9+ rejects
@@ -93,7 +94,8 @@ export default [
     },
     plugins: {
       '@stylistic': stylisticPlugin,
-      '@typescript-eslint': tsPlugin,
+      // see eslint.typeAssertion.js
+      '@typescript-eslint': withoutContextualAssertions(tsPlugin),
       // eslint-plugin-header reports at the first token after the leading
       // comments, so a generated file's /* eslint-disable */ covers it; the
       // maintained fork reports at line 1 instead. The compat layer supplies the

package/config/eslint.typeAssertion.js

@@ -0,0 +1,65 @@
+// Copyright 2017-2026 @pezkuwi/dev authors & contributors
+// SPDX-License-Identifier: Apache-2.0
+
+const RULE = 'no-unnecessary-type-assertion';
+const ASSERTIONS = ['TSAsExpression', 'TSTypeAssertion'];
+
+/**
+ * typescript-eslint 8 added a second check to no-unnecessary-type-assertion:
+ * an `x as T` is reported as unnecessary when the place it is passed to would
+ * accept `x` as it is ("the receiver accepts the original type"), and the
+ * autofix deletes the assertion. That is unsound when the assertion also
+ * drives inference around it: in
+ *
+ *   const { validators } = found || { validators: {} as ValPoints };
+ *
+ * deleting `as ValPoints` leaves `validators` typed `{}`, and every use of it
+ * after that is an unresolved type. It also deletes assertions kept on
+ * purpose for another environment's typings (a Ledger transport under
+ * esm.sh). Measured across the consumers before this was added: 45 such
+ * reports, the first of them breaking the types of api-derive.
+ *
+ * This keeps the rule as it was before that check: an assertion to the type
+ * the expression already has is still reported and fixed, and so are non-null
+ * assertions the receiver makes unnecessary. Only the contextual report on
+ * `as` / `<T>` assertions is dropped.
+ *
+ * @template {object} P
+ * @param {P} plugin the @typescript-eslint plugin
+ * @returns {P}
+ */
+export function withoutContextualAssertions (plugin) {
+  const rules = /** @type {Record<string, import('eslint').Rule.RuleModule>} */ (/** @type {{ rules: unknown }} */ (plugin).rules);
+  const rule = rules[RULE];
+
+  return /** @type {P} */ ({
+    ...plugin,
+    rules: {
+      ...rules,
+      [RULE]: {
+        ...rule,
+        /** @param {import('eslint').Rule.RuleContext} context */
+        create (context) {
+          const filtered = Object.create(context, {
+            report: {
+              value: (/** @type {import('eslint').Rule.ReportDescriptor} */ descriptor) => {
+                if (
+                  'messageId' in descriptor &&
+                  descriptor.messageId === 'contextuallyUnnecessary' &&
+                  'node' in descriptor &&
+                  ASSERTIONS.includes(descriptor.node.type)
+                ) {
+                  return;
+                }
+
+                context.report(descriptor);
+              }
+            }
+          });
+
+          return rule.create(filtered);
+        }
+      }
+    }
+  });
+}

package/package.json

@@ -15,7 +15,7 @@
   },
   "sideEffects": false,
   "type": "module",
-  "version": "0.86.1",
+  "version": "0.86.3",
   "bin": {
     "pezkuwi-ci-ghact-build": "./scripts/pezkuwi-ci-ghact-build.mjs",
     "pezkuwi-ci-ghact-docs": "./scripts/pezkuwi-ci-ghact-docs.mjs",
@@ -65,6 +65,7 @@
     "./config/eslint": "./config/eslint.js",
     "./config/eslint.rules": "./config/eslint.rules.js",
     "./config/eslint.standard": "./config/eslint.standard.js",
+    "./config/eslint.typeAssertion": "./config/eslint.typeAssertion.js",
     "./config/prettier.cjs": "./config/prettier.cjs",
     "./config/prettier": "./config/prettier.cjs",
     "./config/rollup": "./config/rollup.js",
@@ -288,8 +289,8 @@
   "dependencies": {
     "@eslint/compat": "^2.1.1",
     "@eslint/js": "^10.0.1",
-    "@pezkuwi/dev-test": "^0.86.1",
-    "@pezkuwi/dev-ts": "^0.86.1",
+    "@pezkuwi/dev-test": "^0.86.3",
+    "@pezkuwi/dev-ts": "^0.86.3",
     "@rollup/plugin-alias": "^5.1.1",
     "@rollup/plugin-commonjs": "^29.0.3",
     "@rollup/plugin-dynamic-import-vars": "^2.1.5",

package/packageInfo.js

@@ -1 +1 @@
-export const packageInfo = { name: '@pezkuwi/dev', path: (import.meta && import.meta.url) ? new URL(import.meta.url).pathname.substring(0, new URL(import.meta.url).pathname.lastIndexOf('/') + 1) : 'auto', type: 'esm', version: '0.86.1' };
+export const packageInfo = { name: '@pezkuwi/dev', path: (import.meta && import.meta.url) ? new URL(import.meta.url).pathname.substring(0, new URL(import.meta.url).pathname.lastIndexOf('/') + 1) : 'auto', type: 'esm', version: '0.86.3' };

package/scripts/pezkuwi-dev-migrate-eslint10.mjs

@@ -14,7 +14,9 @@
 //   pezkuwi-dev-migrate-eslint10 --check   # report, change nothing (exit 1 if anything would change)
 //
 // It also rewrites such comments inside string literals, which is how code
-// generators emit them.
+// generators emit them, and the rule keys of the repository's own
+// eslint.config.* ('import/extensions': 'off'). A rule that became several
+// is reported for a hand edit there, and the tool then exits 1.
 
 import stylisticPlugin from '@stylistic/eslint-plugin';
 import { builtinRules } from 'eslint/use-at-your-own-risk';
@@ -96,6 +98,38 @@ const files = execFileSync('git', ['ls-files', '-z', '--', '*.ts', '*.tsx', '*.j
 const check = process.argv.includes('--check');
 let changedFiles = 0;
 let changedComments = 0;
+let changedKeys = 0;
+/** @type {string[]} */
+const manual = [];
+
+// Rule keys in a repository's own eslint config ('import/extensions': 'off'),
+// quoted or not. Only in eslint.config.* files, where such a key is a rule.
+const CONFIG_FILE = /(^|\/)eslint\.config\.[cm]?[jt]s$/;
+const CONFIG_KEY = /(^|[{,\s])(['"]?)([@a-z][\w@/-]*)\2(\s*:)/g;
+
+/**
+ * @param {string} file
+ * @param {string} src
+ * @returns {string}
+ */
+function renameConfigKeys (file, src) {
+  return src.replace(CONFIG_KEY, (/** @type {string} */ all, /** @type {string} */ pre, /** @type {string} */ _quote, /** @type {string} */ name, /** @type {string} */ colon) => {
+    const next = rename(name);
+
+    if (next.length === 1 && next[0] === name) {
+      return all;
+    } else if (next.length !== 1) {
+      // one rule became several: the value has to be repeated for each, by hand
+      manual.push(`${file}: '${name}' is now ${next.join(', ')}`);
+
+      return all;
+    }
+
+    changedKeys++;
+
+    return `${pre}'${next[0]}'${colon}`;
+  });
+}
 
 for (const file of files) {
   const src = fs.readFileSync(file, 'utf-8');
@@ -116,19 +150,27 @@ for (const file of files) {
     return `${kind}${gap}${next.join(', ')}${tail}`;
   });
 
-  if (out !== src) {
+  const outKeys = CONFIG_FILE.test(file)
+    ? renameConfigKeys(file, out)
+    : out;
+
+  if (outKeys !== src) {
     changedFiles++;
 
     if (check) {
       console.log(`would change: ${file}`);
     } else {
-      fs.writeFileSync(file, out);
+      fs.writeFileSync(file, outKeys);
     }
   }
 }
 
-console.log(`${check ? 'would rewrite' : 'rewrote'} ${changedComments} directive(s) in ${changedFiles} file(s)`);
+for (const line of manual) {
+  console.log(`by hand: ${line}`);
+}
+
+console.log(`${check ? 'would rewrite' : 'rewrote'} ${changedComments} directive(s) and ${changedKeys} config key(s) in ${changedFiles} file(s)`);
 
-if (check && changedFiles) {
+if ((check && changedFiles) || manual.length) {
   process.exit(1);
 }