@petbee/eslint-config 3.0.6 → 3.0.7

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@petbee/eslint-config",
-  "version": "3.0.6",
+  "version": "3.0.7",
   "description": "Petbee's eslint config",
   "keywords": [
     "eslint",
@@ -51,6 +51,7 @@
     "eslint-plugin-n": "^17.23.1",
     "eslint-plugin-prettier": "^5.5.4",
     "eslint-plugin-react": "7.37.5",
+    "eslint-plugin-react-hooks": "^4.6.2",
     "typescript-eslint": "^8.47.0"
   },
   "peerDependencies": {
@@ -81,5 +82,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "a1aadd4aa610eb4a90c5cb823786abf68ac93d0d"
+  "gitHead": "d44351fa9e995cc0dc22f9b85f55d7305e6642ae"
 }

package/rules/nextjs.js

@@ -1,13 +1,48 @@
-module.exports = {
-  plugins: ['@next/eslint-plugin-next'],
-  extends: ['plugin:@next/next/recommended'],
-  rules: {
-    // Allow non-camelCase naming in Next.js projects (e.g., route segments, pages, metadata)
-    '@typescript-eslint/naming-convention': 'off',
-    // Next.js specific rules can be added here
-    // For example, enforce no HTML <img> element usage
-    '@next/next/no-img-element': 'error',
-    // Enforce usage of next/link for navigation
-    '@next/next/no-html-link-for-pages': 'warn',
-  },
+const { hasPackage } = require('../lib/utils')
+
+const hasNextJs = hasPackage('next')
+
+const nextjsRules = {
+  // Allow non-camelCase naming in Next.js projects (e.g., route segments, pages, metadata)
+  '@typescript-eslint/naming-convention': 'off',
+  // Next.js specific rules can be added here
+  // For example, enforce no HTML <img> element usage
+  '@next/next/no-img-element': 'error',
+  // Enforce usage of next/link for navigation
+  '@next/next/no-html-link-for-pages': 'warn',
 }
+
+// Legacy config for ESLint < 9 - only created if Next.js is available
+let legacyConfig = {}
+
+if (hasNextJs) {
+  legacyConfig = {
+    plugins: ['@next/eslint-plugin-next'],
+    extends: ['plugin:@next/next/recommended'],
+    rules: nextjsRules,
+  }
+}
+
+module.exports = legacyConfig
+
+// Flat config for ESLint v9+ - only created if Next.js is available
+let flatConfig = []
+
+if (hasNextJs) {
+  const nextjsPlugin = require('@next/eslint-plugin-next')
+
+  flatConfig = [
+    {
+      files: ['**/*.{jsx,tsx}'],
+      plugins: {
+        '@next/next': nextjsPlugin,
+      },
+      rules: {
+        ...nextjsPlugin.configs.recommended.rules,
+        ...nextjsRules,
+      },
+    },
+  ]
+}
+
+module.exports.flat = flatConfig

package/rules/react.js

@@ -22,13 +22,19 @@ const reactRules = {
   'react-hooks/exhaustive-deps': 'warn',
 }
 
-// Legacy config for ESLint < 9
-module.exports = {
-  plugins: ['react'],
-  extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  rules: reactRules,
+// Legacy config for ESLint < 9 - only created if React is available
+let legacyConfig = {}
+
+if (hasReact) {
+  legacyConfig = {
+    plugins: ['react'],
+    extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
+    rules: reactRules,
+  }
 }
 
+module.exports = legacyConfig
+
 // Flat config for ESLint v9+ - only created if React is available
 let flatConfig = []
 

package/rules/tests.js

@@ -2,83 +2,117 @@
 // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules
 // Cypress: https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules
 
-module.exports = {
-  overrides: [
-    // ! CYPRESS
-    {
-      files: ['**/cypress/**/*.{ts,tsx,js,jsx}'],
-      extends: ['plugin:cypress/recommended'],
-      rules: {
-        // Enforce assertions before taking a screenshot
-        // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/assertion-before-screenshot.md
-        'cypress/assertion-before-screenshot': 'warn',
-      },
+const { hasPackage } = require('../lib/utils')
+
+const hasCypress = hasPackage('cypress')
+const hasJest = hasPackage('jest')
+
+const overrides = []
+
+if (hasCypress) {
+  overrides.push({
+    files: ['**/cypress/**/*.{ts,tsx,js,jsx}'],
+    extends: ['plugin:cypress/recommended'],
+    rules: {
+      // Enforce assertions before taking a screenshot
+      // https://github.com/cypress-io/eslint-plugin-cypress/blob/master/docs/rules/assertion-before-screenshot.md
+      'cypress/assertion-before-screenshot': 'warn',
     },
-    // ! JEST
-    {
-      // Run through every test file found
-      files: ['*.{test,spec}.{ts,tsx,js,jsx}'],
-      // Unless it's inside a cypress directory
-      excludedFiles: ['**/cypress/**'],
-      extends: ['plugin:jest/recommended', 'plugin:jest/style'],
-      rules: {
-        // Enforce consistent a test method name
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/consistent-test-it.md
-        'jest/consistent-test-it': [
-          'warn',
-          {
-            fn: 'test',
-            withinDescribe: 'it',
-          },
-        ],
-
-        // Disallow alias methods
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-alias-methods.md
-        'jest/no-alias-methods': 'error',
-
-        // Disallow duplicate setup/teardown hooks
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-duplicate-hooks.md
-        'jest/no-duplicate-hooks': 'error',
-
-        // Suggest to have all hooks at top-level before tests
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-hooks-on-top.md
-        'jest/prefer-hooks-on-top': 'error',
-
-        // Suggest jest.spyOn() instead of jest.fn()
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-spy-on.md
-        'jest/prefer-spy-on': 'warn',
-
-        // Suggest using test.todo()
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-todo.md
-        'jest/prefer-todo': 'warn',
-
-        // Disallow return statements from tests
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-test-return-statement.md
-        'jest/no-test-return-statement': 'warn',
-
-        // Disallow deprecated jest functions
-        // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-deprecated-functions.md
-        'jest/no-deprecated-functions': 'error',
-      },
+  })
+}
+
+if (hasJest) {
+  overrides.push({
+    // Run through every test file found
+    files: ['*.{test,spec}.{ts,tsx,js,jsx}'],
+    // Unless it's inside a cypress directory
+    excludedFiles: ['**/cypress/**'],
+    extends: ['plugin:jest/recommended', 'plugin:jest/style'],
+    rules: {
+      // Enforce consistent a test method name
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/consistent-test-it.md
+      'jest/consistent-test-it': [
+        'warn',
+        {
+          fn: 'test',
+          withinDescribe: 'it',
+        },
+      ],
+
+      // Disallow alias methods
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-alias-methods.md
+      'jest/no-alias-methods': 'error',
+
+      // Disallow duplicate setup/teardown hooks
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-duplicate-hooks.md
+      'jest/no-duplicate-hooks': 'error',
+
+      // Suggest to have all hooks at top-level before tests
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-hooks-on-top.md
+      'jest/prefer-hooks-on-top': 'error',
+
+      // Suggest jest.spyOn() instead of jest.fn()
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-spy-on.md
+      'jest/prefer-spy-on': 'warn',
+
+      // Suggest using test.todo()
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/prefer-todo.md
+      'jest/prefer-todo': 'warn',
+
+      // Disallow return statements from tests
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-test-return-statement.md
+      'jest/no-test-return-statement': 'warn',
+
+      // Disallow deprecated jest functions
+      // https://github.com/jest-community/eslint-plugin-jest/blob/master/docs/rules/no-deprecated-functions.md
+      'jest/no-deprecated-functions': 'error',
     },
-  ],
+  })
+}
+
+module.exports = {
+  overrides,
 }
 
 // Flat config for ESLint v9 (no extends, plugins as object)
-module.exports.flat = [
-  {
-    files: module.exports.overrides[0].files,
+const flatConfig = []
+
+if (hasCypress) {
+  flatConfig.push({
+    files: ['**/cypress/**/*.{ts,tsx,js,jsx}'],
     plugins: {
       cypress: require('eslint-plugin-cypress'),
     },
-    rules: module.exports.overrides[0].rules,
-  },
-  {
-    files: module.exports.overrides[1].files,
-    excludedFiles: module.exports.overrides[1].excludedFiles,
+    rules: {
+      'cypress/assertion-before-screenshot': 'warn',
+    },
+  })
+}
+
+if (hasJest) {
+  flatConfig.push({
+    files: ['*.{test,spec}.{ts,tsx,js,jsx}'],
+    excludedFiles: ['**/cypress/**'],
     plugins: {
       jest: require('eslint-plugin-jest'),
     },
-    rules: module.exports.overrides[1].rules,
-  },
-]
+    rules: {
+      'jest/consistent-test-it': [
+        'warn',
+        {
+          fn: 'test',
+          withinDescribe: 'it',
+        },
+      ],
+      'jest/no-alias-methods': 'error',
+      'jest/no-duplicate-hooks': 'error',
+      'jest/prefer-hooks-on-top': 'error',
+      'jest/prefer-spy-on': 'warn',
+      'jest/prefer-todo': 'warn',
+      'jest/no-test-return-statement': 'warn',
+      'jest/no-deprecated-functions': 'error',
+    },
+  })
+}
+
+module.exports.flat = flatConfig