@petbee/eslint-config 3.0.3 → 3.0.5

package/index.mjs

@@ -10,12 +10,14 @@ import importsConfig from './rules/imports.js'
 import nestjsConfig from './rules/nestjs.js'
 import nodeConfig from './rules/node.js'
 import prettierConfig from './rules/prettier.js'
+import reactConfig from './rules/react.js'
 import styleConfig from './rules/style.js'
 import testsConfig from './rules/tests.js'
 import typescriptConfig from './rules/typescript.js'
 import variablesConfig from './rules/variables.js'
 
 const hasTypescript = hasPackage('typescript')
+const hasReact = hasPackage('react')
 
 const ignoreConfig = {
   ignores: ['coverage', 'dist', '**/dist/', 'node_modules', '**/node_modules'],
@@ -33,6 +35,7 @@ const eslintFlatConfig = [
   ...getFlat(bestPracticesConfig),
   ...getFlat(importsConfig),
   ...getFlat(testsConfig),
+  ...(hasReact ? getFlat(reactConfig) : []),
 ]
 
 const nestjsEslintFlatConfig = nestjsConfig.flat

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@petbee/eslint-config",
-  "version": "3.0.3",
+  "version": "3.0.5",
   "description": "Petbee's eslint config",
   "keywords": [
     "eslint",
@@ -81,5 +81,5 @@
   "publishConfig": {
     "access": "public"
   },
-  "gitHead": "46ff4afe672b542fcbd6d2f0b6481f52f2379b24"
+  "gitHead": "033cab1e3f57a1b92490ef1326415d33a21b0ec9"
 }

package/rules/nestjs.js

@@ -1,12 +1,9 @@
-const { hasPackage, getFlat } = require('../lib/utils')
+const { hasPackage } = require('../lib/utils')
 const nestjsLint = require('@darraghor/eslint-plugin-nestjs-typed')
-const tsConfig = require('./typescript.js') // <-- our patched TS config
+const { tsParserOptions } = require('./shared-config.js')
 
 const hasNestJs = hasPackage('@nestjs/core')
 
-// Grab TS-ESLint flat override
-const tsFlat = getFlat(tsConfig)
-
 const nestjsRules = {
   '@typescript-eslint/interface-name-prefix': 'off',
   '@typescript-eslint/explicit-function-return-type': 'off',
@@ -25,19 +22,19 @@ const nestjsRules = {
 }
 
 // If NestJS is present, take its flatRecommended array and
-// graft in parserOptions from tsFlat[0]:
+// graft in parserOptions from shared config:
 const nestFlat = hasNestJs
   ? [
       ...nestjsLint.default.configs.flatRecommended.map((cfg) => ({
         ...cfg,
         languageOptions: {
-          ...tsFlat[0].languageOptions,
-          ...cfg.languageOptions,
-          // merge parserOptions so `project` stays intact
+          parser: require('@typescript-eslint/parser'),
           parserOptions: {
-            ...tsFlat[0].languageOptions.parserOptions,
+            ...tsParserOptions,
+            // merge with any NestJS-specific parserOptions
             ...cfg.languageOptions?.parserOptions,
           },
+          ...cfg.languageOptions,
         },
       })),
       {

package/rules/react.js

@@ -1,23 +1,52 @@
+const reactPlugin = require('eslint-plugin-react')
+const reactHooksPlugin = require('eslint-plugin-react-hooks')
+
+const reactRules = {
+  // Allow non-camelCase naming in React projects (e.g., components, hooks, CSS modules)
+  '@typescript-eslint/naming-convention': 'off',
+  // Enforce consistent usage of function component definition
+  // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/function-component-definition.md
+  'react/function-component-definition': [
+    'error',
+    {
+      namedComponents: 'arrow-function',
+      unnamedComponents: 'arrow-function',
+    },
+  ],
+  // Prevent missing React when using JSX (React 17+ JSX transform)
+  'react/react-in-jsx-scope': 'off',
+  // Enforce rules of hooks
+  'react-hooks/rules-of-hooks': 'error',
+  // Verify the list of the dependencies for Hooks like useEffect and similar
+  'react-hooks/exhaustive-deps': 'warn',
+}
+
+// Legacy config for ESLint < 9
 module.exports = {
   plugins: ['react'],
   extends: ['plugin:react/recommended', 'plugin:react-hooks/recommended'],
-  rules: {
-    // Allow non-camelCase naming in React projects (e.g., components, hooks, CSS modules)
-    '@typescript-eslint/naming-convention': 'off',
-    // Enforce consistent usage of function component definition
-    // https://github.com/jsx-eslint/eslint-plugin-react/blob/master/docs/rules/function-component-definition.md
-    'react/function-component-definition': [
-      'error',
-      {
-        namedComponents: 'arrow-function',
-        unnamedComponents: 'arrow-function',
+  rules: reactRules,
+}
+
+// Flat config for ESLint v9+
+module.exports.flat = [
+  {
+    files: ['**/*.{jsx,tsx}'],
+    plugins: {
+      react: reactPlugin,
+      'react-hooks': reactHooksPlugin,
+    },
+    languageOptions: {
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
       },
-    ],
-    // Prevent missing React when using JSX (React 17+ JSX transform)
-    'react/react-in-jsx-scope': 'off',
-    // Enforce rules of hooks
-    'react-hooks/rules-of-hooks': 'error',
-    // Verify the list of the dependencies for Hooks like useEffect and similar
-    'react-hooks/exhaustive-deps': 'warn',
+    },
+    rules: {
+      ...reactPlugin.configs.recommended.rules,
+      ...reactHooksPlugin.configs.recommended.rules,
+      ...reactRules,
+    },
   },
-}
+]

package/rules/shared-config.js

@@ -0,0 +1,36 @@
+// Shared configuration to avoid circular dependencies
+const { hasPackage } = require('../lib/utils')
+
+const hasTypescript = hasPackage('typescript')
+
+// Common TypeScript parser configuration
+const tsParserOptions = {
+  ecmaVersion: 2022,
+  sourceType: 'module',
+  projectService: true,
+  tsconfigRootDir: process.cwd(),
+  projectFolderIgnoreList: [/node_modules/i],
+  allowAutomaticSingleRunInference: true,
+}
+
+// Common TypeScript rules
+const tsCommonRules = {
+  'no-useless-catch': 'warn',
+  'no-magic-numbers': ['warn', { ignore: [0, 1], ignoreArrayIndexes: true }],
+  'max-classes-per-file': ['warn', 1],
+  'prefer-arrow-callback': ['warn', { allowNamedFunctions: false, allowUnboundThis: true }],
+  'no-console': ['warn', { allow: ['warn', 'error', 'info'] }],
+  'import/no-relative-parent-imports': 'warn',
+  'no-restricted-imports': [
+    'error',
+    {
+      patterns: ['../../*'],
+    },
+  ],
+}
+
+module.exports = {
+  hasTypescript,
+  tsParserOptions,
+  tsCommonRules,
+}

package/rules/typescript.js

@@ -1,13 +1,16 @@
 const { hasPackage } = require('../lib/utils')
-const hasTypescript = hasPackage('typescript')
+const { hasTypescript, tsParserOptions, tsCommonRules } = require('./shared-config.js')
+
 const hasNestJs = hasPackage('@nestjs/core')
-const hasReact = hasPackage('react')
 const hasNext = hasPackage('next') || hasPackage('nextjs')
 
 // Load framework-specific rules
-const reactRules = hasReact ? require('./react.js').rules : {}
 const nextjsRules = hasNext ? require('./nextjs.js').rules : {}
-const nestjsRules = hasNestJs ? require('./nestjs.js').rules : {}
+// Note: Don't require nestjs.js here to avoid circular dependency.
+// NestJS handles its own flat config completely.
+// React rules are now handled separately in index.mjs
+const nestjsRules = {}
+const reactRules = {}
 
 const tsConfigOptions = [
   {
@@ -15,30 +18,9 @@ const tsConfigOptions = [
     extends: ['plugin:@typescript-eslint/eslint-recommended', 'plugin:@typescript-eslint/recommended'],
     plugins: ['@typescript-eslint'],
     parser: '@typescript-eslint/parser',
-    parserOptions: {
-      ecmaVersion: 2022,
-      sourceType: 'module',
-      projectService: true,
-      tsconfigRootDir: process.cwd(),
-      projectFolderIgnoreList: [/node_modules/i],
-      // We need this configuration to avoid performance issues in monorepos
-      // https://github.com/typescript-eslint/typescript-eslint/issues/1192#issuecomment-862414778
-      allowAutomaticSingleRunInference: true,
-    },
+    parserOptions: tsParserOptions,
     rules: {
-      // General improvements
-      'no-useless-catch': 'warn',
-      'no-magic-numbers': ['warn', { ignore: [0, 1], ignoreArrayIndexes: true }],
-      'max-classes-per-file': ['warn', 1],
-      'prefer-arrow-callback': ['warn', { allowNamedFunctions: false, allowUnboundThis: true }],
-      'no-console': ['warn', { allow: ['warn', 'error', 'info'] }],
-      'import/no-relative-parent-imports': 'warn',
-      'no-restricted-imports': [
-        'error',
-        {
-          patterns: ['../../*'],
-        },
-      ],
+      ...tsCommonRules,
       ...reactRules,
       ...nextjsRules,
       ...nestjsRules,
@@ -62,7 +44,7 @@ const flatConfig = hasTypescript
         languageOptions: {
           parser: require('@typescript-eslint/parser'),
           parserOptions: {
-            ...tsConfigOptions[0].parserOptions,
+            ...tsParserOptions,
             tsconfigRootDir: process.cwd(),
           },
         },