@perses-dev/plugin-system 0.0.0-snapshot-scatter-chart-embed-8efdfab → 0.0.0-snapshot-explorer-plugin-c4a7621

package/dist/cjs/{validation/resource.js → components/MetricLabelInput/index.js}

@@ -1,4 +1,4 @@
-// Copyright 2023 The Perses Authors
+// Copyright 2025 The Perses Authors
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -14,11 +14,17 @@
 Object.defineProperty(exports, "__esModule", {
     value: true
 });
-Object.defineProperty(exports, "resourceIdValidationSchema", {
-    enumerable: true,
-    get: function() {
-        return resourceIdValidationSchema;
-    }
-});
-const _zod = require("zod");
-const resourceIdValidationSchema = _zod.z.string().nonempty('Required').max(75, 'Must be 75 or fewer characters long').regex(/^[a-zA-Z0-9_.-]+$/, 'Must only contains alphanumerical characters and special characters _ . -');
+_export_star(require("./MetricLabelInput"), exports);
+function _export_star(from, to) {
+    Object.keys(from).forEach(function(k) {
+        if (k !== "default" && !Object.prototype.hasOwnProperty.call(to, k)) {
+            Object.defineProperty(to, k, {
+                enumerable: true,
+                get: function() {
+                    return from[k];
+                }
+            });
+        }
+    });
+    return from;
+}

package/dist/cjs/components/{TraceQueryEditor/TraceQueryEditor.js → MultiQueryEditor/MultiQueryEditor.js}

@@ -1,4 +1,4 @@
-// Copyright 2023 The Perses Authors
+// Copyright 2024 The Perses Authors
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -14,35 +14,53 @@
 Object.defineProperty(exports, "__esModule", {
     value: true
 });
-Object.defineProperty(exports, "TraceQueryEditor", {
+Object.defineProperty(exports, "MultiQueryEditor", {
     enumerable: true,
     get: function() {
-        return TraceQueryEditor;
+        return MultiQueryEditor;
     }
 });
 const _jsxruntime = require("react/jsx-runtime");
-const _material = require("@mui/material");
-const _Plus = /*#__PURE__*/ _interop_require_default(require("mdi-material-ui/Plus"));
 const _react = require("react");
 const _immer = require("immer");
+const _material = require("@mui/material");
+const _Plus = /*#__PURE__*/ _interop_require_default(require("mdi-material-ui/Plus"));
 const _runtime = require("../../runtime");
-const _TraceQueryInput = require("./TraceQueryInput");
+const _QueryEditorContainer = require("./QueryEditorContainer");
 function _interop_require_default(obj) {
     return obj && obj.__esModule ? obj : {
         default: obj
     };
 }
-const DEFAULT_QUERY_PLUGIN_TYPE = 'TraceQuery';
-function TraceQueryEditor({ queries =[] , onChange  }) {
-    const hasMoreThanOneQuery = queries.length > 1;
-    const defaultTraceQueryKind = 'TempoTraceQuery';
-    // State for which queries are collapsed
-    // TODO: Would be easier if we had IDs for queries.
-    const [queriesCollapsed, setQueriesCollapsed] = (0, _react.useState)(queries.map(()=>false));
-    const { data: defaultQueryPlugin  } = (0, _runtime.usePlugin)(DEFAULT_QUERY_PLUGIN_TYPE, defaultTraceQueryKind, {
-        useErrorBoundary: true,
+function useDefaultQueryDefinition(queryTypes) {
+    // Build the default query plugin
+    // This will be used only if the queries are empty, to open a starting query
+    // Firs the default query type
+    const defaultQueryType = queryTypes[0];
+    // Then the default plugin kind
+    // Use as default the plugin kind explicitly set as default or the first in the list
+    const { data: queryPlugins } = (0, _runtime.useListPluginMetadata)(queryTypes);
+    const { defaultPluginKinds } = (0, _runtime.usePluginRegistry)();
+    const defaultQueryKind = defaultPluginKinds?.[defaultQueryType] ?? queryPlugins?.[0]?.spec.name ?? '';
+    const { data: defaultQueryPlugin } = (0, _runtime.usePlugin)(defaultQueryType, defaultQueryKind, {
+        throwOnError: true,
         enabled: true
     });
+    // This default query definition is used if no query is provided initially or when we add a new query
+    return {
+        kind: defaultQueryType,
+        spec: {
+            plugin: {
+                kind: defaultQueryKind,
+                spec: defaultQueryPlugin?.createInitialOptions() || {}
+            }
+        }
+    };
+}
+function MultiQueryEditor({ queryTypes, queries = [], onChange }) {
+    const defaultInitialQueryDefinition = useDefaultQueryDefinition(queryTypes);
+    // State for which queries are collapsed
+    const [queriesCollapsed, setQueriesCollapsed] = (0, _react.useState)(queries.map(()=>false));
     // Query handlers
     const handleQueryChange = (index, queryDef)=>{
         onChange((0, _immer.produce)(queries, (draft)=>{
@@ -56,23 +74,13 @@ function TraceQueryEditor({ queries =[] , onChange  }) {
         }));
     };
     const handleQueryAdd = ()=>{
-        if (!defaultQueryPlugin) return;
         onChange((0, _immer.produce)(queries, (draft)=>{
-            const queryDef = {
-                kind: DEFAULT_QUERY_PLUGIN_TYPE,
-                spec: {
-                    plugin: {
-                        kind: defaultTraceQueryKind,
-                        spec: defaultQueryPlugin.createInitialOptions()
-                    }
-                }
-            };
             if (draft) {
-                draft.push(queryDef);
+                draft.push(defaultInitialQueryDefinition);
             } else {
                 draft = [
                     ...queries,
-                    queryDef
+                    defaultInitialQueryDefinition
                 ];
             }
         }));
@@ -104,28 +112,19 @@ function TraceQueryEditor({ queries =[] , onChange  }) {
     };
     // show one query input if queries is empty
     const queryDefinitions = queries.length ? queries : [
-        {
-            kind: 'TraceQuery',
-            spec: {
-                plugin: {
-                    kind: 'TempoTraceQuery',
-                    spec: {
-                        query: ''
-                    }
-                }
-            }
-        }
+        defaultInitialQueryDefinition
     ];
     return /*#__PURE__*/ (0, _jsxruntime.jsxs)(_jsxruntime.Fragment, {
         children: [
             /*#__PURE__*/ (0, _jsxruntime.jsx)(_material.Stack, {
                 spacing: 1,
-                children: queryDefinitions.map((query, i)=>/*#__PURE__*/ (0, _jsxruntime.jsx)(_TraceQueryInput.TraceQueryInput, {
+                children: queryDefinitions.map((query, i)=>/*#__PURE__*/ (0, _jsxruntime.jsx)(_QueryEditorContainer.QueryEditorContainer, {
+                        queryTypes: queryTypes,
                         index: i,
                         query: query,
                         isCollapsed: !!queriesCollapsed[i],
                         onChange: handleQueryChange,
-                        onDelete: hasMoreThanOneQuery ? handleQueryDelete : undefined,
+                        onDelete: queries.length > 1 ? handleQueryDelete : undefined,
                         onCollapseExpand: handleQueryCollapseExpand
                     }, i))
             }),

package/dist/cjs/components/{TimeSeriesQueryEditor/TimeSeriesQueryInput.js → MultiQueryEditor/QueryEditorContainer.js}

@@ -1,4 +1,4 @@
-// Copyright 2023 The Perses Authors
+// Copyright 2024 The Perses Authors
 // Licensed under the Apache License, Version 2.0 (the "License");
 // you may not use this file except in compliance with the License.
 // You may obtain a copy of the License at
@@ -14,10 +14,10 @@
 Object.defineProperty(exports, "__esModule", {
     value: true
 });
-Object.defineProperty(exports, "TimeSeriesQueryInput", {
+Object.defineProperty(exports, "QueryEditorContainer", {
     enumerable: true,
     get: function() {
-        return TimeSeriesQueryInput;
+        return QueryEditorContainer;
     }
 });
 const _jsxruntime = require("react/jsx-runtime");
@@ -32,7 +32,7 @@ function _interop_require_default(obj) {
         default: obj
     };
 }
-const TimeSeriesQueryInput = ({ index , query , isCollapsed , onDelete , onChange , onCollapseExpand  })=>{
+const QueryEditorContainer = ({ queryTypes, index, query, isCollapsed, onDelete, onChange, onCollapseExpand })=>{
     return /*#__PURE__*/ (0, _jsxruntime.jsxs)(_material.Stack, {
         spacing: 1,
         children: [
@@ -51,7 +51,7 @@ const TimeSeriesQueryInput = ({ index , query , isCollapsed , onDelete , onChang
                         variant: "overline",
                         component: "h4",
                         children: [
-                            "Query ",
+                            "Query #",
                             index + 1
                         ]
                     }),
@@ -68,6 +68,7 @@ const TimeSeriesQueryInput = ({ index , query , isCollapsed , onDelete , onChang
                 ]
             }),
             !isCollapsed && /*#__PURE__*/ (0, _jsxruntime.jsx)(QueryEditor, {
+                queryTypes: queryTypes,
                 value: query,
                 onChange: (next)=>onChange(index, next)
             })
@@ -75,21 +76,32 @@ const TimeSeriesQueryInput = ({ index , query , isCollapsed , onDelete , onChang
     }, index);
 };
 /**
- * Displays an editor for TimeSeriesQueryDefinition objects.
+ * Editor for a query definition. This component is responsible for rendering the plugin editor for the given query.
+ * This will allow user to select a plugin extending from the given supported query types, and then edit the plugin
+ * spec for this plugin.
+ * @param props
+ * @constructor
  */ function QueryEditor(props) {
-    const { value , onChange , ...others } = props;
-    const { spec: { plugin  }  } = value;
+    const { value, onChange, queryTypes, ...others } = props;
     const handlePluginChange = (next)=>{
         onChange((0, _immer.default)(value, (draft)=>{
-            draft.spec.plugin = next;
+            draft.kind = next.selection.type;
+            draft.spec.plugin.kind = next.selection.kind;
+            draft.spec.plugin.spec = next.spec;
         }));
     };
     return /*#__PURE__*/ (0, _jsxruntime.jsx)(_material.Box, {
         ...others,
         children: /*#__PURE__*/ (0, _jsxruntime.jsx)(_PluginEditor.PluginEditor, {
-            pluginType: "TimeSeriesQuery",
+            pluginTypes: queryTypes,
             pluginKindLabel: "Query Type",
-            value: plugin,
+            value: {
+                selection: {
+                    kind: value.spec.plugin.kind,
+                    type: value.kind
+                },
+                spec: value.spec.plugin.spec
+            },
             onChange: handlePluginChange
         })
     });

package/dist/cjs/components/MultiQueryEditor/index.js

@@ -0,0 +1,30 @@
+// Copyright 2024 The Perses Authors
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+"use strict";
+Object.defineProperty(exports, "__esModule", {
+    value: true
+});
+_export_star(require("./MultiQueryEditor"), exports);
+function _export_star(from, to) {
+    Object.keys(from).forEach(function(k) {
+        if (k !== "default" && !Object.prototype.hasOwnProperty.call(to, k)) {
+            Object.defineProperty(to, k, {
+                enumerable: true,
+                get: function() {
+                    return from[k];
+                }
+            });
+        }
+    });
+    return from;
+}

package/dist/cjs/components/OptionsEditorRadios/OptionsEditorRadios.js

@@ -25,7 +25,7 @@ const _material = require("@mui/material");
 const _react = require("react");
 const _OptionsEditorTabPanel = require("../OptionsEditorTabPanel");
 const OptionsEditorRadios = (props)=>{
-    const { tabs , defaultTab , onModeChange , isReadonly  } = props;
+    const { tabs, defaultTab, onModeChange, isReadonly } = props;
     const [activeTab, setActiveTab] = (0, _react.useState)(defaultTab);
     const handleChange = (_, value)=>{
         const v = parseInt(value);
@@ -46,7 +46,7 @@ const OptionsEditorRadios = (props)=>{
                         value: activeTab,
                         onChange: handleChange,
                         "aria-labelledby": "Configuration radio",
-                        children: tabs.map(({ label  }, i)=>{
+                        children: tabs.map(({ label }, i)=>{
                             return /*#__PURE__*/ (0, _jsxruntime.jsx)(_material.FormControlLabel, {
                                 disabled: isReadonly,
                                 value: i,
@@ -57,7 +57,7 @@ const OptionsEditorRadios = (props)=>{
                     })
                 })
             }),
-            tabs.map(({ label , content  }, i)=>{
+            tabs.map(({ label, content }, i)=>{
                 return /*#__PURE__*/ (0, _jsxruntime.jsx)(_OptionsEditorTabPanel.OptionsEditorTabPanel, {
                     value: activeTab,
                     index: i,

package/dist/cjs/components/OptionsEditorTabPanel/OptionsEditorTabPanel.js

@@ -23,7 +23,7 @@ Object.defineProperty(exports, "OptionsEditorTabPanel", {
 const _jsxruntime = require("react/jsx-runtime");
 const _material = require("@mui/material");
 function OptionsEditorTabPanel(props) {
-    const { children , value , index , ...other } = props;
+    const { children, value, index, ...other } = props;
     const isActive = value === index;
     return /*#__PURE__*/ (0, _jsxruntime.jsx)("div", {
         role: "tabpanel",

package/dist/cjs/components/OptionsEditorTabs/OptionsEditorTabs.js

@@ -24,7 +24,7 @@ const _jsxruntime = require("react/jsx-runtime");
 const _material = require("@mui/material");
 const _react = require("react");
 const _OptionsEditorTabPanel = require("../OptionsEditorTabPanel");
-const OptionsEditorTabs = ({ tabs  })=>{
+const OptionsEditorTabs = ({ tabs })=>{
     const [activeTab, setActiveTab] = (0, _react.useState)(0);
     const handleChange = (_, newValue)=>{
         setActiveTab(newValue);
@@ -40,7 +40,7 @@ const OptionsEditorTabs = ({ tabs  })=>{
                     value: activeTab,
                     onChange: handleChange,
                     "aria-label": "Panel configuration tabs",
-                    children: tabs.map(({ label  }, i)=>{
+                    children: tabs.map(({ label }, i)=>{
                         return /*#__PURE__*/ (0, _jsxruntime.jsx)(_material.Tab, {
                             label: label,
                             id: `options-editor-tab-${i}`,
@@ -49,7 +49,7 @@ const OptionsEditorTabs = ({ tabs  })=>{
                     })
                 })
             }),
-            tabs.map(({ label , content  }, i)=>{
+            tabs.map(({ label, content }, i)=>{
                 return /*#__PURE__*/ (0, _jsxruntime.jsx)(_OptionsEditorTabPanel.OptionsEditorTabPanel, {
                     value: activeTab,
                     index: i,

package/dist/cjs/components/PanelSpecEditor/PanelSpecEditor.js

@@ -22,95 +22,87 @@ Object.defineProperty(exports, "PanelSpecEditor", {
 });
 const _jsxruntime = require("react/jsx-runtime");
 const _components = require("@perses-dev/components");
+const _reacthookform = require("react-hook-form");
 const _runtime = require("../../runtime");
 const _OptionsEditorTabs = require("../OptionsEditorTabs");
-const _TimeSeriesQueryEditor = require("../TimeSeriesQueryEditor");
-const _TraceQueryEditor = require("../TraceQueryEditor");
+const _MultiQueryEditor = require("../MultiQueryEditor");
 function PanelSpecEditor(props) {
-    const { panelDefinition , onJSONChange , onQueriesChange , onPluginSpecChange  } = props;
-    const { kind  } = panelDefinition.spec.plugin;
-    const { data: plugin , isLoading , error  } = (0, _runtime.usePlugin)('Panel', kind);
+    const { control, panelDefinition, onJSONChange, onQueriesChange, onPluginSpecChange } = props;
+    const { kind } = panelDefinition.spec.plugin;
+    const { data: plugin, isPending, error } = (0, _runtime.usePlugin)('Panel', kind);
     if (error) {
         return /*#__PURE__*/ (0, _jsxruntime.jsx)(_components.ErrorAlert, {
             error: error
         });
     }
     // TODO: Proper loading indicator
-    if (isLoading) {
+    if (isPending) {
         return null;
     }
     if (plugin === undefined) {
         throw new Error(`Missing implementation for panel plugin with kind '${kind}'`);
     }
-    const getQueryType = ()=>{
-        var _panelDefinition_spec, _queriesList_;
-        const queriesList = panelDefinition === null || panelDefinition === void 0 ? void 0 : (_panelDefinition_spec = panelDefinition.spec) === null || _panelDefinition_spec === void 0 ? void 0 : _panelDefinition_spec.queries;
-        if (queriesList === undefined) {
-            return '';
-        }
-        const queryType = (_queriesList_ = queriesList[0]) === null || _queriesList_ === void 0 ? void 0 : _queriesList_.kind;
-        return queryType;
-    };
-    // Get the corresponding queryEditor depending on the queryType
-    const getQueryEditorComponent = ()=>{
-        const queryType = getQueryType();
-        // default case handles cause where there is no queryType yet (e.g. UI > 'editing' mode > 'Add Panel')
-        switch(queryType){
-            case 'TimeSeriesQuery':
-                var _panelDefinition_spec_queries;
-                return /*#__PURE__*/ (0, _jsxruntime.jsx)(_TimeSeriesQueryEditor.TimeSeriesQueryEditor, {
-                    queries: (_panelDefinition_spec_queries = panelDefinition.spec.queries) !== null && _panelDefinition_spec_queries !== void 0 ? _panelDefinition_spec_queries : [],
-                    onChange: onQueriesChange
-                });
-            case 'TraceQuery':
-                var _panelDefinition_spec_queries1;
-                return /*#__PURE__*/ (0, _jsxruntime.jsx)(_TraceQueryEditor.TraceQueryEditor, {
-                    queries: (_panelDefinition_spec_queries1 = panelDefinition.spec.queries) !== null && _panelDefinition_spec_queries1 !== void 0 ? _panelDefinition_spec_queries1 : [],
-                    onChange: onQueriesChange
-                });
-            default:
-                // ScatterChart only handles trace queries for now
-                if (kind === 'ScatterChart') {
-                    var _panelDefinition_spec_queries2;
-                    return /*#__PURE__*/ (0, _jsxruntime.jsx)(_TraceQueryEditor.TraceQueryEditor, {
-                        queries: (_panelDefinition_spec_queries2 = panelDefinition.spec.queries) !== null && _panelDefinition_spec_queries2 !== void 0 ? _panelDefinition_spec_queries2 : [],
-                        onChange: onQueriesChange
-                    });
-                }
-                var _panelDefinition_spec_queries3;
-                return /*#__PURE__*/ (0, _jsxruntime.jsx)(_TimeSeriesQueryEditor.TimeSeriesQueryEditor, {
-                    queries: (_panelDefinition_spec_queries3 = panelDefinition.spec.queries) !== null && _panelDefinition_spec_queries3 !== void 0 ? _panelDefinition_spec_queries3 : [],
-                    onChange: onQueriesChange
-                });
-        }
-    };
-    const { panelOptionsEditorComponents , hideQueryEditor  } = plugin;
+    const { panelOptionsEditorComponents, hideQueryEditor } = plugin;
     let tabs = [];
     if (!hideQueryEditor) {
         tabs.push({
             label: 'Query',
-            content: getQueryEditorComponent()
+            content: /*#__PURE__*/ (0, _jsxruntime.jsx)(_reacthookform.Controller, {
+                control: control,
+                name: "panelDefinition.spec.queries",
+                render: ({ field })=>/*#__PURE__*/ (0, _jsxruntime.jsx)(_MultiQueryEditor.MultiQueryEditor, {
+                        queryTypes: plugin.supportedQueryTypes ?? [],
+                        queries: panelDefinition.spec.queries ?? [],
+                        onChange: (queries)=>{
+                            field.onChange(queries);
+                            onQueriesChange(queries);
+                        }
+                    })
+            })
         });
     }
     if (panelOptionsEditorComponents !== undefined) {
-        tabs = tabs.concat(panelOptionsEditorComponents.map(({ label , content: OptionsEditorComponent  })=>({
+        tabs = tabs.concat(panelOptionsEditorComponents.map(({ label, content: OptionsEditorComponent })=>({
                 label,
-                content: /*#__PURE__*/ (0, _jsxruntime.jsx)(OptionsEditorComponent, {
-                    value: panelDefinition.spec.plugin.spec,
-                    onChange: onPluginSpecChange
+                content: /*#__PURE__*/ (0, _jsxruntime.jsx)(_reacthookform.Controller, {
+                    control: control,
+                    name: "panelDefinition.spec.plugin.spec",
+                    render: ({ field })=>/*#__PURE__*/ (0, _jsxruntime.jsx)(OptionsEditorComponent, {
+                            value: panelDefinition.spec.plugin.spec,
+                            onChange: (spec)=>{
+                                field.onChange(spec);
+                                onPluginSpecChange(spec);
+                            }
+                        })
                 })
             })));
     }
-    // always show json editor by default
+    // always show json editor and links editor by default
+    tabs.push({
+        label: 'Links',
+        content: /*#__PURE__*/ (0, _jsxruntime.jsx)(_components.LinksEditor, {
+            control: control
+        })
+    });
     tabs.push({
         label: 'JSON',
-        content: /*#__PURE__*/ (0, _jsxruntime.jsx)(_components.JSONEditor, {
-            maxHeight: "80vh",
-            value: panelDefinition,
-            onChange: onJSONChange
+        content: /*#__PURE__*/ (0, _jsxruntime.jsx)(_reacthookform.Controller, {
+            control: control,
+            name: "panelDefinition",
+            render: ({ field })=>/*#__PURE__*/ (0, _jsxruntime.jsx)(_components.JSONEditor, {
+                    maxHeight: "80vh",
+                    value: panelDefinition,
+                    onChange: (json)=>{
+                        field.onChange(JSON.parse(json));
+                        onJSONChange(json);
+                    }
+                })
         })
     });
-    return /*#__PURE__*/ (0, _jsxruntime.jsx)(_OptionsEditorTabs.OptionsEditorTabs, {
-        tabs: tabs
-    }, tabs.length);
+    return /*#__PURE__*/ (0, _jsxruntime.jsx)(_runtime.QueryCountProvider, {
+        queryCount: (panelDefinition.spec.queries ?? []).length,
+        children: /*#__PURE__*/ (0, _jsxruntime.jsx)(_OptionsEditorTabs.OptionsEditorTabs, {
+            tabs: tabs
+        }, tabs.length)
+    });
 }

package/dist/cjs/components/PluginEditor/PluginEditor.js

@@ -22,40 +22,43 @@ Object.defineProperty(exports, "PluginEditor", {
 });
 const _jsxruntime = require("react/jsx-runtime");
 const _material = require("@mui/material");
+const _components = require("@perses-dev/components");
 const _PluginKindSelect = require("../PluginKindSelect");
 const _PluginSpecEditor = require("../PluginSpecEditor");
 const _plugineditorapi = require("./plugin-editor-api");
 function PluginEditor(props) {
     // eslint-disable-next-line @typescript-eslint/no-unused-vars
-    const { value , pluginType , pluginKindLabel , onChange: _ , isReadonly , ...others } = props;
-    const { pendingKind , isLoading , error , onKindChange , onSpecChange  } = (0, _plugineditorapi.usePluginEditor)(props);
+    const { value, pluginTypes, pluginKindLabel, onChange: _, isReadonly, ...others } = props;
+    const { pendingSelection, isLoading, error, onSelectionChange, onSpecChange } = (0, _plugineditorapi.usePluginEditor)(props);
     return /*#__PURE__*/ (0, _jsxruntime.jsxs)(_material.Box, {
         ...others,
         children: [
             /*#__PURE__*/ (0, _jsxruntime.jsx)(_PluginKindSelect.PluginKindSelect, {
                 fullWidth: false,
                 sx: {
-                    mb: 1,
+                    mb: 2,
                     minWidth: 120
                 },
                 margin: "dense",
                 label: pluginKindLabel,
-                pluginType: pluginType,
+                pluginTypes: pluginTypes,
                 disabled: isLoading,
-                value: pendingKind !== '' ? pendingKind : value.kind,
+                value: pendingSelection ? pendingSelection : value.selection,
                 InputProps: {
                     readOnly: isReadonly
                 },
                 error: !!error,
-                helperText: error === null || error === void 0 ? void 0 : error.message,
-                onChange: onKindChange
+                helperText: error?.message,
+                onChange: onSelectionChange
             }),
-            /*#__PURE__*/ (0, _jsxruntime.jsx)(_PluginSpecEditor.PluginSpecEditor, {
-                pluginType: pluginType,
-                pluginKind: value.kind,
-                value: value.spec,
-                onChange: onSpecChange,
-                isReadonly: isReadonly
+            /*#__PURE__*/ (0, _jsxruntime.jsx)(_components.ErrorBoundary, {
+                FallbackComponent: _components.ErrorAlert,
+                children: /*#__PURE__*/ (0, _jsxruntime.jsx)(_PluginSpecEditor.PluginSpecEditor, {
+                    pluginSelection: value.selection,
+                    value: value.spec,
+                    onChange: onSpecChange,
+                    isReadonly: isReadonly
+                })
             })
         ]
     });