@perses-dev/dashboards 0.23.1 → 0.25.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@perses-dev/dashboards",
-  "version": "0.23.1",
+  "version": "0.25.0",
   "description": "The dashboards feature in Perses",
   "license": "Apache-2.0",
   "homepage": "https://github.com/perses/perses/blob/main/README.md",
@@ -20,7 +20,8 @@
     "build": "concurrently \"npm:build:*\"",
     "build:cjs": "swc ./src -d dist/cjs --config-file ../.cjs.swcrc",
     "build:esm": "swc ./src -d dist --config-file ../.swcrc",
-    "build:types": "tsc --emitDeclarationOnly --declaration --preserveWatchOutput",
+    "build:types": "tsc --project tsconfig.build.json",
+    "type-check": "tsc --noEmit",
     "start": "concurrently -P \"npm:build:* -- {*}\" -- --watch",
     "test": "TZ=UTC jest",
     "test:watch": "npm run test -- --watch",
@@ -28,9 +29,9 @@
     "lint:fix": "eslint --fix src --ext .ts,.tsx"
   },
   "dependencies": {
-    "@perses-dev/components": "0.23.1",
-    "@perses-dev/core": "0.23.1",
-    "@perses-dev/plugin-system": "0.23.1",
+    "@perses-dev/components": "0.25.0",
+    "@perses-dev/core": "0.25.0",
+    "@perses-dev/plugin-system": "0.25.0",
     "@types/react-grid-layout": "^1.3.2",
     "date-fns": "^2.28.0",
     "immer": "^9.0.15",

package/dist/cjs/components/Panel/Panel.test.js

@@ -1,137 +0,0 @@
-// Copyright 2023 The Perses Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-"use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
-const _jsxRuntime = require("react/jsx-runtime");
-const _react = require("@testing-library/react");
-const _userEvent = /*#__PURE__*/ _interopRequireDefault(require("@testing-library/user-event"));
-const _test = require("../../test");
-const _panel = require("./Panel");
-function _interopRequireDefault(obj) {
-    return obj && obj.__esModule ? obj : {
-        default: obj
-    };
-}
-describe('Panel', ()=>{
-    const createTestPanel = ()=>({
-            kind: 'Panel',
-            spec: {
-                display: {
-                    name: 'Fake Panel Title',
-                    description: 'This is a fake panel'
-                },
-                plugin: {
-                    kind: 'TimeSeriesChart',
-                    spec: {}
-                }
-            }
-        });
-    // Helper to render the panel with some context set
-    const renderPanel = (definition, editHandlers)=>{
-        definition !== null && definition !== void 0 ? definition : definition = createTestPanel();
-        (0, _test.renderWithContext)(/*#__PURE__*/ (0, _jsxRuntime.jsx)(_panel.Panel, {
-            definition: definition,
-            editHandlers: editHandlers
-        }));
-    };
-    // Helper to get the panel once rendered
-    const getPanel = ()=>_react.screen.getByRole('region', {
-            name: 'Fake Panel Title'
-        });
-    it('should render panel', async ()=>{
-        renderPanel();
-        const panel = getPanel();
-        expect(panel).toBeInTheDocument();
-        // Should diplay header with panel's title
-        const header = _react.screen.getByRole('banner');
-        expect(header).toHaveTextContent('Fake Panel Title');
-        // Should display chart's content from the fake panel plugin
-        const content = _react.screen.getByRole('figure');
-        await (0, _react.waitFor)(()=>{
-            expect(content).toHaveTextContent('TimeSeriesChart panel');
-        });
-        expect(content);
-    });
-    it('shows panel description', async ()=>{
-        renderPanel();
-        const panel = getPanel();
-        // Description button should not be visible until hover on panel
-        const missingButton = _react.screen.queryByRole('button', {
-            name: /description/i
-        });
-        expect(missingButton).not.toBeInTheDocument();
-        _userEvent.default.hover(panel);
-        const descriptionButton = _react.screen.getByRole('button', {
-            name: /description/i
-        });
-        expect(descriptionButton).toBeInTheDocument();
-        // Can hover to see panel description in tooltip
-        _userEvent.default.hover(descriptionButton);
-        const tooltip = await _react.screen.findByRole('tooltip');
-        expect(tooltip).toHaveTextContent('This is a fake panel');
-    });
-    it('does not show description when panel does not have one', ()=>{
-        // Render a panel without a description set
-        const withoutDescription = createTestPanel();
-        withoutDescription.spec.display.description = undefined;
-        renderPanel(withoutDescription);
-        const panel = getPanel();
-        _userEvent.default.hover(panel);
-        const descriptionButton = _react.screen.queryByRole('button', {
-            name: /description/i
-        });
-        expect(descriptionButton).not.toBeInTheDocument();
-    });
-    it('does not show description in edit mode', ()=>{
-        renderPanel(undefined, {
-            onEditPanelClick: jest.fn(),
-            onDeletePanelClick: jest.fn(),
-            onDuplicatePanelClick: jest.fn()
-        });
-        const panel = getPanel();
-        _userEvent.default.hover(panel);
-        const descriptionButton = _react.screen.queryByRole('button', {
-            name: /description/i
-        });
-        expect(descriptionButton).not.toBeInTheDocument();
-    });
-    it('can trigger panel actions in edit mode', ()=>{
-        const onEditPanelClick = jest.fn();
-        const onDeletePanelClick = jest.fn();
-        const onDuplicatePanelClick = jest.fn();
-        renderPanel(undefined, {
-            onEditPanelClick,
-            onDeletePanelClick,
-            onDuplicatePanelClick
-        });
-        const panel = getPanel();
-        _userEvent.default.hover(panel);
-        const editButton = _react.screen.getByRole('button', {
-            name: /edit/i
-        });
-        _userEvent.default.click(editButton);
-        const deleteButton = _react.screen.getByRole('button', {
-            name: /delete/i
-        });
-        _userEvent.default.click(deleteButton);
-        const duplicateButton = _react.screen.getByRole('button', {
-            name: /duplicate/i
-        });
-        _userEvent.default.click(duplicateButton);
-        expect(onEditPanelClick).toHaveBeenCalledTimes(1);
-        expect(onDeletePanelClick).toHaveBeenCalledTimes(1);
-        expect(onDuplicatePanelClick).toHaveBeenCalledTimes(1);
-    });
-});

package/dist/cjs/components/PanelDrawer/PanelDrawer.test.js

@@ -1,131 +0,0 @@
-// Copyright 2023 The Perses Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-"use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
-const _jsxRuntime = require("react/jsx-runtime");
-const _react = require("@testing-library/react");
-const _userEvent = /*#__PURE__*/ _interopRequireDefault(require("@testing-library/user-event"));
-const _testUtils = require("react-dom/test-utils");
-const _test = require("../../test");
-const _dashboardProvider = require("../../context/DashboardProvider");
-const _panelDrawer = require("./PanelDrawer");
-function _interopRequireDefault(obj) {
-    return obj && obj.__esModule ? obj : {
-        default: obj
-    };
-}
-describe('Panel Drawer', ()=>{
-    const renderPanelDrawer = ()=>{
-        const { store , DashboardProviderSpy  } = (0, _test.createDashboardProviderSpy)();
-        (0, _test.renderWithContext)(/*#__PURE__*/ (0, _jsxRuntime.jsxs)(_dashboardProvider.DashboardProvider, {
-            initialState: {
-                dashboardResource: (0, _test.getTestDashboard)(),
-                isEditMode: true
-            },
-            children: [
-                /*#__PURE__*/ (0, _jsxRuntime.jsx)(DashboardProviderSpy, {}),
-                /*#__PURE__*/ (0, _jsxRuntime.jsx)(_panelDrawer.PanelDrawer, {})
-            ]
-        }));
-        const { value: storeApi  } = store;
-        if (storeApi === undefined) {
-            throw new Error('Expected dashboard store to be set after initial render');
-        }
-        return storeApi;
-    };
-    it('should add new panel', async ()=>{
-        const storeApi = renderPanelDrawer();
-        // Open the drawer for a new panel
-        (0, _testUtils.act)(()=>storeApi.getState().openAddPanel());
-        const nameInput = await _react.screen.findByLabelText(/Name/);
-        _userEvent.default.type(nameInput, 'New Panel');
-        _userEvent.default.click(_react.screen.getByText('Add'));
-        // TODO: Assert drawer is closed?
-        const panels = storeApi.getState().panels;
-        expect(panels).toMatchObject({
-            // Should have the new panel in the store
-            NewPanel: {
-                kind: 'Panel',
-                spec: {
-                    display: {
-                        name: 'New Panel'
-                    },
-                    plugin: {
-                        kind: '',
-                        spec: {}
-                    }
-                }
-            }
-        });
-    });
-    it('should add panel with duplicate panel name', async ()=>{
-        const storeApi = renderPanelDrawer();
-        (0, _testUtils.act)(()=>storeApi.getState().openAddPanel());
-        const nameInput = await _react.screen.findByLabelText(/Name/);
-        _userEvent.default.type(nameInput, 'cpu');
-        _userEvent.default.click(_react.screen.getByText('Add'));
-        const panels = storeApi.getState().panels;
-        expect(panels).toMatchObject({
-            // make sure we don't have duplicate panel key by appending "-1"
-            'cpu-1': {
-                kind: 'Panel',
-                spec: {
-                    display: {
-                        name: 'cpu'
-                    },
-                    plugin: {
-                        kind: '',
-                        spec: {}
-                    }
-                }
-            }
-        });
-    });
-    it('should edit an existing panel', async ()=>{
-        const storeApi = renderPanelDrawer();
-        // Open the drawer for an existing panel
-        const group = Object.values(storeApi.getState().panelGroups).find((group)=>group.title === 'CPU Stats');
-        if (group === undefined) {
-            throw new Error('Test group not found');
-        }
-        const layout = Object.entries(group.itemPanelKeys).find(([, panelKey])=>panelKey === 'cpu');
-        if (layout === undefined) {
-            throw new Error('Test panel not found');
-        }
-        (0, _testUtils.act)(()=>storeApi.getState().openEditPanel({
-                panelGroupId: group.id,
-                panelGroupItemLayoutId: layout[0]
-            }));
-        const nameInput = await _react.screen.findByLabelText(/Name/);
-        _userEvent.default.clear(nameInput);
-        _userEvent.default.type(nameInput, 'cpu usage');
-        _userEvent.default.click(_react.screen.getByText('Apply'));
-        const panels = storeApi.getState().panels;
-        expect(panels).toMatchObject({
-            cpu: {
-                kind: 'Panel',
-                spec: {
-                    display: {
-                        name: 'cpu usage'
-                    },
-                    plugin: {
-                        kind: 'TimeSeriesChart',
-                        spec: {}
-                    }
-                }
-            }
-        });
-    });
-});

package/dist/cjs/components/PanelGroupDialog/PanelGroupDialog.test.js

@@ -1,87 +0,0 @@
-// Copyright 2023 The Perses Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-"use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
-const _jsxRuntime = require("react/jsx-runtime");
-const _react = require("@testing-library/react");
-const _userEvent = /*#__PURE__*/ _interopRequireDefault(require("@testing-library/user-event"));
-const _testUtils = require("react-dom/test-utils");
-const _context = require("../../context");
-const _test = require("../../test");
-const _panelGroupDialog = require("./PanelGroupDialog");
-function _interopRequireDefault(obj) {
-    return obj && obj.__esModule ? obj : {
-        default: obj
-    };
-}
-describe('Add Panel Group', ()=>{
-    const renderDialog = ()=>{
-        const { store , DashboardProviderSpy  } = (0, _test.createDashboardProviderSpy)();
-        (0, _test.renderWithContext)(/*#__PURE__*/ (0, _jsxRuntime.jsxs)(_context.DashboardProvider, {
-            initialState: {
-                dashboardResource: (0, _test.getTestDashboard)(),
-                isEditMode: true
-            },
-            children: [
-                /*#__PURE__*/ (0, _jsxRuntime.jsx)(DashboardProviderSpy, {}),
-                /*#__PURE__*/ (0, _jsxRuntime.jsx)(_panelGroupDialog.PanelGroupDialog, {})
-            ]
-        }));
-        const { value: storeApi  } = store;
-        if (storeApi === undefined) {
-            throw new Error('Expected dashboard store to be set after initial render');
-        }
-        return storeApi;
-    };
-    it('should add new panel group', async ()=>{
-        const storeApi = renderDialog();
-        // Open the dialog for a new panel group
-        (0, _testUtils.act)(()=>storeApi.getState().openAddPanelGroup());
-        const nameInput = await _react.screen.findByLabelText(/Name/);
-        _userEvent.default.type(nameInput, 'New Panel Group');
-        _userEvent.default.click(_react.screen.getByText('Add'));
-        // TODO: Figure out how to test this without coupling to the store state
-        const panelGroups = Object.values(storeApi.getState().panelGroups);
-        expect(panelGroups).toContainEqual({
-            id: expect.any(Number),
-            title: 'New Panel Group',
-            isCollapsed: false,
-            itemLayouts: expect.any(Array),
-            itemPanelKeys: expect.any(Object)
-        });
-    });
-    it('should edit existing panel group', async ()=>{
-        const storeApi = renderDialog();
-        // Open the dialog for an existing panel group
-        const group = Object.values(storeApi.getState().panelGroups).find((group)=>group.title === 'CPU Stats');
-        if (group === undefined) {
-            throw new Error('Missing test group');
-        }
-        (0, _testUtils.act)(()=>storeApi.getState().openEditPanelGroup(group.id));
-        const nameInput = await _react.screen.findByLabelText(/Name/);
-        _userEvent.default.clear(nameInput);
-        _userEvent.default.type(nameInput, 'New Name');
-        _userEvent.default.click(_react.screen.getByText('Apply'));
-        // TODO: Figure out how to test this without coupling to the store state
-        const panelGroups = storeApi.getState().panelGroups;
-        expect(panelGroups).toMatchObject({
-            [group.id]: {
-                id: group.id,
-                title: 'New Name',
-                isCollapsed: false
-            }
-        });
-    });
-});

package/dist/cjs/components/TimeRangeControls/TimeRangeControls.test.js

@@ -1,95 +0,0 @@
-// Copyright 2023 The Perses Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-"use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
-const _jsxRuntime = require("react/jsx-runtime");
-const _reactRouter = require("react-router");
-const _history = require("history");
-const _userEvent = /*#__PURE__*/ _interopRequireDefault(require("@testing-library/user-event"));
-const _react = require("@testing-library/react");
-const _pluginSystem = require("@perses-dev/plugin-system");
-const _test = require("../../test");
-const _testDashboard = /*#__PURE__*/ _interopRequireDefault(require("../../test/testDashboard"));
-const _context = require("../../context");
-const _timeRangeControls = require("./TimeRangeControls");
-function _interopRequireDefault(obj) {
-    return obj && obj.__esModule ? obj : {
-        default: obj
-    };
-}
-const history = (0, _history.createMemoryHistory)({
-    initialEntries: [
-        (0, _reactRouter.generatePath)('/home'),
-        (0, _reactRouter.generatePath)('/dashboards/:id', {
-            id: 'test'
-        })
-    ]
-});
-describe('TimeRangeControls', ()=>{
-    let initialState;
-    const testDefaultTimeRange = {
-        pastDuration: _testDashboard.default.spec.duration
-    };
-    beforeEach(()=>{
-        initialState = {
-            dashboardResource: _testDashboard.default
-        };
-    });
-    const renderTimeRangeControls = (testURLParams)=>{
-        (0, _test.renderWithContext)(/*#__PURE__*/ (0, _jsxRuntime.jsx)(_context.DashboardProvider, {
-            initialState: initialState,
-            children: /*#__PURE__*/ (0, _jsxRuntime.jsx)(_pluginSystem.TimeRangeProvider, {
-                initialTimeRange: testDefaultTimeRange,
-                enabledURLParams: testURLParams,
-                children: /*#__PURE__*/ (0, _jsxRuntime.jsx)(_timeRangeControls.TimeRangeControls, {})
-            })
-        }), undefined, history);
-    };
-    it('should default to dashboard duration and update selected time option when clicked', async ()=>{
-        renderTimeRangeControls(false);
-        expect(_react.screen.getByText('Last 30 minutes')).toBeInTheDocument();
-        const dateButton = _react.screen.getByRole('button', {
-            name: /time range/i
-        });
-        _userEvent.default.click(dateButton);
-        const firstSelected = _react.screen.getByRole('option', {
-            name: 'Last 5 minutes'
-        });
-        _userEvent.default.click(firstSelected);
-        expect(dateButton).toHaveTextContent(/5 minutes/i);
-    });
-    it('should update URL params with correct time range values', ()=>{
-        renderTimeRangeControls(true);
-        const dateButton = _react.screen.getByRole('button', {
-            name: /time range/i
-        });
-        _userEvent.default.click(dateButton);
-        const firstSelected = _react.screen.getByRole('option', {
-            name: 'Last 5 minutes'
-        });
-        _userEvent.default.click(firstSelected);
-        expect(history.location.search).toEqual('?start=5m');
-        // pick another option from TimeRangeSelector dropdown
-        const secondSelected = _react.screen.getByText('Last 12 hours');
-        _userEvent.default.click(secondSelected);
-        expect(history.location.search).toEqual('?start=12h');
-        // back button should return to previous page selected
-        (0, _react.act)(()=>{
-            history.back();
-        });
-        expect(history.location.pathname).toEqual('/home');
-    });
-// TODO: add additional tests for absolute time selection, other inputs, form validation, etc.
-});

package/dist/cjs/components/Variables/variable-model.test.js

@@ -1,106 +0,0 @@
-// Copyright 2023 The Perses Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-"use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
-const _variableModel = require("./variable-model");
-describe('filterVariableList', ()=>{
-    const testSuite = [
-        {
-            title: 'basic case',
-            capturing_regexp: /([^-]*)-host-([^-]*)/g,
-            originalValues: [
-                {
-                    label: 'l1',
-                    value: 'us1-host-ahdix'
-                },
-                {
-                    label: 'l2',
-                    value: 'us1-host-diua'
-                },
-                {
-                    label: 'l3',
-                    value: 'eu1-host-adf'
-                },
-                {
-                    label: 'l4',
-                    value: 'bar'
-                }
-            ],
-            result: [
-                {
-                    label: 'l1',
-                    value: 'us1ahdix'
-                },
-                {
-                    label: 'l2',
-                    value: 'us1diua'
-                },
-                {
-                    label: 'l3',
-                    value: 'eu1adf'
-                }
-            ]
-        },
-        {
-            title: 'duplicate captured value',
-            capturing_regexp: /prometheus-(.+):\d+/g,
-            originalValues: [
-                {
-                    label: 'l1',
-                    value: 'prometheus-app:9090'
-                },
-                {
-                    label: 'l2',
-                    value: 'prometheus-app:9091'
-                },
-                {
-                    label: 'l3',
-                    value: 'prometheus-platform:9091'
-                },
-                {
-                    label: 'l4',
-                    value: 'prometheus-database:9091'
-                },
-                {
-                    label: 'l5',
-                    value: 'prometheus-perses:9091'
-                }
-            ],
-            result: [
-                {
-                    label: 'l1',
-                    value: 'app'
-                },
-                {
-                    label: 'l3',
-                    value: 'platform'
-                },
-                {
-                    label: 'l4',
-                    value: 'database'
-                },
-                {
-                    label: 'l5',
-                    value: 'perses'
-                }
-            ]
-        }
-    ];
-    testSuite.forEach(({ title , capturing_regexp , originalValues , result  })=>{
-        it(title, ()=>{
-            expect((0, _variableModel.filterVariableList)(originalValues, capturing_regexp)).toEqual(result);
-        });
-    });
-});

package/dist/cjs/context/TemplateVariableProvider/query-params.test.js

@@ -1,82 +0,0 @@
-// Copyright 2023 The Perses Authors
-// Licensed under the Apache License, Version 2.0 (the "License");
-// you may not use this file except in compliance with the License.
-// You may obtain a copy of the License at
-//
-// http://www.apache.org/licenses/LICENSE-2.0
-//
-// Unless required by applicable law or agreed to in writing, software
-// distributed under the License is distributed on an "AS IS" BASIS,
-// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
-// See the License for the specific language governing permissions and
-// limitations under the License.
-"use strict";
-Object.defineProperty(exports, "__esModule", {
-    value: true
-});
-const _queryParams = require("./query-params");
-describe('getInitalValuesFromQueryParameters', ()=>{
-    test('base case', ()=>{
-        expect((0, _queryParams.getInitalValuesFromQueryParameters)({
-            'var-foo': 'bar',
-            'var-baz': [
-                'qux',
-                'quux'
-            ]
-        })).toEqual({
-            foo: 'bar',
-            baz: [
-                'qux',
-                'quux'
-            ]
-        });
-    });
-});
-describe('encodeVariableValue', ()=>{
-    const testCases = [
-        {
-            input: 'foo',
-            expected: 'foo'
-        },
-        {
-            input: [
-                'foo',
-                'bar'
-            ],
-            expected: 'foo,bar'
-        },
-        {
-            input: '$__all',
-            expected: '$__all'
-        }
-    ];
-    testCases.forEach(({ input , expected  })=>{
-        test(`encodes ${input} as ${expected}`, ()=>{
-            expect((0, _queryParams.encodeVariableValue)(input)).toEqual(expected);
-        });
-    });
-});
-describe('decodeVariableValue', ()=>{
-    const testCases = [
-        {
-            input: 'foo',
-            expected: 'foo'
-        },
-        {
-            input: 'foo,bar',
-            expected: [
-                'foo',
-                'bar'
-            ]
-        },
-        {
-            input: '$__all',
-            expected: '$__all'
-        }
-    ];
-    testCases.forEach(({ input , expected  })=>{
-        test(`encodes ${input} as ${expected}`, ()=>{
-            expect((0, _queryParams.decodeVariableValue)(input)).toEqual(expected);
-        });
-    });
-});