@periskope/baileys 7.0.0-alpha-5 → 7.0.0-beta-2

package/lib/Socket/messages-send.js

@@ -2,26 +2,21 @@ import NodeCache from '@cacheable/node-cache';
 import { Boom } from '@hapi/boom';
 import { proto } from '../../WAProto/index.js';
 import { DEFAULT_CACHE_TTLS, WA_DEFAULT_EPHEMERAL } from '../Defaults/index.js';
-import { WAMessageAddressingMode } from '../Types/index.js';
-import { aggregateMessageKeysNotFromMe, assertMediaContent, bindWaitForEvent, decryptMediaRetryData, encodeNewsletterMessage, encodeSignedDeviceIdentity, encodeWAMessage, encryptMediaRetryRequest, extractDeviceJids, generateMessageIDV2, generateParticipantHashV2, generateWAMessage, getStatusCodeForMediaRetry, getUrlFromDirectPath, getWAUploadToServer, MessageRetryManager, normalizeMessageContent, parseAndInjectE2ESessions, unixTimestampSeconds } from '../Utils/index.js';
+import { aggregateMessageKeysNotFromMe, assertMediaContent, bindWaitForEvent, decryptMediaRetryData, encodeNewsletterMessage, encodeSignedDeviceIdentity, encodeWAMessage, encryptMediaRetryRequest, extractDeviceJids, generateMessageIDV2, generateWAMessage, getStatusCodeForMediaRetry, getUrlFromDirectPath, getWAUploadToServer, normalizeMessageContent, parseAndInjectE2ESessions, unixTimestampSeconds } from '../Utils/index.js';
 import { getUrlInfo } from '../Utils/link-preview.js';
-import { makeKeyedMutex } from '../Utils/make-mutex.js';
-import { areJidsSameUser, getBinaryNodeChild, getBinaryNodeChildren, isJidGroup, isPnUser, jidDecode, jidEncode, jidNormalizedUser, S_WHATSAPP_NET } from '../WABinary/index.js';
+import { areJidsSameUser, getBinaryNodeChild, getBinaryNodeChildren, isJidGroup, isJidUser, jidDecode, jidEncode, jidNormalizedUser, S_WHATSAPP_NET } from '../WABinary/index.js';
 import { USyncQuery, USyncUser } from '../WAUSync/index.js';
+import { makeGroupsSocket } from './groups.js';
 import { makeNewsletterSocket } from './newsletter.js';
 export const makeMessagesSocket = (config) => {
-    const { logger, linkPreviewImageThumbnailWidth, generateHighQualityLinkPreview, options: axiosOptions, patchMessageBeforeSending, cachedGroupMetadata, enableRecentMessageCache, maxMsgRetryCount } = config;
-    const sock = makeNewsletterSocket(config);
+    const { logger, linkPreviewImageThumbnailWidth, generateHighQualityLinkPreview, options: axiosOptions, patchMessageBeforeSending, cachedGroupMetadata } = config;
+    const sock = makeNewsletterSocket(makeGroupsSocket(config));
     const { ev, authState, processingMutex, signalRepository, upsertMessage, query, fetchPrivacySettings, sendNode, groupMetadata, groupToggleEphemeral } = sock;
     const userDevicesCache = config.userDevicesCache ||
         new NodeCache({
             stdTTL: DEFAULT_CACHE_TTLS.USER_DEVICES, // 5 minutes
             useClones: false
         });
-    // Initialize message retry manager if enabled
-    const messageRetryManager = enableRecentMessageCache ? new MessageRetryManager(logger, maxMsgRetryCount) : null;
-    // Prevent race conditions in Signal session encryption by user
-    const encryptionMutex = makeKeyedMutex();
     let mediaConn;
     const refreshMediaConn = async (forceGet = false) => {
         const media = await mediaConn;
@@ -70,7 +65,7 @@ export const makeMessagesSocket = (config) => {
         if (isReadReceipt) {
             node.attrs.t = unixTimestampSeconds().toString();
         }
-        if (type === 'sender' && isPnUser(jid)) {
+        if (type === 'sender' && isJidUser(jid)) {
             node.attrs.recipient = jid;
             node.attrs.to = participant;
         }
@@ -113,34 +108,6 @@ export const makeMessagesSocket = (config) => {
         const readType = privacySettings.readreceipts === 'all' ? 'read' : 'read-self';
         await sendReceipts(keys, readType);
     };
-    /**
-     * Deduplicate JIDs when both LID and PN versions exist for same user
-     * Prefers LID over PN to maintain single encryption layer
-     */
-    const deduplicateLidPnJids = (jids) => {
-        const lidUsers = new Set();
-        const filteredJids = [];
-        // Collect all LID users
-        for (const jid of jids) {
-            if (jid.includes('@lid')) {
-                const user = jidDecode(jid)?.user;
-                if (user)
-                    lidUsers.add(user);
-            }
-        }
-        // Filter out PN versions when LID exists
-        for (const jid of jids) {
-            if (jid.includes('@s.whatsapp.net')) {
-                const user = jidDecode(jid)?.user;
-                if (user && lidUsers.has(user)) {
-                    logger.debug({ jid }, 'Skipping PN - LID version exists');
-                    continue;
-                }
-            }
-            filteredJids.push(jid);
-        }
-        return filteredJids;
-    };
     /** Fetch all the devices we've to send a message to */
     const getUSyncDevices = async (jids, useCache, ignoreZeroDevices) => {
         const deviceResults = [];
@@ -148,41 +115,14 @@ export const makeMessagesSocket = (config) => {
             logger.debug('not using cache for devices');
         }
         const toFetch = [];
-        jids = deduplicateLidPnJids(Array.from(new Set(jids)));
-        const jidsWithUser = jids
-            .map(jid => {
-            const decoded = jidDecode(jid);
-            const user = decoded?.user;
-            const device = decoded?.device;
-            const isExplicitDevice = typeof device === 'number' && device >= 0;
-            if (isExplicitDevice && user) {
-                deviceResults.push({
-                    user,
-                    device,
-                    wireJid: jid // again this makes no sense
-                });
-                return null;
-            }
+        jids = Array.from(new Set(jids));
+        for (let jid of jids) {
+            const user = jidDecode(jid)?.user;
             jid = jidNormalizedUser(jid);
-            return { jid, user };
-        })
-            .filter(jid => jid !== null);
-        let mgetDevices;
-        if (useCache && userDevicesCache.mget) {
-            const usersToFetch = jidsWithUser.map(j => j?.user).filter(Boolean);
-            mgetDevices = await userDevicesCache.mget(usersToFetch);
-        }
-        for (const { jid, user } of jidsWithUser) {
             if (useCache) {
-                const devices = mgetDevices?.[user] ||
-                    (userDevicesCache.mget ? undefined : (await userDevicesCache.get(user)));
+                const devices = userDevicesCache.get(user);
                 if (devices) {
-                    const isLidJid = jid.includes('@lid');
-                    const devicesWithWire = devices.map(d => ({
-                        ...d,
-                        wireJid: isLidJid ? jidEncode(d.user, 'lid', d.device) : jidEncode(d.user, 's.whatsapp.net', d.device)
-                    }));
-                    deviceResults.push(...devicesWithWire);
+                    deviceResults.push(...devices);
                     logger.trace({ user }, 'using cache for devices');
                 }
                 else {
@@ -196,17 +136,9 @@ export const makeMessagesSocket = (config) => {
         if (!toFetch.length) {
             return deviceResults;
         }
-        const requestedLidUsers = new Set();
-        for (const jid of toFetch) {
-            if (jid.includes('@lid')) {
-                const user = jidDecode(jid)?.user;
-                if (user)
-                    requestedLidUsers.add(user);
-            }
-        }
         const query = new USyncQuery().withContext('message').withDeviceProtocol();
         for (const jid of toFetch) {
-            query.withUser(new USyncUser().withId(jid)); // todo: investigate - the idea here is that <user> should have an inline lid field with the lid being the pn equivalent
+            query.withUser(new USyncUser().withId(jid));
         }
         const result = await sock.executeUSyncQuery(query);
         if (result) {
@@ -215,170 +147,32 @@ export const makeMessagesSocket = (config) => {
             for (const item of extracted) {
                 deviceMap[item.user] = deviceMap[item.user] || [];
                 deviceMap[item.user]?.push(item);
+                deviceResults.push(item);
             }
-            // Process each user's devices as a group for bulk LID migration
-            for (const [user, userDevices] of Object.entries(deviceMap)) {
-                const isLidUser = requestedLidUsers.has(user);
-                // Process all devices for this user
-                for (const item of userDevices) {
-                    const finalWireJid = isLidUser
-                        ? jidEncode(user, 'lid', item.device)
-                        : jidEncode(item.user, 's.whatsapp.net', item.device);
-                    deviceResults.push({
-                        ...item,
-                        wireJid: finalWireJid
-                    });
-                    logger.debug({
-                        user: item.user,
-                        device: item.device,
-                        finalWireJid,
-                        usedLid: isLidUser
-                    }, 'Processed device with LID priority');
-                }
-            }
-            if (userDevicesCache.mset) {
-                // if the cache supports mset, we can set all devices in one go
-                await userDevicesCache.mset(Object.entries(deviceMap).map(([key, value]) => ({ key, value })));
-            }
-            else {
-                for (const key in deviceMap) {
-                    if (deviceMap[key])
-                        await userDevicesCache.set(key, deviceMap[key]);
-                }
+            for (const key in deviceMap) {
+                userDevicesCache.set(key, deviceMap[key]);
             }
         }
         return deviceResults;
     };
     const assertSessions = async (jids, force) => {
         let didFetchNewSession = false;
-        const jidsRequiringFetch = [];
-        // Apply same deduplication as in getUSyncDevices
-        jids = deduplicateLidPnJids(jids);
+        let jidsRequiringFetch = [];
         if (force) {
-            // Check which sessions are missing (with LID migration check)
-            const addrs = jids.map(jid => signalRepository.jidToSignalProtocolAddress(jid));
-            const sessions = await authState.keys.get('session', addrs);
-            // Simplified: Check session existence directly
-            const checkJidSession = (jid) => {
-                const signalId = signalRepository.jidToSignalProtocolAddress(jid);
-                const hasSession = !!sessions[signalId];
-                // Add to fetch list if no session exists
-                // Session type selection (LID vs PN) is handled in encryptMessage
-                if (!hasSession) {
-                    if (jid.includes('@lid')) {
-                        logger.debug({ jid }, 'No LID session found, will create new LID session');
-                    }
-                    jidsRequiringFetch.push(jid);
-                }
-            };
-            // Process all JIDs
-            for (const jid of jids) {
-                checkJidSession(jid);
-            }
+            jidsRequiringFetch = jids;
         }
         else {
             const addrs = jids.map(jid => signalRepository.jidToSignalProtocolAddress(jid));
             const sessions = await authState.keys.get('session', addrs);
-            // Group JIDs by user for bulk migration
-            const userGroups = new Map();
             for (const jid of jids) {
-                const user = jidNormalizedUser(jid);
-                if (!userGroups.has(user)) {
-                    userGroups.set(user, []);
-                }
-                userGroups.get(user).push(jid);
-            }
-            // Helper to check LID mapping for a user
-            const checkUserLidMapping = async (user, userJids) => {
-                if (!userJids.some(jid => jid.includes('@s.whatsapp.net'))) {
-                    return { shouldMigrate: false, lidForPN: undefined };
-                }
-                try {
-                    // Convert user to proper PN JID format for getLIDForPN
-                    const pnJid = `${user}@s.whatsapp.net`;
-                    const mapping = await signalRepository.lidMapping.getLIDForPN(pnJid);
-                    if (mapping?.includes('@lid')) {
-                        logger.debug({ user, lidForPN: mapping, deviceCount: userJids.length }, 'User has LID mapping - preparing bulk migration');
-                        return { shouldMigrate: true, lidForPN: mapping };
-                    }
-                }
-                catch (error) {
-                    logger.debug({ user, error }, 'Failed to check LID mapping for user');
-                }
-                return { shouldMigrate: false, lidForPN: undefined };
-            };
-            // Process each user group for potential bulk LID migration
-            for (const [user, userJids] of userGroups) {
-                const mappingResult = await checkUserLidMapping(user, userJids);
-                const shouldMigrateUser = mappingResult.shouldMigrate;
-                const lidForPN = mappingResult.lidForPN;
-                // Migrate all devices for this user if LID mapping exists
-                if (shouldMigrateUser && lidForPN) {
-                    // Bulk migrate all user devices in single transaction
-                    const migrationResult = await signalRepository.migrateSession(userJids, lidForPN);
-                    if (migrationResult.migrated > 0) {
-                        logger.info({
-                            user,
-                            lidMapping: lidForPN,
-                            migrated: migrationResult.migrated,
-                            skipped: migrationResult.skipped,
-                            total: migrationResult.total
-                        }, 'Completed bulk migration for user devices');
-                    }
-                    else {
-                        logger.debug({
-                            user,
-                            lidMapping: lidForPN,
-                            skipped: migrationResult.skipped,
-                            total: migrationResult.total
-                        }, 'All user device sessions already migrated');
-                    }
+                const signalId = signalRepository.jidToSignalProtocolAddress(jid);
+                if (!sessions[signalId]) {
+                    jidsRequiringFetch.push(jid);
                 }
-                // Direct bulk session check with LID single source of truth
-                const addMissingSessionsToFetchList = (jid) => {
-                    const signalId = signalRepository.jidToSignalProtocolAddress(jid);
-                    if (sessions[signalId])
-                        return;
-                    // Determine correct JID to fetch (LID if mapping exists, otherwise original)
-                    if (jid.includes('@s.whatsapp.net') && shouldMigrateUser && lidForPN) {
-                        const decoded = jidDecode(jid);
-                        const lidDeviceJid = decoded.device !== undefined ? `${jidDecode(lidForPN).user}:${decoded.device}@lid` : lidForPN;
-                        jidsRequiringFetch.push(lidDeviceJid);
-                        logger.debug({ pnJid: jid, lidJid: lidDeviceJid }, 'Adding LID JID to fetch list (conversion)');
-                    }
-                    else {
-                        jidsRequiringFetch.push(jid);
-                        logger.debug({ jid }, 'Adding JID to fetch list');
-                    }
-                };
-                userJids.forEach(addMissingSessionsToFetchList);
             }
         }
         if (jidsRequiringFetch.length) {
             logger.debug({ jidsRequiringFetch }, 'fetching sessions');
-            // DEBUG: Check if there are PN versions of LID users being fetched
-            const lidUsersBeingFetched = new Set();
-            const pnUsersBeingFetched = new Set();
-            for (const jid of jidsRequiringFetch) {
-                const user = jidDecode(jid)?.user;
-                if (user) {
-                    if (jid.includes('@lid')) {
-                        lidUsersBeingFetched.add(user);
-                    }
-                    else if (jid.includes('@s.whatsapp.net')) {
-                        pnUsersBeingFetched.add(user);
-                    }
-                }
-            }
-            // Find overlaps
-            const overlapping = Array.from(pnUsersBeingFetched).filter(user => lidUsersBeingFetched.has(user));
-            if (overlapping.length > 0) {
-                logger.warn({
-                    overlapping,
-                    lidUsersBeingFetched: Array.from(lidUsersBeingFetched),
-                    pnUsersBeingFetched: Array.from(pnUsersBeingFetched)
-                }, 'Fetching both LID and PN sessions for same users');
-            }
             const result = await query({
                 tag: 'iq',
                 attrs: {
@@ -422,133 +216,43 @@ export const makeMessagesSocket = (config) => {
         });
         return msgId;
     };
-    const createParticipantNodes = async (jids, message, extraAttrs, dsmMessage) => {
+    const createParticipantNodes = async (jids, message, extraAttrs) => {
         let patched = await patchMessageBeforeSending(message, jids);
         if (!Array.isArray(patched)) {
             patched = jids ? jids.map(jid => ({ recipientJid: jid, ...patched })) : [patched];
         }
         let shouldIncludeDeviceIdentity = false;
-        const meId = authState.creds.me.id;
-        const meLid = authState.creds.me?.lid;
-        const meLidUser = meLid ? jidDecode(meLid)?.user : null;
-        const devicesByUser = new Map();
-        for (const patchedMessageWithJid of patched) {
-            const { recipientJid: wireJid, ...patchedMessage } = patchedMessageWithJid;
-            if (!wireJid)
-                continue;
-            // Extract user from JID for grouping
-            const decoded = jidDecode(wireJid);
-            const user = decoded?.user;
-            if (!user)
-                continue;
-            if (!devicesByUser.has(user)) {
-                devicesByUser.set(user, []);
-            }
-            devicesByUser.get(user).push({ recipientJid: wireJid, patchedMessage });
-        }
-        // Process each user's devices sequentially, but different users in parallel
-        const userEncryptionPromises = Array.from(devicesByUser.entries()).map(([user, userDevices]) => encryptionMutex.mutex(user, async () => {
-            logger.debug({ user, deviceCount: userDevices.length }, 'Acquiring encryption lock for user devices');
-            const userNodes = [];
-            // Helper to get encryption JID with LID migration
-            const getEncryptionJid = async (wireJid) => {
-                if (!wireJid.includes('@s.whatsapp.net'))
-                    return wireJid;
-                try {
-                    const lidForPN = await signalRepository.lidMapping.getLIDForPN(wireJid);
-                    if (!lidForPN?.includes('@lid'))
-                        return wireJid;
-                    // Preserve device ID from original wire JID
-                    const wireDecoded = jidDecode(wireJid);
-                    const deviceId = wireDecoded?.device || 0;
-                    const lidDecoded = jidDecode(lidForPN);
-                    const lidWithDevice = jidEncode(lidDecoded?.user, 'lid', deviceId);
-                    // Migrate session to LID for unified encryption layer
-                    try {
-                        const migrationResult = await signalRepository.migrateSession([wireJid], lidWithDevice);
-                        const recipientUser = jidNormalizedUser(wireJid);
-                        const ownPnUser = jidNormalizedUser(meId);
-                        const isOwnDevice = recipientUser === ownPnUser;
-                        logger.info({ wireJid, lidWithDevice, isOwnDevice }, 'Migrated to LID encryption');
-                        // Delete PN session after successful migration
-                        try {
-                            if (migrationResult.migrated) {
-                                await signalRepository.deleteSession([wireJid]);
-                                logger.debug({ deletedPNSession: wireJid }, 'Deleted PN session');
-                            }
-                        }
-                        catch (deleteError) {
-                            logger.warn({ wireJid, error: deleteError }, 'Failed to delete PN session');
-                        }
-                        return lidWithDevice;
-                    }
-                    catch (migrationError) {
-                        logger.warn({ wireJid, error: migrationError }, 'Failed to migrate session');
-                        return wireJid;
+        const nodes = await Promise.all(patched.map(async (patchedMessageWithJid) => {
+            const { recipientJid: jid, ...patchedMessage } = patchedMessageWithJid;
+            if (!jid) {
+                return {};
+            }
+            const bytes = encodeWAMessage(patchedMessage);
+            const { type, ciphertext } = await signalRepository.encryptMessage({ jid, data: bytes });
+            if (type === 'pkmsg') {
+                shouldIncludeDeviceIdentity = true;
+            }
+            const node = {
+                tag: 'to',
+                attrs: { jid },
+                content: [
+                    {
+                        tag: 'enc',
+                        attrs: {
+                            v: '2',
+                            type,
+                            ...(extraAttrs || {})
+                        },
+                        content: ciphertext
                     }
-                }
-                catch (error) {
-                    logger.debug({ wireJid, error }, 'Failed to check LID mapping');
-                    return wireJid;
-                }
+                ]
             };
-            // Encrypt to this user's devices sequentially to prevent session corruption
-            for (const { recipientJid: wireJid, patchedMessage } of userDevices) {
-                // DSM logic: Use DSM for own other devices (following whatsmeow implementation)
-                let messageToEncrypt = patchedMessage;
-                if (dsmMessage) {
-                    const { user: targetUser } = jidDecode(wireJid);
-                    const { user: ownPnUser } = jidDecode(meId);
-                    const ownLidUser = meLidUser;
-                    // Check if this is our device (same user, different device)
-                    const isOwnUser = targetUser === ownPnUser || (ownLidUser && targetUser === ownLidUser);
-                    // Exclude exact sender device (whatsmeow: if jid == ownJID || jid == ownLID { continue })
-                    const isExactSenderDevice = wireJid === meId || (authState.creds.me?.lid && wireJid === authState.creds.me.lid);
-                    if (isOwnUser && !isExactSenderDevice) {
-                        messageToEncrypt = dsmMessage;
-                        logger.debug({ wireJid, targetUser }, 'Using DSM for own device');
-                    }
-                }
-                const bytes = encodeWAMessage(messageToEncrypt);
-                // Get encryption JID with LID migration
-                const encryptionJid = await getEncryptionJid(wireJid);
-                // ENCRYPT: Use the determined encryption identity (prefers migrated LID)
-                const { type, ciphertext } = await signalRepository.encryptMessage({
-                    jid: encryptionJid, // Unified encryption layer (LID when available)
-                    data: bytes
-                });
-                if (type === 'pkmsg') {
-                    shouldIncludeDeviceIdentity = true;
-                }
-                const node = {
-                    tag: 'to',
-                    attrs: { jid: wireJid }, // Always use original wire identity in envelope
-                    content: [
-                        {
-                            tag: 'enc',
-                            attrs: {
-                                v: '2',
-                                type,
-                                ...(extraAttrs || {})
-                            },
-                            content: ciphertext
-                        }
-                    ]
-                };
-                userNodes.push(node);
-            }
-            logger.debug({ user, nodesCreated: userNodes.length }, 'Releasing encryption lock for user devices');
-            return userNodes;
+            return node;
         }));
-        // Wait for all users to complete (users are processed in parallel)
-        const userNodesArrays = await Promise.all(userEncryptionPromises);
-        const nodes = userNodesArrays.flat();
         return { nodes, shouldIncludeDeviceIdentity };
     };
     const relayMessage = async (jid, message, { messageId: msgId, participant, additionalAttributes, additionalNodes, useUserDevicesCache, useCachedGroupMetadata, statusJidList }) => {
         const meId = authState.creds.me.id;
-        const meLid = authState.creds.me?.lid;
-        // ADDRESSING CONSISTENCY: Keep envelope addressing as user provided, handle LID migration in encryption
         let shouldIncludeDeviceIdentity = false;
         const { user, server } = jidDecode(jid);
         const statusJid = 'status@broadcast';
@@ -556,23 +260,11 @@ export const makeMessagesSocket = (config) => {
         const isStatus = jid === statusJid;
         const isLid = server === 'lid';
         const isNewsletter = server === 'newsletter';
-        // Keep user's original JID choice for envelope addressing
-        const finalJid = jid;
-        // ADDRESSING CONSISTENCY: Match own identity to conversation context
-        // TODO: investigate if this is true
-        let ownId = meId;
-        if (isLid && meLid) {
-            ownId = meLid;
-            logger.debug({ to: jid, ownId }, 'Using LID identity for @lid conversation');
-        }
-        else {
-            logger.debug({ to: jid, ownId }, 'Using PN identity for @s.whatsapp.net conversation');
-        }
         msgId = msgId || generateMessageIDV2(sock.user?.id);
         useUserDevicesCache = useUserDevicesCache !== false;
         useCachedGroupMetadata = useCachedGroupMetadata !== false && !isStatus;
         const participants = [];
-        const destinationJid = !isStatus ? finalJid : statusJid;
+        const destinationJid = !isStatus ? jidEncode(user, isLid ? 'lid' : isGroup ? 'g.us' : 's.whatsapp.net') : statusJid;
         const binaryNodeContent = [];
         const devices = [];
         const meMsg = {
@@ -590,12 +282,8 @@ export const makeMessagesSocket = (config) => {
             if (!isGroup && !isStatus) {
                 additionalAttributes = { ...additionalAttributes, device_fanout: 'false' };
             }
-            const { user, device } = jidDecode(participant.jid); // rajeh: how does this even make sense TODO check out
-            devices.push({
-                user,
-                device,
-                wireJid: participant.jid // Use the participant JID as wire JID
-            });
+            const { user, device } = jidDecode(participant.jid);
+            devices.push({ user, device });
         }
         await authState.keys.transaction(async () => {
             const mediaType = getMediaType(message);
@@ -626,12 +314,12 @@ export const makeMessagesSocket = (config) => {
                 return;
             }
             if (normalizeMessageContent(message)?.pinInChatMessage) {
-                extraAttrs['decrypt-fail'] = 'hide'; // todo: expand for reactions and other types
+                extraAttrs['decrypt-fail'] = 'hide';
             }
             if (isGroup || isStatus) {
                 const [groupData, senderKeyMap] = await Promise.all([
                     (async () => {
-                        let groupData = useCachedGroupMetadata && cachedGroupMetadata ? await cachedGroupMetadata(jid) : undefined; // todo: should we rely on the cache specially if the cache is outdated and the metadata has new fields?
+                        let groupData = useCachedGroupMetadata && cachedGroupMetadata ? await cachedGroupMetadata(jid) : undefined;
                         if (groupData && Array.isArray(groupData?.participants)) {
                             logger.trace({ jid, participants: groupData.participants.length }, 'using cached group metadata');
                         }
@@ -642,7 +330,7 @@ export const makeMessagesSocket = (config) => {
                     })(),
                     (async () => {
                         if (!participant && !isStatus) {
-                            const result = await authState.keys.get('sender-key-memory', [jid]); // TODO: check out what if the sender key memory doesn't include the LID stuff now?
+                            const result = await authState.keys.get('sender-key-memory', [jid]);
                             return result[jid] || {};
                         }
                         return {};
@@ -654,10 +342,9 @@ export const makeMessagesSocket = (config) => {
                         participantsList.push(...statusJidList);
                     }
                     if (!isStatus) {
-                        const groupAddressingMode = groupData?.addressingMode || (isLid ? WAMessageAddressingMode.LID : WAMessageAddressingMode.PN);
                         additionalAttributes = {
                             ...additionalAttributes,
-                            addressing_mode: groupAddressingMode
+                            addressing_mode: groupData?.addressingMode || 'pn'
                         };
                     }
                     const additionalDevices = await getUSyncDevices(participantsList, !!useUserDevicesCache, false);
@@ -668,24 +355,19 @@ export const makeMessagesSocket = (config) => {
                     throw new Boom('Per-jid patching is not supported in groups');
                 }
                 const bytes = encodeWAMessage(patched);
-                // This should match the group's addressing mode and conversation context
-                const groupAddressingMode = groupData?.addressingMode || (isLid ? 'lid' : 'pn');
-                const groupSenderIdentity = groupAddressingMode === 'lid' && meLid ? meLid : meId;
                 const { ciphertext, senderKeyDistributionMessage } = await signalRepository.encryptGroupMessage({
                     group: destinationJid,
                     data: bytes,
-                    meId: groupSenderIdentity
+                    meId
                 });
                 const senderKeyJids = [];
                 // ensure a connection is established with every device
-                for (const device of devices) {
-                    // This preserves the LID migration results from getUSyncDevices
-                    const deviceJid = device.wireJid;
-                    const hasKey = !!senderKeyMap[deviceJid];
-                    if (!hasKey || !!participant) {
-                        senderKeyJids.push(deviceJid);
+                for (const { user, device } of devices) {
+                    const jid = jidEncode(user, groupData?.addressingMode === 'lid' ? 'lid' : 's.whatsapp.net', device);
+                    if (!senderKeyMap[jid] || !!participant) {
+                        senderKeyJids.push(jid);
                         // store that this person has had the sender keys sent to them
-                        senderKeyMap[deviceJid] = true;
+                        senderKeyMap[jid] = true;
                     }
                 }
                 // if there are some participants with whom the session has not been established
@@ -711,54 +393,23 @@ export const makeMessagesSocket = (config) => {
                 await authState.keys.set({ 'sender-key-memory': { [jid]: senderKeyMap } });
             }
             else {
-                const { user: ownUser } = jidDecode(ownId);
+                const { user: meUser } = jidDecode(meId);
                 if (!participant) {
-                    const targetUserServer = isLid ? 'lid' : 's.whatsapp.net';
-                    devices.push({
-                        user,
-                        device: 0,
-                        wireJid: jidEncode(user, targetUserServer, 0)
-                    });
-                    // Own user matches conversation addressing mode
-                    if (user !== ownUser) {
-                        const ownUserServer = isLid ? 'lid' : 's.whatsapp.net';
-                        const ownUserForAddressing = isLid && meLid ? jidDecode(meLid).user : jidDecode(meId).user;
-                        devices.push({
-                            user: ownUserForAddressing,
-                            device: 0,
-                            wireJid: jidEncode(ownUserForAddressing, ownUserServer, 0)
-                        });
+                    devices.push({ user });
+                    if (user !== meUser) {
+                        devices.push({ user: meUser });
                     }
                     if (additionalAttributes?.['category'] !== 'peer') {
-                        // Clear placeholders and enumerate actual devices
-                        devices.length = 0;
-                        // Use conversation-appropriate sender identity
-                        const senderIdentity = isLid && meLid
-                            ? jidEncode(jidDecode(meLid)?.user, 'lid', undefined)
-                            : jidEncode(jidDecode(meId)?.user, 's.whatsapp.net', undefined);
-                        // Enumerate devices for sender and target with consistent addressing
-                        const sessionDevices = await getUSyncDevices([senderIdentity, jid], false, false);
-                        devices.push(...sessionDevices);
-                        logger.debug({
-                            deviceCount: devices.length,
-                            devices: devices.map(d => `${d.user}:${d.device}@${jidDecode(d.wireJid)?.server}`)
-                        }, 'Device enumeration complete with unified addressing');
+                        const additionalDevices = await getUSyncDevices([meId, jid], !!useUserDevicesCache, true);
+                        devices.push(...additionalDevices);
                     }
                 }
                 const allJids = [];
                 const meJids = [];
                 const otherJids = [];
-                const { user: mePnUser } = jidDecode(meId);
-                const { user: meLidUser } = meLid ? jidDecode(meLid) : { user: null };
-                for (const { user, wireJid } of devices) {
-                    const isExactSenderDevice = wireJid === meId || (meLid && wireJid === meLid);
-                    if (isExactSenderDevice) {
-                        logger.debug({ wireJid, meId, meLid }, 'Skipping exact sender device (whatsmeow pattern)');
-                        continue;
-                    }
-                    // Check if this is our device (could match either PN or LID user)
-                    const isMe = user === mePnUser || (meLidUser && user === meLidUser);
-                    const jid = wireJid;
+                for (const { user, device } of devices) {
+                    const isMe = user === meUser;
+                    const jid = jidEncode(isMe && isLid ? authState.creds?.me?.lid.split(':')[0] || user : user, isLid ? 'lid' : 's.whatsapp.net', device);
                     if (isMe) {
                         meJids.push(jid);
                     }
@@ -767,17 +418,13 @@ export const makeMessagesSocket = (config) => {
                     }
                     allJids.push(jid);
                 }
-                await assertSessions([...otherJids, ...meJids], false);
+                await assertSessions(allJids, false);
                 const [{ nodes: meNodes, shouldIncludeDeviceIdentity: s1 }, { nodes: otherNodes, shouldIncludeDeviceIdentity: s2 }] = await Promise.all([
-                    // For own devices: use DSM if available (1:1 chats only)
-                    createParticipantNodes(meJids, meMsg || message, extraAttrs),
-                    createParticipantNodes(otherJids, message, extraAttrs, meMsg)
+                    createParticipantNodes(meJids, meMsg, extraAttrs),
+                    createParticipantNodes(otherJids, message, extraAttrs)
                 ]);
                 participants.push(...meNodes);
                 participants.push(...otherNodes);
-                if (meJids.length > 0 || otherJids.length > 0) {
-                    extraAttrs['phash'] = generateParticipantHashV2([...meJids, ...otherJids]);
-                }
                 shouldIncludeDeviceIdentity = shouldIncludeDeviceIdentity || s1 || s2;
             }
             if (participants.length) {
@@ -799,7 +446,6 @@ export const makeMessagesSocket = (config) => {
                 tag: 'message',
                 attrs: {
                     id: msgId,
-                    to: destinationJid,
                     type: getMessageType(message),
                     ...(additionalAttributes || {})
                 },
@@ -839,20 +485,13 @@ export const makeMessagesSocket = (config) => {
             }
             logger.debug({ msgId }, `sending message to ${participants.length} devices`);
             await sendNode(stanza);
-            // Add message to retry cache if enabled
-            if (messageRetryManager && !participant) {
-                messageRetryManager.addRecentMessage(destinationJid, msgId, message);
-            }
-        }, meId);
+        });
         return msgId;
     };
     const getMessageType = (message) => {
         if (message.pollCreationMessage || message.pollCreationMessageV2 || message.pollCreationMessageV3) {
             return 'poll';
         }
-        if (message.eventMessage) {
-            return 'event';
-        }
         return 'text';
     };
     const getMediaType = (message) => {
@@ -944,7 +583,6 @@ export const makeMessagesSocket = (config) => {
         sendPeerDataOperationMessage,
         createParticipantNodes,
         getUSyncDevices,
-        messageRetryManager,
         updateMediaMessage: async (message) => {
             const content = assertMediaContent(message.message);
             const mediaKey = content.mediaKey;
@@ -1016,14 +654,12 @@ export const makeMessagesSocket = (config) => {
                     }),
                     //TODO: CACHE
                     getProfilePicUrl: sock.profilePictureUrl,
-                    getCallLink: sock.createCallLink,
                     upload: waUploadToServer,
                     mediaCache: config.mediaCache,
                     options: config.options,
                     messageId: generateMessageIDV2(sock.user?.id),
                     ...options
                 });
-                const isEventMsg = 'event' in content && !!content.event;
                 const isDeleteMsg = 'delete' in content && !!content.delete;
                 const isEditMsg = 'edit' in content && !!content.edit;
                 const isPinMsg = 'pin' in content && !!content.pin;
@@ -1054,14 +690,6 @@ export const makeMessagesSocket = (config) => {
                         }
                     });
                 }
-                else if (isEventMsg) {
-                    additionalNodes.push({
-                        tag: 'meta',
-                        attrs: {
-                            event_type: 'creation'
-                        }
-                    });
-                }
                 if ('cachedGroupMetadata' in options) {
                     console.warn('cachedGroupMetadata in sendMessage are deprecated, now cachedGroupMetadata is part of the socket config.');
                 }