@perfective/eslint-config 0.17.0-beta → 0.18.0-beta

package/README.adoc

@@ -7,7 +7,7 @@ As the `@perfective` library itself,
 these rules are configured for the TypeScript projects only.
 
 In addition to the core https://eslint.org/docs/rules/[ESLint rules]
-and the `link:https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin[@typescript-eslint]` plugin rules,
+and the `link:https://typescript-eslint.io/rules/[@typescript-eslint]` plugin rules,
 `@perfective/eslint-config` configures:
 
 * `link:https://github.com/freaktechnik/eslint-plugin-array-func[eslint-plugin-array-func]`;
@@ -131,7 +131,7 @@ and override `options` for the `unicorn/prevent-abbreviation` rule.
 ESLint and its plugins replace most of the https://palantir.github.io/tslint/[TSLint] rules.
 Yet, there are few rules that still need to be supported.
 TSLint rules are executed using the
-https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin-tslint[ESLint Plugin TSLint].
+https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin-tslint[ESLint Plugin TSLint].
 
 `eslint-plugin-tslint` provides only one rule `@typescript-eslint/tslint/config`
 that configures all the remaining TSLint rules,

package/README.md

@@ -7,7 +7,7 @@ As the `@perfective` library itself,
 these rules are configured for the TypeScript projects only.
 
 In addition to the core [ESLint rules](https://eslint.org/docs/rules/)
-and the [`@typescript-eslint`](https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin) plugin rules,
+and the [`@typescript-eslint`](https://typescript-eslint.io/rules/) plugin rules,
 `@perfective/eslint-config` configures:
 
 -   [`eslint-plugin-array-func`](https://github.com/freaktechnik/eslint-plugin-array-func);
@@ -79,7 +79,7 @@ Require the configuration in your root `.eslintrc.js` or `.eslintrc.json`.
 ESLint and its plugins replace most of the [TSLint](https://palantir.github.io/tslint/) rules.
 Yet, there are few rules that still need to be supported.
 TSLint rules are executed using the
-[ESLint Plugin TSLint](https://github.com/typescript-eslint/typescript-eslint/tree/master/packages/eslint-plugin-tslint).
+[ESLint Plugin TSLint](https://github.com/typescript-eslint/typescript-eslint/tree/main/packages/eslint-plugin-tslint).
 
 Read the [full documentation](https://github.com/perfective/eslint-config/blob/main/README.adoc)
 in the repository.

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "@perfective/eslint-config",
-    "version": "0.17.0-beta",
+    "version": "0.18.0-beta",
     "description": "ESLint shareable rules configuration",
     "keywords": ["code quality", "code standard", "code style", "eslint", "eslint-config", "lint", "perfective", "tslint", "tslint-config", "typescript"],
     "author": "Andrey Mikheychik <a.mikheychik@gmail.com>",
@@ -12,28 +12,28 @@
     "license": "MIT",
     "peerDependencies": {
         "@babel/eslint-parser": "^7.17.0",
-        "@typescript-eslint/eslint-plugin": "^5.12.0",
-        "@typescript-eslint/eslint-plugin-tslint": "^5.12.0",
-        "@typescript-eslint/parser": "^5.12.0",
-        "eslint": "^8.9.0",
-        "eslint-import-resolver-typescript": "^2.5.0",
+        "@typescript-eslint/eslint-plugin": "^5.30.5",
+        "@typescript-eslint/eslint-plugin-tslint": "^5.30.5",
+        "@typescript-eslint/parser": "^5.30.5",
+        "eslint": "^8.19.0",
+        "eslint-import-resolver-typescript": "^3.2.4",
         "eslint-plugin-array-func": "^3.1.7",
         "eslint-plugin-cypress": "^2.12.1",
         "eslint-plugin-deprecation": "^1.3.2",
         "eslint-plugin-eslint-comments": "^3.2.0",
-        "eslint-plugin-import": "^2.25.4",
-        "eslint-plugin-jest": "^26.1.1",
-        "eslint-plugin-jest-dom": "^4.0.1",
+        "eslint-plugin-import": "^2.26.0",
+        "eslint-plugin-jest": "^26.5.3",
+        "eslint-plugin-jest-dom": "^4.0.2",
         "eslint-plugin-jest-formatting": "^3.1.0",
-        "eslint-plugin-jsdoc": "^37.9.3",
+        "eslint-plugin-jsdoc": "^39.3.3",
         "eslint-plugin-node": "^11.1.0",
         "eslint-plugin-prefer-arrow": "^1.2.3",
         "eslint-plugin-promise": "^6.0.0",
         "eslint-plugin-rxjs": "^5.0.2",
         "eslint-plugin-simple-import-sort": "^7.0.0",
-        "eslint-plugin-sonarjs": "^0.11.0",
-        "eslint-plugin-testing-library": "^5.0.5",
-        "eslint-plugin-unicorn": "^41.0.0",
+        "eslint-plugin-sonarjs": "^0.13.0",
+        "eslint-plugin-testing-library": "^5.5.1",
+        "eslint-plugin-unicorn": "^43.0.0",
         "tslint": "^6.1.3"
     },
     "main": "./index.js",

package/rules/eslint/possible-problems.js

@@ -13,6 +13,7 @@ module.exports = {
         'no-compare-neg-zero': 'error',
         'no-cond-assign': ['error', 'always'],
         'no-const-assign': 'error',
+        'no-constant-binary-expression': 'error',
         'no-constant-condition': 'error',
         'no-constructor-return': 'error',
         'no-control-regex': 'error',
@@ -58,16 +59,24 @@ module.exports = {
         'no-unused-vars': ['error', {
                 args: 'after-used',
                 argsIgnorePattern: '^_',
+                caughtErrors: 'all',
+                destructuredArrayIgnorePattern: '^_',
+                ignoreRestSiblings: false,
+                vars: 'all',
             }],
         'no-use-before-define': ['error', {
                 functions: false,
                 classes: false,
+                variables: false,
+                allowNamedExports: false,
             }],
         'no-useless-backreference': 'error',
         'require-atomic-updates': ['error', {
                 allowProperties: false,
             }],
         'use-isnan': 'error',
-        'valid-typeof': 'error',
+        'valid-typeof': ['error', {
+                requireStringLiterals: true,
+            }],
     },
 };

package/rules/eslint/suggestions.js

@@ -54,6 +54,7 @@ module.exports = {
         'no-case-declarations': 'error',
         'no-confusing-arrow': ['warn', {
                 allowParens: true,
+                onlyOneSimpleParam: false,
             }],
         'no-console': 'error',
         'no-continue': 'error',
@@ -137,6 +138,7 @@ module.exports = {
                 allowAfterThisConstructor: false,
                 allowFunctionParams: true,
                 enforceInMethodNames: true,
+                enforceInClassFields: true,
             }],
         'no-unneeded-ternary': 'warn',
         'no-unused-expressions': 'error',

package/rules/import/static-analysis.js

@@ -6,7 +6,7 @@ module.exports = {
                 caseSensitiveStrict: true,
             }],
         'import/named': ['error', {
-                commonjs: true,
+                commonjs: false,
             }],
         'import/default': 'error',
         'import/namespace': 'error',
@@ -23,6 +23,6 @@ module.exports = {
             }],
         'import/no-useless-path-segments': 'warn',
         'import/no-relative-parent-imports': 'off',
-        'import/no-relative-packages': 'error',
+        'import/no-relative-packages': 'warn',
     },
 };

package/rules/jest/index.js

@@ -51,6 +51,7 @@ module.exports = {
         'jest/prefer-equality-matcher': 'error',
         'jest/prefer-expect-assertions': 'off',
         'jest/prefer-expect-resolves': 'warn',
+        'jest/prefer-hooks-in-order': 'error',
         'jest/prefer-hooks-on-top': 'error',
         'jest/prefer-lowercase-title': ['error', {
                 allowedPrefixes: [],

package/rules/jsdoc/index.js

@@ -106,6 +106,7 @@ module.exports = {
         'jsdoc/sort-tags': 'warn',
         'jsdoc/tag-lines': ['off', 'never', {
                 count: 1,
+                dropEndLines: false,
                 noEndLines: true,
                 tags: {},
             }],

package/rules/sonarjs/code-smell-detection.js

@@ -9,7 +9,7 @@ module.exports = {
         'sonarjs/no-duplicate-string': 'off',
         'sonarjs/no-duplicated-branches': 'error',
         'sonarjs/no-gratuitous-expressions': 'error',
-        'sonarjs/no-identical-functions': 'error',
+        'sonarjs/no-identical-functions': ['error', 3],
         'sonarjs/no-inverted-boolean-check': 'warn',
         'sonarjs/no-nested-switch': 'error',
         'sonarjs/no-nested-template-literals': 'error',

package/rules/testing-library/index.js

@@ -16,6 +16,7 @@ module.exports = {
         'testing-library/no-container': 'error',
         'testing-library/no-debugging-utils': 'error',
         'testing-library/no-dom-import': 'warn',
+        'testing-library/no-global-regexp-flag-in-query': 'warn',
         'testing-library/no-manual-cleanup': 'error',
         'testing-library/no-node-access': 'error',
         'testing-library/no-promise-in-fire-event': 'error',
@@ -27,7 +28,10 @@ module.exports = {
         'testing-library/no-wait-for-snapshot': 'error',
         'testing-library/prefer-explicit-assert': 'error',
         'testing-library/prefer-find-by': 'warn',
-        'testing-library/prefer-presence-queries': 'error',
+        'testing-library/prefer-presence-queries': ['error', {
+                presence: true,
+                absence: true,
+            }],
         'testing-library/prefer-query-by-disappearance': 'error',
         'testing-library/prefer-user-event': 'error',
         'testing-library/prefer-screen-queries': 'error',

package/rules/typescript-eslint/extension-rules.js

@@ -55,7 +55,7 @@ module.exports = {
         'no-dupe-class-members': 'off',
         '@typescript-eslint/no-dupe-class-members': 'error',
         'no-duplicate-imports': 'off',
-        '@typescript-eslint/no-duplicate-imports': ['error', {
+        '@typescript-eslint/no-duplicate-imports': ['off', {
                 includeExports: true,
             }],
         'no-empty-function': 'off',
@@ -99,6 +99,10 @@ module.exports = {
         '@typescript-eslint/no-unused-vars': ['error', {
                 args: 'after-used',
                 argsIgnorePattern: '^_',
+                caughtErrors: 'all',
+                destructuredArrayIgnorePattern: '^_',
+                ignoreRestSiblings: false,
+                vars: 'all',
             }],
         'no-use-before-define': 'off',
         '@typescript-eslint/no-use-before-define': ['error', {
@@ -126,6 +130,8 @@ module.exports = {
         '@typescript-eslint/return-await': ['warn', 'never'],
         'semi': 'off',
         '@typescript-eslint/semi': ['warn', 'always'],
+        'space-before-blocks': 'off',
+        '@typescript-eslint/space-before-blocks': ['warn', 'always'],
         'space-before-function-paren': 'off',
         '@typescript-eslint/space-before-function-paren': ['warn', {
                 anonymous: 'always',

package/rules/typescript-eslint/rules/typescript-eslint-naming-convention.d.ts

@@ -5,7 +5,7 @@ export declare type TypescriptEslintNamingConventionSelector = TypescriptEslintN
 export declare type TypescriptEslintNamingConventionUnderscore = 'forbid' | 'require' | 'requireDouble' | 'allow' | 'allowDouble' | 'allowSingleOrDouble';
 export interface TypescriptEslintNamingConvention {
     selector: TypescriptEslintNamingConventionSelector | TypescriptEslintNamingConventionSelector[];
-    format?: TypescriptEslintNamingConventionFormat[];
+    format: TypescriptEslintNamingConventionFormat[] | null;
     modifiers?: string[];
     leadingUnderscore?: TypescriptEslintNamingConventionUnderscore;
     trailingUnderscore?: TypescriptEslintNamingConventionUnderscore;

package/rules/typescript-eslint/rules/typescript-eslint-naming-convention.js

@@ -14,6 +14,10 @@ function typescriptEslintNamingConventionDefaults() {
         }, {
             selector: ['memberLike', 'variableLike'],
             format: ['strictCamelCase'],
+        }, {
+            selector: ['objectLiteralProperty'],
+            modifiers: ['requiresQuotes'],
+            format: null,
         }, {
             selector: ['parameter'],
             modifiers: ['unused'],

package/rules/typescript-eslint/supported-rules.js

@@ -24,6 +24,7 @@ module.exports = {
                 extendDefaults: true,
             }],
         '@typescript-eslint/class-literal-property-style': 'off',
+        '@typescript-eslint/consistent-generic-constructors': ['warn', 'type-annotation'],
         '@typescript-eslint/consistent-indexed-object-style': ['warn', 'record'],
         '@typescript-eslint/consistent-type-assertions': ['error', {
                 assertionStyle: 'as',
@@ -117,6 +118,7 @@ module.exports = {
                 ignoreArrowShorthand: true,
                 ignoreVoidOperator: false,
             }],
+        '@typescript-eslint/no-duplicate-enum-values': 'error',
         '@typescript-eslint/no-dynamic-delete': 'warn',
         '@typescript-eslint/no-empty-interface': ['off', {
                 allowSingleExtends: true,
@@ -145,12 +147,16 @@ module.exports = {
                 checkNever: true,
             }],
         '@typescript-eslint/no-misused-new': 'error',
-        '@typescript-eslint/no-misused-promises': 'error',
+        '@typescript-eslint/no-misused-promises': ['error', {
+                checksConditionals: true,
+                checksVoidReturn: true,
+            }],
         '@typescript-eslint/no-namespace': 'error',
         '@typescript-eslint/no-non-null-asserted-nullish-coalescing': 'error',
         '@typescript-eslint/no-non-null-asserted-optional-chain': 'error',
         '@typescript-eslint/no-non-null-assertion': 'error',
         '@typescript-eslint/no-parameter-properties': 'off',
+        '@typescript-eslint/no-redundant-type-constituents': 'error',
         '@typescript-eslint/no-require-imports': 'error',
         '@typescript-eslint/no-this-alias': 'error',
         '@typescript-eslint/no-type-alias': 'off',
@@ -170,6 +176,9 @@ module.exports = {
         '@typescript-eslint/no-unsafe-return': 'error',
         '@typescript-eslint/no-var-requires': 'error',
         '@typescript-eslint/non-nullable-type-assertion-style': 'error',
+        '@typescript-eslint/parameter-properties': ['error', {
+                prefer: 'parameter-property',
+            }],
         '@typescript-eslint/prefer-as-const': 'warn',
         '@typescript-eslint/prefer-enum-initializers': 'error',
         '@typescript-eslint/prefer-for-of': 'error',
@@ -252,6 +261,9 @@ module.exports = {
         '@typescript-eslint/unbound-method': ['error', {
                 ignoreStatic: true,
             }],
-        '@typescript-eslint/unified-signatures': 'error',
+        '@typescript-eslint/unified-signatures': ['error', {
+                ignoreDifferentlyNamedParameters: true,
+            }],
+        '@typescript-eslint/no-useless-empty-export': 'warn',
     },
 };

package/rules/unicorn/index.js

@@ -20,7 +20,7 @@ module.exports = {
         'unicorn/filename-case': ['error', {
                 case: 'kebabCase',
             }],
-        'unicorn/import-index': 'warn',
+        'unicorn/import-index': 'off',
         'unicorn/import-style': 'off',
         'unicorn/new-for-builtins': 'warn',
         'unicorn/no-abusive-eslint-disable': 'error',
@@ -55,12 +55,14 @@ module.exports = {
         'unicorn/no-thenable': 'error',
         'unicorn/no-this-assignment': 'error',
         'unicorn/no-unreadable-array-destructuring': 'error',
+        'unicorn/no-unreadable-iife': 'error',
         'unicorn/no-unsafe-regex': 'error',
         'unicorn/no-unused-properties': 'off',
         'unicorn/no-useless-fallback-in-spread': 'warn',
         'unicorn/no-useless-length-check': 'warn',
         'unicorn/no-useless-promise-resolve-reject': 'warn',
         'unicorn/no-useless-spread': 'warn',
+        'unicorn/no-useless-switch-case': 'error',
         'unicorn/no-useless-undefined': 'off',
         'unicorn/no-zero-fractions': 'off',
         'unicorn/number-literal-case': 'warn',
@@ -96,17 +98,19 @@ module.exports = {
         'unicorn/prefer-dom-node-dataset': 'warn',
         'unicorn/prefer-dom-node-remove': 'warn',
         'unicorn/prefer-dom-node-text-content': 'warn',
+        'unicorn/prefer-event-target': 'error',
         'unicorn/prefer-export-from': 'warn',
         'unicorn/prefer-includes': 'warn',
         'unicorn/prefer-json-parse-buffer': 'warn',
         'unicorn/prefer-keyboard-event-key': 'warn',
+        'unicorn/prefer-logical-operator-over-ternary': 'error',
         'unicorn/prefer-math-trunc': 'warn',
         'unicorn/prefer-modern-dom-apis': 'warn',
+        'unicorn/prefer-modern-math-apis': 'warn',
         'unicorn/prefer-module': 'off',
+        'unicorn/prefer-native-coercion-functions': 'warn',
         'unicorn/prefer-negative-index': 'warn',
-        'unicorn/prefer-node-protocol': ['warn', {
-                checkRequire: false,
-            }],
+        'unicorn/prefer-node-protocol': 'warn',
         'unicorn/prefer-number-properties': ['warn', {
                 checkInfinity: true,
             }],