@percy/sdk-utils 1.31.3-beta.5 → 1.31.3-beta.6

package/dist/proxy.js

@@ -134,7 +134,32 @@ function stripQuotesAndSpaces(str) {
 // Returns the proxy URL for a set of request options
 function getProxy(options) {
   let proxyUrl = options.protocol === 'https:' && (process.env.https_proxy || process.env.HTTPS_PROXY) || process.env.http_proxy || process.env.HTTP_PROXY;
-  let shouldProxy = !!proxyUrl && !hostnameMatches(stripQuotesAndSpaces(process.env.no_proxy || process.env.NO_PROXY), href(options));
+
+  // Always exclude localhost/127.0.0.1 from proxying to prevent internal loops
+  //
+  // CRITICAL: Percy SDK communicates with percy-cli server via HTTP calls to localhost:5338
+  // When HTTP_PROXY is set, these internal communications would be routed through the proxy,
+  // creating a feedback loop that causes memory leaks and crashes:
+  //
+  // 1. SDK makes request to localhost:5338/percy/log (internal communication)
+  // 2. Request gets routed through external proxy due to HTTP_PROXY setting
+  // 3. Proxy forwards request back to localhost:5338 (adds latency + overhead)
+  // 4. Percy server processes request and generates internal logs/metrics
+  // 5. Those logs trigger MORE requests to localhost:5338/percy/log
+  // 6. Each new request also gets proxied, creating exponential growth
+  // 7. Eventually: JavaScript heap exhaustion and process crash
+  //
+  // By excluding localhost by default, we ensure:
+  // - External requests (percy.io, etc.) go through proxy as intended
+  // - Internal percy-cli ↔ sdk communications remain fast and direct
+  // - No risk of internal communication loops or memory leaks
+  //
+  // This follows standard industry practice - most proxy implementations
+  // (Docker, browsers, corporate proxies) exclude localhost by default.
+  let noProxyList = stripQuotesAndSpaces(process.env.no_proxy || process.env.NO_PROXY) || '';
+  const defaultNoProxy = 'localhost,127.0.0.1,::1,[::1]';
+  noProxyList = noProxyList ? `${noProxyList},${defaultNoProxy}` : defaultNoProxy;
+  let shouldProxy = !!proxyUrl && !hostnameMatches(noProxyList, href(options));
   if (proxyUrl && typeof proxyUrl === 'string') {
     proxyUrl = stripQuotesAndSpaces(proxyUrl);
   }
@@ -169,7 +194,7 @@ class ProxyHttpAgent extends _http.default.Agent {
     var _request$outputData;
     let proxy = getProxy(options);
     if (!proxy) return super.addRequest(request, options);
-    (0, _logger.default)('sdk-utils:proxy').debug(`Proxying request: ${href(options)}`);
+    (0, _logger.default)('sdk-utils:proxy').debug(`Proxying request: ${href(options)} via ${proxy.host}:${proxy.port}`);
 
     // modify the request for proxying
     request.path = href(options);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/sdk-utils",
-  "version": "1.31.3-beta.5",
+  "version": "1.31.3-beta.6",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -54,5 +54,5 @@
   "dependencies": {
     "pac-proxy-agent": "^7.0.2"
   },
-  "gitHead": "b029fc53f478818c5a34205d1ff3b22d7d4390af"
+  "gitHead": "ca15e75708a7d474d32e460265afb4bb07fd4110"
 }