@percy/dom 1.24.1 → 1.24.3-beta.0

package/dist/bundle.js

@@ -328,6 +328,19 @@
       }
     }
 
+    // Drop loading attribute. We do not scroll page in discovery stage but we want to make sure that
+    // all resources are requested, so we drop loading attribute [as it can be set to lazy]
+    function dropLoadingAttribute(domElement) {
+      var _domElement$tagName;
+      if (!['img', 'iframe'].includes((_domElement$tagName = domElement.tagName) === null || _domElement$tagName === void 0 ? void 0 : _domElement$tagName.toLowerCase())) return;
+      domElement.removeAttribute('loading');
+    }
+
+    // All transformations that we need to apply for a successful discovery and stable render
+    function applyElementTransformations(domElement) {
+      dropLoadingAttribute(domElement);
+    }
+
     /**
      * Custom deep clone function that replaces Percy's current clone behavior.
      * This enables us to capture shadow DOM in snapshots. It takes advantage of `attachShadow`'s mode option set to open
@@ -355,6 +368,9 @@
         // mark the node before cloning
         markElement(node, disableShadowDOM);
         let clone = node.cloneNode();
+
+        // We apply any element transformations here to avoid another treeWalk
+        applyElementTransformations(clone);
         parent.appendChild(clone);
 
         // shallow clone should not contain children
@@ -401,7 +417,9 @@
         includeShadowRoots: true
       });
       docElement.textContent = '';
-      return docElement.outerHTML.replace('</html>', `${innerHTML}</html>`);
+      // Note: Here we are specifically passing replacer function to avoid any replacements due to
+      // special characters in client's dom like $&
+      return docElement.outerHTML.replace('</html>', () => `${innerHTML}</html>`);
     }
 
     // we inject declarative shadow dom polyfill to allow shadow dom to load in non chromium infrastructure browsers

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/dom",
-  "version": "1.24.1",
+  "version": "1.24.3-beta.0",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -34,5 +34,5 @@
   "devDependencies": {
     "interactor.js": "^2.0.0-beta.10"
   },
-  "gitHead": "289eb8467fd317b6c17decc5d4f1b6586aa7b75e"
+  "gitHead": "1c5664ca09f7f3b3d3c20484348ee748295dd1e2"
 }