@percy/core 1.9.0 → 1.10.1

package/dist/api.js

@@ -138,14 +138,16 @@ export function createPercyServer(percy, port) {
     }
   }, res) => {
     body = Buffer.isBuffer(body) ? body.toString() : body;
+    let {
+      remoteLoggers
+    } = percy.testing;
 
     if (cmd === 'reset') {
-      var _percy$testing$remote;
-
-      // the reset command will terminate connections, clear logs, and reset testing mode
-      (_percy$testing$remote = percy.testing.remoteLoggers) === null || _percy$testing$remote === void 0 ? void 0 : _percy$testing$remote.forEach(ws => ws.terminate());
+      // the reset command will reset testing mode and clear any logs
+      percy.testing = remoteLoggers ? {
+        remoteLoggers
+      } : {};
       logger.instance.messages.clear();
-      percy.testing = {};
     } else if (cmd === 'version') {
       // the version command will update the api version header for testing
       percy.testing.version = body;
@@ -161,10 +163,8 @@ export function createPercyServer(percy, port) {
         error: 'Build failed'
       };
     } else if (cmd === 'remote-logging') {
-      var _percy$testing$remote2;
-
       // the remote-logging command will toggle remote logging support
-      if (body === false) (_percy$testing$remote2 = percy.testing.remoteLoggers) === null || _percy$testing$remote2 === void 0 ? void 0 : _percy$testing$remote2.forEach(ws => ws.terminate());
+      if (body === false) remoteLoggers === null || remoteLoggers === void 0 ? void 0 : remoteLoggers.forEach(ws => ws.terminate());
       percy.testing.remoteLogging = body;
     } else {
       // 404 for unknown commands
@@ -189,15 +189,17 @@ export function createPercyServer(percy, port) {
 export function createStaticServer(options) {
   let {
     serve: dir,
-    baseUrl = '/'
+    baseUrl = ''
   } = options;
-  let server = Server.createServer(options); // used when generating an automatic sitemap
+  let server = Server.createServer(options); // remove trailing slashes so the base snapshot name matches other snapshots
+
+  baseUrl = baseUrl.replace(/\/$/, ''); // used when generating an automatic sitemap
 
   let toURL = Server.createRewriter( // reverse rewrites' src, dest, & order
-  Object.entries((options === null || options === void 0 ? void 0 : options.rewrites) ?? {}).reduce((acc, rw) => [rw.reverse(), ...acc], []), (filename, rewrite) => new URL(path.posix.join(baseUrl, // cleanUrls will trim trailing .html/index.html from paths
+  Object.entries((options === null || options === void 0 ? void 0 : options.rewrites) ?? {}).reduce((acc, rw) => [rw.reverse(), ...acc], []), (filename, rewrite) => new URL(path.posix.join('/', baseUrl, // cleanUrls will trim trailing .html/index.html from paths
   !options.cleanUrls ? rewrite(filename) : rewrite(filename).replace(/(\/index)?\.html$/, '')), server.address())); // include automatic sitemap route
 
-  server.route('get', '/sitemap.xml', async (req, res) => {
+  server.route('get', `${baseUrl}/sitemap.xml`, async (req, res) => {
     let {
       default: glob
     } = await import('fast-glob');

package/dist/percy.js

@@ -31,7 +31,9 @@ export class Percy {
     deferUploads,
     // run without uploading anything
     skipUploads,
-    // implies `skipUploads` and also skips asset discovery
+    // run without asset discovery
+    skipDiscovery,
+    // implies `skipUploads` and `skipDiscovery`
     dryRun,
     // implies `dryRun`, silent logs, and adds extra api endpoints
     testing,
@@ -53,6 +55,7 @@ export class Percy {
     this.testing = testing ? {} : null;
     this.dryRun = !!testing || !!dryRun;
     this.skipUploads = this.dryRun || !!skipUploads;
+    this.skipDiscovery = this.dryRun || !!skipDiscovery;
     this.delayUploads = this.skipUploads || !!delayUploads;
     this.deferUploads = this.delayUploads || !!deferUploads;
     if (this.deferUploads) this.#uploads.stop();
@@ -150,7 +153,7 @@ export class Percy {
   // at a later time when uploads are deferred, or run immediately when not deferred.
 
 
-  async *start(options) {
+  async *start() {
     // already starting or started
     if (this.readyState != null) return;
     this.readyState = 0; // create a percy build as the first immediately queued task
@@ -193,10 +196,7 @@ export class Percy {
       // when not deferred, wait until the build is created first
       if (!this.deferUploads) await buildTask; // maybe launch the discovery browser
 
-      if (!this.dryRun && (options === null || options === void 0 ? void 0 : options.browser) !== false) {
-        yield this.browser.launch();
-      } // start the server after everything else is ready
-
+      if (!this.skipDiscovery) yield this.browser.launch(); // start the server after everything else is ready
 
       yield (_this$server2 = this.server) === null || _this$server2 === void 0 ? void 0 : _this$server2.listen(); // mark instance as started
 
@@ -234,8 +234,8 @@ export class Percy {
       if (this.#snapshots.size) {
         if (close) this.#snapshots.close();
         yield* this.#snapshots.flush(s => {
-          // do not log a count when not closing or while dry-running
-          if (!close || this.dryRun) return;
+          // do not log a count when not closing or if asset discovery is disabled
+          if (!close || this.skipDiscovery) return;
           this.log.progress(`Processing ${s} snapshot${s !== 1 ? 's' : ''}...`, !!s);
         });
       } // run, close, and wait for the upload queue to empty

package/dist/snapshot.js

@@ -117,6 +117,8 @@ export async function* gatherSnapshots(percy, options) {
 // other invalid options which are also scrubbed from the returned migrated options.
 
 export function validateSnapshotOptions(options) {
+  var _migrated$baseUrl;
+
   // decide which schema to validate against
   let schema = ['domSnapshot', 'dom-snapshot', 'dom_snapshot'].some(k => k in options) && '/snapshot/dom' || 'url' in options && '/snapshot' || 'sitemap' in options && '/snapshot/sitemap' || 'serve' in options && '/snapshot/server' || 'snapshots' in options && '/snapshot/list' || '/snapshot';
   let {
@@ -125,10 +127,12 @@ export function validateSnapshotOptions(options) {
     environmentInfo,
     snapshots,
     ...migrated
-  } = PercyConfig.migrate(options, schema); // gather info for validating individual snapshot URLs
+  } = PercyConfig.migrate(options, schema); // maintain a trailing slash for base URLs to normalize them
+
+  if (((_migrated$baseUrl = migrated.baseUrl) === null || _migrated$baseUrl === void 0 ? void 0 : _migrated$baseUrl.endsWith('/')) === false) migrated.baseUrl += '/';
+  let baseUrl = schema === '/snapshot/server' ? 'http://localhost/' : migrated.baseUrl; // gather info for validating individual snapshot URLs
 
   let isSnapshot = schema === '/snapshot/dom' || schema === '/snapshot';
-  let baseUrl = schema === '/snapshot/server' ? 'http://localhost' : options.baseUrl;
   let snaps = isSnapshot ? [migrated] : Array.isArray(snapshots) ? snapshots : [];
 
   for (let snap of snaps) validURL(typeof snap === 'string' ? snap : snap.url, baseUrl); // add back snapshots before validating and scrubbing; function snapshots are validated later
@@ -370,7 +374,14 @@ export async function* discoverSnapshotResources(percy, snapshot, callback) {
 
   let cache = percy[RESOURCE_CACHE_KEY] || (percy[RESOURCE_CACHE_KEY] = new Map()); // preload the root resource for existing dom snapshots
 
-  let resources = new Map(snapshot.domSnapshot && [createRootResource(snapshot.url, snapshot.domSnapshot)].map(resource => [resource.url, resource])); // open a new browser page
+  let resources = new Map(snapshot.domSnapshot && [createRootResource(snapshot.url, snapshot.domSnapshot)].map(resource => [resource.url, resource])); // when no discovery browser is available, do not attempt to discover other resources
+
+  if (percy.skipDiscovery && !snapshot.domSnapshot) {
+    throw new Error('Cannot capture DOM snapshot when asset discovery is disabled');
+  } else if (percy.skipDiscovery) {
+    return handleSnapshotResources(snapshot, resources, callback);
+  } // open a new browser page
+
 
   let page = yield percy.browser.page({
     enableJavaScript: snapshot.enableJavaScript ?? !snapshot.domSnapshot,

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.9.0",
+  "version": "1.10.1",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -39,10 +39,10 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.9.0",
-    "@percy/config": "1.9.0",
-    "@percy/dom": "1.9.0",
-    "@percy/logger": "1.9.0",
+    "@percy/client": "1.10.1",
+    "@percy/config": "1.10.1",
+    "@percy/dom": "1.10.1",
+    "@percy/logger": "1.10.1",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",
@@ -53,5 +53,5 @@
     "rimraf": "^3.0.2",
     "ws": "^8.0.0"
   },
-  "gitHead": "3332a2a63802c58848d0a5fbdd3c7aadc076212b"
+  "gitHead": "3e16144300e8b49aab638ceb699630f4be71bb9f"
 }