@percy/core 1.29.4-beta.2 → 1.29.4-beta.4

package/dist/discovery.js

@@ -61,6 +61,25 @@ function debugSnapshotOptions(snapshot) {
   }
 }
 
+// parse browser cookies in correct format if flag is enabled
+// it assumes that cookiesStr is string returned by document.cookie
+function parseCookies(cookiesStr) {
+  if (process.env.PERCY_DO_NOT_USE_CAPTURED_COOKIES === 'true' || !(typeof cookiesStr === 'string' && cookiesStr !== '')) return null;
+  return cookiesStr.split('; ').map(c => {
+    const eqIdx = c.indexOf('=');
+    const name = c.substring(0, eqIdx);
+    const value = c.substring(eqIdx + 1);
+    const cookieObj = {
+      name,
+      value
+    };
+    if (name.startsWith('__Secure')) {
+      cookieObj.secure = true;
+    }
+    return cookieObj;
+  });
+}
+
 // Wait for a page's asset discovery network to idle
 function waitForDiscoveryNetworkIdle(page, options) {
   let {
@@ -163,6 +182,7 @@ function processSnapshotResources({
 // Triggers the capture of resource requests for a page by iterating over snapshot widths to resize
 // the page and calling any provided execute options.
 async function* captureSnapshotResources(page, snapshot, options) {
+  var _snapshot$domSnapshot;
   const log = logger('core:discovery');
   let {
     discovery,
@@ -176,20 +196,7 @@ async function* captureSnapshotResources(page, snapshot, options) {
     mobile,
     captureForDevices
   } = options;
-  let cookies;
-  if (process.env.PERCY_DO_NOT_USE_CAPTURED_COOKIES !== 'true') {
-    var _snapshot$domSnapshot;
-    cookies = snapshot === null || snapshot === void 0 ? void 0 : (_snapshot$domSnapshot = snapshot.domSnapshot) === null || _snapshot$domSnapshot === void 0 ? void 0 : _snapshot$domSnapshot.cookies;
-  }
-  if (typeof cookies === 'string' && cookies !== '') {
-    cookies = cookies.split('; ').map(c => c.split('='));
-    cookies = cookies.map(([key, value]) => {
-      return {
-        name: key,
-        value: value
-      };
-    });
-  }
+  let cookies = parseCookies(snapshot === null || snapshot === void 0 ? void 0 : (_snapshot$domSnapshot = snapshot.domSnapshot) === null || _snapshot$domSnapshot === void 0 ? void 0 : _snapshot$domSnapshot.cookies);
 
   // iterate over device to trigger reqeusts and capture other dpr width
   async function* captureResponsiveAssets() {

package/dist/network.js

@@ -510,7 +510,7 @@ async function saveResponseResource(network, request) {
       // font anyway as font responses from the browser may not be properly encoded,
       // so request them directly.
       if (mimeType !== null && mimeType !== void 0 && mimeType.includes('font') || detectedMime && detectedMime.includes('font')) {
-        log.debug('- Requesting asset directly');
+        log.debug('- Requesting asset directly', meta);
         body = await makeDirectRequest(network, request);
       }
       resource = createResource(url, body, mimeType, {
@@ -525,7 +525,7 @@ async function saveResponseResource(network, request) {
       log.debug(`- mimetype: ${resource.mimetype}`, meta);
     } catch (error) {
       log.debug(`Encountered an error processing resource: ${url}`, meta);
-      log.debug(error);
+      log.debug(error, meta);
     }
   }
   if (resource) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.29.4-beta.2",
+  "version": "1.29.4-beta.4",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -43,11 +43,11 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.29.4-beta.2",
-    "@percy/config": "1.29.4-beta.2",
-    "@percy/dom": "1.29.4-beta.2",
-    "@percy/logger": "1.29.4-beta.2",
-    "@percy/webdriver-utils": "1.29.4-beta.2",
+    "@percy/client": "1.29.4-beta.4",
+    "@percy/config": "1.29.4-beta.4",
+    "@percy/dom": "1.29.4-beta.4",
+    "@percy/logger": "1.29.4-beta.4",
+    "@percy/webdriver-utils": "1.29.4-beta.4",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",
@@ -60,5 +60,5 @@
     "ws": "^8.17.1",
     "yaml": "^2.4.1"
   },
-  "gitHead": "f316b7f672fbec81d3f13c53591735f102bc17a1"
+  "gitHead": "373606636f133996307a33529e6f45632d18bdd9"
 }