@percy/core 1.29.3 → 1.29.4-beta.2

package/dist/config.js

@@ -205,6 +205,14 @@ export const configSchema = {
         maximum: 750,
         minimum: 1
       },
+      waitForSelector: {
+        type: 'string'
+      },
+      waitForTimeout: {
+        type: 'integer',
+        minimum: 1,
+        maximum: 30000
+      },
       disableCache: {
         type: 'boolean'
       },
@@ -363,6 +371,12 @@ export const snapshotSchema = {
             requestHeaders: {
               $ref: '/config/discovery#/properties/requestHeaders'
             },
+            waitForSelector: {
+              $ref: '/config/discovery#/properties/waitForSelector'
+            },
+            waitForTimeout: {
+              $ref: '/config/discovery#/properties/waitForTimeout'
+            },
             authorization: {
               $ref: '/config/discovery#/properties/authorization'
             },

package/dist/discovery.js

@@ -1,6 +1,7 @@
 import logger from '@percy/logger';
 import Queue from './queue.js';
-import { normalizeURL, hostnameMatches, createResource, createRootResource, createPercyCSSResource, createLogResource, yieldAll, snapshotLogName, withRetries } from './utils.js';
+import Page from './page.js';
+import { normalizeURL, hostnameMatches, createResource, createRootResource, createPercyCSSResource, createLogResource, yieldAll, snapshotLogName, waitForTimeout, withRetries, waitForSelectorInsideBrowser } from './utils.js';
 import { sha256hash } from '@percy/client/utils';
 import Pako from 'pako';
 import TimeIt from './timing.js';
@@ -238,6 +239,18 @@ async function* captureSnapshotResources(page, snapshot, options) {
   yield page.goto(snapshot.url, {
     cookies
   });
+
+  // wait for any specified timeout
+  if (snapshot.discovery.waitForTimeout && page.enableJavaScript) {
+    log.debug(`Wait for ${snapshot.discovery.waitForTimeout}ms timeout`);
+    await waitForTimeout(snapshot.discovery.waitForTimeout);
+  }
+
+  // wait for any specified selector
+  if (snapshot.discovery.waitForSelector && page.enableJavaScript) {
+    log.debug(`Wait for selector: ${snapshot.discovery.waitForSelector}`);
+    await waitForSelectorInsideBrowser(page, snapshot.discovery.waitForSelector, Page.TIMEOUT);
+  }
   if (snapshot.execute) {
     // when any execute options are provided, inject snapshot options
     /* istanbul ignore next: cannot detect coverage of injected code */

package/dist/network.js

@@ -472,7 +472,8 @@ async function saveResponseResource(network, request) {
   let response = request.response;
   let meta = {
     ...network.meta,
-    url
+    url,
+    responseStatus: response === null || response === void 0 ? void 0 : response.status
   };
   let resource = network.intercept.getResource(url);
   if (!resource || !resource.root && !resource.provided && disableCache) {

package/dist/snapshot.js

@@ -142,6 +142,8 @@ function getSnapshotOptions(options, {
       allowedHostnames: config.discovery.allowedHostnames,
       disallowedHostnames: config.discovery.disallowedHostnames,
       networkIdleTimeout: config.discovery.networkIdleTimeout,
+      waitForTimeout: config.discovery.waitForTimeout,
+      waitForSelector: config.discovery.waitForSelector,
       devicePixelRatio: config.discovery.devicePixelRatio,
       requestHeaders: config.discovery.requestHeaders,
       authorization: config.discovery.authorization,

package/dist/utils.js

@@ -274,6 +274,15 @@ async function waitForSelector(selector, timeout) {
   }
 }
 
+// wait for a query selector to exist within an optional timeout inside browser
+export async function waitForSelectorInsideBrowser(page, selector, timeout) {
+  try {
+    return page.eval(`await waitForSelector(${JSON.stringify(selector)}, ${timeout})`);
+  } catch {
+    throw new Error(`Unable to find: ${selector}`);
+  }
+}
+
 // Browser-specific util to wait for an xpath selector to exist within an optional timeout.
 /* istanbul ignore next: tested, but coverage is stripped */
 async function waitForXPath(selector, timeout) {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@percy/core",
-  "version": "1.29.3",
+  "version": "1.29.4-beta.2",
   "license": "MIT",
   "repository": {
     "type": "git",
@@ -9,7 +9,7 @@
   },
   "publishConfig": {
     "access": "public",
-    "tag": "latest"
+    "tag": "beta"
   },
   "engines": {
     "node": ">=14"
@@ -43,11 +43,11 @@
     "test:types": "tsd"
   },
   "dependencies": {
-    "@percy/client": "1.29.3",
-    "@percy/config": "1.29.3",
-    "@percy/dom": "1.29.3",
-    "@percy/logger": "1.29.3",
-    "@percy/webdriver-utils": "1.29.3",
+    "@percy/client": "1.29.4-beta.2",
+    "@percy/config": "1.29.4-beta.2",
+    "@percy/dom": "1.29.4-beta.2",
+    "@percy/logger": "1.29.4-beta.2",
+    "@percy/webdriver-utils": "1.29.4-beta.2",
     "content-disposition": "^0.5.4",
     "cross-spawn": "^7.0.3",
     "extract-zip": "^2.0.1",
@@ -60,5 +60,5 @@
     "ws": "^8.17.1",
     "yaml": "^2.4.1"
   },
-  "gitHead": "f374b2c04840cc2992a43bff837d9740bf30f7b8"
+  "gitHead": "f316b7f672fbec81d3f13c53591735f102bc17a1"
 }